50d0857f82
Add result interfaces used by AnalysisSession
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2908543002 .
2017-05-25 12:50:08 -07:00
54d6e3a1c5
cleanup fasta token classes
...
* replace fasta.SymbolToken --> analyzer.Token
* replace fasta.BeginGroupToken --> analyzer.BeginToken
* replace fasta.SymbolToken.eof --> analyzer.Token.eof
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2899043006 .
2017-05-25 07:26:50 -04:00
136698a734
remove fasta <--> analyzer token translation
...
R=ahe@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2902813005 .
2017-05-24 17:34:08 -04:00
6e981d0cbf
enable analyzer scanner adapter generic method support
...
This turns on generic method support in the scanner adapter layer
and updates the token.offset when the analyzer scanner
is being used to parse generic method comments.
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2900963009 .
2017-05-24 13:37:52 -04:00
61d855bb47
Prepare for development branch by updating externally-used API.
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2898183002 .
2017-05-24 14:32:45 +02:00
3c447ab35d
add fasta.scanner support for lazy assignment operators
...
R=paulberry@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2895803002 .
2017-05-20 23:02:47 -04:00
80fd95bb70
Fix parser bug found while trying to reproduce a different bug
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2895743002 .
2017-05-19 13:07:59 -07:00
f19e46e946
Update Listener implementations.
...
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2892173002 .
2017-05-19 13:32:23 +02:00
547b2cdcce
Implement generalized function types.
...
Fixes https://github.com/dart-lang/sdk/issues/6972
Fixes https://github.com/dart-lang/sdk/issues/26581
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2876813002 .
2017-05-19 11:03:24 +02:00
32c4094d04
Analyzer: add ignore_for_file comment that ignores a type of problem for the whole file; add tests.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2888953002 .
2017-05-19 10:01:53 +02:00
5659afc812
Make instrumentation data structure more regular
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2890193002 .
2017-05-18 09:09:17 -07:00
091752f158
Register files with new drivers (issue 29641)
...
Review-Url: https://codereview.chromium.org/2886343002 .
2017-05-18 07:43:47 -07:00
876db33bf4
Add import/export declaration AST node boilerplate to kernel.
...
Previously only deferred imports were represented. They have been
merged with the general form.
BUG=
R=kmillikin@google.com
Review-Url: https://codereview.chromium.org/2852373002 .
2017-05-18 14:38:08 +02:00
6866291fb3
Fix declaration of GenericTypeAliasElementForLink.
...
This class needs to implement FunctionTypeAliasElementForLink so that
it can be stored in CompilationUnitElementForLink._functionTypeAliases
(and returned by CompilationUnitElementForLink.functionTypeAliases)
without incurring checked mode errors.
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2888653005 .
2017-05-17 14:03:46 -07:00
cb258a952c
Remove unused contentHash from results
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2885203002 .
2017-05-16 14:08:11 -07:00
278c7bfbeb
merge fasta.Token into analyzer.Token
...
This eliminates much of the duplication between the two token hierarchies
by merging much of the fasta.Token hierarchy into the analyzer.Token.
* merge token hierarchies
* cleanup fasta.Token.copy()
* set preceedingComments field via constructor
* replace isBuiltInIdentifier --> type.isBuiltIn
* change all fasta.Token references to analyzer.Token
* move fasta.Token.value() implementation into analyzer.SimpleToken
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2890523002 .
2017-05-16 11:50:14 -04:00
d566906167
cleanup unused incremental resolution
...
* remove unused analyzer incremental resolution
* remove unused Token.applyDelta method
Patch Set 1 is the original CL that was landed and reverted
https://codereview.chromium.org/2876993005
Patsh Set 2 contains additional fixes and test changes
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2884853002 .
2017-05-16 07:53:17 -04:00
d644be82ab
Revert "cleanup unused incremental resolution"
...
This reverts commit 77b383e6b8https://codereview.chromium.org/2887443002 .
2017-05-15 11:01:57 -04:00
77b383e6b8
cleanup unused incremental resolution
...
* remove unused analyzer incremental resolution
* remove unused Token.applyDelta method
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2876993005 .
2017-05-15 09:09:25 -04:00
dd62ad5d77
Store Typedef(s) in kernel when parsing with Fasta, deserilize in DillLibraryBuilder.
...
R=ahe@google.com , paulberry@google.com , sigmund@google.com
BUG=
Review-Url: https://codereview.chromium.org/2882893002 .
2017-05-14 17:51:55 -07:00
a4fd5d814f
Extract PerformanceLogger from AnalysisDriver.
...
I also added the runAsync().
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2883633002 .
2017-05-12 14:27:50 -07:00
02cb71685e
Move flat_buffer and api_signature into front_end.
...
I will need to use these in front_end to store precomputed information
and computing combined signatures.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2875373002 .
2017-05-12 10:48:28 -07:00
bef53e72e4
Remove unintentional dependency on analysis_server
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2875323002 .
2017-05-12 10:07:37 -07:00
6cb0966401
Allowing e of any type in void f(...) => e in the analyzer.
...
Re-land, now including adjustment of two tests in pkg/analyzer/test.
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2870363003 .
2017-05-11 10:10:03 +02:00
3b2c3ae5b2
Add support for built-in plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2874803003 .
2017-05-10 13:31:20 -07:00
7adb470835
Revert "Allowing e of any type in void f(...) => e in the analyzer."
...
This reverts commit 025b83fb89https://codereview.chromium.org/2871163002 .
2017-05-10 12:54:24 +02:00
025b83fb89
Allowing e of any type in void f(...) => e in the analyzer.
...
Addresses https://github.com/dart-lang/sdk/issues/28940 .
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2870063002 .
2017-05-10 11:36:43 +02:00
bd1ee32543
Move [file_]byte_store.dart into pkg/front_end/test/src/incremental/.
...
We are going to reuse ByteStore in front_end, also for incremental
compilation.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2869803004 .
2017-05-09 09:12:15 -07:00
81d25f4c71
more work aligning fasta.Token with analyzer.Token
...
* move isPseudo getter out of Token into TokenType
* move special case charCount logic out of fasta.Token into fasta.ErrorToken
* move more accessors from fasta.Token into analyzer.Token
* add @overrides to denote which methods have been declared in analyzer.Token
* make fasta LazySubstring and its subclasses private
* rename fasta.previousToken to previous to match analyzer.Token
* flatten fasta.Token.preceedingCommentTokens into preceedingComments
* normalize fasta.Token.next and analyzer.Token.next
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2872433005 .
2017-05-09 00:09:56 -04:00
3347169016
cleanup TokenType var names
...
* rename TokenType info --> type
* rename fasta Token.info --> Token.type
R=paulberry@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2872453004 .
2017-05-08 12:43:08 -04:00
cc91d04514
Use FileSystem to read files in SourceLoader and TranslateUri.
...
This is a prerequisite for writing fast unit tests, as I would like
to do while working on the incremental kernel driver.
R=ahe@google.com , paulberry@google.com , sigmund@google.com
BUG=
Review-Url: https://codereview.chromium.org/2865843002 .
2017-05-06 13:09:28 -07:00
796baf6f16
Fix an issue with configuring the severity of lints.
...
BUG=
R=brianwilkerson@google.com , pquitslund@google.com
Review-Url: https://codereview.chromium.org/2863013002 .
2017-05-05 13:17:04 -07:00
006c22d0a2
Re-remove ad hoc Future.then inference.
...
Ad hoc inference for Future.then (and overrides) was kept in place for
an extra release cycle to allow code that implemented the Future
interface to work both before and after the transition to using
FutureOr for the callback return type. This CL removes support for
this ad hoc inference.
BUG=
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2859703004 .
2017-05-04 10:45:21 -07:00
f6f845c879
Fix a completion exception during import suggestions.
...
BUG=
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2862793002 .
2017-05-04 09:24:18 -07:00
84ca84b1a7
Implement more of the behavior of a plugin; refactor some API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2857233002 .
2017-05-03 12:48:39 -07:00
3a162d4241
Add flag to track if a constructor is the synthetic default constructor.
...
BUG=
R=ahe@google.com
Review-Url: https://codereview.chromium.org/2856123002 .
2017-05-03 12:48:11 +02:00
37092ed677
New tests and improvements for generics in comments parsing.
...
R=ahe@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2856463004 .
2017-05-01 12:52:09 -07:00
4cba15b081
allow to set enableAssertInitializer with DriverOptions ( #29506 )
2017-05-01 06:13:35 -07:00
aa6353b6da
Dart SDK Spelling b, c, and d.
...
R=kmillikin@google.com
BUG=
Review-Url: https://codereview.chromium.org/2850783002 .
2017-05-01 08:28:10 +02:00
f2f1c60904
Add 'scanGenericMethodComments' parameter to constructors and scan() functions.
...
R=ahe@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2850853004 .
2017-04-28 14:47:29 -07:00
f0e1add542
Set 'enclosingElement' for FunctionElementImpl_forLUB.
...
This makes almost all <unknown> library names to go away in front_end
inference tests.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2849893002 .
2017-04-28 09:30:07 -07:00
0fe8546217
Rollback instrumentation during analysis and validate resolved ASTs instead.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2846883005 .
2017-04-27 10:30:19 -07:00
511a06ee00
Fix some issues with options handling
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2844663003 .
2017-04-27 10:22:37 -07:00
66ac96c4a6
Use the dart:io Platform.resolvedExecutable API to locate the Dart SDK.
...
BUG=
R=brianwilkerson@google.com , danrubel@google.com , pquitslund@google.com
Review-Url: https://codereview.chromium.org/2844883005 .
2017-04-27 09:29:08 -07:00
cf013c6469
Instrument analyzer's type analysis and run front_end inference tests.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2846463003 .
2017-04-26 13:31:10 -07:00
3b790e5311
new TokenType and Keyword API
...
This adds two new methods and adapts most of the old references
to use these new API. Once all call sites have been updated,
the old API can be removed.
This is part one of https://codereview.chromium.org/2842643004/
* replace type == TokenType.KEYWORD with type.isKeyword
* change Keyword.syntax --> Keyword.lexeme
R=paulberry@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2842213003 .
2017-04-26 15:53:58 -04:00
65f492a043
Add support for watch events and error notifications
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2842013003 .
2017-04-26 09:36:26 -07:00
06189b271a
loader, target, diet_listener moved
...
from front_end/lib/src/fasta/analyzer/
to analyzer/lib/src/fasta/
analyzer_compile and compile_platform_dartk moved
from front_end/lib/src/fasta/analyzer/
to front_end/tool/_fasta/
front_end/src/fasta/testing/* continues to have some shared testing logic,
- logic to compute the patched sdk is moved up one level
- TestContext, Run, and suite.dart (which depend on analyzer) moved to pkg/front_end/test/fasta/testing/
- only a copy of TestContext is duplicated under pkg/kernel/test/closure/.
R=ahe@google.com , paulberry@google.com
Review-Url: https://codereview.chromium.org/2828583003 .
2017-04-25 13:16:14 -07:00
684065855f
merge PrecedenceInfo into TokenType and update all refs
...
* replace PrecedenceInfo *_INFO with TokenType.*
* remove outdated PrecedenceInfo tests
* delete unused precedence_info.dart
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2832403002 .
2017-04-25 08:51:52 -04:00
613881a433
fix #29426 , class type alias was missing checks
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2837173002 .
2017-04-24 15:02:29 -07:00
Brian Wilkerson