Commit Graph

47162 Commits

Author SHA1 Message Date
Paul Berry cefc4cc768 Perform type inference on explicitly typed fields.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2905123002 .
2017-05-25 13:22:26 -07:00
Brian Wilkerson f65c7ecbdf Fix a recent regression with nested contexts
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2903303002 .
2017-05-25 13:17:08 -07:00
Siva Chandra 1eaa3dd84b Cleanup how a best fit function is found when setting a breakpoint.
1. Look for functions/closures only in the script where the breakpoint
is being set.
2. If an inner most closure is found, return that as the best fit.
3. When going over a class' functions, return immediately when a fit is
found as going over the other class functions will not yield a narrower
fit.

BUG=
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2898153006 .
2017-05-25 12:57:40 -07:00
Terry Lucas 20dc749844 Suppress Scale interface - unused.
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2901213006 .
2017-05-25 12:54:38 -07:00
Brian Wilkerson 1c8b59dc31 Update status pages to show package map and plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2904983003 .
2017-05-25 12:51:19 -07:00
Brian Wilkerson 50d0857f82 Add result interfaces used by AnalysisSession
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2908543002 .
2017-05-25 12:50:08 -07:00
Sigmund Cherem edd835c5bb Fix vm tests: introduce a hybrid file system so that the vm tests can find the
sdk files.

The reason the tests broke is that they use a memory-file-system which only
contains the test file and a mock .packages file.

BUG= https://github.com/dart-lang/sdk/issues/29723
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2910473003 .
2017-05-25 12:25:15 -07:00
Alan Knight 6f71f9c80b Revert "[Experiment] Stop suppressing DragEvent"
This reverts commit fbbb974670.

Also updates the cached_patches.dart file.

BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2907563003 .
2017-05-25 11:16:10 -07:00
Paul Berry 1e45167514 Update strong mode expectations to reflect kernel type parameter conventions.
When outputting the name of a type parameter, Kernel follows two
special conventions:

- It fully qualifies the name of the type parameter with respect to
  the scope of its declaration; so for example a type parameter `T` of
  a class `C` in a library `lib` might be annotated as `lib::C::T`.

- Within a factory constructor, type parameters of the class are
  annotated as though they are type parameters of the factory
  constructor (this is because factory constructors are represented in
  kernel as static methods).

This CL adjusts the strong mode type inference tests to reflect this
behavior (and modifies analyzer's front_end_inference_test so that
follows the kernel conventions).

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2909503004 .
2017-05-25 11:11:14 -07:00
Brian Wilkerson 013411c10b Allow plugins to provide completions for non-dart files
R=maxkim@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2910463002 .
2017-05-25 10:53:07 -07:00
Brian Wilkerson 7f5e1f260f Add a getNavigation request for plugins
R=mfairhurst@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2908523002 .
2017-05-25 10:51:24 -07:00
Vijay Menon 570f6de05b Remove unsafe flag from ddc sdk
One small step for man...

R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2910473002 .
2017-05-25 10:50:17 -07:00
Ryan Macnak bcf2900a26 Reapply "Shuffle around deopt id allocation to give the flow graph builder a chance to record other data as they are allocated".
- Fix inlining of new List(n) to propogate deopt id.
 - Fix CreateArrayOpt to check for a Smi length.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2900963008 .
2017-05-25 10:12:22 -07:00
Kevin Moore 2248502611 Add .gitignore to pkg/analyzer directory
R=pquitslund@google.com

Review-Url: https://codereview.chromium.org/2905883002 .
2017-05-25 09:57:48 -07:00
Alan Knight 0bb2d5e548 Update DDC html libraries to match SDK
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2899083007 .
2017-05-25 09:33:23 -07:00
Paul Berry 560cf61b3b Add type inference logic for cascade expressions.
R=ahe@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2903243002 .
2017-05-25 09:30:26 -07:00
Paul Berry aa085b56b6 Update status after 8a92a2a79c
TBR=ahe@google.com

Review-Url: https://codereview.chromium.org/2907573002 .
2017-05-25 07:30:39 -07:00
Peter von der Ahé 9b4bc8b0ff Read file names from libraries.json, not URIs.
R=danrubel@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2906673002 .
2017-05-25 16:20:05 +02:00
Peter von der Ahé bcb2ea962b Complain about function literals not being constant expressions.
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2899343002 .
2017-05-25 16:02:30 +02:00
Peter von der Ahé 27761fd369 Read SDK and patches from a JSON file.
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2895983002 .
2017-05-25 15:57:57 +02:00
Paul Berry 8a92a2a79c Infer the types of initializing formals from the corresponding fields.
This inference is enabled for both strong and non-strong mode, since
it is mandated by the Dart 1.0 spec.

R=ahe@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2908453002 .
2017-05-25 04:47:44 -07:00
Dan Rubel 54d6e3a1c5 cleanup fasta token classes
* replace fasta.SymbolToken --> analyzer.Token
* replace fasta.BeginGroupToken --> analyzer.BeginToken
* replace fasta.SymbolToken.eof --> analyzer.Token.eof

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2899043006 .
2017-05-25 07:26:50 -04:00
Alexander Aprelev 1333f97b9a Mark more dartk tests as failing with vm switched to DFE parser
TBR=siva

BUG=https://github.com/dart-lang/sdk/issues/28264

Review-Url: https://codereview.chromium.org/2901103006 .
2017-05-24 21:54:59 -07:00
Alexander Aprelev 16c0db1022 Revert "Revert "With this change 'tools/test.py -cdartk vm' will run vm tests with Dart Frontend parser.""
This reverts commit e0cdea811a.

Update status of vm tests, that don't work with DFE yet.

BUG=https://github.com/dart-lang/sdk/issues/28264
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2895153005 .
2017-05-24 20:16:48 -07:00
Siva Annamalai 91c1202fc8 Add ability to run the hot reload unit tests using the '--dfe' option
R=aam@google.com

Review-Url: https://codereview.chromium.org/2899043005 .
2017-05-24 19:29:20 -07:00
danrubel 498a39ed61 delete obsolete scanner roundtrip test
Review-Url: https://codereview.chromium.org/2900303003 .
2017-05-24 21:07:25 -04:00
Konstantin Shcheglov 97d587520c Add LimitedBinaryPrinter, tests and switch incremental generator to it.
R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2896493002 .
2017-05-24 16:17:28 -07:00
Alan Knight bbfa1dac84 Update lib_strong status for passing svg_element_test
BUG=

Review-Url: https://codereview.chromium.org/2903143002 .
2017-05-24 15:54:22 -07:00
Konstantin Shcheglov 2b8fd9dee8 Transform async code only for source libraries.
R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2905463002 .
2017-05-24 15:51:18 -07:00
Brian Wilkerson 6bff3433b7 Add navigation support in plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2902193002 .
2017-05-24 15:06:18 -07:00
Ryan Macnak 14ec8fa979 Use assembly instead of C array literals to link the core snapshot into the VM.
Allows for including instructions.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2901163002 .
2017-05-24 14:38:15 -07:00
Dan Rubel 136698a734 remove fasta <--> analyzer token translation
R=ahe@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2902813005 .
2017-05-24 17:34:08 -04:00
Zachary Anderson 58c0cacefb Remove unused <sys/syscall.h> inclusion on Fuchsia
Fuchsia doesn't specify its syscall interface in this header. In fact,
the header is empty, and we will soon remove it. So don't include it.

R=zra@google.com
BUG=

Review-Url: https://codereview.chromium.org/2904963002 .
2017-05-24 14:23:16 -07:00
Dan Rubel dff793d05f update lazy assignment operators
and remove scanLazyAssignmentOperators flag

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2903063003 .
2017-05-24 17:05:02 -04:00
Sigmund Cherem 80942f15cf add _CompileTimeError error to dart2js patch
See https://github.com/dart-lang/sdk/issues/29661 for context

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2901323002 .
2017-05-24 13:52:32 -07:00
Vijay Menon 2187f5232d DDC cleanup
R=jacobr@google.com, jakemac@google.com

Review-Url: https://codereview.chromium.org/2902103005 .
2017-05-24 13:01:10 -07:00
Alan Knight b4b02daade Include DDC fixes to dart:html in the main version
BUG=
R=jacobr@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2899173002 .
2017-05-24 12:49:13 -07:00
Alan Knight d60efa87fe Remove obsolete test in svgelement_test
BUG=

Review-Url: https://codereview.chromium.org/2902973004 .
2017-05-24 12:29:15 -07:00
Zachary Anderson f6ca2fc63a [Fuchsia] Fix arm64 build
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2897173006 .
2017-05-24 12:12:49 -07:00
Vijay Menon 5919a12038 Library root fix for win
R=jakemac@google.com

Jacob: do we need a fix in jsDebuggingLibraryName too?  could that code be refactored - it looks like it duplicates a lot of logic.
Review-Url: https://codereview.chromium.org/2899363002 .
2017-05-24 12:10:47 -07:00
Ryan Macnak 93864c0db9 Revert "Shuffle around deopt id allocation to give the flow graph builder a chance to record other data as they are allocated."
This reverts commit c94bebf289.

Review-Url: https://codereview.chromium.org/2904733003 .
2017-05-24 11:55:56 -07:00
Paul Berry a21b9e5638 Remove AstFactory from the front end.
R=ahe@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2904673003 .
2017-05-24 11:28:12 -07:00
Sigmund Cherem 9fd47a08d1 Address follow up comments
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2902643002 .
2017-05-24 11:20:40 -07:00
Paul Berry 11fbbea7a7 Create language test that exercises bug #29709.
R=ahe@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2903033002 .
2017-05-24 11:20:07 -07:00
Sigmund Cherem 5f8bc4feb2 fasta: revert check for null fileUri in the error reporting of the verifier.
(as discussed in https://codereview.chromium.org/2894283002, we are reverting
this because we don't know how to reproduce this issue anymore. When it comes up
again we can either fix the issue or re-revert and include an explanation).

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2902153003 .
2017-05-24 11:17:15 -07:00
Dan Rubel 6e981d0cbf enable analyzer scanner adapter generic method support
This turns on generic method support in the scanner adapter layer
and updates the token.offset when the analyzer scanner
is being used to parse generic method comments.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2900963009 .
2017-05-24 13:37:52 -04:00
Zachary Anderson 61300d19c6 [dart:io] Re-limit the number of IO Service ports per Isolate
Previous change removed the limit, but this causes too many
threads to be spawned at the same time on Windows, which
crashes the VM. This change restores the limit, but continues
use of the free-list approach, which still avoids the blocking
problem fixed by the previous change.

fixes #29702

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2903013002 .
2017-05-24 10:22:26 -07:00
Jacob Richman a0414390f9 Properly link building dev compiler tools to create_full_sdk.
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2900833002 .
2017-05-24 10:00:00 -07:00
Paul Berry 6b100c007b Use declared return type for inference of return and yield statements.
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2899073004 .
2017-05-24 09:28:26 -07:00
Florian Loitsch e9e9835afc Add a changelog entry for the function-type syntax.
Fixes #27527
BUG= http://dartbug.com/27527
R=leafp@google.com

Review-Url: https://codereview.chromium.org/2906453002 .
2017-05-24 18:23:06 +02:00