Brian Wilkerson
f65c7ecbdf
Fix a recent regression with nested contexts
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2903303002 .
2017-05-25 13:17:08 -07:00
Brian Wilkerson
013411c10b
Allow plugins to provide completions for non-dart files
...
R=maxkim@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2910463002 .
2017-05-25 10:53:07 -07:00
Konstantin Shcheglov
ab9ee72a34
Switch server tests to strong mode.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2903523003 .
2017-05-23 14:58:53 -07:00
Brian Wilkerson
0929b7736e
Convert quick assist support to use AnalysisDriver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2899843002 .
2017-05-22 13:45:55 -07:00
Brian Wilkerson
7e47a24c8a
Convert quick fix support to use AnalysisDriver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2894403003 .
2017-05-22 10:41:57 -07:00
Steve Messick
5455f21565
Fix reparent on windows
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2892963002 .
2017-05-19 10:28:44 -07:00
Brian Wilkerson
a8dc041543
Capture the request time for performance data and support forced shutdown
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2893803004 .
2017-05-19 08:49:47 -07:00
Brian Wilkerson
c1a7070770
Add the ability to whitelist plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2897653002 .
2017-05-19 08:48:32 -07:00
Brian Wilkerson
7e11a13cf5
Add requestTime to responses
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2890163004 .
2017-05-18 10:32:47 -07:00
Brian Wilkerson
daffcecc11
Pass the sdk path to plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2885993004 .
2017-05-17 08:19:49 -07:00
Brian Wilkerson
7d26ff6d4f
Remove some more library directives
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2884233004 .
2017-05-17 08:02:08 -07:00
Brian Wilkerson
cb258a952c
Remove unused contentHash from results
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2885203002 .
2017-05-16 14:08:11 -07:00
pq
aa491e7133
Support tear-off completions for named params (in constructors) (flutter-intellij#836)
...
R=danrubel@google.com
Fixes: https://github.com/flutter/flutter-intellij/issues/836
Review-Url: https://codereview.chromium.org/2883363002 .
2017-05-16 13:40:33 -07:00
Dan Rubel
d566906167
cleanup unused incremental resolution
...
* remove unused analyzer incremental resolution
* remove unused Token.applyDelta method
Patch Set 1 is the original CL that was landed and reverted
https://codereview.chromium.org/2876993005
Patsh Set 2 contains additional fixes and test changes
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2884853002 .
2017-05-16 07:53:17 -04:00
Brian Wilkerson
a03958bfc9
More clean-up after getting common protocol classes
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2880393002 .
2017-05-15 13:01:57 -07:00
Brian Wilkerson
0b5bee6c66
Fix a failing test (TBR)
...
Review-Url: https://codereview.chromium.org/2877353003 .
2017-05-15 09:49:22 -07:00
Brian Wilkerson
fb982f5476
Make server use the common protocol classes
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2879273002 .
2017-05-15 09:35:46 -07:00
Brian Wilkerson
38143be701
Fix an error to fix the bots (TBR)
...
Review-Url: https://codereview.chromium.org/2883883003 .
2017-05-15 09:11:12 -07:00
Brian Wilkerson
27f9e5e4ce
Reverse the sense of the flag to make it easier to find test that need to be converted
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2884593003 .
2017-05-15 08:40:40 -07:00
Devon Carew
4afc0aeb73
Fix some analysis issues.
...
BUG=
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2882003002 .
2017-05-13 16:24:47 -07:00
Brian Wilkerson
3085734ef6
Generate common types into a separate library
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2880443006 .
2017-05-13 08:12:14 -07:00
Konstantin Shcheglov
a4fd5d814f
Extract PerformanceLogger from AnalysisDriver.
...
I also added the runAsync().
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2883633002 .
2017-05-12 14:27:50 -07:00
danrubel
98825b4918
improve code completion abort request tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2876793006 .
2017-05-12 13:28:39 -07:00
danrubel
69cc6c3183
convert completion tests to use new analysis driver
...
Update more tests and remove dead code from tests
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2875223003 .
2017-05-12 11:48:20 -07:00
Brian Wilkerson
bef53e72e4
Remove unintentional dependency on analysis_server
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2875323002 .
2017-05-12 10:07:37 -07:00
danrubel
66bb2d618e
Remove unused analysisContext from completion request and contributors
...
Now that the analysis server uses the new analysis driver,
the CompletionRequest analysisContext field is always null.
This change removes that field and much of the unused code.
R=brianwilkerson@google.com , pquitslund@google.com
Review-Url: https://codereview.chromium.org/2877653002 .
2017-05-11 09:38:50 -07:00
danrubel
6798cdfcd1
cleanup dart code completion contributors
...
Remove the following unnecessary methods now that analysis driver
resolves everything in the compilation unit upfront.
DartCompletionRequest
* resolveUnits
* resolveImports
* resolveContainingStatement
* resolveContainingExpression
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2873943003 .
2017-05-11 09:12:36 -07:00
Brian Wilkerson
3b2c3ae5b2
Add support for built-in plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2874803003 .
2017-05-10 13:31:20 -07:00
Steve Messick
55097a44b3
Recover from merge problem
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2868383002 .
2017-05-10 13:12:14 -07:00
Brian Wilkerson
a3ac4253b1
Remove an obsolete error from the spec and an obsolete command-line flag
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2865403005 .
2017-05-10 09:33:43 -07:00
Brian Wilkerson
2a4772a537
Remove unnecessary tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2868233003 .
2017-05-10 09:15:36 -07:00
Brian Wilkerson
e6c8092cea
Enable analysis driver in tests where possible
...
R=danrubel@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2868353002 .
2017-05-10 09:13:25 -07:00
danrubel
5b969e04f9
enable new analysis driver for completion sorter tests
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2875483002 .
2017-05-09 16:54:43 -07:00
Brian Wilkerson
947413addc
Remove an obsolete flag from test support
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2875433002 .
2017-05-09 16:39:57 -07:00
Brian Wilkerson
fbc3f3708d
Remove unused reference to SearchEngine
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2872803003 .
2017-05-09 14:32:12 -07:00
Brian Wilkerson
1f893e86a9
Clean up some warnings
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2874443003 .
2017-05-09 13:07:06 -07:00
Brian Wilkerson
98e8f17b96
Convert server to use RangeFactory
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2869083002 .
2017-05-09 10:08:14 -07:00
Konstantin Shcheglov
bd1ee32543
Move [file_]byte_store.dart into pkg/front_end/test/src/incremental/.
...
We are going to reuse ByteStore in front_end, also for incremental
compilation.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2869803004 .
2017-05-09 09:12:15 -07:00
pq
11558c8a90
Add trailing commas after Flutter instance creation params fixes (flutter-intellij/#f978).
...
R=brianwilkerson@google.com
Fixes: https://github.com/flutter/flutter-intellij/issues/978
Review-Url: https://codereview.chromium.org/2864373003 .
2017-05-09 07:00:15 -07:00
danrubel
959b7c14b8
improve completion for formal param initializers
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2864233002 .
2017-05-08 06:50:46 -07:00
danrubel
eb15a4c7c9
add constructor initializer completions
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2869653002 .
2017-05-08 05:52:12 -07:00
Brian Wilkerson
6b8a56cd7f
Switch the default from non-driver to driver in several tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2864813002 .
2017-05-07 08:34:16 -07:00
Brian Wilkerson
863bd921e1
Remove the non-driver versions of several tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2863593004 .
2017-05-05 13:46:03 -07:00
Brian Wilkerson
0b59d3f650
Convert some tests to use the driver and prepare for others to be converted
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2859993004 .
2017-05-05 13:20:38 -07:00
Brian Wilkerson
d2bbfb4f77
Make an AstProvider available to AssistProcessors
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2862143003 .
2017-05-05 09:24:30 -07:00
Brian Wilkerson
6c2023bd07
Move ChangeBuilder to analyzer_plugin
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2860383002 .
2017-05-05 07:52:27 -07:00
pq
1a394e975f
Specify types in generated closure args.
...
Follow-up from: https://github.com/flutter/flutter-intellij/issues/975
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2863683002 .
2017-05-04 12:54:23 -07:00
Brian Wilkerson
4a9092d9c9
Change the ChangeBuilder API to use SourceRange
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2856233003 .
2017-05-04 08:49:01 -07:00
pq
374871da75
Add default implementation when fixing missing required closures (flutter-intellij#975)
...
Fixes: https://github.com/flutter/flutter-intellij/issues/975
Also improves code generation for required lists to include empty list literals.
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2862623002 .
2017-05-03 13:22:52 -07:00
Brian Wilkerson
78eec999e5
Fix a broken test (TBR)
...
Review-Url: https://codereview.chromium.org/2861593003 .
2017-05-03 13:21:00 -07:00