dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
43,582 Commits 2 Branches 0 Tags
be0ce86f435fe169edba593a0d1663cbe956fb1d
Commit Graph

55 Commits

Author SHA1 Message Date
Martin Kustermann 1c7c3408bf VM: [Kernel] Fix constructor invocations by creating the unfolded type argument vector 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2624273002 .
 2017-01-11 20:24:06 +01:00
Martin Kustermann 36b16c6f1c VM: [Kernel] Merge common test expectations from language_kernel.status -> language.status 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2624973004 .
 2017-01-11 20:08:19 +01:00
Martin Kustermann bce0be4540 VM: [Kernel] Add kernel::ConstantEvaluator support for string.length 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2621343002 .
 2017-01-11 19:53:57 +01:00
Martin Kustermann 02018bdb8e VM: [Kernel] Ensure tear-offs of static methods are canonicalized 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2628853003 .
 2017-01-11 19:52:55 +01:00
Martin Kustermann 2f21c261c9 VM: [Kernel] Make type literals which refer to type parameters work 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2623143003 .
 2017-01-11 19:51:42 +01:00
Martin Kustermann 23cc9cca41 VM: [Kernel] Add toString() support for generated enum classes 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2625053003 .
 2017-01-11 19:50:21 +01:00
Florian Loitsch 4095deb7d4 Change "crash" to "dartkcrash" in status file. 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2626943003 .
 2017-01-11 19:40:04 +01:00
Martin Kustermann 673eb56471 VM: [Kernel] Fix remaining issues with kernel-based async/await implementation 
This CL brings us on-par with the VM implementation in terms of tests.

  * Ensure we have saved-try-ctx/exception/stacktrace variables hoisted out for
    try-catch **and** try-finally.

  * Instead of closing the stream controller for 'async*' functions on return we
    do it inside an try-finally block so we get there in terms of normal and
    exceptional exit.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2627873002 .
 2017-01-11 19:35:02 +01:00
Florian Loitsch 71ec2f0297 Implement 'covariant' modifier for dart2js. 
Also adds some tests.

Fixes #28165

BUG= http://dartbug.com/28165
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2626843003 .
 2017-01-11 19:12:48 +01:00
Florian Schneider 204bd5a932 VM: Add missing token position in async rethrow 
Fixes #28325.

R=hausner@google.com

Review-Url: https://codereview.chromium.org/2626753002 .
 2017-01-10 13:49:13 -08:00
Martin Kustermann be01bf89b3 VM: [Kernel] Skip large_class_declaration_test with --compiler=dartk/dartkp 
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2623833003 .
 2017-01-10 10:44:05 +01:00
Regis Crelier 7b68f5a2ee Status update: 3 previously failing kernel tests are now passing, most probably 
fixed by https://codereview.chromium.org/2624543002/

R=hausner@google.com

Review-Url: https://codereview.chromium.org/2621733003 .
 2017-01-09 16:21:41 -08:00
Martin Kustermann 663febe910 VM: [Kernel] Status file triaging of language.status 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2624563002 .
 2017-01-09 22:04:49 +01:00
Martin Kustermann 98e3037f41 Share common failures between kernel and non-kernel in language_kernel.status -> language.status 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2621623002 .
 2017-01-09 13:53:23 +01:00
Florian Schneider 86e902ce5a Fix test status of new test for dartk. 
TBR=vegorov@google.com

BUG=

Review-Url: https://codereview.chromium.org/2617903003 .
 2017-01-05 19:08:09 -08:00
Zach Anderson cf1a432ac7 Gardening: Update status file for kernel crash 
I believe this is by design as there are no mirrors in precompiled
mode.

Review-Url: https://codereview.chromium.org/2616793003 .
 2017-01-05 11:19:49 -08:00
Regis Crelier 4e7ab97a20 Update dartk status file. 
Review-Url: https://codereview.chromium.org/2614743005 .
 2017-01-05 10:34:33 -08:00
Bob Nystrom 45b771f946 Remove tests for generalized tear-offs. 
R=mit@google.com

Review-Url: https://codereview.chromium.org/2608363002 .
 2017-01-04 10:14:41 -08:00
Asger Feldthaus 0546f6b4b7 Support generic method syntax in kernel pipeline. 
Closes https://github.com/dart-lang/sdk/issues/28231
Closes https://github.com/dart-lang/sdk/issues/28238

R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2613683003 .
 2017-01-04 14:25:36 +01:00
Siva Annamalai 4ef532a979 Update status file for enum_syntax_test/05 which is not crashing under dartkp/dart_precompiled/debug mode anymore. 
Review-Url: https://codereview.chromium.org/2609953003 .
 2017-01-03 18:47:03 -08:00
Lasse R.H. Nielsen 821eeb1aac Update expectations for dartk-vm crashes. 
Review-Url: https://codereview.chromium.org/2606343002 .
 2017-01-03 13:38:30 +01:00
Florian Loitsch 5464ae2c93 Update status file. 
Review-Url: https://codereview.chromium.org/2598993003 .
 2016-12-22 18:47:24 +01:00
Florian Loitsch 411e0d60ac Update status file. 
Review-Url: https://codereview.chromium.org/2600543002 .
 2016-12-22 18:07:28 +01:00
Johnni Winther f6b5361adb Support for Null as bottom in dart2js 
Closes #28026

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2595363002 .
 2016-12-22 15:01:33 +01:00
Asger Feldthaus 92f74d21e3 Update kernel status file after configurable import test was added. 
BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2577893006 .
 2016-12-16 15:59:29 +01:00
Martin Kustermann 44b45f8f59 Mark language/generic_sends_test as passing 
Review-Url: https://codereview.chromium.org/2578423002 .
 2016-12-16 10:33:11 +01:00
Vyacheslav Egorov b0a0a42962 VM: [Kernel] Do not crash when encountering generic methods in Kernel. 
Instead do what source based front-end does for now: replace type parameters with dynamic.

BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2571393002 .
 2016-12-15 16:23:42 +01:00
Vyacheslav Egorov ddd6534540 VM: [Kernel] Update status files to mark failing language test. 
BUG=
TBR=kustermann@google.com

Review-Url: https://codereview.chromium.org/2566283006 .
 2016-12-14 00:18:01 +01:00
Martin Kustermann 6a30db5997 Remove sub-errortype DartkMissingCompileTimeError: Since there is a very big overlap between missing CTEs from dartk and from dart_bootstrap 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2563983002 .
 2016-12-09 10:55:03 +01:00
Regis Crelier 6da1083953 Disallow deprecated typedef syntax for mixin apps in the VM (fixes #14410). 
Update status files (will reassign issue #14410 to dart2js, since it still
accepts the syntax).

R=floitsch@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2556433004 .
 2016-12-07 07:34:09 -08:00
Martin Kustermann 117924ed15 Update kernel status files for precompilation after refactoring 
The tests for which dartk is missing a compile-time error will run the precompiler on the result and will therefore have a different status entry (even though it is caused by dartk).

Review URL: https://codereview.chromium.org/2547523002 .
 2016-12-01 14:48:24 +01:00
Martin Kustermann abd77cab64 Refactor kernel-related status files 
To make it clear in the status file whether a crash (or other issues) are coming
from the dartk compiler or from the vm, this CL introduces new status file
markers which are the normal markers prefixed with Dartk (e.g. DartkCrash).

Furthermore this CL groups common failures
  * compiler: dartk & dartkp
  * runtime: vm & dart_precompiled
into shared status file blocks, thereby deduplicating failures (which removes around 500 lines).

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2543973002 .
 2016-12-01 13:48:35 +01:00
Asger Feldthaus ecf9acd26c Update vm-kernel status file. 
BUG=
R=jensj@google.com

Review URL: https://codereview.chromium.org/2538063002 .
 2016-11-30 10:38:21 +01:00
Brian Wilkerson 37bc2efa1f Update status file after enabling read-only access to initializing formals 
Review URL: https://codereview.chromium.org/2538803002 .
 2016-11-29 09:56:27 -08:00
Martin Kustermann 8698589dee VM: [Kernel] Update status file for precompiled (debug) builders 
Review URL: https://codereview.chromium.org/2538713002 .
 2016-11-29 10:32:53 +01:00
Martin Kustermann f81bcb660a VM: [Kernel] Update status file for precompiled (release) builders 
R=vegorov@google.com

Review URL: https://codereview.chromium.org/2537543002 .
 2016-11-28 19:23:23 +01:00
Vyacheslav Egorov 8eceda053f VM: [Kernel] Don't add implicit getters for top level fields into the library dictionary. 
Tree shaker can't cope with this and produces incorrect snapshots that contains tree shaken classes.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org/2536683002 .
 2016-11-28 15:50:24 +01:00
Erik Ernst f234278474 Status updates required after CL 2141023002. 
Review URL: https://codereview.chromium.org/2524363004 .
 2016-11-25 12:16:49 +01:00
Vyacheslav Egorov 73ef820ec1 VM: [Kernel] Relax assertions in SSA construction and in Kernel loading. 
- Kernel-to-IL translation leaves behind some unused constants without temp indices assigned.

- Let compile time errors propagate instead of failing with FATAL error in the post load class finalization.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org/2528763002 .
 2016-11-24 16:19:22 +01:00
Asger Feldthaus b0ffc26dab Fix vm-kernel status file after merging kernel. 
The buildbots run tests against the checked-in version of analyzer,
not the one in the pubspec, which is why the tests behave differently.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2524973002 .
 2016-11-23 14:19:34 +01:00
Asger Feldthaus ce428a1f20 Complete merge of kernel repo into SDK. 
This removes third_party/pkg/kernel and changes dependencies to
refer to pkg/kernel instead.

Some status files are updated to reflect new test outcomes.
 2016-11-23 12:46:29 +01:00
Martin Kustermann 656be7a7aa Update status file for kernel 
Review URL: https://codereview.chromium.org/2525883002 .
 2016-11-23 08:58:18 +01:00
Asger Feldthaus fbb698393d Update third_party/pkg/kernel version 
This CL also updates the use of kernel in dart2js, and
updates the VM/kernel status files.

This is a preliminary step to moving kernel into the
SDK repository.

BUG=
R=het@google.com, johnniwinther@google.com, kmillikin@google.com, sigmund@google.com, vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/5d66d0e5dc32ce06641f360876361a07de821997

Review URL: https://codereview.chromium.org/2518023002 .

Reverted: https://github.com/dart-lang/sdk/commit/d69e048d600468f4a4fe112cb7a750f79e5d9c69
 2016-11-22 15:22:20 +01:00
Asger Feldthaus d69e048d60 Revert "Update third_party/pkg/kernel version" 
This reverts commit 5d66d0e5dc.

BUG=

Review URL: https://codereview.chromium.org/2514323005 .
 2016-11-22 14:35:56 +01:00
Asger Feldthaus 5d66d0e5dc Update third_party/pkg/kernel version 
This CL also updates the use of kernel in dart2js, and
updates the VM/kernel status files.

This is a preliminary step to moving kernel into the
SDK repository.

BUG=
R=het@google.com, johnniwinther@google.com, kmillikin@google.com, sigmund@google.com, vegorov@google.com

Review URL: https://codereview.chromium.org/2518023002 .
 2016-11-22 13:42:13 +01:00
Martin Kustermann 63af3f56ee VM: [Kernel] Cherry-pick from dart-lang/kernel_sdk 
Fix a trio of issues in type finalization.

1. We were using is_type_finalized to detect classes that had already been
   initialized by DilReader::ReadPreliminaryClass.  This state is not
   guaranteed by this function, however is_cycle_free is.

2. In the VM, classes that were created type finalized were not marked as
   cycle free because finalization did not consider them so cycle-freeness
   didn't matter.  We would therefore try to initialize these classes with
   DilReader::ReadPreliminaryClass and mutate types in them.  This causes
   them to have unfinalized types but still have is_type_finalized true.

3. Types in top-level procedures were not necessarily finalized.  A simple
   way to achieve this is to finalize each library's top-level class.

Review URL: https://chromereviews.googleplex.com/520437013 .

R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2514373002 .
 2016-11-21 16:38:30 +01:00
Martin Kustermann 8cb83ecde0 VM: [Kernel] Update status file for debug mode after merge 
R=vegorov@google.com

Review URL: https://codereview.chromium.org/2518983002 .
 2016-11-21 10:51:07 +01:00
Vyacheslav Egorov 57af30e2d5 VM: [Kernel] Make NativeFieldWrapperClass[1-4] constructible when running from Kernel. 
For unclear reason sdk/lib/html/dartium/nativewrappers.dart had these classes
with constructors that would throw. In reality on Kernel ever uses this file so
nobody would use these constructors before anyway.

When running Kernel binaries we need to be able to construct subclasses of
these classes - so they need to have non-throwing constructors.

R=kustermann@google.com
BUG=http://dartbug.com/27590

Review URL: https://codereview.chromium.org/2511083003 .
 2016-11-17 18:59:08 +01:00
Vyacheslav Egorov 23fd1a184b VM: Support bootstrapping core libraries from Kernel binaries instead of source. 
BUG=http://dartbug.com/27590
R=asiva@google.com

Review URL: https://codereview.chromium.org/2485993002 .
 2016-11-16 13:56:20 +01:00
Martin Kustermann 61c0467d41 Implement instance field guards for kernel-based FlowGraphBuilder 
R=vegorov@google.com

Review URL: https://codereview.chromium.org/2469703002 .
 2016-11-01 16:09:22 +01:00