be0ce86f43
Run more analysis tests with the new analysis driver.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2628083002 .
2017-01-11 13:35:46 -08:00
85b1e7abbe
Revert "Add support for generic function type syntax, part 1"
...
Review-Url: https://codereview.chromium.org/2624283003 .
2017-01-11 13:30:52 -08:00
9007ee6a2a
Fix missing parenthesis.
...
Review-Url: https://codereview.chromium.org/2623283003 .
2017-01-11 22:27:51 +01:00
f12527455d
Fix leaks in some parsers tests and triage remaining cc tests.
...
Issue #28342
Issue #28345
Issue #28347
Issue #28348
Issue #28349
R=zra@google.com
Review-Url: https://codereview.chromium.org/2627713005 .
2017-01-11 13:12:32 -08:00
1cd918533d
Add support for generic function type syntax, part 1
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2613383003 .
2017-01-11 13:12:10 -08:00
e197fd81ba
Replace same() with equals() in TypeAssertions.
...
R=brianwilkerson@google.com , leafp@google.com
BUG=
Review-Url: https://codereview.chromium.org/2623283002 .
2017-01-11 12:55:04 -08:00
df45dacb88
Fixes #28338
...
Fix await/cascade bug and corresponding test.
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2628053002 .
2017-01-11 12:37:18 -08:00
799296e92b
Extract x_Driver tests that time out on Windows bots.
...
R=paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2623253003 .
2017-01-11 11:49:34 -08:00
1c7c3408bf
VM: [Kernel] Fix constructor invocations by creating the unfolded type argument vector
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2624273002 .
2017-01-11 20:24:06 +01:00
b9fc9497e2
Update the DEPS file to pull in the latest version of dart_style
...
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2622623004 .
2017-01-11 11:17:20 -08:00
31f08c798a
Don't instantiate a new InterfaceTypeImpl for a ClassElement without type parameters.
...
R=paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2628013002 .
2017-01-11 11:15:40 -08:00
df2ef7fd4b
Speed up AOT compilation of is-tests.
...
* In subtype-tests in the compiler, allocate temporary objects in new-space.
* Add local StackZone to avoid accumulating zone memory.
* Exlude "Function" type from this optimization.
Fixes #28318 .
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2622283004 .
2017-01-11 11:13:17 -08:00
cbf3eaeb90
Fix various memory leaks in unit tests detected by a new version of ASAN.
...
R=zra@google.com
Review-Url: https://codereview.chromium.org/2620413002 .
2017-01-11 11:12:40 -08:00
443f2a0672
Roll latest linter into DEPS.
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2620373002 .
2017-01-11 11:11:48 -08:00
36b16c6f1c
VM: [Kernel] Merge common test expectations from language_kernel.status -> language.status
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2624973004 .
2017-01-11 20:08:19 +01:00
bce0be4540
VM: [Kernel] Add kernel::ConstantEvaluator support for string.length
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2621343002 .
2017-01-11 19:53:57 +01:00
02018bdb8e
VM: [Kernel] Ensure tear-offs of static methods are canonicalized
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2628853003 .
2017-01-11 19:52:55 +01:00
2f21c261c9
VM: [Kernel] Make type literals which refer to type parameters work
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2623143003 .
2017-01-11 19:51:42 +01:00
23cc9cca41
VM: [Kernel] Add toString() support for generated enum classes
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2625053003 .
2017-01-11 19:50:21 +01:00
bfb5ee07b6
Change from "CompileTimeError" to "Fail".
...
Dartium treats compile time errors as runtime errors. "Fail" covers both.
Review-Url: https://codereview.chromium.org/2623073003 .
2017-01-11 19:49:13 +01:00
4095deb7d4
Change "crash" to "dartkcrash" in status file.
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2626943003 .
2017-01-11 19:40:04 +01:00
673eb56471
VM: [Kernel] Fix remaining issues with kernel-based async/await implementation
...
This CL brings us on-par with the VM implementation in terms of tests.
* Ensure we have saved-try-ctx/exception/stacktrace variables hoisted out for
try-catch **and** try-finally.
* Instead of closing the stream controller for 'async*' functions on return we
do it inside an try-finally block so we get there in terms of normal and
exceptional exit.
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2627873002 .
2017-01-11 19:35:02 +01:00
46b7f79fd5
Defer all recursive mixins
...
This defers mixins along with the supertype. It passes Leaf's example on the bug. Will add that as a proper test.
Fixes #28334
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2625913003 .
2017-01-11 10:32:23 -08:00
71ec2f0297
Implement 'covariant' modifier for dart2js.
...
Also adds some tests.
Fixes #28165
BUG= http://dartbug.com/28165
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2626843003 .
2017-01-11 19:12:48 +01:00
e5a45ffb5c
Fix ddc USAGE doc.
...
The only substantive change is adding the missing
"--dart-sdk-summary=build" parameter to building the SDK. I went ahead
and prettied up the Markdown too while I was at it.
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2620203002 .
2017-01-11 09:51:37 -08:00
dae3b69321
Fix the test on Windows.
...
TBR
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2625143002 .
2017-01-11 09:39:22 -08:00
41f8d695b0
Fix an analysis error in tests.
...
TBR
R=paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2622323002 .
2017-01-11 09:22:14 -08:00
73e7da4976
Run the most of error generating tests with the new analysis driver.
...
Some tests have more failures than I feel comfortable marking as failing.
I will triage them in following CLs.
StaticTypeAnalyzer2Test
StrictModeTest
StrongModeDownwardsInferenceTest
StrongModeStaticTypeAnalyzer2Test
TypePropagationTest
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2628743002 .
2017-01-11 08:25:21 -08:00
61eba61153
Gardening: Mark slow subtype_28 and subtype_27 tests in different compilers.
...
R=kustermann@google.com
BUG=28318
Review-Url: https://codereview.chromium.org/2625123002 .
2017-01-11 17:22:47 +01:00
70a4d169c0
Insert covariance checks in strong mode.
...
"Covariance checks" are checks on certain parameters, necessary due to
the unsafe covariant subtyping rule for interface types.
The new pass generates a checked entry point for each method with
covariance checks. This entry point checks the parameters whose type
cannot be trusted, and then calls the actual method implementation.
Every typed call is then redirected to the checked entry point if the
interface taget declares any parameters with unsafe types, unless the
receiver is 'this'.
Dynamic calls and covariant overrides are not addressed by this CL,
these are still unchecked.
BUG=
R=kmillikin@google.com
Review-Url: https://codereview.chromium.org/2618393002 .
2017-01-11 16:33:04 +01:00
fdbdd8a4d8
Add code to ProcessedOptions to fetch the SDK summary bundle.
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2625533002 .
2017-01-11 06:19:40 -08:00
d0624a3815
Small fix to MappedListIterable
...
No need to implement EfficientLengthIterable, it's inherited from ListIterable.
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/2621273002 .
2017-01-11 14:04:44 +01:00
8dd2b15951
Insert implicit downcasts in kernel strong mode.
...
This is implemented as a separate pass, although going forward
I would like the new frontend to insert these checks.
R=kmillikin@google.com
Review-Url: https://codereview.chromium.org/2619193003 .
2017-01-11 13:47:40 +01:00
d2dfc35575
Gardening: mark subtype_t28 as timeout on the vm-kernel config
...
TBR=fschneider@google.com
BUG=28318
Review-Url: https://codereview.chromium.org/2624133002 .
2017-01-11 11:32:55 +01:00
414d66dce6
More offsets in kernel
...
Added offsets to more nodes.
Added end offsets to some nodes.
Added functionnode debuggability flag.
This changes the dill format.
The new offsets et al. are read on the C++ side, but not used
for anything usefull yet.
This is step #2 in introducing these things, next step(s) will be
using it on the C++ side.
R=asgerf@google.com
Review-Url: https://codereview.chromium.org/2626613002 .
2017-01-11 09:59:52 +01:00
cf069d2dfa
Make build.py ensure that goma is started if it is enabled
...
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2620113002 .
2017-01-10 15:09:34 -08:00
9d5c3a9917
Fix Windows path handling in uri_resolver_test.
...
Fixes #28309
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2628653002 .
2017-01-10 15:09:17 -08:00
a1579c6a45
Fuchsia: Implement recursive delete
...
Currently, readdir() doesn't fill out d_type correctly, so we just do
an extra stat() to get the file type.
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2621093002 .
2017-01-10 15:08:39 -08:00
499248e4e4
Fix for 27467 - dart2js error with re-entrant static initializer
...
BUG=
R=lrn@google.com
Review-Url: https://codereview.chromium.org/2620123002 .
2017-01-10 14:57:26 -08:00
d54341927e
Change test to work with app-snapshots.
...
App snapshot don't contain column information. Change the expectation to
only expect line numbers.
R=hausner@google.com
Review-Url: https://codereview.chromium.org/2624023002 .
2017-01-10 14:29:07 -08:00
204bd5a932
VM: Add missing token position in async rethrow
...
Fixes #28325 .
R=hausner@google.com
Review-Url: https://codereview.chromium.org/2626753002 .
2017-01-10 13:49:13 -08:00
dfde15a8be
Gardening: mark regexp pcre_test slow/timeout in precompiled code
...
This test seems to be slow in any configuration. There are old bugs,
e.g. 21593 and 22008 that mention the slowness and flakiness, but there
are no takers to either fix the regexp code or make the test smaller.
Note: in precompiled mode, the regular expression code is interpreted, and thus actually slower than in the JIT version of the test.
BUG=
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2624733005 .
2017-01-10 13:03:49 -08:00
65ff5b5e50
Explicitly compute analysis results for sources to check errors.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2625783002 .
2017-01-10 12:58:58 -08:00
be95523221
Cleanup references to the old DDC repo
...
Reachable issues migrated over.
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2621543004 .
2017-01-10 12:56:29 -08:00
42341c2abc
fix regression to analysis_server tests
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2622953002 .
2017-01-10 11:02:32 -08:00
245e62280e
Fuchsia: Pass a job to launchpad_create()
...
This API will change soon such that passing 0 for the
job handle will prevent spawned processes from creating
new processes themselves.
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2621783003 .
2017-01-10 11:01:09 -08:00
5a3afed30f
Make error producing tests ansynchronous.
...
This is another preliminary test to run these tests with the new
analysis driver. Especially when we're going to replace the task based
analysis implementation with another one.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2624793002 .
2017-01-10 10:33:44 -08:00
4b497fb319
Fixed checked mode error for resolvePackageUri.
...
TBR=asiva@google.com
Review-Url: https://codereview.chromium.org/2626643003 .
2017-01-10 09:00:16 -08:00
6a6ea68f88
Gardening: mark tests that are timing out as slow
...
R=kustermann@google.com
Review-Url: https://codereview.chromium.org/2624733003 .
2017-01-10 17:59:16 +01:00
b5c5c1c222
Remove computeLibrarySourceErrors().
...
All errors are computed and validated in assertErrors().
In a 3 tests assertErrors() for the library was mved before the call
for a part to ensure library/part link establishment.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2626653002 .
2017-01-10 08:44:48 -08:00
Konstantin Shcheglov