Commit Graph

1094 Commits

Author SHA1 Message Date
Matthias Hausner dfde15a8be Gardening: mark regexp pcre_test slow/timeout in precompiled code
This test seems to be slow in any configuration. There are old bugs,
e.g. 21593 and 22008 that mention the slowness and flakiness, but there
are no takers to either fix the regexp code or make the test smaller.

Note: in precompiled mode, the regular expression code is interpreted, and thus actually slower than in the JIT version of the test.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2624733005 .
2017-01-10 13:03:49 -08:00
Regis Crelier dc0605012f Move Null type to the Bottom in the VM (fixes #28025).
Fix wrong comments.

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2608373002 .
2017-01-05 10:05:31 -08:00
Florian Loitsch 59ffd06f15 Update status file.
Review-Url: https://codereview.chromium.org/2598183002 .
2016-12-23 11:51:28 +01:00
Johnni Winther dd1a470dda No luck at status-bingo
Review-Url: https://codereview.chromium.org/2600503002 .
2016-12-22 15:27:52 +01:00
Johnni Winther f6b5361adb Support for Null as bottom in dart2js
Closes #28026

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2595363002 .
2016-12-22 15:01:33 +01:00
Kasper Lund 0efa6cfda0 Revert "Update status"
This reverts commit 5fdc195aa1 and follows
the revert of the dart2js support for null-as-bottom.

TBR'ed.

R=johnniwinter@google.com
BUG=

Review-Url: https://codereview.chromium.org/2592373002 .
2016-12-22 09:53:14 +01:00
Johnni Winther 5fdc195aa1 Update status
Review-Url: https://codereview.chromium.org/2594013002 .
2016-12-21 16:36:35 +01:00
Harry Terkelsen c78814326c Update jsshell to 50.0
R=sra@google.com

Review URL: https://codereview.chromium.org/2552123003 .
2016-12-06 16:58:15 -08:00
Ryan Macnak 1ebeb79942 Remove runtime 'dart_app' as it became identical to 'vm'.
Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing.

Update status files to reflect these changes.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2541533004 .
2016-12-01 16:47:33 -08:00
William Hesse e2a48dbf38 Update status for failing tests
BUG=https://github.com/dart-lang/sdk/issues/27925
R=eernst@google.com

Review URL: https://codereview.chromium.org/2536183002 .
2016-11-29 14:26:27 +01:00
William Hesse 6f7005ee71 Update status for co19 tests on browsers.
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2538443002 .
2016-11-28 16:32:41 +01:00
Lasse Reichstein Holst Nielsen 7957a1c256 Make EfficientLength extend Iterable.
This should help least-upper-bound computations to not think of EfficientLength
as completely separate from Iterable even though they are always used together.

It doesn't solve all problems with the least-upper-bound computation,
but at least some of the more often occuring ones.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2467113003 .

Committed: https://github.com/dart-lang/sdk/commit/b08fb1373f88121bb4056adce9b71849a5bede2a
2016-11-28 08:04:04 +01:00
William Hesse 4bfe727db6 Update status for Firefox 50
BUG=https://github.com/dart-lang/sdk/issues/27873
BUG=https://github.com/dart-lang/sdk/issues/27872
BUG=https://github.com/dart-lang/sdk/issues/27871
BUG=https://github.com/dart-lang/sdk/issues/27867
R=sortie@google.com

Review URL: https://codereview.chromium.org/2526493004 .
2016-11-23 09:49:01 +01:00
Vyacheslav Egorov 2403444eba VM: Optimize RegExp.matchAsPrefix(...) by generating a sticky RegExp specialization.
This is the same as a sticky RegExp flag in ES2015.

Overlay some RegExp fields on top of each other - given that they should never be used simultaneously.

BUG=http://dartbug.com/27810
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2510783002 .
2016-11-17 17:46:21 +01:00
John McCutchan 50b47360bd Update more status files for hot reload bots
BUG=

Review URL: https://codereview.chromium.org/2500343003 .
2016-11-15 07:34:03 -08:00
Ryan Macnak 3658a16e47 DBC: When calling DRT_OptimizeInvokedFunction, patch the stack to have a stub instead of the to-be-optimized function as the caller.
Fixes #27746

R=fschneider@google.com, zra@google.com

Review URL: https://codereview.chromium.org/2473213002 .
2016-11-04 09:51:02 -07:00
Florian Schneider 6fa4a54bba DBC: Fix smi shl with large (>word-size) shift counts
Insert check to guard against large shift counts.

Integer shifts with shift counts greater or equal than the number
of bits per word are undefined behavior in C/C++.

Fixes #27474.

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2474103003 .
2016-11-04 12:16:34 +01:00
Florian Schneider de6b131857 Temporarily skip flaky tests for DBC
BUG=#27746

Review URL: https://codereview.chromium.org/2477753002 .
2016-11-03 15:08:42 +01:00
Florian Schneider 44418359e0 DBC: Handle constants correctly in the optimizing backend
We don't always allocate a register for constants in optimized code. Instead
they are copied into registes as needed by parallel moves at the use site.

Fixes #27731.

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2477653002 .
2016-11-03 12:24:05 +01:00
Ryan Macnak d8bb15f915 Mark failing DBC tests.
Issue #27731
Issue #27732
Issue #27733

R=zra@google.com

Review URL: https://codereview.chromium.org/2465253007 .
2016-11-02 15:28:57 -07:00
Ryan Macnak 6cf5c3baa3 Revert "Make EfficientLength extend Iterable."
This reverts commit b08fb1373f.

TBR=lrn@google.com

Review URL: https://codereview.chromium.org/2467283003 .
2016-11-02 13:20:41 -07:00
Lasse R.H. Nielsen b08fb1373f Make EfficientLength extend Iterable.
This should help least-upper-bound computations to not think of EfficientLength
as completely separate from Iterable even though they are always used together.

It doesn't solve all problems with the least-upper-bound computation,
but at least some of the more often occuring ones.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2467113003 .
2016-11-02 14:05:35 +01:00
Florian Loitsch 6beb1fdd11 Change Set.difference API to accept Set<Object>.
Fixes #27573
BUG= http://dartbug.com/27573
R=lrn@google.com

Review URL: https://codereview.chromium.org/2413233002 .
2016-10-20 14:37:15 +02:00
Florian Schneider 6d66f3dea8 VM: Make optimized try-catch work in DBC.
The catch entry block has all locals in fixed locations
(Rj) where j = kNumberOfRegisters - i for parameter i.

This means we reserve a range of DBC registers at the top-end of the frame.
Those registers are blocked for general allocation to avoid any overlap
with the rest of the registers that are allocated from the bottom.

Each optimized frame with a try-catch will be kNumberOfRegisters wide.

BUG=
R=vegorov@google.com

Review URL: https://codereview.chromium.org/2388093003 .
2016-10-13 11:36:23 -07:00
Florian Schneider 8a7dabe522 Temporarily update status for 2 tests on SIMDBC.
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/2388363002 .
2016-10-04 09:25:44 -07:00
Lasse R.H. Nielsen 9bd4406d4b Fix bug in _SimpleUri.resolve.
In some cases it didn't follow our non-RFC behavior for resolving a relative
path on top of another relative path.

Fixes issue #27447
BUG= http://dartbug.com/27447
R=eernst@google.com

Review URL: https://codereview.chromium.org/2374253004 .
2016-09-29 15:00:42 +02:00
Sigmund Cherem fc0bf7a85b First set of test triage for fast-startup
Review URL: https://codereview.chromium.org/2285823002 .
2016-08-26 10:04:41 -07:00
Lasse R.H. Nielsen 99ec987a09 Remove deprecated Resource class from dart:core.
BUG=
R=floitsch@google.com, mit@google.com

Review URL: https://codereview.chromium.org/2272373002 .

Committed: https://github.com/dart-lang/sdk/commit/f61143153a9aee2738bf3bf83d447e016f41e653
Committed: https://github.com/dart-lang/sdk/commit/35437dda1f8b120d4b241a0a4925071a16f42442
2016-08-26 11:58:04 +02:00
Lasse Nielsen 35437dda1f Remove deprecated Resource class from dart:core.
BUG=
R=floitsch@google.com, mit@google.com

Review URL: https://codereview.chromium.org/2272373002 .

Committed: https://github.com/dart-lang/sdk/commit/f61143153a9aee2738bf3bf83d447e016f41e653
2016-08-26 10:50:58 +02:00
Lasse Nielsen f61143153a Remove deprecated Resource class from dart:core.
BUG=
R=floitsch@google.com, mit@google.com

Review URL: https://codereview.chromium.org/2272373002 .
2016-08-26 10:31:08 +02:00
Lasse R.H. Nielsen afbbbb97cf Reapply fast-URI patch.
Review URL: https://codereview.chromium.org/2245533004 .
2016-08-17 10:54:24 +02:00
Florian Schneider 021ebb2033 Correct and GC unrecognized flags from our tests.
Fix some misspelled flags.

Remove some non-existent flags.

Fix --short_socket_read and --short_socket_write flags used in IO tests.

Running with --ignore-unrecognized-flags is still on because some flags are only visible
in DEBUG mode.

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2247733005 .
2016-08-15 18:28:11 -07:00
Lasse R.H. Nielsen 3502fd5fd7 Revert "Reapply fast-URI patch."
Seems to trigger VM bug.

Review URL: https://codereview.chromium.org/2225243003 .
2016-08-09 12:51:58 +02:00
Lasse R.H. Nielsen 99e94db85b Reapply fast-URI patch.
R=whesse@google.com

Review URL: https://codereview.chromium.org/2220373002 .
2016-08-09 09:38:47 +02:00
William Hesse ca49303576 Revert "Add fast-mode Uri class."
This reverts commit 00090a0c72.

Revert "Add fast-mode Uri class."

This reverts commit 323ca7e410.

Revert "Fix regression for the one case where we deliberately don't follow the RFC."

This reverts commit b39e048c4b.

Revert "Cache hashCode in Uri implementations to improve performance when used as, e.g., Map key."

This reverts commit a11ad27723.

BUG=https://github.com/dart-lang/sdk/issues/26917
TBR=keertip@google.com

Review URL: https://codereview.chromium.org/2167663002 .
2016-07-20 14:32:52 +02:00
Keerti Parthasarathy 69a8b11f67 Fix for uri replace whene uri has fragment. Was adding a second '#'.
BUG=
R=het@google.com

Review URL: https://codereview.chromium.org/2158933003 .
2016-07-18 16:31:43 -07:00
Stephen Adams 1eee3c7dc7 dart2js js_runtime: faster code for floor() & ceil()
Within the [-2^31, 2^31) range it is faster to truncate and correct at boundaries than call Math.ceil/Math.floor.

Each call to toInt() has been specialized to the calling operator (ceil, floor, ~/ etc).

This makes the conversion faster (values are already integral) and lets us put the name of the operation and original operands in conversion errors, e.g

(a / b).floor();  // b == 0
Unsupported operation: Infinity
-->
Unsupported operation: Infinity.floor()

a ~/ b;   // b == 0
Unsupported operation: Infinity
-->
Unsupported operation: Result of truncating division is Infinity: 132 ~/ 0

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1405113003 .

Downside: an extra 400 bytes
2016-07-15 12:27:59 -07:00
Brian Wilkerson afd21330f7 Generalize the first argument in an assert to be an expression (issue 26865)
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2140673004 .
2016-07-12 11:02:51 -07:00
John McCutchan ef71bc1834 Improve hot reload test mode
- [x] Start reloading even earlier.
- [x] Keep the value of FLAG_reload_every per-isolate (so spawned isolates reload eagerly too).
- [x] Adjust the reload every back off curve to be linear in the beginning.
- [x] Cap the reload every threshold at 1,000,000
- [x] Test status file updates.
- [x] Stop disabling the background compiler / OSR when running tests.
- [x] Skip multi tests with compilation errors when reloading.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2133823002 .
2016-07-11 12:29:13 -07:00
William Hesse c87a720c86 Update status for package_resource_test
BUG=https://github.com/dart-lang/sdk/issues/26842
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2131263002 .
2016-07-08 17:38:29 +02:00
Johnni Winther 4764bbc66f Update status for package_resource_test.
Review URL: https://codereview.chromium.org/2130373002 .
2016-07-08 16:18:41 +02:00
Ryan Macnak eb20b68e87 Add --hot-reload to the test harness.
./tools/build.py -mdebug,release runtime
./tools/test.py -mdebug,release --checked --hot-reload

BUG=http://dartbug.com/26809
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2114083002 .
2016-07-01 11:28:00 -07:00
Lasse R.H. Nielsen b39e048c4b Fix regression for the one case where we deliberately don't follow the RFC.
The new code didn't have that exception.

Also optimize some string operations when it's possible.

R=eernst@google.com

Review URL: https://codereview.chromium.org/2117453002 .
2016-06-30 14:52:23 +02:00
Lasse R.H. Nielsen 323ca7e410 Add fast-mode Uri class.
Optimize parser and make it recognize a class of URIs that don't need extra
handling: no escapes, no funny characters, already (nearly or completely)
normalized.
Have a class specifically for those URIs which retains the original
input string without having allocate any further strings.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/00090a0c7237b636a73f048e53966879e74ec55a

Review URL: https://codereview.chromium.org/2086613003 .
2016-06-30 13:25:36 +02:00
Lasse R.H. Nielsen 00090a0c72 Add fast-mode Uri class.
Optimize parser and make it recognize a class of URIs that don't need extra
handling: no escapes, no funny characters, already (nearly or completely)
normalized.
Have a class specifically for those URIs which retains the original
input string without having allocate any further strings.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2086613003.
2016-06-30 12:20:15 +02:00
Zach Anderson 22e449ba09 Fix Windows time zone name extraction. Update API docs
On Windows, the OS provides a full name for the time zone
rather than an abbreviation. Further the string may
contain non-ASCII characters, so a conversion is
necessary. This CL updates the API docs to match the
actual behavior, and fixes the string conversion problem.

fixes #17085

R=asiva@google.com

Review URL: https://codereview.chromium.org/2069783002 .
2016-06-14 13:51:19 -07:00
Todd Turnidge a7d46eb5a6 Canonicalize uris in C++ instead of Dart for the standalone embedder.
Adds Dart_DefaultCanonicalizeUrl() to the dart embedding api.

Motivation:

As we try to get source reloading working for the standalone embedder, things get simpler if an isolate doesn't run Dart code while it is loading Dart code.  We intend to solve this by moving the embedder tag handler calls to the service isolate.  But making a blocking rpc into the service isolate whenever a url needs to be canonicalized during parsing seems like it would slow things down and make things complicated.  By moving canonicalization into C++, we avoid this.

R=ahe@google.com, fschneider@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2011543002 .
2016-06-02 12:29:57 -07:00
Ryan Macnak ef8baa8760 Add test harness option for app snapshots with unoptimized code.
./tools/test.py -m all -c dart2appjit -r dart_app --use-blobs

Rename 'dart_product' runtime to 'dart_app'.

Rename Dart_PrecompiledJITSnapshotBlob to Dart_CreateAppJITSnapshot and add documentation.

Remove out-of-date scripts in tools/precompilation.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/1992703005 .
2016-05-26 10:37:47 -07:00
Lasse R.H. Nielsen fbf64bb7a5 Make Iterable.toList more efficient if the length is known.
Add more tests. Fix (some) bugs found by tests.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/1999793002.
2016-05-23 10:00:19 +02:00
Lasse R.H. Nielsen 5d6e8bcda1 Make Iterable.generate use ListIterable as base implementation.
This makes it work the same as a List like the documentation claims.

Update documentation of Future.doWhile, and a few other documentation fixes.

BUG= http://dartbug.com/26358
BUG= http://dartbug.com/26462
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1992713002.
2016-05-18 13:52:10 +02:00