dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
43,582 Commits 2 Branches 0 Tags
be0ce86f435fe169edba593a0d1663cbe956fb1d
Commit Graph

13951 Commits

Author SHA1 Message Date
Vijay Menon df45dacb88 Fixes #28338 
Fix await/cascade bug and corresponding test.

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2628053002 .
 2017-01-11 12:37:18 -08:00
Martin Kustermann 1c7c3408bf VM: [Kernel] Fix constructor invocations by creating the unfolded type argument vector 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2624273002 .
 2017-01-11 20:24:06 +01:00
Florian Schneider df2ef7fd4b Speed up AOT compilation of is-tests. 
* In subtype-tests in the compiler, allocate temporary objects in new-space.
* Add local StackZone to avoid accumulating zone memory.
* Exlude "Function" type from this optimization.

Fixes #28318.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2622283004 .
 2017-01-11 11:13:17 -08:00
Martin Kustermann 36b16c6f1c VM: [Kernel] Merge common test expectations from language_kernel.status -> language.status 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2624973004 .
 2017-01-11 20:08:19 +01:00
Martin Kustermann bce0be4540 VM: [Kernel] Add kernel::ConstantEvaluator support for string.length 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2621343002 .
 2017-01-11 19:53:57 +01:00
Martin Kustermann 02018bdb8e VM: [Kernel] Ensure tear-offs of static methods are canonicalized 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2628853003 .
 2017-01-11 19:52:55 +01:00
Martin Kustermann 2f21c261c9 VM: [Kernel] Make type literals which refer to type parameters work 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2623143003 .
 2017-01-11 19:51:42 +01:00
Martin Kustermann 23cc9cca41 VM: [Kernel] Add toString() support for generated enum classes 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2625053003 .
 2017-01-11 19:50:21 +01:00
Florian Loitsch bfb5ee07b6 Change from "CompileTimeError" to "Fail". 
Dartium treats compile time errors as runtime errors. "Fail" covers both.

Review-Url: https://codereview.chromium.org/2623073003 .
 2017-01-11 19:49:13 +01:00
Florian Loitsch 4095deb7d4 Change "crash" to "dartkcrash" in status file. 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2626943003 .
 2017-01-11 19:40:04 +01:00
Martin Kustermann 673eb56471 VM: [Kernel] Fix remaining issues with kernel-based async/await implementation 
This CL brings us on-par with the VM implementation in terms of tests.

  * Ensure we have saved-try-ctx/exception/stacktrace variables hoisted out for
    try-catch **and** try-finally.

  * Instead of closing the stream controller for 'async*' functions on return we
    do it inside an try-finally block so we get there in terms of normal and
    exceptional exit.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2627873002 .
 2017-01-11 19:35:02 +01:00
Vijay Menon 46b7f79fd5 Defer all recursive mixins 
This defers mixins along with the supertype.  It passes Leaf's example on the bug.  Will add that as a proper test.

Fixes #28334

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2625913003 .
 2017-01-11 10:32:23 -08:00
Florian Loitsch 71ec2f0297 Implement 'covariant' modifier for dart2js. 
Also adds some tests.

Fixes #28165

BUG= http://dartbug.com/28165
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2626843003 .
 2017-01-11 19:12:48 +01:00
Erik Corry 61eba61153 Gardening: Mark slow subtype_28 and subtype_27 tests in different compilers. 
R=kustermann@google.com
BUG=28318

Review-Url: https://codereview.chromium.org/2625123002 .
 2017-01-11 17:22:47 +01:00
Asger Feldthaus 8dd2b15951 Insert implicit downcasts in kernel strong mode. 
This is implemented as a separate pass, although going forward
I would like the new frontend to insert these checks.

R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2619193003 .
 2017-01-11 13:47:40 +01:00
Erik Corry d2dfc35575 Gardening: mark subtype_t28 as timeout on the vm-kernel config 
TBR=fschneider@google.com
BUG=28318

Review-Url: https://codereview.chromium.org/2624133002 .
 2017-01-11 11:32:55 +01:00
Stephen Adams 499248e4e4 Fix for 27467 - dart2js error with re-entrant static initializer 
BUG=
R=lrn@google.com

Review-Url: https://codereview.chromium.org/2620123002 .
 2017-01-10 14:57:26 -08:00
Florian Schneider d54341927e Change test to work with app-snapshots. 
App snapshot don't contain column information. Change the expectation to
only expect line numbers.

R=hausner@google.com

Review-Url: https://codereview.chromium.org/2624023002 .
 2017-01-10 14:29:07 -08:00
Florian Schneider 204bd5a932 VM: Add missing token position in async rethrow 
Fixes #28325.

R=hausner@google.com

Review-Url: https://codereview.chromium.org/2626753002 .
 2017-01-10 13:49:13 -08:00
Matthias Hausner dfde15a8be Gardening: mark regexp pcre_test slow/timeout in precompiled code 
This test seems to be slow in any configuration. There are old bugs,
e.g. 21593 and 22008 that mention the slowness and flakiness, but there
are no takers to either fix the regexp code or make the test smaller.

Note: in precompiled mode, the regular expression code is interpreted, and thus actually slower than in the JIT version of the test.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2624733005 .
 2017-01-10 13:03:49 -08:00
Dmitry Olshansky 6a6ea68f88 Gardening: mark tests that are timing out as slow 
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2624733003 .
 2017-01-10 17:59:16 +01:00
Dmitry Olshansky aa583a0ec2 Gardening: mark flaky test on SIMMIPS 
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2622933002 .
 2017-01-10 16:50:30 +01:00
Terry Lucas 559ae993d1 Added VMLibraryHooks setup for Dartium to support resolvePackageUri. 
BUG=25594
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2611353002 .
 2017-01-10 07:25:10 -08:00
Florian Loitsch 2547caab25 Reapply "reflectType() dynamic type arguments support (#26012)" 
This was a pull request: 8a8033a417

MirrorsUsed doesn't transitively include reflective information. However, it must still be able to create TypeMirrors for types that are used as return- or parameter types.

Initially, the patch checked that TypeMirrors had the correct number of arguments for generic types. This is now disabled.

A better approach would be to know if a class has full reflective information, or not. But this would require much bigger changes to the system.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2615943004 .
 2017-01-10 15:53:21 +01:00
Martin Kustermann be01bf89b3 VM: [Kernel] Skip large_class_declaration_test with --compiler=dartk/dartkp 
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2623833003 .
 2017-01-10 10:44:05 +01:00
Regis Crelier 7b68f5a2ee Status update: 3 previously failing kernel tests are now passing, most probably 
fixed by https://codereview.chromium.org/2624543002/

R=hausner@google.com

Review-Url: https://codereview.chromium.org/2621733003 .
 2017-01-09 16:21:41 -08:00
Martin Kustermann 663febe910 VM: [Kernel] Status file triaging of language.status 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2624563002 .
 2017-01-09 22:04:49 +01:00
Jennifer Messerly 816592a941 fixes #28236, generic methods should not cause warnings in Dart 1 
Instantiate universal functions in subtype tests & tear-offs. Also updates the status files and one Analyzer test that covered the tear-off type.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2621433003 .
 2017-01-09 12:46:20 -08:00
Ryan Macnak 6840abebd6 Unmark 3 tests in precomp debug as slow following change to debug from -O1 to -O2. 
This reverts commit 8222b4deda.

Review-Url: https://codereview.chromium.org/2622483004 .
 2017-01-09 11:11:36 -08:00
Jacob Richman badfd146d2 Fix type error in js_dart2js.dart caught by DDC. 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2611423002 .
 2017-01-09 07:42:49 -08:00
John McCutchan bd5e949226 Mark io/raw_socket_test as flakey 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2610893006 .
 2017-01-09 07:39:52 -08:00
Vyacheslav Egorov aa39062c0a VM: [Kernel] Remove custom expectations for generic closurization tests. 
This feature is removed from the VM and now these tests fail with compile error on VM's source front-end too.

BUG=http://dartbug.com/28263
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2619323002 .
 2017-01-09 16:31:27 +01:00
Martin Kustermann 98e3037f41 Share common failures between kernel and non-kernel in language_kernel.status -> language.status 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2621623002 .
 2017-01-09 13:53:23 +01:00
Johnni Winther d1ef805c38 Use entities in the TypeMask interface. 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2613833005 .
 2017-01-09 10:46:51 +01:00
Jens Johansen 8222b4deda Gardening: Marked 3 tests in precomp debug as slow. 
BUG=

Review-Url: https://codereview.chromium.org/2620613004 .
 2017-01-09 09:38:32 +01:00
Emily Fortuna 745c2989f4 Reapply 0c78abd090 
"Ensure we're looking at the correct resolved AST when initializing fields in constructors."

BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2614983004 .
 2017-01-06 11:01:39 -08:00
Asger Feldthaus 6bae3151e2 Revert "reflectType() dynamic type arguments support (#26012)" 
This reverts commit 8a8033a417.

There are a bunch of dart2js mirror tests that fail.

Issue https://github.com/dart-lang/sdk/pull/26012

BUG=

Review-Url: https://codereview.chromium.org/2617163002 .
 2017-01-06 19:12:27 +01:00
Asger Feldthaus 6d6df75271 Mark html/fileapi_test/entry as flaky on chrome. 
Likely related issue: https://github.com/dart-lang/sdk/issues/20488

BUG=
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2615153003 .
 2017-01-06 16:51:46 +01:00
Anatoly Pulyaevskiy 8a8033a417 reflectType() dynamic type arguments support (#26012) 
* Basic implementation of reflecting generic types using dynamic list of type arguments

* Removed redundant expectation in test

* Added basic support for dynamic type arguments in reflectType of js_mirrors

* Fixes according to code review comments: major cleanup, added more test cases and updated docs

* Updated JS mirrors reflectType() to match behavior of VM implementation

* Terminate exception messages with a dot; Improved error handling for empty argument list and type checks;

* Use NumTypeParameters when checking provided argument list size

* Check if type arguments are malbounded; added test cases for typedefs and mixins

* Uncommented a test case

* Updated lib.status to mark some tests as failing in dart2js due to limitations in JS mirrors

* Fixed mixin test mock definition; updated configuration for tests requiring checked mode

* Handle nested generic types in type argument parsing (JS)
 2017-01-06 06:05:14 -08:00
Florian Loitsch e0abc45287 Add test that crashes dart2js. 
When a typedef compilation fails, it seems to replace itself with a dynamic type. However, that type leads to a crash later in the pipeline.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2607133002 .
 2017-01-06 13:27:35 +01:00
Asger Feldthaus 492c6c5b13 Skip language_strong/generic_tearoff_test. 
The test passes a generic function value of type <T>(T,T)=>T as argument
to a parameter that expects (int,int)=>int.

DDC implicitly instantiates the function, but this is not seen as the
correct behavior by the language team, so we will not try to reproduce
it.

BUG=
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2610923008 .
 2017-01-06 13:11:19 +01:00
Johnni Winther e43c9e732b Disable test for fast-startup. 
Review-Url: https://codereview.chromium.org/2618753005 .
 2017-01-06 09:41:51 +01:00
Florian Schneider 97acc859cc Make test work with Dartium. 
Dartium requires main() to have zero arguments. Standalone VM accepts both.

TBR=asiva@google.com,

Review-Url: https://codereview.chromium.org/2613203002 .
 2017-01-05 21:37:10 -08:00
Florian Schneider 86e902ce5a Fix test status of new test for dartk. 
TBR=vegorov@google.com

BUG=

Review-Url: https://codereview.chromium.org/2617903003 .
 2017-01-05 19:08:09 -08:00
Florian Schneider 4347f9f0a2 Fix test status for hot-reload for a new test 
The test uses deferred libraries which are not supported with hot reload.

TBR=johnmccutchan@google.com,

Review-Url: https://codereview.chromium.org/2616053002 .
 2017-01-05 18:41:02 -08:00
Florian Schneider 9c82d88d67 VM: Fix bug in deferred loading. 
In some cases when loading a deferred library twice, the VM would crash/throw.

Make sure we generate the correct static NoSuchMethod error when referring to
a deferred library that is not loaded yet.

Fixes #28278.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2618823002 .
 2017-01-05 18:20:51 -08:00
Emily Fortuna 5f60d0c3c4 Revert "Ensure we're looking at the correct resolved AST when initializing fields in constructors." 
This reverts commit 0c78abd090.

The change to in-memory tests requires a little more finesse than what is written. Backing out to redo.

BUG=

Review-Url: https://codereview.chromium.org/2615173002 .
 2017-01-05 17:53:04 -08:00
Emily Fortuna 0c78abd090 Ensure we're looking at the correct resolved AST when initializing fields in constructors. 
Step 30 of bagilliondy.

BUG=https://github.com/dart-lang/sdk/issues/27394
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2616933003 .
 2017-01-05 16:19:57 -08:00
Regis Crelier e8d1c09d34 Add mirrors tests for Null type. 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2617743002 .
 2017-01-05 13:27:14 -08:00
Zach Anderson cf1a432ac7 Gardening: Update status file for kernel crash 
I believe this is by design as there are no mirrors in precompiled
mode.

Review-Url: https://codereview.chromium.org/2616793003 .
 2017-01-05 11:19:49 -08:00