87e045c484
Remove the helper dart script from our browser test framework
...
BUG=https://github.com/dart-lang/sdk/issues/32539
Change-Id: Ia1d5c04babf21e244c807f32a21b43198a7151a5
Reviewed-on: https://dart-review.googlesource.com/60845
Reviewed-by: Jonas Termansen <sortie@google.com >
2018-06-19 08:43:55 +00:00
1a443da6ad
Adjust options passed to precompile runtime.
...
Change-Id: I6c825a5a0b2f1f6ee9f7e16e06db727239d30b5e
Reviewed-on: https://dart-review.googlesource.com/60834
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-06-19 06:44:54 +00:00
bc7220a4fd
[VM] Turn dart2 on by default on the command line VM
...
- make Dart2 the default option for the command line VM
- add option --no-preview-dart-2 as a fallback option to run dart1
- change test scripts to use the executable dart for testing dart2 mode instead of
pkg/vm/tool/dart2
- adjust numerous build and test configurations
Change-Id: Id813fa5b71a89c7ec9335d3f6e83cfc9f35f86e7
Reviewed-on: https://dart-review.googlesource.com/58240
Commit-Queue: Siva Annamalai <asiva@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2018-06-18 22:31:32 +00:00
8fedfc7f8c
Removed DomName, DosEditable, and experimental annoations they are unused.
...
R=kevmoo@google.com ,vsm@google.com
Fixes #32304
Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2018-06-18 18:48:03 +00:00
e2d72aad91
Prepare tools/bots/try_benchmarks.sh for Dart 2.
...
Change-Id: Ifa56dc223b9f559df6cf7b0d95569a30a4a2ebec
Reviewed-on: https://dart-review.googlesource.com/59883
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2018-06-17 04:44:45 +00:00
aabb78f56a
Update checked-in SDK to 2.0.0-dev.63.0 on mac and linux.
...
Windows is already updated to -dev.63.0
Change-Id: If01455bc865f984e456911359a0802b942ac3085
Reviewed-on: https://dart-review.googlesource.com/60501
Reviewed-by: Jenny Messerly <jmesserly@google.com >
2018-06-15 22:38:00 +00:00
82ed18cdb9
Update checked-in Windows SDK to 2.0.0-dev.63.0
...
Linux and Mac SDKs will be updated in a follow-up commit.
Change-Id: I23277bce01257409c8a8634ea5dbe58981f76bf1
Reviewed-on: https://dart-review.googlesource.com/60460
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2018-06-15 20:04:56 +00:00
dd8988c9b2
- Moved all WebGL rendering/drawing constants to synthesized class WebGL.
...
- Removed obsolete Dartium/_blink code.
R=kevmoo@google.com
Change-Id: I81a6f0d5bfe33592ff8ae9c85db9266e898c2861
Reviewed-on: https://dart-review.googlesource.com/60380
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2018-06-15 17:08:54 +00:00
f479435bca
- Removed custom handling of fill - it was wrong the method is now overloaded.
...
- Associate the JS class SpeechSyntesisVoice with the correct Dart class (DDC).
- Top-level querySelectorAll wasn't generic.
- Handle "static" for attributes in the IDLs.
Fixes #33147
Fixes #33178
Fixes #31886
Fixes #20585
R=vsm@google.com
Change-Id: Ic75a2bfc66670b72342269be259408b610547dab
Reviewed-on: https://dart-review.googlesource.com/59240
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2018-06-15 02:25:13 +00:00
1ef4399df0
Run dartfmt --fix for dart2 on pkg/dev_compiler
...
This uses optional new/const and `=` in named argument defaults.
All changes are automated, except for:
- utils/dartdevc/BUILD.gn: run DDC build scripts with --preview-dart-2
- pkg/dev_compiler/tool/patch_sdk.dart: add a TODO that Analyzer doesn't
supporting implicit const in libraries.dart
- pkg/dev_compiler/tool/input_sdk/libraries.dart: was not formatted due
to the aforementioned Analyzer bug
- tools/bots/test_matrix.json: run DDC sourcemap suite in Dart 2 mode
- pkg/pkg.status: skip pkg/dev_compiler if running in Dart 1 mode
Change-Id: I9b80ccba0c2cc7b66efc662a0b16562e3660aee3
Reviewed-on: https://dart-review.googlesource.com/60402
Commit-Queue: Jenny Messerly <jmesserly@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2018-06-15 00:28:13 +00:00
4b2d60cb18
[infra] Remove obsolete signcla verifier from CQ
...
See https://crbug.com/851738
TBR=whesse@google.com
Change-Id: Ied9221ef9aba1721b6dad24bf011773191a468d2
Reviewed-on: https://dart-review.googlesource.com/60144
Reviewed-by: Alexander Thomas <athom@google.com >
2018-06-13 20:14:42 +00:00
eea2dff20d
Added support for members of type Promise.
...
Fixes #31046
R=sra@google.com
Change-Id: Id1e8d415b91a842bd8e2f50c6064c24aaaed9d98
Reviewed-on: https://dart-review.googlesource.com/59460
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Terry Lucas <terry@google.com >
2018-06-13 18:20:53 +00:00
371d8e934f
Reorder tar exclude options in try_benchmarks.sh for forward compatibility.
...
The latest GNU tar(1) releases requires --exclude to come first or it has no
effect.
Change-Id: Ia41c01d167c4e283cea4210f90d3764a708d3dcb
Reviewed-on: https://dart-review.googlesource.com/60120
Commit-Queue: Jonas Termansen <sortie@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2018-06-13 16:13:21 +00:00
f3ce474673
[infra] Remove obsolete analyzer test configurations
...
The --preview-dart-2 flag flip makes it unecessary to:
* Test Dart 2 configs in host-checked mode.
* Test --checked and --strong together.
* Test --preview-dart-2 and --strong separately.
Change-Id: I1738d351c866fb95fd9e1249f5f4ffb88169e106
Reviewed-on: https://dart-review.googlesource.com/59900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-13 04:17:16 +00:00
0b91676362
Remove the retype method.
...
See #33075 .
Bug: http://dartbug.com/33075
Change-Id: I1ee2f587afbc672dd08ac61ac003bbdc85bb95e2
Reviewed-on: https://dart-review.googlesource.com/59091
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2018-06-12 14:36:09 +00:00
305c166154
[infra] Add --no-preview-dart-2 to all Dart 1 configurations in the test matrix
...
Change-Id: Ib51adc2587c573598ceddd343cb48d0f8136a71b
Reviewed-on: https://dart-review.googlesource.com/59801
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2018-06-11 21:36:15 +00:00
08cfd68263
[build] Don't add a device to the source tarball.
...
Change-Id: I6c4b22879e65d61c8585e91113f2b914ebe897ee
Reviewed-on: https://dart-review.googlesource.com/59800
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2018-06-11 21:16:47 +00:00
c83811a86e
[infra] Add --no-preview-dart-2 flag to test.py to prepare for flag flip
...
This flag is a no-op until this change lands:
https://dart-review.googlesource.com/c/sdk/+/58240
Change-Id: I6f0fcd053dc84738959b67a628d17165e12d3fac
Reviewed-on: https://dart-review.googlesource.com/59741
Reviewed-by: Siva Annamalai <asiva@google.com >
2018-06-11 19:49:10 +00:00
c72a3403a0
[infra] Remove vm-kernel-legacy-linux builder from the CQ
...
TBR=whesse@google.com
Change-Id: Ic538e4470acd7e2efb2ed9e96422556e2760d91d
Reviewed-on: https://dart-review.googlesource.com/59780
Reviewed-by: Alexander Thomas <athom@google.com >
2018-06-11 19:41:42 +00:00
86db7810ba
[build] Declare dependency of the version strings on the current Git commit.
...
Add fake Git reflog to Debian source tarball.
Bug: https://github.com/flutter/flutter/issues/15348
Bug: https://github.com/dart-lang/sdk/issues/32614
Change-Id: Ib4104a98cf245ee11285a37d5eee3165ca656645
Reviewed-on: https://dart-review.googlesource.com/48091
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2018-06-11 18:22:09 +00:00
b6cea45ee8
[infra] Escape $ in new homebrew script string
...
Change-Id: I9f4f675372589929c117e73cfc445e7b13c30f0f
Reviewed-on: https://dart-review.googlesource.com/59740
Reviewed-by: William Hesse <whesse@google.com >
2018-06-11 16:58:00 +00:00
67525aef37
Convert a batch of negative tests to multitests.
...
Change-Id: I380c12ef633ec8c40de982782623d3e3659a4834
Reviewed-on: https://dart-review.googlesource.com/57162
Reviewed-by: Leaf Petersen <leafp@google.com >
2018-06-08 19:43:34 +00:00
976aa4074b
Run dartdevk against its own compiled SDK and packages
...
Currently we test dartdevk against SDK/packages that were compiled with
dartdevc (DDC+Analyzer). This CL migrates to having those files compiled
with DDC+Kernel. dartdevc testing is unchanged.
Most of the fixes are around things like special optimized annotations
used in our SDK code, that were not understood by DDK. Also some inline
JS type annoations were not correct.
Change-Id: Iccf4427e4b9beffd6d97a4be654253d91f6cb89e
Reviewed-on: https://dart-review.googlesource.com/57800
Reviewed-by: Vijay Menon <vsm@google.com >
2018-06-08 19:18:34 +00:00
f4386ed488
Fix type error in MultiElementCssClassSet constructor.
...
Fixes #29901
R=sra@google.com
Change-Id: Idfa1dee3d243ed34c3ca8d1225404143a28746e8
Reviewed-on: https://dart-review.googlesource.com/59340
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Terry Lucas <terry@google.com >
2018-06-08 17:47:32 +00:00
fffad5472a
[infra] Add test matrix documentation
...
Change-Id: I71be9e3a8ea5419e16bf065c69235a9813b98886
Reviewed-on: https://dart-review.googlesource.com/36483
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2018-06-07 17:39:12 +00:00
2c780c4b1d
[gardening] Make gardening tools accept more swarming URLs & Dart 2 fixes
...
Change-Id: I9101020f3a32da130e26c53391477dc5501ef6ff
Reviewed-on: https://dart-review.googlesource.com/59080
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2018-06-07 14:57:26 +00:00
cf319e484a
[infra] Remove checked tests from VM product builders in test matrix
...
Change-Id: I32a68f18eaad0d999d1c3f51795da5f50ab84e50
Reviewed-on: https://dart-review.googlesource.com/59081
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2018-06-07 12:23:53 +00:00
61e57e2012
update_homebrew 🎯 also make a dart@2, for Dart 2 migration
...
This PR modifies update_homebrew to also generate a dart@2 versioned formula. The new file is dropped out right next to the old `dart.rb` file.
The dart@2 formula is a temporary measure to aid application developers
migrating from Dart 1 to Dart 2.
Supersedes https://github.com/dart-lang/homebrew-dart/pull/52 .
This looks right by inspection, but I haven't been able to test it yet: my local `dart` environment is all messed up, and I am a Dart newbie. Still, I'm putting this out here as a PR so the discussion from https://github.com/dart-lang/homebrew-dart/pull/52 can proceed.
Closes #33318
https://github.com/dart-lang/sdk/pull/33318
GitOrigin-RevId: 5230782aabf4f45199cff9b1fb9c5304e5dcb21c
Change-Id: I78cf5b066d85ac8b0ef51ed44e6eb1a15192b23c
Reviewed-on: https://dart-review.googlesource.com/58120
Commit-Queue: William Hesse <whesse@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2018-06-07 10:17:22 +00:00
5ec940a2e0
Updated to expose APIs promiseToFuture calls for users.
...
Fixes #33226
R=kevmoo@google.com , sra@google.com
Change-Id: I04995b33e9445d0fcef8d874315f14fd272018d1
Reviewed-on: https://dart-review.googlesource.com/57482
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2018-06-07 01:40:22 +00:00
f059df7cc5
unfork DDC package:async_helper
...
This code was from the old travis/karma test runner setup, it is no
longer used. Also deletes the old browser test runner files.
Change-Id: I7eab3ebdc709cfc9c48d6f230c73035bc512cea9
Reviewed-on: https://dart-review.googlesource.com/57780
Reviewed-by: Vijay Menon <vsm@google.com >
2018-06-06 21:58:01 +00:00
94091b10f2
[infra] Use the correct runtime for dartjs-csp-minified builder in the test matrix
...
TBR=whesse@google.com
Change-Id: I925f16ef8c143a743f5ca4e12dc15bd21098834f
Reviewed-on: https://dart-review.googlesource.com/58861
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2018-06-06 19:40:34 +00:00
c3b5939965
[vm] Remove --limit-ints-to-64-bits option and old _Bigint class
...
Closes https://github.com/dart-lang/sdk/issues/33306
Change-Id: I7088d8b7143edbe24f5cefe4be037ad2006e0625
Reviewed-on: https://dart-review.googlesource.com/58101
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2018-06-04 20:10:40 +00:00
c8860b4ca2
Remove all uses of --limit-ints-to-64-bits VM option
...
VM option --limit-ints-to-64-bits was enabled by default a while ago,
and now we're preparing to remove it from Dart VM.
This CL removes all uses of this option in preparation for this cleanup.
Issue: https://github.com/dart-lang/sdk/issues/33306
Change-Id: I8f33cf4ca8ce7ef9a171a982346e43dd8cb722a9
Reviewed-on: https://dart-review.googlesource.com/57960
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2018-06-01 19:32:24 +00:00
14b9d7f128
[infra] Prepare test.py for the --preview-dart-2 VM flag flip
...
Change-Id: I61ce096d41d7e20b61c577b05eaa20cf6e39e8cd
Reviewed-on: https://dart-review.googlesource.com/57510
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2018-05-31 13:45:52 +00:00
ff8100d1e3
[infra] Add dartk reload/rollback configurations to test matrix ( #33126 )
...
Change-Id: Iedff74fbdfd04165755f2609333742f62e48f18f
Reviewed-on: https://dart-review.googlesource.com/56114
Reviewed-by: Martin Kustermann <kustermann@google.com >
2018-05-31 10:48:23 +00:00
1eb1885c62
tools/addlatexhash.dart: Remove unused import
...
... as reported by the 2-dev.19 analyzer:
```nocode
info: Unused import. (unused_import at [tools] addlatexhash.dart:28)
```
cc @kwalrath
Closes #31958
https://github.com/dart-lang/sdk/pull/31958
GitOrigin-RevId: b4b7f9ab8cd3b04618f29d5ada5eefb1e0592f19
Change-Id: I17195312c8580b9f51d0f00099c6283bf23cdffe
Reviewed-on: https://dart-review.googlesource.com/45620
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2018-05-30 13:36:38 +00:00
d28c5499fc
[infra] Add support for app_jitk compiler to test.py ( #33126 )
...
* Add app_jitk configuration to test matrix.
* Skip it on non-Dart 2 test suites.
Change-Id: I05f75dbbd33d34a4acf4df1fe63104933d39d2fe
Reviewed-on: https://dart-review.googlesource.com/56113
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2018-05-28 11:54:56 +00:00
9b44fc39c8
Deprecate chaseDependencies option.
...
The option is not used by any client at this time and removing it simplifies the
next stack of changes I'll be making on how we compose file systems.
I also don't believe we will necessarily add this back as an option, but instead
it might be that clients requriing hermeticity will provide a custom file system
that helps with that.
Change-Id: I401efb042920d234382b6c041b13d40ffae5c908
Reviewed-on: https://dart-review.googlesource.com/56462
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-05-24 04:57:01 +00:00
e35ed9c749
[ VM / Build ] Added '--no-include-kernel-service' to build.py. By default, the kernel service is now included in all build modes, including product mode. Providing '--no-include-kernel-service' will build the specified configuration without the kernel service.
...
Change-Id: I682cd7c2895a9bcb215948615f2bdc627abe8d08
Reviewed-on: https://dart-review.googlesource.com/56286
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Zach Anderson <zra@google.com >
2018-05-23 20:35:53 +00:00
cf87b84f7d
Support Promise to Future for both DDC and dart2js.
...
APIs in the newer Chrome IDLs support more JS style promises. The Dart web libraries now hookup those promises and return a Dart Future.
Additionally, a new type maplike is exposed in the IDL this is exposed too.
Change-Id: I44175877eb95f4d910586d42c0139fb182483f82
Reviewed-on: https://dart-review.googlesource.com/49800
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2018-05-23 04:08:14 +00:00
96cfc632bb
[infra] Use a less specific browser version that works across platforms
...
TBR=whesse@google.com
Change-Id: Ieff493c187dc5da5dbee49887454cf25e1dc6eef
Reviewed-on: https://dart-review.googlesource.com/56115
Reviewed-by: Alexander Thomas <athom@google.com >
2018-05-22 21:11:03 +00:00
2a8eb8089d
[infra] Specify chrome version used by builds running on the test matrix
...
Prepares the test matrix for the corresponding recipe change:
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1064632
Change-Id: I21d380f6ad452e3eca6e6f20133297d31347872c
Reviewed-on: https://dart-review.googlesource.com/56109
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2018-05-22 16:17:34 +00:00
eeec6466b6
Convert the command-line analyzer to a dart 2 snapshot.
...
Change-Id: Ieb5cd8971494a8a6ffc07c0fd4dde07cfb6f5373
Reviewed-on: https://dart-review.googlesource.com/56034
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-05-22 15:44:04 +00:00
1d6619eba6
[infra] Upgrade checked in SDKs to 2.0.0-dev.55.0
...
TBR=whesse@google.com
Change-Id: Iaa6f059e805a85df1a81b594a488bce14d539a67
Reviewed-on: https://dart-review.googlesource.com/55782
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2018-05-17 20:45:26 +00:00
4d22c0de58
[infra] Improve cycle time of dart2js builders
...
* Remove co19_2 from file sets for now.
* Skip extremely slow test.
* Remove redundant build target from test matrix.
#33150
Change-Id: Ib17d2e7438dc2ab473e751f1d79c617cbc26275d
Reviewed-on: https://dart-review.googlesource.com/55661
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2018-05-17 10:21:23 +00:00
aafc2a6d43
Reland "[vm/kernel] Enable kernel2kernel "constants" transformation in AOT mode (after running TFA)"
...
The CL was originally committed in 039e8a17546ab040e59d9ce8d69https://dart-review.googlesource.com/55361
Commit-Queue: Martin Kustermann <kustermann@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-05-16 12:48:38 +00:00
b092930350
[infra] Enable vm-kernel-simdbc64 builder on the CQ
...
Closes #33021
Change-Id: I452bcade300d7b1ea3b75ad0f174099c5650c383
Reviewed-on: https://dart-review.googlesource.com/55164
Reviewed-by: Martin Kustermann <kustermann@google.com >
2018-05-15 13:37:12 +00:00
2d5c1064b9
[infra] Add .bat to pub command on Windows
...
#32656
Change-Id: I3a34bf2c81676eea0ab112a8aad701962590a6c3
Reviewed-on: https://dart-review.googlesource.com/55165
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2018-05-15 12:50:32 +00:00
dcd842267a
[infra] Add experimental vm-kernel-simdbc64 builder to the CQ
...
Change-Id: I886ccf1fd984d7c71dd04effc42c0f5423f82312
Reviewed-on: https://dart-review.googlesource.com/55141
Reviewed-by: William Hesse <whesse@google.com >
2018-05-15 09:08:18 +00:00
243f3e5333
[infra] Add basic pub integration test
...
Closes #32656
Change-Id: Id3646e7b9567e6f60e449a90c355d3e535ac2a6a
Reviewed-on: https://dart-review.googlesource.com/51661
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2018-05-15 07:09:58 +00:00
William Hesse