dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,503 Commits 2 Branches 0 Tags
bd94de8e4866cc315a08bd6ef6d20037da717a01
Commit Graph

56503 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Peter von der Ahé bd94de8e48 Use dynamic to fix string_interpolate_test 
Change-Id: I48f7b1127e5c61f9c399ac32d7118adc110a6519
Reviewed-on: https://dart-review.googlesource.com/60846
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-06-19 10:58:45 +00:00
Martin Kustermann b172a42881 [VM] Catch errors for integer operations in kernel2kernel constant evaluator 
Issue https://github.com/dart-lang/sdk/issues/33481

Closes https://github.com/dart-lang/sdk/issues/33469

Change-Id: I7ca9825a0aa5f062732a759b4dd116e716a0d1b3
Reviewed-on: https://dart-review.googlesource.com/60580
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-06-19 10:28:05 +00:00
Peter von der Ahé f288124d5a Fix InvalidInlineFunctionType example 
Change-Id: Id573fa1067a2448fd3bf573d63a7ad2fc3cec4ba
Reviewed-on: https://dart-review.googlesource.com/60100
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-06-19 10:03:43 +00:00
Peter von der Ahé 15821a28a3 Explicit type args in body_builder 
Change-Id: I9f9324b9766a970877c312f429a7873ae2359329
Reviewed-on: https://dart-review.googlesource.com/60428
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-06-19 09:35:13 +00:00
Peter von der Ahé 1f6925718b Add message for missing type arguments 
This message is ignored by default and Fasta uses this internally
to help migrate to Dart 2 and type errors in analyzer integration
at compile-time.

Change-Id: Ie0def14f09eb387fdae0486cd7a4bbed2536c64d
Reviewed-on: https://dart-review.googlesource.com/60427
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-06-19 09:35:13 +00:00
William Hesse 87e045c484 Remove the helper dart script from our browser test framework 
BUG=https://github.com/dart-lang/sdk/issues/32539

Change-Id: Ia1d5c04babf21e244c807f32a21b43198a7151a5
Reviewed-on: https://dart-review.googlesource.com/60845
Reviewed-by: Jonas Termansen <sortie@google.com>
 2018-06-19 08:43:55 +00:00
Johnni Winther 532b9aaa93 Flatten *WorldBuilder hierarchies. 
Change-Id: I59bfa08f151f2e238816a4da6163a39e6df2dc9c
Reviewed-on: https://dart-review.googlesource.com/60544
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-06-19 08:16:03 +00:00
William Hesse f1d44e39fa Update status for passing Windows Firefox co19 tests 
Change-Id: If7d9aabe7a192be404e36f33cecf740cf392bc60
Reviewed-on: https://dart-review.googlesource.com/60844
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-06-19 08:10:41 +00:00
asiva efb4f69a13 Adjust simarm status. 
Change-Id: I0caa211296dc3fba914e97908403d987a6e89136
Reviewed-on: https://dart-review.googlesource.com/60835
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-06-19 06:57:26 +00:00
asiva 1a443da6ad Adjust options passed to precompile runtime. 
Change-Id: I6c825a5a0b2f1f6ee9f7e16e06db727239d30b5e
Reviewed-on: https://dart-review.googlesource.com/60834
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-06-19 06:44:54 +00:00
Devon Carew f8caffd9e6 Remove some uses of Platform.packageRoot. 
Change-Id: Ic01e7f7a9f5c677bcf3779ae2a9386345620793a
Reviewed-on: https://dart-review.googlesource.com/60443
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-06-19 05:12:13 +00:00
asiva ebe2f1db2c Adjust status files. 
Change-Id: I294248bb2970645692f0c648477d7af8983580a3
Reviewed-on: https://dart-review.googlesource.com/60831
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-06-19 04:53:43 +00:00
asiva 6fcc95d2a4 Adjust status files. 
Change-Id: Ia94c7477b73ae1f5fa90ffa072436355fcbacf0e
Reviewed-on: https://dart-review.googlesource.com/60830
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-06-19 03:38:20 +00:00
Konstantin Shcheglov f2f6ebf547 Convert ShadowAssertInitializer to AssertInitializerJudgment. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I7cf5138eacb91761fcec99808a729ecc31f5399e
Reviewed-on: https://dart-review.googlesource.com/60826
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-06-19 02:52:59 +00:00
Alexander Aprelev ea837c91a0 Transition tests to EvaluateCompiledExpression. 
This is follow-up to https://dart-review.googlesource.com/c/sdk/+/58660.

Change-Id: Ic0ae58eb34dabe6e0902f37c8e817f949ed4ac64
Reviewed-on: https://dart-review.googlesource.com/60705
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-06-19 02:41:00 +00:00
Konstantin Shcheglov 3e6e2dd7f4 Convert ShadowAssertStatement to AssertStatementJudgment. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I58be3e6a5fd448c2b00afb194bb566c7d6987733
Reviewed-on: https://dart-review.googlesource.com/60807
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-06-19 01:55:59 +00:00
Konstantin Shcheglov 27fefd7bb3 Convert ShadowAwaitExpression to AwaitExpressionJudgment. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I1b2bd381aa29a58eab8f7c4434dc5b6151970d15
Reviewed-on: https://dart-review.googlesource.com/60806
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-06-19 00:58:59 +00:00
Brian Wilkerson dd1c54c442 Convert ShadowBoolLiteral to BoolLiteralJudgement 
Change-Id: I2cdf2a345126c2cdd05e7c06ffa2ad41a22e5502
Reviewed-on: https://dart-review.googlesource.com/60805
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-06-19 00:54:09 +00:00
Brian Wilkerson 4a353fea35 Another attempt to fix tests on Windows 
Change-Id: I7c1c12ec3b9244d52633bc46a115e1b9e51dc87b
Reviewed-on: https://dart-review.googlesource.com/60821
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-19 00:23:59 +00:00
asiva a69d922794 Adjust some of the test expectations based on the flip to Dart 2 mode. 
Change-Id: I84491b161959050b3fab2493f125ab23c8078ec4
Reviewed-on: https://dart-review.googlesource.com/60823
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-06-19 00:04:57 +00:00
Devon Carew b3b8ca6dc4 Remove the --package-default-analysis-options flag. 
Change-Id: If36ee3478d8c95c38ff2cd5ed43f4dc3cdfe973e
Reviewed-on: https://dart-review.googlesource.com/60442
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-06-18 23:34:09 +00:00
Nate Bosch 9943547d5d Default pub to Dart 2 with opt out 
Flip the check to look for the flag `--no-preview-dart-2`

Bug: #33187
Change-Id: I60b8e678303f5efcf41835df2a5d8515e29ddde9
Reviewed-on: https://dart-review.googlesource.com/56641
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2018-06-18 23:08:01 +00:00
Konstantin Shcheglov aba94f051e Convert ShadowAsExpression to AsJudgment. 
Change-Id: I27cb2903a4d018a54e47ff433803789f45b9c24b
Reviewed-on: https://dart-review.googlesource.com/60800
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-18 22:44:32 +00:00
asiva bc7220a4fd [VM] Turn dart2 on by default on the command line VM 
- make Dart2 the default option for the command line VM
- add option --no-preview-dart-2 as a fallback option to run dart1
- change test scripts to use the executable dart for testing dart2 mode instead of
pkg/vm/tool/dart2
- adjust numerous build and test configurations

Change-Id: Id813fa5b71a89c7ec9335d3f6e83cfc9f35f86e7
Reviewed-on: https://dart-review.googlesource.com/58240
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-06-18 22:31:32 +00:00
Alexander Markov cdd2553a12 [vm/kernel/bytecode] Fix null handling in operator == 
Change-Id: I2de516b98c2e49baa65c725e85a696850318ee36
Reviewed-on: https://dart-review.googlesource.com/60801
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-06-18 22:20:41 +00:00
Régis Crelier df2bf6590d [VM runtime] Minor cleanup of stubs on all architectures as already done for x64 
Change-Id: Ibd5b6c074080cac231b54db2755ca57b6609e255
Reviewed-on: https://dart-review.googlesource.com/60802
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2018-06-18 22:19:13 +00:00
Konstantin Shcheglov b140baeb55 Own files by their URIs during search. 
R=brianwilkerson@google.com

Change-Id: If17700a4d433701cb6cb2432f6be9c27dc6e6b92
Reviewed-on: https://dart-review.googlesource.com/60803
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-06-18 22:07:17 +00:00
Paul Berry 56cee22800 Build out the initial version of the Factory class (and derived classes). 
Still to be done: add the necessary arguments to plumb tokens and
subexpressions into the factory methods.

Change-Id: I99206aaca3430ad62726cb51fb818d9b820f4f96
Reviewed-on: https://dart-review.googlesource.com/60804
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-18 22:01:41 +00:00
Mike Fairhurst 83cb0c425d Fix awaiting void in analyzer ast_test.dart. Fix at method decl. 
Required to unblock #33415

Change-Id: I18306967737fc26136cc74c70f14cf33509e96f3
Reviewed-on: https://dart-review.googlesource.com/60706
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-06-18 21:32:46 +00:00
danrubel c9af309cbf Fix fasta parsing of ?. in cascade expression 
... and fix more Analyzer fasta parser tests

Change-Id: I42e6f25784dbc62bca620b1ab522c07350f53aff
Reviewed-on: https://dart-review.googlesource.com/60721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-18 21:25:41 +00:00
Bob Nystrom 67695b9842 Fix the dependencies on the dartdevk_sdk build step. 
Change-Id: If3c58294ef1ecd23a5aef4c0019a029e9a2fd7d9
Reviewed-on: https://dart-review.googlesource.com/60780
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2018-06-18 21:24:41 +00:00
Mike Fairhurst 0a59b2ff90 Fix test cases that await "void." Blocks #33415, making that an error 
Change-Id: I758d66d5112de631283adc791c0e33b3b98edfc1
Reviewed-on: https://dart-review.googlesource.com/60707
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-06-18 20:33:13 +00:00
Jenny Messerly 3ba3e2a752 Revert "switch to dart_action until prebuilt Windows Dart VM is updated" 
This reverts commit 0bac650833.

Change-Id: Iccdb81c1b2bca2f7ef5de45105ae5b262f41129c
Reviewed-on: https://dart-review.googlesource.com/60740
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-06-18 20:31:44 +00:00
danrubel 741ed336f1 Improve AstBuilder int literal recovery 
... and fix more Analyzer fasta parser tests

Change-Id: Ic051369580311e0ee1be09210d34a6654d90c023
Reviewed-on: https://dart-review.googlesource.com/60720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-18 20:00:13 +00:00
Paul Berry e77158eb38 First steps toward generating analyzer/kernel ASTs during type inference. 
This CL makes the following changes:

- Adds a Factory interface (currently empty), and threads that through
  type inference logic.  In later CLs, this will be used by the infer
  methods to create ASTs as a side effect of type inference.  The
  interface is parameterized so that it can create either analyzer or
  kernel ASTs.

- Adds a KernelFactory implementation, to be used when creating kernel
  ASTs (also currently empty).

- Adds a ToplevelInferenceFactory implementation, to be used during
  top level type inference (when no ASTs need to be created).

- Renames ShadowExpression, ShadowInitializer, and ShadowStatement to
  ExpressionJudgment, InitializerJudgment, and StatementJudgment,
  respectively.  This reflects the fact that once we decouple the
  "shadow" hierarchy from the kernel AST, each shadow node will
  represent a type inference judgment.  The derived classes will be
  renamed in later CLs.

- Renames the methods _inferExpression, _inferInitializer, and
  _inferStatement to infer.

- Adds an inferredType field to each class derived from
  ExpressionJudgment.  In later CLs, this will allow us to change the
  infer methods so that they store the inferred type and return the
  AST (currently they return the inferred type).  For the moment, the
  inferredType field is set by the common method
  ShadowTypeInferrer.inferExpression.

Change-Id: Ibf7b7df2cc9754080c84b9ec5d1e2e2721569fa4
Reviewed-on: https://dart-review.googlesource.com/60620
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-06-18 19:29:52 +00:00
Martin Kustermann f1c3f997bd [VM] Clear out return-value-register from call-to-runtime-stub, it needs to be GC-safe for lazy deopts 
When the slow path code of StackOverflowInstr is calling out to runtime
and the runtime causes a lazy-deopt, the lazy deopt stub will treat the value in the
return-value-register as GC-safe and the value will be visited during GCs.

This CL changes the call-to-runtime-stub to always put 0 into the
return-value-register.

This should fix the flaky vm-linux-debug-x64-reload-be builder.

Change-Id: Ibea3630b8b9fa5de2b96134725df0017c09282bd
Reviewed-on: https://dart-review.googlesource.com/60661
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-06-18 19:25:43 +00:00
Régis Crelier 686fd133a7 [VM interpreter] Propagate unhandled exception returned from jitted code to interpreter. 
Change-Id: I1d6426b6af7a0efbda1ef3a9b8c838d3b0119063
Reviewed-on: https://dart-review.googlesource.com/60520
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-06-18 19:22:05 +00:00
Terry Lucas 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused. 
R=kevmoo@google.com,vsm@google.com

Fixes #32304

Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-06-18 18:48:03 +00:00
Konstantin Shcheglov 7d94755836 Issue 33471. Use full ResolveResult in Extract Local refactoring. 
So, that we can give the file content to CorrectionUtils. Otherwise we
might attempt to use resolved unit for older version of the file
content, and re-read file content.

It does not fully solves the problem, because the client still might
get changes that corresponds to the older state of the file, or
files. We might want to consider un-deprecating fileStamp in
SourceFileEdit.

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/33471
Change-Id: I4877bc86a14033cc4c944cfaa0265db78b17de4c
Reviewed-on: https://dart-review.googlesource.com/60701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-06-18 18:22:01 +00:00
Alexander Markov 57c0fc9593 [vm/corelib] More cleanup in integer operations after _Bigint is removed 
Change-Id: I41da6a37e554ffb8b77f51fda3fee5a15f2b8045
Reviewed-on: https://dart-review.googlesource.com/60441
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-06-18 18:16:51 +00:00
danrubel 88d12fda42 Parse throw on RHS of an assignment 
Change-Id: I4177dcee9eb2826474e43b43c6aa3820590e93d0
Reviewed-on: https://dart-review.googlesource.com/60600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-06-18 17:50:04 +00:00
Brian Wilkerson 1dcc3264e7 Fix tests that are failing on Windows 
Change-Id: Id7182df3f08078f0e6c1959db94cf2da0bebd995
Reviewed-on: https://dart-review.googlesource.com/60680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-18 17:07:11 +00:00
Konstantin Shcheglov 691313f357 Move newOptionsFile() and newPackagesFile() into ResourceProviderMixin. 
R=brianwilkerson@google.com

Change-Id: I903312db8e738c988a197fdd875cfd4ae5e4799d
Reviewed-on: https://dart-review.googlesource.com/60641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-06-18 16:50:31 +00:00
Konstantin Shcheglov e62f563b2d Validate sdkPath in AnalysisContextCollectionImpl. 
R=brianwilkerson@google.com

Change-Id: Iaffd3dc66fbb4bb8c4e4aae5f036c28ba68b07d6
Reviewed-on: https://dart-review.googlesource.com/60640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-06-18 16:42:31 +00:00
Konstantin Shcheglov 493c421f0d Add AnalysisContextCollection. 
R=brianwilkerson@google.com

Change-Id: Id0c64648983129f5ecd46d784e978ce321ba2041
Reviewed-on: https://dart-review.googlesource.com/60404
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-18 15:53:36 +00:00
Alexander Aprelev 4c9689c1d2 [vm] Support pluggable expression compiler for evaluate service api call. 
This is follow-up to https://dart-review.googlesource.com/c/sdk/+/57520, which added expression compiler support for EvaluateInFrame

Bug: dartbug.com/31981
Change-Id: I19e6b654698d5b032a276c9cb3634324f4f1ad37
Reviewed-on: https://dart-review.googlesource.com/58660
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-06-18 15:50:02 +00:00
Martin Kustermann d70c38eed8 [Gardening] Mark test as flaky on also non-kernel (legacy) 
Change-Id: I1b035f13bc28a15e664b9c0e024c0118af0c5a71
Reviewed-on: https://dart-review.googlesource.com/60582
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-06-18 13:32:13 +00:00
Lasse R.H. Nielsen 060ee6769e Make CastStreamSubscription.onData handle a null callback 
Fixes #33166

Bug: http://dartbug/com/33166
Change-Id: If2f0f714b96ce592936d3298bb5d84732d34f69b
Reviewed-on: https://dart-review.googlesource.com/56101
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-06-18 13:24:17 +00:00
Lasse R.H. Nielsen f7289aa219 Remove specification of naming conventions. 
Fixes #25531.

BUG= http://dartbug.com/25531

Change-Id: I3e483d2465e6709a6bd9504d21b12c41d13cc793
Reviewed-on: https://dart-review.googlesource.com/60101
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-06-18 13:04:47 +00:00
Lasse R.H. Nielsen 87131780cb Add appendix to spec which specifies JavaScript integer behavior. 
Also update the `int` class documentation.

Change-Id: I2de6c62aa9642c18134effa8187a12902d5f2259
Reviewed-on: https://dart-review.googlesource.com/58204
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-06-18 11:17:57 +00:00