dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,503 Commits 2 Branches 0 Tags
bd94de8e4866cc315a08bd6ef6d20037da717a01
Commit Graph

160 Commits

Author SHA1 Message Date
Alexander Markov d23176dc40 [gardening] Skip flaky test lib_2/isolate/spawn_uri_nested_vm_test 
Issue: https://github.com/dart-lang/sdk/issues/33385
Change-Id: If5bf03d61226baac8fe6a7a3e4642e3a69fe9e0d
Reviewed-on: https://dart-review.googlesource.com/59220
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-06-07 21:47:35 +00:00
Alexander Aprelev 6fcc68bee3 Adjust test status. 
Mark isolate/message4_test as Pass, Timeout.

Change-Id: I6103b35d874766030c8219dfde43890aafd382d2
Reviewed-on: https://dart-review.googlesource.com/58621
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-06-06 03:47:59 +00:00
Ryan Macnak 787a43ec78 [vm] Fix some missing private name mangling in the kernel reader. 
Bug: https://github.com/dart-lang/sdk/issues/32345
Bug: https://github.com/dart-lang/sdk/issues/33326
Bug: https://github.com/dart-lang/sdk/issues/33345
Change-Id: I89fb8f0332ef6f9f40de59c219af2a7c23e5943f
Reviewed-on: https://dart-review.googlesource.com/58400
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-06-05 20:14:46 +00:00
Alexander Markov 6b71414296 [Test status] Update status of several triaged lib_2/mirrors tests 
Change-Id: Ie90688ea7a9fd95a939c87b4c619213b74c904c1
Reviewed-on: https://dart-review.googlesource.com/58422
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-06-05 16:24:09 +00:00
Alexander Thomas a9257d05fb [vm] Prepare status files for dartk reload/rollback builders (#33126) 
Change-Id: I954debb9f258eb94de227f6772ff08b53daba322
Reviewed-on: https://dart-review.googlesource.com/57623
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-06-04 11:30:21 +00:00
Martin Kustermann 9a193853d4 [VM] Mark a few tests as passing 
They are passing since  315a186

Change-Id: Iee40f0c50160b87763fb031bb74d2499ef578807
Reviewed-on: https://dart-review.googlesource.com/58181
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-06-04 08:50:32 +00:00
Lasse R.H. Nielsen 315a186dc4 Better test error handler argument types. 
Change-Id: I460a40dc9db096f3ae95602ba9c8dc86b4576c56
Reviewed-on: https://dart-review.googlesource.com/53208
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-06-01 12:26:37 +00:00
Alexander Markov 1ca17b6d03 [vm/kernel] Recognize desugared mixin applications in dart:mirrors 
Kernel mixin transformation desugars mixin applications into normal
classes. Mixed-in type is pulled into interfaces list.
However, dart:mirrors needs to know the original mixed-in type of
a mixin application.

This change solves this problem by propagating a 'isTransformedMixinApplication'
attribute of a class through kernel AST, kernel binary and VM objects
into dart:mirrors implementation.

Fixes: https://github.com/dart-lang/sdk/issues/33240
Change-Id: I98ca69294e1ad445402a5ca91d90c30447aabcb2
Reviewed-on: https://dart-review.googlesource.com/56721
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-05-29 18:12:26 +00:00
Alexander Thomas 2a3d1dc9ed [vm] Prepare status for app_jitk builders (#33126) 
Change-Id: Iec5347b5f091b9fd6ff3c24047b011527f8b08ee
Reviewed-on: https://dart-review.googlesource.com/56802
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-05-29 11:43:25 +00:00
Alexander Markov 4fb0c60938 [vm/kernel] Set active class when evaluating Dart annotations 
Without active class, kernel reader is not able to finalize types
and fails to parse type literals.

Fixes https://github.com/dart-lang/sdk/issues/33173

Change-Id: Iefe7f33a371f3d4f892f21f8ea0060d70887186c
Reviewed-on: https://dart-review.googlesource.com/56242
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-05-23 16:17:55 +00:00
Kevin Millikin 7ff8adcec9 Fix an incorrect dart:mirrors test 
The class defined by an anonymous mixin application is always
abstract.  If it were not, then it would be a Dart 2 static error that
it does not provide implementations of any of the abstract members of
the mixed-in class.  For example:

  class S {}
  abstract class M {
    int f();
  }
  abstract class C extends S with M {}

The class defined by `S with M` must be abstract because it does not
provide an implementation of `f`.

Change-Id: I3a990d7db4c5cb3c2dc83f4f12e4fd1eba68f876
Reviewed-on: https://dart-review.googlesource.com/56107
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-05-22 13:56:41 +00:00
Martin Kustermann 2dc8f3f0b0 [VM] Mark crashing test in status file 
This test was removed from the status file in 87fb51fa8c (after
landing dd3ec65af)

Issue https://github.com/dart-lang/sdk/issues/33128

Change-Id: I77e4a4f303d6a248a87a9a9739e883d2a68fafc6
Reviewed-on: https://dart-review.googlesource.com/55241
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-05-15 15:54:47 +00:00
Ryan Macnak 87fb51fa8c [test] Mark isolate_complex_messages_test as fixed in Dart 2. 
Fixed by dd3ec65af8.

Change-Id: Ia877330109b74b29fd5a52a755b2910511885de8
Reviewed-on: https://dart-review.googlesource.com/55024
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-05-14 23:12:50 +00:00
Ryan Macnak 1e28b8987d [vm] Reify even more generics in the mirrors implementation to appease Dart 2. 
Bug: https://github.com/dart-lang/sdk/issues/33091
Bug: https://github.com/dart-lang/sdk/issues/33098
Change-Id: Ibecce1274b9bda47e387d109a29a5af4d53adb7f
Reviewed-on: https://dart-review.googlesource.com/54704
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2018-05-11 19:18:49 +00:00
Jenny Messerly 3002e47e36 cleanup language_2 and corelib_2 tests that import dart:mirrors 
Preserves tests that didn't really need mirrors, and moves tests for
mirror functionality into lib_2/mirrors tests.

Change-Id: Ie16dee1a4b508e3f14da53499f57c5dae2d1e513
Reviewed-on: https://dart-review.googlesource.com/49624
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-05-07 23:50:56 +00:00
Ryan Macnak 2f458c4c48 [vm] Reify more generics in the mirrors implementation to appease Dart 2. 
Bug: https://github.com/dart-lang/sdk/issues/32889
Change-Id: Ic115a2db257eb1a70a82e727890fef8695ec8bc2
Reviewed-on: https://dart-review.googlesource.com/53693
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-05-04 00:34:54 +00:00
Dmitry Stefantsov 5af05d407d [fasta] Report type argument number mismatch during outline building 
Change-Id: I1c1f22f3117ccbfc8620b3b0459bc96ed1ad1bdf
Reviewed-on: https://dart-review.googlesource.com/51128
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-04-30 13:01:15 +00:00
Aske Simon Christensen 2fb94418cd Mark mirrors test crashing. 
Bug: https://github.com/dart-lang/sdk/issues/32879
Change-Id: I66633e44d1a8a46aa54b6309b94603887fdfb16e
Reviewed-on: https://dart-review.googlesource.com/51130
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-04-13 16:55:00 +00:00
Aske Simon Christensen 51a2f96a71 Always call writeAnnotationList to write annotations. 
This fixes an issue where an (illegal) annotation contained a
variable declaration, but the variable indexer was not set up.

Closes https://github.com/dart-lang/sdk/issues/32800

Change-Id: I50e828256e1ec0d14004aa38eaab2dce93ca7112
Reviewed-on: https://dart-review.googlesource.com/50942
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-04-13 12:41:17 +00:00
Alexander Thomas 3851591642 [infra] Keep comments intact when updating status files. 
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.

Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-04-10 19:03:21 +00:00
Régis Crelier bd6e66c538 [VM runtime] Ignore 'implements Function' in strong mode type tests (fixes #32154). 
Change-Id: I7d53594e6ffaef616b3384e073e2240a8ca7017c
Reviewed-on: https://dart-review.googlesource.com/49080
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2018-04-04 17:52:55 +00:00
Dmitry Stefantsov 59d859645e [fasta] Do new/const insertion in simple cases 
Bug: http://dartbug.com/32553
Change-Id: I58e201ffd5019a5a65c0ac188aaab363225b5296
Reviewed-on: https://dart-review.googlesource.com/48481
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-30 18:35:05 +00:00
Dmitry Stefantsov f8995da6aa Report a compile-time error on magic const 
When inferring const or new for expressions that aren't required to be const,
Fasta always choses new. That's not correct, and this is a short-term work
around to avoid introducing a breaking change in the future. The plan is to
implement this feature correctly, but that will require more time than we have
right now.

Originally submitted by ahe@google.com.  Added: status file fixes.

Change-Id: I2d70bd2488de6b69fcd5546c1f4654dfbbb30b7f
Reviewed-on: https://dart-review.googlesource.com/46340
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-03-13 19:07:12 +00:00
Sigmund Cherem 4c58384b50 Prepare html, isolate, lib, and lib_2 status files to turn on CFE on dart2js by default 
TBR=sra@google.com

Change-Id: I4ed72f27eb21477bf281df5039a53d0eb703b8ac
Reviewed-on: https://dart-review.googlesource.com/45581
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-08 01:04:05 +00:00
Peter von der Ahé 94aa20dd07 Update status for $compiler == fasta 
Change-Id: I5d073d1c678dc313e79193074c6491085c093596
Reviewed-on: https://dart-review.googlesource.com/45381
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-03-07 10:32:33 +00:00
Dmitry Stefantsov e7830a9f7b Add a flag to Procedures indicating that it's a redirecting factory 
Fixes #32282

Bug: http://dartbug.com/32282
Change-Id: Iee8535b053ced415e3047e990a0940d859faa86a
Reviewed-on: https://dart-review.googlesource.com/43440
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-02-27 10:42:07 +00:00
Alexander Aprelev ffad1d2287 Update dartkp status files. 
This is follow-up to ec7029daf6.

Change-Id: I8aee1bc0002290ca5f6d91b87149b67ebb4943c2
Reviewed-on: https://dart-review.googlesource.com/43241
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Chandra <sivachandra@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-02-22 23:35:47 +00:00
Alexander Aprelev ec7029daf6 Workaround deferred library limitation. 
Introduce no-op LoadLibrary, CheckLibraryIsLoaded into kernel_binary_flowgraph.cc

Bug: https://github.com/dart-lang/sdk/issues/32245
Change-Id: If93a4d717844dcb8a5d45d0237660ec764a6f738
Reviewed-on: https://dart-review.googlesource.com/42461
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-02-22 20:34:39 +00:00
Leaf Petersen f1a0257167 Fix Status files 
Change-Id: I069eabb22a80af6cffd393807df624885b729856
Reviewed-on: https://dart-review.googlesource.com/42160
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-02-17 01:44:25 +00:00
Leaf Petersen 3d6ad7b3a2 Remove fuzzy arrows except on assignability 
Change-Id: I00ffa8f6f85cede8badd4d7082da4603f998956c
Reviewed-on: https://dart-review.googlesource.com/40470
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2018-02-17 00:30:56 +00:00
Régis Crelier 3d756ec4ab [VM runtime] In strong mode, restrict subtyping rules of callable instances (fixes #32154). 
Update kernel status files.

Change-Id: I2bf6097b5229d80cc90baed92fd8dcc750667b23
Reviewed-on: https://dart-review.googlesource.com/41482
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-02-14 21:48:27 +00:00
Jens Johansen 4083ff54e7 [gardening] Status files for kernel optimization_counter_threshold bot 
Change-Id: I12334bfcec3e31aea753dd815ccb15695f0db5a3
Reviewed-on: https://dart-review.googlesource.com/40780
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-02-13 12:40:34 +00:00
Jens Johansen 4fac2530de [gardening] kernel/windows status file updates #1 
Bugs #32137 and #32138.

Change-Id: If91591170b342794120076fe6af269e8020d3796
Reviewed-on: https://dart-review.googlesource.com/40744
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-02-13 11:58:15 +00:00
William Hesse be2e6c4f82 Update status for new dartk and dartkp builders 
Change-Id: Ie5ed3cade049d1d7831440adece520dd09ad13d7
Reviewed-on: https://dart-review.googlesource.com/39985
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-02-08 16:52:56 +00:00
Dmitry Stefantsov 47fbe76d03 Avoid patching with redirecting factories in vm-related patches 
Change-Id: Id45696a38b281b1b75a9a0e26d89216388a4ec19
Reviewed-on: https://dart-review.googlesource.com/39942
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-02-08 14:11:50 +00:00
Peter von der Ahé 8815bbe90e Update status files for $compiler == fasta 
Change-Id: I09761d12b98864d9a9abcc7abe6f046e45951715
Reviewed-on: https://dart-review.googlesource.com/36642
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-02-07 15:38:09 +00:00
Régis Crelier 9a36711149 [Kernel] Insert argument type check in implicit setters (fixes #32065). 
Update status file.

Change-Id: I4c7e1b5352ba40e1f571bd3e8eb6f8d7623a1e80
Reviewed-on: https://dart-review.googlesource.com/39422
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2018-02-07 01:35:24 +00:00
Florian Loitsch 7bd76a466a Update status files. 
Change-Id: I83ee3e48b8923aa5ae9497e8d1042ada7f3678c8
Reviewed-on: https://dart-review.googlesource.com/38240
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2018-02-02 14:42:28 +00:00
Florian Loitsch d858eea600 Update status files. 
Change-Id: I85e9f25c5d87b7cf87ed848f4a71919ab07f5790
Reviewed-on: https://dart-review.googlesource.com/37762
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
 2018-02-02 11:55:02 +00:00
Florian Loitsch 5ec65552d5 Update status files. 
Change-Id: I3c569645ebac013ac2d72b9d9da0eeb6f2609fcd
Reviewed-on: https://dart-review.googlesource.com/38200
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
 2018-02-02 09:46:12 +00:00
Jenny Messerly 5013b28bbe fix #31999, remove fuzzy arrow runtime support from DDC 
Also updates tests that relied on fuzzy arrows.

Change-Id: Ia8df1d8d421e43dfada589223d5e46182b92fa67
Reviewed-on: https://dart-review.googlesource.com/37425
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-01-31 22:20:38 +00:00
Jens Johansen 827573fc2c Status file updates after changes to Windows crash-sniffing 
Change-Id: I1fbf5ca58d1bb99811e622896ceb0d7177c87b43
Reviewed-on: https://dart-review.googlesource.com/36400
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-01-23 14:35:26 +00:00
Erik Corry 5c7804fe32 [VM] Add SIMD arrays to raw snapshot code 
This has not been done earlier because no decision was made about
how to handle endian issues. This change assumes the same low
level format at either end of the serialization/deserialization.

R=kustermann@google.com

Bug: 21818
Change-Id: I5d97c1d0b89badf9cb972f0b1977eba0d1c0b9f8
Reviewed-on: https://dart-review.googlesource.com/35962
Commit-Queue: Erik Corry <erikcorry@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-01-22 22:09:59 +00:00
Peter von der Ahé 26f7ad3098 Implement implicit const for constructors 
Change-Id: I25add4ce4830414266b8fed2388b6de2747b227d
Reviewed-on: https://dart-review.googlesource.com/35863
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-19 15:26:25 +00:00
Peter von der Ahé 2c4e98f2e3 Implict new for constructor invocations 
Change-Id: I3806d705295c581e8a5d93f1bf0698c88fc073b3
Reviewed-on: https://dart-review.googlesource.com/33321
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-19 15:26:25 +00:00
Sigmund Cherem e2ad2db805 Generate checks for library-is-loaded to fasta and dart2js. 
Change-Id: Ibf453ca7390b81da7231dcb1be43e426c00d6eeb
Reviewed-on: https://dart-review.googlesource.com/35100
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-01-18 20:17:14 +00:00
Leaf Petersen a767fc81d2 More status file updates 
TBR=rnystrom@google.com

Change-Id: I995f63096ed3c416dd80fe91292cff3d484e0c37
Reviewed-on: https://dart-review.googlesource.com/35080
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-01-17 02:48:08 +00:00
Leaf Petersen 4021b51a02 Fix stream_from_iterable dartkp status 
TBR=rnystrom@google.com

Change-Id: I59696c196da4faac8a67acb299ea2f8c231aa38e
Reviewed-on: https://dart-review.googlesource.com/35060
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-01-17 00:44:39 +00:00
Leaf Petersen 6b3576f673 Fix fuzzy arrow issues in tests. 
Also fixes a variety of miscellaneous accidental strong mode compile time or runtime check violations.

Change-Id: Ia8a41ac291aff3689efae0b11a9c51a2db30ef33
Reviewed-on: https://dart-review.googlesource.com/34924
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2018-01-16 23:08:01 +00:00
Alexander Thomas 27ebef64d4 [infra] Add VM Kernel Windows x64 builders 
Bug: https://github.com/dart-lang/sdk/issues/31707
Change-Id: Ie56f4c6f78c9b7c27fc4f587857e412db3e8f358
Reviewed-on: https://dart-review.googlesource.com/33960
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-01-16 15:39:03 +00:00