dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
56,503 Commits 2 Branches 0 Tags
bd94de8e4866cc315a08bd6ef6d20037da717a01
Commit Graph

17810 Commits

Author SHA1 Message Date
Peter von der Ahé bd94de8e48 Use dynamic to fix string_interpolate_test 
Change-Id: I48f7b1127e5c61f9c399ac32d7118adc110a6519
Reviewed-on: https://dart-review.googlesource.com/60846
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-06-19 10:58:45 +00:00
Martin Kustermann b172a42881 [VM] Catch errors for integer operations in kernel2kernel constant evaluator 
Issue https://github.com/dart-lang/sdk/issues/33481

Closes https://github.com/dart-lang/sdk/issues/33469

Change-Id: I7ca9825a0aa5f062732a759b4dd116e716a0d1b3
Reviewed-on: https://dart-review.googlesource.com/60580
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-06-19 10:28:05 +00:00
William Hesse f1d44e39fa Update status for passing Windows Firefox co19 tests 
Change-Id: If7d9aabe7a192be404e36f33cecf740cf392bc60
Reviewed-on: https://dart-review.googlesource.com/60844
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-06-19 08:10:41 +00:00
asiva efb4f69a13 Adjust simarm status. 
Change-Id: I0caa211296dc3fba914e97908403d987a6e89136
Reviewed-on: https://dart-review.googlesource.com/60835
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-06-19 06:57:26 +00:00
asiva ebe2f1db2c Adjust status files. 
Change-Id: I294248bb2970645692f0c648477d7af8983580a3
Reviewed-on: https://dart-review.googlesource.com/60831
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-06-19 04:53:43 +00:00
asiva 6fcc95d2a4 Adjust status files. 
Change-Id: Ia94c7477b73ae1f5fa90ffa072436355fcbacf0e
Reviewed-on: https://dart-review.googlesource.com/60830
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-06-19 03:38:20 +00:00
asiva a69d922794 Adjust some of the test expectations based on the flip to Dart 2 mode. 
Change-Id: I84491b161959050b3fab2493f125ab23c8078ec4
Reviewed-on: https://dart-review.googlesource.com/60823
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-06-19 00:04:57 +00:00
asiva bc7220a4fd [VM] Turn dart2 on by default on the command line VM 
- make Dart2 the default option for the command line VM
- add option --no-preview-dart-2 as a fallback option to run dart1
- change test scripts to use the executable dart for testing dart2 mode instead of
pkg/vm/tool/dart2
- adjust numerous build and test configurations

Change-Id: Id813fa5b71a89c7ec9335d3f6e83cfc9f35f86e7
Reviewed-on: https://dart-review.googlesource.com/58240
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-06-18 22:31:32 +00:00
Mike Fairhurst 0a59b2ff90 Fix test cases that await "void." Blocks #33415, making that an error 
Change-Id: I758d66d5112de631283adc791c0e33b3b98edfc1
Reviewed-on: https://dart-review.googlesource.com/60707
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-06-18 20:33:13 +00:00
Alexander Markov 57c0fc9593 [vm/corelib] More cleanup in integer operations after _Bigint is removed 
Change-Id: I41da6a37e554ffb8b77f51fda3fee5a15f2b8045
Reviewed-on: https://dart-review.googlesource.com/60441
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-06-18 18:16:51 +00:00
Lasse R.H. Nielsen 060ee6769e Make CastStreamSubscription.onData handle a null callback 
Fixes #33166

Bug: http://dartbug/com/33166
Change-Id: If2f0f714b96ce592936d3298bb5d84732d34f69b
Reviewed-on: https://dart-review.googlesource.com/56101
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-06-18 13:24:17 +00:00
Lasse R.H. Nielsen dfeaf79cef Fix VM accepting too many overlarge hex numbers in int.parse. 
Fixes #32858

BUG= http://dartbug.com/32858

Change-Id: I362e51ef0fb8b55a0ca1a7ed75a77a13c9d94893
Reviewed-on: https://dart-review.googlesource.com/60243
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-06-18 10:04:07 +00:00
Johnni Winther c84a9f46b2 Recompute ClassHierarchy after adding noSuchMethod forwarding stubs 
Change-Id: Idcd1ba9e43a917a526d0687be8e5b84a267042a2
Reviewed-on: https://dart-review.googlesource.com/60422
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-06-18 08:12:06 +00:00
Johnni Winther b558a9c2f4 Handle missing compile-time errors 
Closes #33468

Change-Id: I6da12012103ed465257335ce5bb81ba1fc54c81a
Reviewed-on: https://dart-review.googlesource.com/60500
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-06-18 07:34:46 +00:00
Alexander Thomas b960e5a3ed [gardening] Mark standalone_2/io/directory_test as Crash on dartkp/debug 
See #33475

TBR=whesse@google.com

Change-Id: I9c162b4ab18cb90e24959a70d92a898b7295d470
Reviewed-on: https://dart-review.googlesource.com/60541
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-06-17 21:11:30 +00:00
Mike Fairhurst e2d903c4dc Remove packages/ directory resolution from CFE 
Change-Id: I560941d08965a58b8a88e1b49c4d7d216389609e
Reviewed-on: https://dart-review.googlesource.com/60062
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-06-15 22:47:20 +00:00
Johnni Winther f59389b688 Optimize .runtimeType impact based on usage 
Change-Id: If6c24d4115241dcb8ac2ed82eee58c4025e3d8e2
Reviewed-on: https://dart-review.googlesource.com/59090
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-06-15 19:51:14 +00:00
Terry Lucas dd8988c9b2 - Moved all WebGL rendering/drawing constants to synthesized class WebGL. 
- Removed obsolete Dartium/_blink code.

R=kevmoo@google.com

Change-Id: I81a6f0d5bfe33592ff8ae9c85db9266e898c2861
Reviewed-on: https://dart-review.googlesource.com/60380
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-06-15 17:08:54 +00:00
Leaf Petersen 8e9e8e1da0 Fix various bugs and regularize behavior of returns statements in 
various kinds of functions.

Closes-bug: #31887
Closes-bug: #30638
Closes-bug: #32233
Closes-bug: #32881
Closes-bug: #31278
Change-Id: I4ebd7e71096d611e189b571ba5de2998dd11c98b
Reviewed-on: https://dart-review.googlesource.com/60300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
 2018-06-15 16:07:44 +00:00
Aske Simon Christensen 309baedc72 Mark some frequently flaky co19 dart2js tests. 
Change-Id: Ia30d9e7b3ffc4ebf83c0d9fc9e16c687f615b0f1
Reviewed-on: https://dart-review.googlesource.com/60260
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2018-06-15 08:16:04 +00:00
Terry Lucas f479435bca - Removed custom handling of fill - it was wrong the method is now overloaded. 
- Associate the JS class SpeechSyntesisVoice with the correct Dart class (DDC).
- Top-level querySelectorAll wasn't generic.
- Handle "static" for attributes in the IDLs.

Fixes #33147
Fixes #33178
Fixes #31886
Fixes #20585

R=vsm@google.com

Change-Id: Ic75a2bfc66670b72342269be259408b610547dab
Reviewed-on: https://dart-review.googlesource.com/59240
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-06-15 02:25:13 +00:00
Jenny Messerly d2a37231b3 optimize await in async* methods in dartdevc 
Refactors async* implementation class to dart:async and ports it back to
Dart. Improves `await` to avoid zone registration at each await.

Change-Id: I15cac2a40bd56269c8ade1dc0810792c23459ef5
Reviewed-on: https://dart-review.googlesource.com/59260
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-06-15 01:54:03 +00:00
Sigmund Cherem 0cf860f361 Remove pub_build_validity test 
Now that `pub-build` is gone, this is no longer needed.

Change-Id: Ie3b7e6c3e2e50fc43bcf6601387e9e839d3b6ff8
Reviewed-on: https://dart-review.googlesource.com/60321
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-06-14 22:57:35 +00:00
Terry Lucas 17d2839a03 Fixed tests for FF difference. 
TBR=sra@google.com

Change-Id: I8698294f8d4b8c63930616ff72df191b10eb9de9
Reviewed-on: https://dart-review.googlesource.com/60220
Reviewed-by: Terry Lucas <terry@google.com>
 2018-06-14 04:02:08 +00:00
Terry Lucas aca417a256 Fix test and expected failure. 
TBR=sra@google.com

Change-Id: I1ee39073ccf977725d89152ddfba5c56211815d1
Reviewed-on: https://dart-review.googlesource.com/60181
Reviewed-by: Terry Lucas <terry@google.com>
 2018-06-13 21:19:27 +00:00
Ryan Macnak 9b5a931b06 [vm] Replace most runtime/vm uses of OS::Print with OS::PrintErr. 
Leave --print-snapshot-sizes on stdout because it is parsed by Flutter benchmarks.

Replace all runtime/bin uses of OS::Print with Log::Print.

Bug: https://github.com/dart-lang/sdk/issues/32134
Change-Id: I74aacfb410cdfa9270d06e7f6ab0534520c7c7ba
Reviewed-on: https://dart-review.googlesource.com/60021
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-06-13 19:51:40 +00:00
Terry Lucas 354d5863dd Updated expected tests and fix for FF test. 
TBR=sra@google.com

Change-Id: I83e368ce58948bdb3e22d0c0f342990497dd9984
Reviewed-on: https://dart-review.googlesource.com/60143
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-06-13 19:48:02 +00:00
Terry Lucas eea2dff20d Added support for members of type Promise. 
Fixes #31046

R=sra@google.com

Change-Id: Id1e8d415b91a842bd8e2f50c6064c24aaaed9d98
Reviewed-on: https://dart-review.googlesource.com/59460
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-06-13 18:20:53 +00:00
Ben Konyi 1e91c62d4b [ VM / dart:io ] Fixed issue where Link.rename would fail on Windows if another link or directory with the same name as the target existed. Fixes issue #30687. 
Change-Id: I2ef4dc08cc60c57e1fab38323d67afd3fba47e84
Reviewed-on: https://dart-review.googlesource.com/60060
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-06-13 18:03:20 +00:00
Johnni Winther 37425618d5 Narrow to static types in invoke/get in inference 
Change-Id: Ifb085cf881c21a6161a22cb1f2b6058a9947f321
Reviewed-on: https://dart-review.googlesource.com/55920
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-06-13 13:11:10 +00:00
Aske Simon Christensen 08de1b30aa Error when a file is a part of more than one library 
Fixes https://github.com/dart-lang/sdk/issues/32999

Corresponding spec issue: https://github.com/dart-lang/sdk/issues/33225
Issue for co19 fix: https://github.com/dart-lang/co19/issues/149

The code contains a temporary hack that works around the co19 use.
This hack can be removed when the co19 fix rolls in.

Change-Id: I61b50c9142f4b215fc4d9258f1259e24ab4c052f
Reviewed-on: https://dart-review.googlesource.com/56521
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2018-06-13 12:55:20 +00:00
Mike Fairhurst fa629f6269 No longer expect crash on windows which was caused by now-unused packages/ dir in test 
Change-Id: Ia979a2d6291e8df49e12a548803a1095a9eca5ad
Reviewed-on: https://dart-review.googlesource.com/60061
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2018-06-12 23:57:42 +00:00
Mike Fairhurst 3977fa7e32 Fix analyzer non strong test for packages file test changes 
Change-Id: I058b2a19446a2e952cb2f8597bcdbe0fce61fd15
Reviewed-on: https://dart-review.googlesource.com/60000
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2018-06-12 20:23:59 +00:00
Mike Fairhurst 7911fb2683 First pass at disabling packages/ dir, packageRoot 
Change-Id: Ib2d7738c84cd1258dcad46e8e2c8da8105efea60
Reviewed-on: https://dart-review.googlesource.com/59100
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-06-12 19:38:40 +00:00
Régis Crelier 89e88f00a5 [Tests] Adjust status for slow bigint test with simulated architectures. 
Change-Id: If28eeee4ad1e2e9e8701aee2e51b1a4a875ff0c4
Reviewed-on: https://dart-review.googlesource.com/59961
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2018-06-12 19:06:37 +00:00
Régis Crelier 23c92f9ab2 [Tests] Adjust status for slow bigint test with dartkp. 
Change-Id: Id643e33fcd9365635e5e266d2465eba32dc0b973
Reviewed-on: https://dart-review.googlesource.com/59960
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2018-06-12 18:43:18 +00:00
Régis Crelier 83142f08c6 [Tests] Adjust status for slow bigint test. 
Change-Id: I67c49839fcd8a75b5dc6a3979ffe38cfdef3af73
Reviewed-on: https://dart-review.googlesource.com/59902
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2018-06-12 17:51:35 +00:00
Régis Crelier ea96922935 [Tests] Adjust iteration number and optimization threshold for slow bigint test. 
Change-Id: Ibf3cf39f252e251de9998269c2101389446f1d8c
Reviewed-on: https://dart-review.googlesource.com/59901
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2018-06-12 16:25:37 +00:00
Régis Crelier 87a46b8bee [VM Bigint] Fix _convert() of classic reduction for negative Bigint (fixes #33405). 
Add regression test in existing bigint test.


Change-Id: I3dd0cc24ef19531dd16c89b4565f687a7b2b46bd
Reviewed-on: https://dart-review.googlesource.com/59820
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2018-06-12 15:12:00 +00:00
Lasse R.H. Nielsen 0b91676362 Remove the retype method. 
See #33075.

Bug: http://dartbug.com/33075
Change-Id: I1ee2f587afbc672dd08ac61ac003bbdc85bb95e2
Reviewed-on: https://dart-review.googlesource.com/59091
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-06-12 14:36:09 +00:00
Johnni Winther e7ad806bf1 Provide default type variable bounds on inlining. 
+ use the 'any' type to avoid failing on bounds with type variables, which we currently don't support.

Change-Id: I57d74d17fa9eee598bd86c8e76790778438cddfd
Reviewed-on: https://dart-review.googlesource.com/59540
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-06-12 09:05:09 +00:00
Johnni Winther 7321f938d5 Use default type for type variable bounds. 
Change-Id: I5d21a16a76eb6cd898e8e11104d0be0f7e669426
Reviewed-on: https://dart-review.googlesource.com/59420
Reviewed-by: Stephen Adams <sra@google.com>
 2018-06-12 09:05:09 +00:00
Johnni Winther 52d7a3043a Track RTI dependency through instantiations 
Closes #33093

Change-Id: Ia7d9cd1235cd4fe60858f37533689f5eeb600540
Reviewed-on: https://dart-review.googlesource.com/59400
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-06-12 08:00:09 +00:00
Stephen Adams 1fb845c2f4 [dart2js] Apply stub should default type parameters 
Change-Id: Ie01ade9b6e561a96a3ac06bf13617bb679122c63
Reviewed-on: https://dart-review.googlesource.com/59020
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-06-12 01:10:39 +00:00
Aske Simon Christensen f20672e00a Parse name of factory as method name instead of constructor reference. 
Report an error when a factory constructor has type parameters.

Report a better error than the old "couldn't find constructor" or
"illegal method name" when the name of a constructor does not match
the name of the enclosing class.

Fixes https://github.com/dart-lang/sdk/issues/31196

Change-Id: Ie46a5b4cbe07ba05ce2936e1f8f9ca2cad0208f7
Reviewed-on: https://dart-review.googlesource.com/57620
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-06-11 09:55:24 +00:00
Samir Jindel b45482a989 [kernel/vm/precomp] Update status file for duplicate_interface_implements_test/01. 
Change-Id: I27ddf1ee2d53033f376c8404c5aec7dac0d5275c
Reviewed-on: https://dart-review.googlesource.com/59620
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-06-10 16:53:03 +00:00
Jenny Messerly 3971e76a92 Mark uri_parse_test slow on ddc 
This is something we'll want to investigate. It looks like dartdevk's
performance using its own SDK is slightly worse, suggesting it's missing
some optimizations (e.g. `JS` types that are not recognized, extra null
checks, covariance check elimination).

Change-Id: Ieaedd6be3bfb70718f495fc86cb1adcf67aad3cc
Reviewed-on: https://dart-review.googlesource.com/59580
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2018-06-08 22:58:40 +00:00
Bob Nystrom 67525aef37 Convert a batch of negative tests to multitests. 
Change-Id: I380c12ef633ec8c40de982782623d3e3659a4834
Reviewed-on: https://dart-review.googlesource.com/57162
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-06-08 19:43:34 +00:00
Jenny Messerly 976aa4074b Run dartdevk against its own compiled SDK and packages 
Currently we test dartdevk against SDK/packages that were compiled with
dartdevc (DDC+Analyzer). This CL migrates to having those files compiled
with DDC+Kernel. dartdevc testing is unchanged.

Most of the fixes are around things like special optimized annotations
used in our SDK code, that were not understood by DDK. Also some inline
JS type annoations were not correct.

Change-Id: Iccf4427e4b9beffd6d97a4be654253d91f6cb89e
Reviewed-on: https://dart-review.googlesource.com/57800
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-06-08 19:18:34 +00:00
Terry Lucas f4386ed488 Fix type error in MultiElementCssClassSet constructor. 
Fixes #29901

R=sra@google.com

Change-Id: Idfa1dee3d243ed34c3ca8d1225404143a28746e8
Reviewed-on: https://dart-review.googlesource.com/59340
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-06-08 17:47:32 +00:00