Commit Graph

20 Commits

Author SHA1 Message Date
Ryan Macnak 558a931409 [vm] Move some string utils from runtime/vm to runtime/platform.
Change-Id: I552086445a7e07792f9da85afa5edf23b6c450d5
Reviewed-on: https://dart-review.googlesource.com/44402
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2018-03-01 02:07:46 +00:00
Zachary Anderson 6cd8a79078 VM: Re-format to use at most one newline between functions
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2974233002 .
2017-07-13 08:08:37 -07:00
Ryan Macnak ab212fedb3 Undo rename of LoadExtensionLibrary to LoadLibrary since mangling on Windows seems to create a conflict with LoadLibraryW.
Update use of IsolateData in Dartium's vm service.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2695403003 .
2017-02-16 14:22:23 -08:00
Ryan Macnak a317b90d63 Cleanup app snapshots on isolate/vm exit.
R=zra@google.com

Review-Url: https://codereview.chromium.org/2694103004 .
2017-02-16 13:54:57 -08:00
Zachary Anderson 479a97b129 clang-format runtime/bin
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2480793002 .
2016-11-04 12:30:56 -07:00
Zachary Anderson b990bc3794 Fix native extension lookup
This CL allows native extension lookup to defer to the platform's
library lookup (e.g. dlopen) when the library cannot be found next to
the importing Dart library. It also allows dart-ext: to accept an
absolute path to the native library.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2285223003 .
2016-08-30 09:31:47 -07:00
John McCutchan 7af8d6e5a4 Strip the scheme off of uris passed into the native extension loader.
Fixes https://github.com/dart-lang/sdk/issues/26894

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2153203002 .
2016-07-15 13:09:33 -07:00
Zachary Anderson 1336e6149f Search for a native extension for the host architecture
R=iposva@google.com

Review URL: https://codereview.chromium.org/1896203002 .
2016-04-20 08:02:16 -07:00
Zachary Anderson 45661a7091 Cleanup in //runtime/bin
R=iposva@google.com

Review URL: https://codereview.chromium.org/1800863002 .
2016-03-16 10:01:00 -07:00
Siva Annamalai b4d0ca282d Cleanup the extensions code to avoid the duplication that was introduced in the quick fix to turn the bots green.
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1401253004 .
2015-10-14 15:27:58 -07:00
Siva Annamalai e1ff27e761 Fix for issue 23908 - error message reports the exact error when a native extension fails to load.
BUG=23908
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1403683007 .
2015-10-14 11:16:22 -07:00
whesse@google.com 1ab4461654 Refactor native extension shared library lookup.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//186473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33275 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 14:39:12 +00:00
whesse@google.com 32b2fd3cf1 Change handling of dart-ext: URIs for native extensions.
With this change, a dart-ext: URI is now an opaque URI consisting of
the scheme dart-ext: followed by an actual URI, either relative, or
with a scheme like file:, http:, or package:.  Existing users are mostly
or all using relative URIs, so this change should not affect them.

This is a step toward allowing native extensions in packages to be served
over http, and also cleans up the code, and would help a future change
that replaces "dart-ext:" with metadata or an annotation.

BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org//180783008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33216 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 14:51:44 +00:00
whesse@google.com 631f9f86bc Allow Windows network share paths for the script path and the package root.
BUG=dartbug.com/14577
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//57923004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29878 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-05 08:10:55 +00:00
asiva@google.com 1a2f236fab Fix issue 13942 - Dart_Error function invokes OS::VSNPrint with the "format" string containing data derived from the string
R=iposva@google.com

Review URL: https://codereview.chromium.org//27694005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28809 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 17:49:45 +00:00
smok@google.com ebbc2020a2 Put everything in runtime/bin into '::dart::bin' namespace.
Review URL: https://codereview.chromium.org//14341015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22032 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-25 14:22:30 +00:00
ager@google.com 3c8d8827c0 Deal with extension loading from packages.
The issue is bad interplay with package and dart-ext URIs.
dart-ext URIs overwrite the package URI which makes us lose
the package URI path components. This change resolves
all the way to a file path for dart-ext URIs if the base
URI is a package URI.

R=whesse@google.com
BUG=dartbug.com/6264

Review URL: https://codereview.chromium.org//11308170

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15272 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-23 07:03:15 +00:00
whesse@google.com 7b9880570d Refactor URI processing of native extensions directive #import("dart-ext:foo").
BUG=
TEST=standalone/io/TestExtensionsTest

Review URL: https://chromiumcodereview.appspot.com//10103031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6674 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-18 09:58:01 +00:00
whesse@google.com 3b7099b7e2 Change lookup path for Dart native extensions shared libraries.
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9694045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5524 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-15 15:49:57 +00:00
whesse@google.com 3c6d3843fc Add native extensions for the Dart shell to the Windows platform and the Mac OS X platform.
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9465004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5235 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-09 14:34:57 +00:00