be30b62e3d
Remove the Kernel type inference listener
...
We have decided to move to a different API for Fasta/Analyzer
integration, one that doesn't involve compiling to Kernel or observing
type inference. The listener API will become broken, so let's just
remove it before that happens.
We lose the ability to trace type inference so let's restore that
ability next. The analyzer's resolution storer is not used, but that
code has been left. The resolution applier will no longer work
without the resolution storer, so those tests have been disabled.
Change-Id: If9ac5aba2d5de7788d8a65f7fa8410599e636d21
Reviewed-on: https://dart-review.googlesource.com/42400
Commit-Queue: Kevin Millikin <kmillikin@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-02-21 16:28:07 +00:00
e2ad2db805
Generate checks for library-is-loaded to fasta and dart2js.
...
Change-Id: Ibf453ca7390b81da7231dcb1be43e426c00d6eeb
Reviewed-on: https://dart-review.googlesource.com/35100
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2018-01-18 20:17:14 +00:00
cd878bc433
Create the new flag --use-cfe in the analyzer, analysis server and analyzer_cli and migrate the old behavior of --preview-dart-2 to --use-cfe. The --preview-dart-2 flag is now a no-op, with functionality coming soon.
...
See https://github.com/dart-lang/sdk/issues/31640
Change-Id: I2db2e7ef6a324cbd5d369b807e331495fed167df
Reviewed-on: https://dart-review.googlesource.com/33121
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2018-01-08 22:37:05 +00:00
76c5a9a6c8
Convert errors from FrontEnd into Analyzer.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I94f219e378437e0bcff3ee8e2ca0598594e59afc
Reviewed-on: https://dart-review.googlesource.com/32143
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-01-03 20:05:25 +00:00
f57a0511a4
Apply import prefixes in type annotations.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I185b9860aac8650856c8c13b6784b63f3fe2f379
Reviewed-on: https://dart-review.googlesource.com/32000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-01-02 22:34:04 +00:00
57d75d3358
Apply resolution to static field references with import prefixes.
...
Bug:
Change-Id: Ie84c69aea71cd6e5e5c373eba2c4439af524264c
Reviewed-on: https://dart-review.googlesource.com/31747
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-01-02 20:20:06 +00:00
9b54b25f3e
Fix error reporting when it makes tests behave differently in checked and unchecked modes.
...
R=brianwilkerson@google.com
Bug:
Change-Id: Ib5f7b3c531bfd767e5640ff45e1ad9e7ef0148a9
Reviewed-on: https://dart-review.googlesource.com/31882
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-01-02 05:01:34 +00:00
990dba4e08
Apply resolution to import prefixes.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I9598e11b21ea714f06ce33706c467a161091675a
Reviewed-on: https://dart-review.googlesource.com/31840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-30 19:32:19 +00:00
fa265c892e
Triage some failing tests
...
Change-Id: Ia6ef2b687b4eb5abc5d88a58b8416a6b4c9e2bb8
Reviewed-on: https://dart-review.googlesource.com/28860
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-12-12 23:17:01 +00:00
b1fce8078e
Enable strong mode when previewDart2 is enabled
...
Change-Id: I2d26dec1e3e4dc7a32ef51ff740211032919adb1
Reviewed-on: https://dart-review.googlesource.com/28524
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-12-12 14:08:40 +00:00
3be5621449
Handle method invocations that cannot be resolved because of missing type information
...
Change-Id: I07f22964b07f38fee37ab28ff205f227f50b3024
Reviewed-on: https://dart-review.googlesource.com/28500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-12-12 01:23:33 +00:00
fbe4151da4
Handle member references that cannot be resolved because of missing type information
...
Change-Id: I3599846476c082a533882f6d8d18e1adeb70fa3c
Reviewed-on: https://dart-review.googlesource.com/28383
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-12-11 22:21:53 +00:00
b0d520314e
Run tests with previewDart2 enabled and update failure list
...
Change-Id: I580545037a820e37fe22288177b289371c6ce645
Reviewed-on: https://dart-review.googlesource.com/28320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-12-11 17:57:23 +00:00
3fedd483f3
Parse metadata for import/export directives and resynthesize in Analyzer.
...
R=ahe@google.com , paulberry@google.com , sigmund@google.com
Bug: https://github.com/dart-lang/sdk/issues/30284
Change-Id: I57af6f4d58b6de39f13b9656af25f0be6949cf79
Reviewed-on: https://dart-review.googlesource.com/14363
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-19 16:35:17 +00:00
87410835d6
Resynthesize LibraryElement annotations from Kernel.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I6ba30eff022d6a46fd7a19c887d13ebde243ce03
Reviewed-on: https://dart-review.googlesource.com/14121
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-16 20:26:08 +00:00
0920da5d52
One more pass to triage the rest of the tests.
...
I hope that's it for now.
At this point we need to fix Fasta problems to fix there tests.
R=brianwilkerson@google.com
Bug:
Change-Id: I68c4ea12a9f1ea524a3d15865f71675a91e18d66
Reviewed-on: https://dart-review.googlesource.com/13303
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-11 21:31:34 +00:00
e32b446640
Rework getElement() in resynthesizer.
...
So that it is not recursive anymore.
This also fixes a bug with private classes.
There is no library URI qualifier for classes, even if they are private.
R=brianwilkerson@google.com
Bug:
Change-Id: I3c5c3d56e7f895940192fcee692043aaef25d2dc
Reviewed-on: https://dart-review.googlesource.com/8163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-25 17:08:03 +00:00
f575c099b0
Run all *_driver tests also with Kernel. (attempt #2 )
...
With previous changes that fix finding dart:core on Windows and
flakyness of reporting import errors, I'd like to reland this CL.
Attempt #1 : https://dart-review.googlesource.com/c/sdk/+/7624
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: If5ab2c5ebe2204df6643ee42cbee5b49fb2d8c31
Reviewed-on: https://dart-review.googlesource.com/7961
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-24 18:27:27 +00:00
2274739c3c
Revert addition of kernel tests to analyzer unit tests
...
These tests have flaky failures on the buildbots and commit queue.
Revert "Run all *_driver tests also with Kernel."
This reverts commit d2f887e37b055654e96d824c3f56cchttps://dart-review.googlesource.com/7708
Reviewed-by: William Hesse <whesse@google.com >
2017-09-22 11:37:21 +00:00
d2f887e37b
Run all *_driver tests also with Kernel.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I92a0f5f2192c20276b166a9211ab1064bc6f2b82
Reviewed-on: https://dart-review.googlesource.com/7624
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-21 22:44:39 +00:00
Kevin Millikin