f8caffd9e6
Remove some uses of Platform.packageRoot.
...
Change-Id: Ic01e7f7a9f5c677bcf3779ae2a9386345620793a
Reviewed-on: https://dart-review.googlesource.com/60443
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-06-19 05:12:13 +00:00
4a353fea35
Another attempt to fix tests on Windows
...
Change-Id: I7c1c12ec3b9244d52633bc46a115e1b9e51dc87b
Reviewed-on: https://dart-review.googlesource.com/60821
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-06-19 00:23:59 +00:00
b3b8ca6dc4
Remove the --package-default-analysis-options flag.
...
Change-Id: If36ee3478d8c95c38ff2cd5ed43f4dc3cdfe973e
Reviewed-on: https://dart-review.googlesource.com/60442
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2018-06-18 23:34:09 +00:00
b140baeb55
Own files by their URIs during search.
...
R=brianwilkerson@google.com
Change-Id: If17700a4d433701cb6cb2432f6be9c27dc6e6b92
Reviewed-on: https://dart-review.googlesource.com/60803
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-18 22:07:17 +00:00
83cb0c425d
Fix awaiting void in analyzer ast_test.dart. Fix at method decl.
...
Required to unblock #33415
Change-Id: I18306967737fc26136cc74c70f14cf33509e96f3
Reviewed-on: https://dart-review.googlesource.com/60706
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2018-06-18 21:32:46 +00:00
c9af309cbf
Fix fasta parsing of ?. in cascade expression
...
... and fix more Analyzer fasta parser tests
Change-Id: I42e6f25784dbc62bca620b1ab522c07350f53aff
Reviewed-on: https://dart-review.googlesource.com/60721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-06-18 21:25:41 +00:00
741ed336f1
Improve AstBuilder int literal recovery
...
... and fix more Analyzer fasta parser tests
Change-Id: Ic051369580311e0ee1be09210d34a6654d90c023
Reviewed-on: https://dart-review.googlesource.com/60720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-06-18 20:00:13 +00:00
1dcc3264e7
Fix tests that are failing on Windows
...
Change-Id: Id7182df3f08078f0e6c1959db94cf2da0bebd995
Reviewed-on: https://dart-review.googlesource.com/60680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-06-18 17:07:11 +00:00
691313f357
Move newOptionsFile() and newPackagesFile() into ResourceProviderMixin.
...
R=brianwilkerson@google.com
Change-Id: I903312db8e738c988a197fdd875cfd4ae5e4799d
Reviewed-on: https://dart-review.googlesource.com/60641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-18 16:50:31 +00:00
e62f563b2d
Validate sdkPath in AnalysisContextCollectionImpl.
...
R=brianwilkerson@google.com
Change-Id: Iaffd3dc66fbb4bb8c4e4aae5f036c28ba68b07d6
Reviewed-on: https://dart-review.googlesource.com/60640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-18 16:42:31 +00:00
493c421f0d
Add AnalysisContextCollection.
...
R=brianwilkerson@google.com
Change-Id: Id0c64648983129f5ecd46d784e978ce321ba2041
Reviewed-on: https://dart-review.googlesource.com/60404
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-18 15:53:36 +00:00
dfeaf79cef
Fix VM accepting too many overlarge hex numbers in int.parse.
...
Fixes #32858
BUG= http://dartbug.com/32858
Change-Id: I362e51ef0fb8b55a0ca1a7ed75a77a13c9d94893
Reviewed-on: https://dart-review.googlesource.com/60243
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2018-06-18 10:04:07 +00:00
2394097e44
Support for including/excluding the same path in ContextRoot.isAnalyzed().
...
R=brianwilkerson@google.com
Change-Id: Iab7deb1a0e4a541c3c0ee9fbd9518366e6e1a91e
Reviewed-on: https://dart-review.googlesource.com/60450
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-15 19:52:06 +00:00
ee1f7f5a93
Fix newly reported warnings
...
Change-Id: I7688b3777209ec3d36057d3e20d9fd49ec1324e4
Reviewed-on: https://dart-review.googlesource.com/60449
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-06-15 19:42:20 +00:00
afa8ff6292
Add a resource provider that supports file overlays
...
Change-Id: If09447d2bf50c69e007bf1953461ee16c46c7ab4
Reviewed-on: https://dart-review.googlesource.com/60406
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-06-15 19:28:29 +00:00
8e9e8e1da0
Fix various bugs and regularize behavior of returns statements in
...
various kinds of functions.
Closes-bug: #31887
Closes-bug: #30638
Closes-bug: #32233
Closes-bug: #32881
Closes-bug: #31278
Change-Id: I4ebd7e71096d611e189b571ba5de2998dd11c98b
Reviewed-on: https://dart-review.googlesource.com/60300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Leaf Petersen <leafp@google.com >
2018-06-15 16:07:44 +00:00
8f0106e490
Update more Analyzer fasta tests
...
Change-Id: I1b39eebaf11882bd1524335a7dcbba86f2d26cfb
Reviewed-on: https://dart-review.googlesource.com/60362
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-15 00:38:53 +00:00
53c2a6f9d5
Cleanup remaining unescape string call sites
...
Change-Id: Iaf4ac9d9c48c6cca7bd2ada2d370e0253fcaa963
Reviewed-on: https://dart-review.googlesource.com/60361
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-15 00:38:13 +00:00
5bf6436bc9
Initial implementations of two generators
...
Change-Id: Ib751abe9920d0f8b07b4395b47a60ed99ab80493
Reviewed-on: https://dart-review.googlesource.com/60322
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-06-14 23:45:54 +00:00
c015e8d303
Improve invalid string literal error recovery
...
Change-Id: Ic7d5d3f19e97a0004254377170bcc91efc7bfb08
Reviewed-on: https://dart-review.googlesource.com/60360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-06-14 22:53:34 +00:00
9df6426adb
Mark the library analyzer.dart as being deprecated
...
Change-Id: I037073a3a482e99fb6db1205d069cfc4b5ba31ee
Reviewed-on: https://dart-review.googlesource.com/60280
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-06-14 16:53:09 +00:00
bd956620fe
Remove code that is causing a couple of hints
...
Change-Id: Ie0f575da1d5b5638f8ea55bf8f423c8f2cba85e8
Reviewed-on: https://dart-review.googlesource.com/60281
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-06-14 16:43:29 +00:00
99575f79ca
Split ContextAwareGenerator and its subclasses
...
This prepares the generators to be implemented by the analyzer.
Change-Id: I8b5a5b6e00d5ec7003f75b899be74c6c33a4585d
Reviewed-on: https://dart-review.googlesource.com/60244
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-06-14 14:14:14 +00:00
41a8b79475
Use the inferred type of const lists/maps to for constant evaluation.
...
This addresses one of the root causes of #33304 . Note that when a
constant list or map is recorded in a summary, we don't encode enough
information in the summary to resynthesize its inferred type
correctly, so this only fixes cases where the constant is used in the
same build unit as its declaration.
Change-Id: Id0034f481cb82f18c77bbe2ee8ebec7e8b244caa
Reviewed-on: https://dart-review.googlesource.com/60203
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-06-14 14:08:54 +00:00
f7ef66f5b0
Issue 33412. Fix for race condition in knownFiles during search.
...
In theory discoverAvailableFiles() should wait for all possibly known
files to be discovered. But I think it is still possible to get the
set of known files changed, e.g. when are asking asynchronoiusly for
getIndex() and the user open a file that is not yet part of any driver.
Only the second hunk of the change (inside subtypes()) is required for fixing
the issue, the crucial change is toList() invocation. The switch from
_driver.knownFiles to _driver.fsState.knownFiles is done to avoid one extra
lookup for FileState.
The first hunk (inside declarations()) is done just for consistency.
Fixes https://github.com/dart-lang/sdk/issues/33412
R=paulberry@google.com
Change-Id: I652ef7a156eba4bf0298c7e863dcef2b7c9f2b0e
Reviewed-on: https://dart-review.googlesource.com/60142
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-06-13 21:49:14 +00:00
695aa1fc00
Improve recovery of missing method parameters
...
... and consolidate insertion of synthetic parenthesis
Change-Id: I08a3ce04bd11fc6201862c9ee101ca9c8538c14c
Reviewed-on: https://dart-review.googlesource.com/60040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-06-13 17:41:20 +00:00
ec58802ea4
Update Analyzer/fasta async* and sync* error message tests
...
Change-Id: I5aea43305a65797d279ca132764c34b33f19ca41
Reviewed-on: https://dart-review.googlesource.com/59980
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-13 13:02:50 +00:00
5df04a89b7
Update more Analyzer tests
...
Change-Id: I23ca56867eb33c9d8983648be9305b82e6441934
Reviewed-on: https://dart-review.googlesource.com/59920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-06-13 12:34:20 +00:00
a474ec8e7d
Default package:analyzer parser to enable optional new/const parsing.
...
Change-Id: I71395d49aa3148817cfc7d3e4fb38b15199e6d76
Reviewed-on: https://dart-review.googlesource.com/59825
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2018-06-12 19:02:09 +00:00
ebc30fd0da
Move void to top of type hierarchy
...
Fixes #33341
Change-Id: Ib2b7b5542b702a04b38dee5261fc80664a7fcc18
Reviewed-on: https://dart-review.googlesource.com/59822
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2018-06-11 22:40:44 +00:00
9cfe8b844e
Improve nested expression recovery
...
Change-Id: Icea54a2bfa1a6a5bf561d91b5a84bb2b4cccf8cd
Reviewed-on: https://dart-review.googlesource.com/58581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-06-11 16:28:29 +00:00
f20672e00a
Parse name of factory as method name instead of constructor reference.
...
Report an error when a factory constructor has type parameters.
Report a better error than the old "couldn't find constructor" or
"illegal method name" when the name of a constructor does not match
the name of the enclosing class.
Fixes https://github.com/dart-lang/sdk/issues/31196
Change-Id: Ie46a5b4cbe07ba05ce2936e1f8f9ca2cad0208f7
Reviewed-on: https://dart-review.googlesource.com/57620
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2018-06-11 09:55:24 +00:00
300fd66f5c
Support for implemented classes/members in package files.
...
Note, that we remove getResolvedUnitObject() and replace it with
normal getIndex(). I think it was done initially this way because we
initiate sending implemented notification when analysis is finished
in analysis server. So, to avoid analysis-fisnished, send-implemented,
do-analysis, analysis-finished, send-implemented infinite sequence.
But getIndex() does not mark AnalysisDriver as requiring analysis.
So, we don't get infinite sequence of events.
R=brianwilkerson@google.com
Change-Id: Ibaf5be5c7a33edb938bd1a4670811dc200dee522
Reviewed-on: https://dart-review.googlesource.com/59500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-08 20:34:53 +00:00
f6d2c2378a
Add awaits in async methods to restore previous semantics
...
Change-Id: I7711cd878a31df0fb0c92572e2256c0a26923640
Reviewed-on: https://dart-review.googlesource.com/59480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-06-08 19:58:07 +00:00
ec5a848588
Add the ability to create function types not associated with elements.
...
Previously, all FunctionTypeImpl objects needed to be associated with
an element in the element model, and the set of free type variables in
those types had to correspond to types declared in enclosing scopes.
This created problems because there are several instances during type
inference where the analyzer needs to create a synthetic function
type, and it can't easily associate it with an existing element.
Also, when the analyzer is integrated with the common front end, we
will need the ability to represent function types that aren't
associated with elements, since that's how function types are
represented in the common front end.
The new kind of FunctionTypeImpl is implemented by
_FunctionTypeImplStrict; the old behavior is implemented by
_FunctionTypeImplLazy.
Fixes #33159 .
Change-Id: I17e5fef1e59837728faf5265b8b722a7afadfbf4
Reviewed-on: https://dart-review.googlesource.com/59160
Reviewed-by: Jenny Messerly <jmesserly@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-06-08 19:43:03 +00:00
bdbf872079
Issue 33373. Support for annotations for enum constants.
...
R=brianwilkerson@google.com
Fixes https://github.com/dart-lang/sdk/issues/33373
Fixes https://github.com/dart-lang/sdk/issues/33375
Change-Id: I917458b38ed7d6c83351f87387d6854e5311ddf2
Reviewed-on: https://dart-review.googlesource.com/59440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-08 18:15:00 +00:00
95dbff984c
Serialize metadata for enum constants.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Iee11718d5c8ea6256a2a54772b12acc5bf8b5214
Reviewed-on: https://dart-review.googlesource.com/59361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-06-08 16:51:43 +00:00
f68298bb57
Add casts to fix dart2 runtime exceptions
...
Change-Id: I29a9d04fecc94c7f8919026bbc98f695189a6523
Reviewed-on: https://dart-review.googlesource.com/59140
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-06-07 19:40:01 +00:00
f368037126
Remove uses of mockito because they are causing problems in dart2
...
Change-Id: Ife57033ede3abdd1e609e1361fb688d96de4dcbf
Reviewed-on: https://dart-review.googlesource.com/59141
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-06-07 18:59:19 +00:00
8e59876cca
Issue 33381. Make input paths in analyzer_cli absolute and normalized.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/33381
Change-Id: I27e710859fdf2ab8e9380b232739def5acdf561d
Reviewed-on: https://dart-review.googlesource.com/59101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-07 18:48:18 +00:00
292b9037e1
Update a pair of analyzer tests
...
The static type of invocations of methods from class Object on
receivers with static type dynamic has changed. Clean up a pair of
analyzer tests that expected the previous behavior and were expected
to fail because the analyzer already implemented the intended
behavior.
Change-Id: I7a65fa4e46a0da51bcf1c183a7c30f0976baaef5
Reviewed-on: https://dart-review.googlesource.com/58205
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Commit-Queue: Kevin Millikin <kmillikin@google.com >
2018-06-07 13:24:41 +00:00
9c5d54cc7e
Fix the generation of labels
...
Change-Id: I486e5a23d31bc85ad534b072867db883f5d60c33
Reviewed-on: https://dart-review.googlesource.com/58981
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-06-07 13:22:55 +00:00
656ed8491e
Follow up to previous CL
...
This addresses comments from
https://dart-review.googlesource.com/c/sdk/+/58201 .
Change-Id: I59fd5ea06fbd644a7ba5e6be842ce20cfaee7536
Reviewed-on: https://dart-review.googlesource.com/59060
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-06-07 09:33:52 +00:00
80dd725f36
Fix search for private elements inside of discovered packages.
...
R=brianwilkerson@google.com
Change-Id: Ie2e4055369624d89c090a55787477a235754db5e
Reviewed-on: https://dart-review.googlesource.com/58940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-06 23:31:25 +00:00
87c62539a8
Fix issues in the test framework that were causing some tests to fail
...
Change-Id: I6dd8ef3f044fa6f968fe5f4449421ce15225b50f
Reviewed-on: https://dart-review.googlesource.com/58802
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-06-06 20:08:34 +00:00
3ece660fea
Update AstBuilder to handle implicit creation expression
...
Change-Id: I772cbef5ad7e87ecedf0b05551e04ec938cd0096
Reviewed-on: https://dart-review.googlesource.com/58583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-06-06 20:00:56 +00:00
1031735707
Fix DriverBasedUriConverterTest on Windows.
...
R=brianwilkerson@google.com
Change-Id: I58de679d86f9e210dad629aa1614027df3b8f6c6
Reviewed-on: https://dart-review.googlesource.com/58803
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-06 18:10:04 +00:00
4d23db795c
Fix a bug in optional const: missing instantiation to bounds on ctors
...
Part of #30384 . This was usually not a problem as most cases involve
additional visitors which rewrite this (for instance, inference).
However, in some cases (appears to be summaries only), that extra
resolution is not needed/skipped, so the non-instantiated constructors
remain.
That makes the constantValue of annotations vulnerable to this, and the
resulting DartObject types will have 'TypeParameterType's for there
typeArguments.
Instantiate the types to bounds, and get the ctor from the type rather
than the element, inside of AstRewriter in order to ensure these
constructors are instantiated.
Change-Id: I65f55feb751e139e68c774786bfbc53788d32995
Reviewed-on: https://dart-review.googlesource.com/58800
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2018-06-06 17:38:24 +00:00
398ba13e4a
Reapply "Make --sync-async the default for the VM."
...
Change-Id: I6e4da0da6c3f635d84380b384ae17fbb55587895
Reviewed-on: https://dart-review.googlesource.com/58721
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Florian Loitsch <floitsch@google.com >
2018-06-06 14:32:13 +00:00
6054cb3e1f
CompilerContext always expects a Future now
...
This change is made because we were incorrectly calling
CompilerContext.clear *before* running the main compilation
task which is async.
Change-Id: I7181af33fe733e5bc653fa742b9e06782f4278d0
Reviewed-on: https://dart-review.googlesource.com/58201
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-06 09:35:31 +00:00
Devon Carew