b172a42881
[VM] Catch errors for integer operations in kernel2kernel constant evaluator
...
Issue https://github.com/dart-lang/sdk/issues/33481
Closes https://github.com/dart-lang/sdk/issues/33469
Change-Id: I7ca9825a0aa5f062732a759b4dd116e716a0d1b3
Reviewed-on: https://dart-review.googlesource.com/60580
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-06-19 10:28:05 +00:00
f288124d5a
Fix InvalidInlineFunctionType example
...
Change-Id: Id573fa1067a2448fd3bf573d63a7ad2fc3cec4ba
Reviewed-on: https://dart-review.googlesource.com/60100
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-06-19 10:03:43 +00:00
15821a28a3
Explicit type args in body_builder
...
Change-Id: I9f9324b9766a970877c312f429a7873ae2359329
Reviewed-on: https://dart-review.googlesource.com/60428
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-06-19 09:35:13 +00:00
1f6925718b
Add message for missing type arguments
...
This message is ignored by default and Fasta uses this internally
to help migrate to Dart 2 and type errors in analyzer integration
at compile-time.
Change-Id: Ie0def14f09eb387fdae0486cd7a4bbed2536c64d
Reviewed-on: https://dart-review.googlesource.com/60427
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2018-06-19 09:35:13 +00:00
532b9aaa93
Flatten *WorldBuilder hierarchies.
...
Change-Id: I59bfa08f151f2e238816a4da6163a39e6df2dc9c
Reviewed-on: https://dart-review.googlesource.com/60544
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2018-06-19 08:16:03 +00:00
f8caffd9e6
Remove some uses of Platform.packageRoot.
...
Change-Id: Ic01e7f7a9f5c677bcf3779ae2a9386345620793a
Reviewed-on: https://dart-review.googlesource.com/60443
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-06-19 05:12:13 +00:00
f2f6ebf547
Convert ShadowAssertInitializer to AssertInitializerJudgment.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I7cf5138eacb91761fcec99808a729ecc31f5399e
Reviewed-on: https://dart-review.googlesource.com/60826
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-19 02:52:59 +00:00
3e6e2dd7f4
Convert ShadowAssertStatement to AssertStatementJudgment.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I58be3e6a5fd448c2b00afb194bb566c7d6987733
Reviewed-on: https://dart-review.googlesource.com/60807
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-06-19 01:55:59 +00:00
27fefd7bb3
Convert ShadowAwaitExpression to AwaitExpressionJudgment.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I1b2bd381aa29a58eab8f7c4434dc5b6151970d15
Reviewed-on: https://dart-review.googlesource.com/60806
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-06-19 00:58:59 +00:00
dd1c54c442
Convert ShadowBoolLiteral to BoolLiteralJudgement
...
Change-Id: I2cdf2a345126c2cdd05e7c06ffa2ad41a22e5502
Reviewed-on: https://dart-review.googlesource.com/60805
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-06-19 00:54:09 +00:00
4a353fea35
Another attempt to fix tests on Windows
...
Change-Id: I7c1c12ec3b9244d52633bc46a115e1b9e51dc87b
Reviewed-on: https://dart-review.googlesource.com/60821
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-06-19 00:23:59 +00:00
b3b8ca6dc4
Remove the --package-default-analysis-options flag.
...
Change-Id: If36ee3478d8c95c38ff2cd5ed43f4dc3cdfe973e
Reviewed-on: https://dart-review.googlesource.com/60442
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2018-06-18 23:34:09 +00:00
aba94f051e
Convert ShadowAsExpression to AsJudgment.
...
Change-Id: I27cb2903a4d018a54e47ff433803789f45b9c24b
Reviewed-on: https://dart-review.googlesource.com/60800
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-18 22:44:32 +00:00
bc7220a4fd
[VM] Turn dart2 on by default on the command line VM
...
- make Dart2 the default option for the command line VM
- add option --no-preview-dart-2 as a fallback option to run dart1
- change test scripts to use the executable dart for testing dart2 mode instead of
pkg/vm/tool/dart2
- adjust numerous build and test configurations
Change-Id: Id813fa5b71a89c7ec9335d3f6e83cfc9f35f86e7
Reviewed-on: https://dart-review.googlesource.com/58240
Commit-Queue: Siva Annamalai <asiva@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2018-06-18 22:31:32 +00:00
cdd2553a12
[vm/kernel/bytecode] Fix null handling in operator ==
...
Change-Id: I2de516b98c2e49baa65c725e85a696850318ee36
Reviewed-on: https://dart-review.googlesource.com/60801
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2018-06-18 22:20:41 +00:00
b140baeb55
Own files by their URIs during search.
...
R=brianwilkerson@google.com
Change-Id: If17700a4d433701cb6cb2432f6be9c27dc6e6b92
Reviewed-on: https://dart-review.googlesource.com/60803
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-18 22:07:17 +00:00
56cee22800
Build out the initial version of the Factory class (and derived classes).
...
Still to be done: add the necessary arguments to plumb tokens and
subexpressions into the factory methods.
Change-Id: I99206aaca3430ad62726cb51fb818d9b820f4f96
Reviewed-on: https://dart-review.googlesource.com/60804
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-06-18 22:01:41 +00:00
83cb0c425d
Fix awaiting void in analyzer ast_test.dart. Fix at method decl.
...
Required to unblock #33415
Change-Id: I18306967737fc26136cc74c70f14cf33509e96f3
Reviewed-on: https://dart-review.googlesource.com/60706
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2018-06-18 21:32:46 +00:00
c9af309cbf
Fix fasta parsing of ?. in cascade expression
...
... and fix more Analyzer fasta parser tests
Change-Id: I42e6f25784dbc62bca620b1ab522c07350f53aff
Reviewed-on: https://dart-review.googlesource.com/60721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-06-18 21:25:41 +00:00
741ed336f1
Improve AstBuilder int literal recovery
...
... and fix more Analyzer fasta parser tests
Change-Id: Ic051369580311e0ee1be09210d34a6654d90c023
Reviewed-on: https://dart-review.googlesource.com/60720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-06-18 20:00:13 +00:00
e77158eb38
First steps toward generating analyzer/kernel ASTs during type inference.
...
This CL makes the following changes:
- Adds a Factory interface (currently empty), and threads that through
type inference logic. In later CLs, this will be used by the infer
methods to create ASTs as a side effect of type inference. The
interface is parameterized so that it can create either analyzer or
kernel ASTs.
- Adds a KernelFactory implementation, to be used when creating kernel
ASTs (also currently empty).
- Adds a ToplevelInferenceFactory implementation, to be used during
top level type inference (when no ASTs need to be created).
- Renames ShadowExpression, ShadowInitializer, and ShadowStatement to
ExpressionJudgment, InitializerJudgment, and StatementJudgment,
respectively. This reflects the fact that once we decouple the
"shadow" hierarchy from the kernel AST, each shadow node will
represent a type inference judgment. The derived classes will be
renamed in later CLs.
- Renames the methods _inferExpression, _inferInitializer, and
_inferStatement to infer.
- Adds an inferredType field to each class derived from
ExpressionJudgment. In later CLs, this will allow us to change the
infer methods so that they store the inferred type and return the
AST (currently they return the inferred type). For the moment, the
inferredType field is set by the common method
ShadowTypeInferrer.inferExpression.
Change-Id: Ibf7b7df2cc9754080c84b9ec5d1e2e2721569fa4
Reviewed-on: https://dart-review.googlesource.com/60620
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-06-18 19:29:52 +00:00
7d94755836
Issue 33471. Use full ResolveResult in Extract Local refactoring.
...
So, that we can give the file content to CorrectionUtils. Otherwise we
might attempt to use resolved unit for older version of the file
content, and re-read file content.
It does not fully solves the problem, because the client still might
get changes that corresponds to the older state of the file, or
files. We might want to consider un-deprecating fileStamp in
SourceFileEdit.
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/33471
Change-Id: I4877bc86a14033cc4c944cfaa0265db78b17de4c
Reviewed-on: https://dart-review.googlesource.com/60701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-18 18:22:01 +00:00
88d12fda42
Parse throw on RHS of an assignment
...
Change-Id: I4177dcee9eb2826474e43b43c6aa3820590e93d0
Reviewed-on: https://dart-review.googlesource.com/60600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2018-06-18 17:50:04 +00:00
1dcc3264e7
Fix tests that are failing on Windows
...
Change-Id: Id7182df3f08078f0e6c1959db94cf2da0bebd995
Reviewed-on: https://dart-review.googlesource.com/60680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-06-18 17:07:11 +00:00
691313f357
Move newOptionsFile() and newPackagesFile() into ResourceProviderMixin.
...
R=brianwilkerson@google.com
Change-Id: I903312db8e738c988a197fdd875cfd4ae5e4799d
Reviewed-on: https://dart-review.googlesource.com/60641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-18 16:50:31 +00:00
e62f563b2d
Validate sdkPath in AnalysisContextCollectionImpl.
...
R=brianwilkerson@google.com
Change-Id: Iaffd3dc66fbb4bb8c4e4aae5f036c28ba68b07d6
Reviewed-on: https://dart-review.googlesource.com/60640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-18 16:42:31 +00:00
493c421f0d
Add AnalysisContextCollection.
...
R=brianwilkerson@google.com
Change-Id: Id0c64648983129f5ecd46d784e978ce321ba2041
Reviewed-on: https://dart-review.googlesource.com/60404
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-18 15:53:36 +00:00
dfeaf79cef
Fix VM accepting too many overlarge hex numbers in int.parse.
...
Fixes #32858
BUG= http://dartbug.com/32858
Change-Id: I362e51ef0fb8b55a0ca1a7ed75a77a13c9d94893
Reviewed-on: https://dart-review.googlesource.com/60243
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2018-06-18 10:04:07 +00:00
c84a9f46b2
Recompute ClassHierarchy after adding noSuchMethod forwarding stubs
...
Change-Id: Idcd1ba9e43a917a526d0687be8e5b84a267042a2
Reviewed-on: https://dart-review.googlesource.com/60422
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-06-18 08:12:06 +00:00
b558a9c2f4
Handle missing compile-time errors
...
Closes #33468
Change-Id: I6da12012103ed465257335ce5bb81ba1fc54c81a
Reviewed-on: https://dart-review.googlesource.com/60500
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2018-06-18 07:34:46 +00:00
e22706793d
Treat objects with .call as "subtypes" of function types
...
There were a pair of TODOs in constraint gathering in type inference,
where objects with .call methods should be considered as if they were
subtypes of function types. Fix them.
This is a partial fix for
https://github.com/dart-lang/sdk/issues/33298 because it does not
yet handle the case of generic .call methods.
Bug: https://github.com/dart-lang/sdk/issues/33298
Change-Id: Ib9803db9a152cdc6f2108e717bb0934c38016a94
Reviewed-on: https://dart-review.googlesource.com/58206
Commit-Queue: Kevin Millikin <kmillikin@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2018-06-18 07:10:26 +00:00
de5f9ea95f
Add --use-fasta-parser flags to dartanalyzer and the analysis server.
...
Change-Id: Id7272c0d86806f2cbdfc982ee90923b018e08866
Reviewed-on: https://dart-review.googlesource.com/60453
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2018-06-16 13:21:24 +00:00
e2d903c4dc
Remove packages/ directory resolution from CFE
...
Change-Id: I560941d08965a58b8a88e1b49c4d7d216389609e
Reviewed-on: https://dart-review.googlesource.com/60062
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2018-06-15 22:47:20 +00:00
bc8d77231d
Improve flags documentation, reenable hints in dart2js.
...
Now that #32111 has been fixed, we can reenable hints in dart2js. Tested on a
large consumer app and there are no unncessary hints at this time.
Change-Id: Idfe39abb319a0a8d54b4439dc74b9315d2cc1b41
Reviewed-on: https://dart-review.googlesource.com/60445
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Emily Fortuna <efortuna@google.com >
2018-06-15 21:01:59 +00:00
209a602769
Tweak for fixes tests - use orElse to avoid exception.
...
R=brianwilkerson@google.com
Change-Id: Ieefb92172d4d338bffb16071ca648e70c261c5e6
Reviewed-on: https://dart-review.googlesource.com/60454
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-15 20:41:39 +00:00
0e4c158847
Issue 33458. Suggest 'Create Class' Quick Fix for creation without new.
...
When the identifier is not resolved in Test() it is impossible to
know whether is expected to be a function invocation or an instance
creation. Suggest both.
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/33458
Change-Id: I898fb85af33d4553b501a9fe3e59d792562d9053
Reviewed-on: https://dart-review.googlesource.com/60452
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-15 20:34:29 +00:00
44650cc9eb
Pass the location of vm_platform to compile_platform from the commandline.
...
This is to make it more transparent to use the same compile_platform template in
flutter/fushia builds.
Change-Id: I2a94c77bd2887cbc86f4547f7c8a0d54520a259b
Reviewed-on: https://dart-review.googlesource.com/60326
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-06-15 20:19:21 +00:00
2394097e44
Support for including/excluding the same path in ContextRoot.isAnalyzed().
...
R=brianwilkerson@google.com
Change-Id: Iab7deb1a0e4a541c3c0ee9fbd9518366e6e1a91e
Reviewed-on: https://dart-review.googlesource.com/60450
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-15 19:52:06 +00:00
f59389b688
Optimize .runtimeType impact based on usage
...
Change-Id: If6c24d4115241dcb8ac2ed82eee58c4025e3d8e2
Reviewed-on: https://dart-review.googlesource.com/59090
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-06-15 19:51:14 +00:00
ee1f7f5a93
Fix newly reported warnings
...
Change-Id: I7688b3777209ec3d36057d3e20d9fd49ec1324e4
Reviewed-on: https://dart-review.googlesource.com/60449
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-06-15 19:42:20 +00:00
afa8ff6292
Add a resource provider that supports file overlays
...
Change-Id: If09447d2bf50c69e007bf1953461ee16c46c7ab4
Reviewed-on: https://dart-review.googlesource.com/60406
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-06-15 19:28:29 +00:00
a63cf8e0cb
Add --no-preview-dart-2 flag.
...
Currently it is a noop, it will change once we update the default to 2.0
Change-Id: Id0f0b43d4742dddc25d2c9e4ddb77c55d397caaf
Reviewed-on: https://dart-review.googlesource.com/60440
Reviewed-by: Emily Fortuna <efortuna@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2018-06-15 18:25:10 +00:00
541dd195bb
Enable creating full kernel files in addition to outlines from the bazel worker for kernel.
...
Change-Id: I2dc5ef10046fd210a1a7cd7db44a22fc47654e17
Reviewed-on: https://dart-review.googlesource.com/58920
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2018-06-15 16:24:24 +00:00
8e9e8e1da0
Fix various bugs and regularize behavior of returns statements in
...
various kinds of functions.
Closes-bug: #31887
Closes-bug: #30638
Closes-bug: #32233
Closes-bug: #32881
Closes-bug: #31278
Change-Id: I4ebd7e71096d611e189b571ba5de2998dd11c98b
Reviewed-on: https://dart-review.googlesource.com/60300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Leaf Petersen <leafp@google.com >
2018-06-15 16:07:44 +00:00
b51d3d4146
Key string should be avoided
...
Change-Id: I0708ac8bd7aa8c6993bb329b212b400a6f55cae9
Reviewed-on: https://dart-review.googlesource.com/60424
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-06-15 10:03:24 +00:00
1e906c3f7e
Add no-op entry point for IncrementalCompiler
...
Change-Id: Ibe1fef376d1576554b85a2debcde2c3b19c21d92
Reviewed-on: https://dart-review.googlesource.com/60425
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-06-15 09:59:54 +00:00
aeeb7baa96
Change error message to not use imperative tone
...
Change-Id: I605bf097b80495dd627f0b25490d28fca8bc2e70
Reviewed-on: https://dart-review.googlesource.com/60423
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2018-06-15 09:49:44 +00:00
1a08341730
Analyzer status file update
...
Change-Id: Ie1e15259e856cab96dd57fbc51da23f0e3845714
Reviewed-on: https://dart-review.googlesource.com/60421
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2018-06-15 07:50:23 +00:00
ac039abc83
Add option to check if a dill is self-contained
...
This CL adds an option to the dill loader (i.e. BinaryBuilder) to
enable performing a check of all canonical names. The theory is,
that if a dill is self-contained "every" (1) canonical name should
contain a reference to a node.
This check is (currently) disabled by default, but enabled
excplicitly in the incremental compiler when initializing from dill.
If the check fails a warning will be issued (and the dill wont be
used).
On my machine the check seems to take ~15 ms in all tested cases
(sdk, flutter test).
(1): Except for extra layer of URI of a library if the qualified
name is private.
Closes #32449 .
Change-Id: I65c8fba647be3d5ba47f7ee16caef78cb2cfae07
Reviewed-on: https://dart-review.googlesource.com/51462
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2018-06-15 06:46:23 +00:00
d2a37231b3
optimize await in async* methods in dartdevc
...
Refactors async* implementation class to dart:async and ports it back to
Dart. Improves `await` to avoid zone registration at each await.
Change-Id: I15cac2a40bd56269c8ade1dc0810792c23459ef5
Reviewed-on: https://dart-review.googlesource.com/59260
Commit-Queue: Jenny Messerly <jmesserly@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2018-06-15 01:54:03 +00:00
Martin Kustermann