dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
86,948 Commits 2 Branches 0 Tags
bd2d261bc6a82ae2bece034d4aba2cbc4e14c178
Commit Graph

235 Commits

Author SHA1 Message Date
Danny Tuppeny 56f8caa9d4 Mark env as required on DartAttachRequestArguments 
Fixes a TODO.

+ some minor comment improvements.

Change-Id: I1f6249376e3891e0d20f01269493ffcc4d9aec55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253940
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-08-08 13:33:20 +00:00
Danny Tuppeny 09bcc1f4ae [dartdev] [dds] Share DevTools arg parsing with serve_local script 
Change-Id: Ia8f95b205fda1201a7ec50805a84d374a6201f39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253460
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-08-04 20:32:14 +00:00
Helin Shiah 884cfae2c7 Make changes for internal debug 
- Convert to google3:/// scheme and call `lookupPackageUris` for setting
  breakpoints
- Return file:/// scheme URIs from DDS

Change-Id: If9a541be21f5830ec68dc39eb2f308f7ce90c5fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252782
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Helin Shiah <helinx@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-07-28 18:30:10 +00:00
Danny Tuppeny 627481bae1 [dds] Bump to version 2.2.6 and add changelog entry 
Change-Id: Ie3f4710c80129f43f556f62b9b733e2e04e32850
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252361
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-07-27 17:18:13 +00:00
Danny Tuppeny 38dc6e7dc8 [dds] [dap] Ensure debug adapter shuts down on clean termination 
Change-Id: I1baa77dd933a49c1df435ccc31eb6cf8995e3ff3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252660
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-07-25 19:18:49 +00:00
Ahmed Ashour 99f0fb5b70 Fix typos 
Fixes #49364

TEST=ci

Change-Id: Ic643819c9cdd7b56690981b96b854b1e8d622fff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250160
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-12 19:35:22 +00:00
Ben Konyi cc92eb0a7f [ CLI ] Fix LateInitializationError in DartDev when passed an invalid flag 
`log` was previously initialized after argument parsing had already
taken place, which caused an exception when an invalid flag was passed
to DartDev as `log` was referenced in the `dart fix` command
description, which is accessed when building the usage message.

Also fixes a minor test failure related to usage line lengths not being
set correctly for `dart devtools`.

Fixes https://github.com/dart-lang/sdk/issues/49437

Fixed: 49437
Change-Id: Ib367677db5f34d7b6da31e51dbe717c954298ecf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251241
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-07-12 18:22:42 +00:00
Danny Tuppeny 2a440e14f1 [dds] Include exception text in DAP StoppedEvent text field 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4039.

Change-Id: Ibe362a3eaaea1ab9b6075501cb9a245d8daba737
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250745
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-07-07 13:15:01 +00:00
Helin Shiah 4ac76c7f35 Update devtools_shared version 
Change-Id: I2082552f00fc1117c76eb675605f0cb0cd26d270
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249548
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-06-23 17:15:29 +00:00
Danny Tuppeny eb6aa221f0 [dds] [dap] Fix bug that tried to remove previously-removed breakpoints 
Fixes https://github.com/flutter/flutter/issues/106369.

Change-Id: I17fb46ad0ea0f30707ff6280f2e8269662e376f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249485
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-06-23 13:42:55 +00:00
Ben Konyi c75f794913 [ DDS ] Prepare for 2.2.3 release 
Change-Id: I348fe14a1a49a912688dfc68394a993c079770a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249341
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-06-21 15:34:24 +00:00
Danny Tuppeny fe8dd70d47 [dds] Extract sending debugger URIs into a method that can be called by other adapters 
Flutter needs to send Debugger URIs to the client in some cases where we're not connected ourselves (profile mode, where the IDE wants a VM Service for DevTools, but is not debugging).

Change-Id: I901ca02be7c0bfff5130f2e41b83923b1d518e76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249300
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-06-21 14:48:34 +00:00
Danny Tuppeny 51eed0cffd [dds] Fix code generation for type references to simple types 
Fixes https://github.com/dart-lang/sdk/issues/49268.

Change-Id: Iaeda8271d8cb922511958a71cf1300ba64df16da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248605
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-06-17 18:26:09 +00:00
Ahmed Ashour 85700570f6 Fix typos 
Fixes #49241

TEST=ci

Change-Id: I6117bf816fc8c4613cce66927f952fef75632725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248120
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-15 11:08:28 +00:00
Helin Shiah 7f098b4cf5 Update vm service version for DDS 
Change-Id: Ie26f64d629c0d1a319f90e2d0eb3b22caa981c93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248360
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-06-14 16:37:57 +00:00
Danny Tuppeny 3056251f90 [dds] Handle methodNotFound errors for setLibraryDebuggable for DWDS 
DWDS doesn't currently support this so the unhandled error will terminate the DAP when running under Flutter web:

https://github.com/dart-lang/webdev/issues/606

Change-Id: I14f2dbffca66244268802924e347e2d70eec30a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248124
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-06-14 16:36:47 +00:00
Ben Konyi ff08af36ce [ package:dds ] Migrate devtools_observatory_connection_test to null safety 
Fixes https://github.com/dart-lang/sdk/issues/49177

Change-Id: I7221386b64ade709114e793b2665beca0a4c8115
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247440
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2022-06-07 14:49:09 +00:00
Helin Shiah d6665ae4cd Reland "[ Service / DDS ] Add method that can return local paths" 
This is a reland of commit a091ff7b27

TEST=Check that a supplied URL conversion function is correctly applied when the `local` param is true.

Original change's description:
> [ Service / DDS ] Add method that can return local paths
>
> TEST=Check that a supplied URL conversion function is correctly applied when the `local` param is true.
>
> Change-Id: Ibe80b6229c574c976379a519baca5d1904b684b2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245040
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
> Commit-Queue: Ben Konyi <bkonyi@google.com>

Change-Id: I87433a410715393f853a6538dbfe67391e0c773b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246621
Commit-Queue: Helin Shiah <helinx@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-06-01 21:22:34 +00:00
Devon Carew 62bb4b76d5 [pkg] normalize the headers of the pkg/ readmes 
Change-Id: Ida2006d0dd2bbb7d441f15e494fd8c929f15a765
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246680
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2022-05-31 21:00:13 +00:00
Devon Carew f7c46f145c [pkg] prefer 'any' deps for package dev dependencies 
Tested: CI validation
Change-Id: If65cc156130a65ffe00c6f1660ac320e2921afae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246053
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2022-05-27 01:34:59 +00:00
Helin Shiah a8e6756c74 Revert "[ Service / DDS ] Add method that can return local paths" 
This reverts commit a091ff7b27.

Reason for revert: Breaks DevTools and DWDS on internal roll

Original change's description:
> [ Service / DDS ] Add method that can return local paths
>
> TEST=Check that a supplied URL conversion function is correctly applied when the `local` param is true.
>
> Change-Id: Ibe80b6229c574c976379a519baca5d1904b684b2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245040
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
> Commit-Queue: Ben Konyi <bkonyi@google.com>

TBR=bkonyi@google.com,kenzieschmoll@google.com,helinx@google.com

Change-Id: I59d7687ba722fb1f5c706196691fc8471fe862ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246057
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-05-26 18:46:39 +00:00
Helin Shiah a091ff7b27 [ Service / DDS ] Add method that can return local paths 
TEST=Check that a supplied URL conversion function is correctly applied when the `local` param is true.

Change-Id: Ibe80b6229c574c976379a519baca5d1904b684b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245040
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-05-26 17:45:39 +00:00
Ahmed Ashour a6fcb56901 Fix typos 
Fixes #49094

TEST=ci

Change-Id: I23cdcb5ad2fc83e5e91d80e34b66af186c0cb923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245820
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Slava Egorov <vegorov@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
 2022-05-24 09:10:51 +00:00
Danny Tuppeny f6e025ed27 [dds] Unskip tests for checking devtools base href tags 
Change-Id: Ic31344a65b04cb252aa661b2f9af411b5a148bd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243903
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-05-09 13:28:23 +00:00
Danny Tuppeny 5ee800b366 [dds] Fix potential test flake if test runs just happen to straddle midnight at exactly this time 
Very unlikely, but happened in Flutter: https://github.com/flutter/flutter/issues/103215

Change-Id: Ic2acff02fcfe1f15b9ebbe371d6a9ec766ee9575
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243904
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2022-05-09 13:28:18 +00:00
Danny Tuppeny 5dafbb8889 [dds] Provide better error output for DAP protocol violations 
See https://github.com/flutter/flutter/issues/99734.

Change-Id: Idf23f745d0736db41a195fd5294b5f545c2a39a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240541
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-04-27 14:12:54 +00:00
Danny Tuppeny db0d9b1852 [dds] Serve DevTools index page for extension-less requests to support UrlPathStrategy 
Change-Id: I780e16b391dda6159c99b4844f6663dad02a98af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239082
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-04-25 14:12:13 +00:00
Devon Carew f46b40f01b Update the sdk lower bounds for analyzer, dds. 
Change-Id: Ia7814d39ecdc87bf0c445c63e100b154703cd0a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-04-20 00:10:27 +00:00
Devon Carew 2a20d4be24 [pkg] ensure each publishable package has a repository pubspec field 
Change-Id: I06c0d10c87c3f329098352a7abe9ef9fa0b1532e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241504
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-04-19 22:13:51 +00:00
Devon Carew 169365f953 Move pkg/dds to package:lints. 
Change-Id: I614a826569fee248b72f973a863e758949c04932
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241146
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-04-14 22:44:33 +00:00
Ben Konyi 2aed3ea034 [ DDS ] Add R/W-like locking around streamListen and streamCancel 
Reduces latency for concurrent stream subscriptions while no
subscription cancellations are pending.

TEST=Existing regression tests

Fixes https://github.com/dart-lang/sdk/issues/47042

Change-Id: I548bc5d1f30fddcf03af397a2c2b3ed8beeb09f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239862
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-04-04 23:16:42 +00:00
Ben Konyi 1771c55238 [ DDS ] Split DevTools server tests into smaller pieces 
Should resolve timeout issues, particularly around server connection
tests

Change-Id: Ic06d1179b09a17497e38de9aa19549f66ff79d2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240180
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
 2022-04-04 22:07:21 +00:00
Kenzie Schmoll 2e895ad146 Remove duplicated devtools_shared code from dds. 
Fixes https://github.com/flutter/devtools/issues/3571.

Change-Id: I168b44ef0e59a16695ce824499dff774ba46f3d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239800
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
 2022-04-01 16:22:36 +00:00
Ben Konyi d087f0334d [ DDS ] Fix devtools_server tests on Windows 
Fixes https://github.com/dart-lang/sdk/issues/48528

Change-Id: Iaa08d6ee409354eadc37d3beb98ea79b75575758
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239464
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-30 20:45:20 +00:00
Danny Tuppeny 8e90d6ac15 [dds] Fix deserialisation of env vars in DAP 
Change-Id: Ia3da6d4abdfd41b4b4f6631fd82d8680ee1727b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239309
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-29 18:39:29 +00:00
Ben Konyi 0950d887be [ package:dds ] Fix devtools_server_test flakiness 
The test harness wasn't waiting on `CliAppFixture.onAppStarted` which
could cause an unhandled exception if the test cleanup started before
the target application finished initializing. This typically only
occurred while the test was running on a machine under load.

Fixes https://github.com/dart-lang/sdk/issues/48669

TEST=Locally while running under load (e.g., `stress -c 72`)

Change-Id: Ieb67e46f62c33101490899440574fb57fc0f8882
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238922
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-25 18:40:30 +00:00
Elliott Brooks 9f4d5b6e4a Set the cache-control header's max-age value to 0s for DevTools. 
This ensures that the `index.html` file (which determines whether to
load the new service worker and therefore invalidate the cache) will
always be fresh.

Bug: https://github.com/flutter/devtools/issues/3896
Change-Id: Ib0b6adda66b7dd926f57724f21c2a7c6284bce60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237842
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Elliott Brooks <elliottbrooks@google.com>
 2022-03-18 22:46:02 +00:00
Ben Konyi b036052077 Reland "[ Service ] Update VM service message to not reference Observatory" 
This reverts commit ee5837aa7a.

Updated Intellij plugins have been published which support the new
message.

TEST=CQ

Change-Id: I81f6d878f036991a95cc1f58d3102015e77aa609
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237741
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-17 23:15:57 +00:00
Danny Tuppeny 02d9c3e6a5 [dds] Improve suppression of auto-resuming threads when attaching to processes 
Hopefully fixes https://github.com/dart-lang/sdk/issues/48274.

Change-Id: I893a1f5dee54410986644a52b7c2bb406d4e51f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237683
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-17 19:07:36 +00:00
Ben Konyi 8c484d12fe Reland "[ Service / DDS ] Remove VM service polling logic, add --enable-service-fallback-port support to DDS" 
This reverts commit d4f71515c7.

TEST=CQ

Change-Id: I180f9d045870a1ff5f7f3f82b6f4782e18c18cfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237440
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-15 18:14:42 +00:00
Emmanuel Pellereau d4f71515c7 Revert "[ Service / DDS ] Remove VM service polling logic, add --enable-service-fallback-port support to DDS" 
This reverts commit bd8590ba9b.

Reason for revert: breaks google3 (b/224731131)

TEST=Clean revert

Original change's description:
> [ Service / DDS ] Remove VM service polling logic, add --enable-service-fallback-port support to DDS
>
> Polling logic was introduced due to a bug in Fuchsia's network stack
> which could result in the VM service attempting to start the server
> before the network stack was initialized. This issue should be resolved
> now, so this logic is no longer necessary.
>
> TEST=pkg/dartdev/test/commands/run_test.dart
>
> Change-Id: I10f185dfb1be1b0363983f3e0564d65c38c99ea8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235763
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
> Commit-Queue: Ben Konyi <bkonyi@google.com>

TBR=bkonyi@google.com,rmacnak@google.com,asiva@google.com

Change-Id: I3016fad25220c4e5479f17294626d79a17bd316a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237360
Reviewed-by: Alexander Thomas <athom@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Emmanuel Pellereau <emmanuelp@google.com>
Commit-Queue: Emmanuel Pellereau <emmanuelp@google.com>
 2022-03-15 12:01:30 +00:00
Ben Konyi bd8590ba9b [ Service / DDS ] Remove VM service polling logic, add --enable-service-fallback-port support to DDS 
Polling logic was introduced due to a bug in Fuchsia's network stack
which could result in the VM service attempting to start the server
before the network stack was initialized. This issue should be resolved
now, so this logic is no longer necessary.

TEST=pkg/dartdev/test/commands/run_test.dart

Change-Id: I10f185dfb1be1b0363983f3e0564d65c38c99ea8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235763
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-14 21:44:29 +00:00
Kenzie Schmoll 3f623c65b0 Split DevTools server tests up into two libraries 
Change-Id: Ic394faee18547f3338fb36419defa45c6734d90c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236301
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-03-14 17:51:28 +00:00
Kenzie Schmoll 167970dea7 Reland "Add DevTools Server test and test driver to DDS" 
This reverts commit d0dff0e9ba.

Reason for revert: fixed broken tests to reland.

Original change's description:
> Revert "Add DevTools Server test and test driver to DDS"
>
> This reverts commit 02bff5bde2.
>
> Reason for revert: broken tests. (e.g. https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-mac-release/20638/overview)
>
> Original change's description:
> > Add DevTools Server test and test driver to DDS
> >
> > Bug: https://github.com/dart-lang/sdk/issues/48300
> > Change-Id: I3b72274d111489448a482d65eb7cc23a9f263edf
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233320
> > Reviewed-by: Ben Konyi <bkonyi@google.com>
> > Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
>
> TBR=bkonyi@google.com,kenzieschmoll@google.com
>
> Change-Id: Iaca6b34a4e55ddd7b984b49821f3cc95337d696a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: https://github.com/dart-lang/sdk/issues/48300
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234114
> Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
> Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://github.com/dart-lang/sdk/issues/48300
Change-Id: I60ffd0e8a394353014408530d636c5918e517a59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234861
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
 2022-03-09 16:48:54 +00:00
Ben Konyi ee5837aa7a Revert "[ Service ] Update VM service message to not reference Observatory" 
This reverts commit f9147d933e.

TEST=N/A

Change-Id: Idef34b70f1066ddf79d02588dfba7caeec443e7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234325
Reviewed-by: Dan Field <dnfield@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2022-02-24 18:32:14 +00:00
Kenzie Davisson d0dff0e9ba Revert "Add DevTools Server test and test driver to DDS" 
This reverts commit 02bff5bde2.

Reason for revert: broken tests. (e.g. https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-mac-release/20638/overview)

Original change's description:
> Add DevTools Server test and test driver to DDS
>
> Bug: https://github.com/dart-lang/sdk/issues/48300
> Change-Id: I3b72274d111489448a482d65eb7cc23a9f263edf
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233320
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>

TBR=bkonyi@google.com,kenzieschmoll@google.com

Change-Id: Iaca6b34a4e55ddd7b984b49821f3cc95337d696a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/48300
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234114
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
 2022-02-23 23:46:44 +00:00
Kenzie Schmoll 02bff5bde2 Add DevTools Server test and test driver to DDS 
Bug: https://github.com/dart-lang/sdk/issues/48300
Change-Id: I3b72274d111489448a482d65eb7cc23a9f263edf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233320
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
 2022-02-23 21:09:04 +00:00
Ben Konyi f9147d933e [ Service ] Update VM service message to not reference Observatory 
See https://github.com/dart-lang/sdk/issues/46756

TEST=Existing

Change-Id: Ib71bf00d667369d7438a4547ae444951ec0979df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233504
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-02-18 20:53:52 +00:00
Alexander Thomas 30beab0f43 [infra] Add OWNERS to the Dart SDK 
* Add team "groups" in tools/OWNERS_<group name>.
* Add top-level OWNERS as a fallback.
* Add OWNERS for all top-level directories.
* Add OWNERS to all packages.

For additional background information see go/dart-sdk-owners.

TEST=No op until code-owners is enabled.
Bug: b/200915407
Change-Id: I7fe6116cc599c749cd50ca16151d6d6a801d99d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229147
Reviewed-by: Jonas Termansen <sortie@google.com>
 2022-02-14 14:06:34 +00:00
Elliott Brooks a6c96a4707 Allow Dart DevTools to be embedded in Chrome DevTools. 
Change-Id: Iff97f9dbc432ed926d668ac8339c32b679e316ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232482
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
 2022-02-10 23:52:41 +00:00