dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[pkg] prefer 'any' deps for package dev dependencies

Browse Source 
Tested: CI validation
Change-Id: If65cc156130a65ffe00c6f1660ac320e2921afae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246053
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
This commit is contained in:
Devon Carew
2022-05-27 01:34:59 +00:00
committed by Commit Bot
parent fe91c0197a
commit f7c46f145c
44 changed files with 159 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/_fe_analyzer_shared/pubspec.yaml
+5 -1
View File
@@ -9,5 +9,9 @@ environment:
dependencies:
meta: ^1.0.2
# We use 'any' version constraints here as we get our package versions from
# the dart-lang/sdk repo's DEPS file. Note that this is a special case; the
# best practice for packages is to specify their compatible version ranges.
# See also https://dart.dev/tools/pub/dependencies.
dev_dependencies:
test: ^1.3.4
test: any
pkg/_js_interop_checks/pubspec.yaml
+1
View File
@@ -5,6 +5,7 @@ publish_to: none
environment:
sdk: '>=2.12.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
_fe_analyzer_shared: any
kernel: any
pkg/analysis_server/pubspec.yaml
+2
View File
@@ -5,6 +5,7 @@ publish_to: none
environment:
sdk: '>=2.17.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
_fe_analyzer_shared: any
analyzer: any
@@ -25,6 +26,7 @@ dependencies:
watcher: any
yaml: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
analyzer_utilities: any
cli_util: any
pkg/analysis_server_client/pubspec.yaml
+8 -7
View File
@@ -13,11 +13,12 @@ dependencies:
path: ^1.8.0
pub_semver: ^2.0.0
# We use 'any' version constraints here as we get our package versions from
# the dart-lang/sdk repo's DEPS file. Note that this is a special case; the
# best practice for packages is to specify their compatible version ranges.
# See also https://dart.dev/tools/pub/dependencies.
dev_dependencies:
analyzer:
path: ../analyzer
analysis_server:
path: ../analysis_server
analyzer_utilities:
path: ../analyzer_utilities
test: ^1.14.2
analyzer: any
analysis_server: any
analyzer_utilities: any
test: any
pkg/analyzer/pubspec.yaml
+12 -9
View File
@@ -20,13 +20,16 @@ dependencies:
watcher: ^1.0.0
yaml: ^3.0.0
# We use 'any' version constraints here as we get our package versions from
# the dart-lang/sdk repo's DEPS file. Note that this is a special case; the
# best practice for packages is to specify their compatible version ranges.
# See also https://dart.dev/tools/pub/dependencies.
dev_dependencies:
analyzer_utilities:
path: ../analyzer_utilities
args: ^2.0.0
async: ^2.5.0
linter: ^1.12.0
lints: ^2.0.0
matcher: ^0.12.10
test: ^1.16.0
test_reflective_loader: ^0.2.0
analyzer_utilities: any
args: any
async: any
linter: any
lints: any
matcher: any
test: any
test_reflective_loader: any
pkg/analyzer_cli/pubspec.yaml
+2
View File
@@ -7,6 +7,7 @@ publish_to: none
environment:
sdk: "^2.14.0"
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
analyzer: any
args: any
@@ -16,6 +17,7 @@ dependencies:
pub_semver: any
yaml: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
lints: any
test_reflective_loader: any
pkg/analyzer_plugin/pubspec.yaml
+9 -6
View File
@@ -13,10 +13,13 @@ dependencies:
pub_semver: ^2.0.0
yaml: ^3.1.0
# We use 'any' version constraints here as we get our package versions from
# the dart-lang/sdk repo's DEPS file. Note that this is a special case; the
# best practice for packages is to specify their compatible version ranges.
# See also https://dart.dev/tools/pub/dependencies.
dev_dependencies:
analyzer_utilities:
path: ../analyzer_utilities
html: ^0.15.0
path: ^1.8.0
test_reflective_loader: ^0.2.0
test: ^1.16.6
analyzer_utilities: any
html: any
path: any
test_reflective_loader: any
test: any
pkg/analyzer_utilities/pubspec.yaml
+2
View File
@@ -5,6 +5,7 @@ publish_to: none
environment:
sdk: '>=2.12.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
analyzer: any
html: any
@@ -12,5 +13,6 @@ dependencies:
path: any
test: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
lints: any
pkg/async_helper/pubspec.yaml
+5 -5
View File
@@ -3,14 +3,14 @@ name: async_helper
publish_to: none
description: >-
Async_helper is used for asynchronous tests that do not want to
make use of the Dart unittest library - for example, the core
language tests.
Third parties are discouraged from using this, and should use
the facilities provided in package:test.
Async_helper is used for asynchronous tests that do not want to make use of
the Dart unittest library - for example, the core language tests. Third
parties are discouraged from using this, and should use the facilities
provided in package:test.
environment:
sdk: '>=2.12.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
expect: any
pkg/build_integration/pubspec.yaml
+2
View File
@@ -8,8 +8,10 @@ publish_to: none
environment:
sdk: '>=2.12.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
front_end: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
test: any
pkg/compiler/pubspec.yaml
+2 -2
View File
@@ -6,8 +6,7 @@ publish_to: none
environment:
sdk: '>=2.16.0 <3.0.0'
# NOTE: `pub get / pub upgrade` are generally not needed when working on this
# package. The `.packages` file in the repository root will be used by default.
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
_fe_analyzer_shared: any
_js_interop_checks: any
@@ -21,6 +20,7 @@ dependencies:
kernel: any
vm_service: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
args: any
dart_style: any
pkg/dart2js_info/pubspec.yaml
+2
View File
@@ -8,6 +8,7 @@ description: >-
environment:
sdk: '>=2.16.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
args: any
collection: any
@@ -17,6 +18,7 @@ dependencies:
shelf: any
yaml: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
lints: any
test: any
pkg/dart2js_runtime_metrics/pubspec.yaml
+1
View File
@@ -11,5 +11,6 @@ environment:
# a later version of the SDK without it being a breaking change.
sdk: ">=2.14.0 <2.15.0"
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
expect: any
pkg/dart2js_tools/pubspec.yaml
+1
View File
@@ -8,6 +8,7 @@ description: >
environment:
sdk: '>=2.12.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
path: any
source_maps: any
pkg/dart2native/pubspec.yaml
+2
View File
@@ -9,8 +9,10 @@ environment:
executables:
dart2native:
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
path: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
lints: any
pkg/dart2wasm/pubspec.yaml
+1
View File
@@ -4,6 +4,7 @@ publish_to: none
environment:
sdk: '>=2.12.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
_js_interop_checks: any
front_end: any
pkg/dartdev/pubspec.yaml
+2
View File
@@ -6,6 +6,7 @@ publish_to: none
environment:
sdk: '>=2.12.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
analysis_server: any
analysis_server_client: any
@@ -25,6 +26,7 @@ dependencies:
telemetry: any
usage: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
expect: any
lints: any
pkg/dds/pubspec.yaml
+9 -5
View File
@@ -19,18 +19,22 @@ dependencies:
json_rpc_2: ^3.0.0
meta: ^1.1.8
path: ^1.8.0
shelf: ^1.0.0
shelf_proxy: ^1.0.0
shelf_static: ^1.0.0
shelf_web_socket: ^1.0.0
stack_trace: ^1.10.0
shelf: ^1.0.0
sse: ^4.0.0
stack_trace: ^1.10.0
stream_channel: ^2.0.0
vm_service: ^8.1.0
web_socket_channel: ^2.0.0
# We use 'any' version constraints here as we get our package versions from
# the dart-lang/sdk repo's DEPS file. Note that this is a special case; the
# best practice for packages is to specify their compatible version ranges.
# See also https://dart.dev/tools/pub/dependencies.
dev_dependencies:
http: ^0.13.0
http: any
lints: any
test: ^1.0.0
webdriver: ^3.0.0
test: any
webdriver: any
pkg/dds_service_extensions/pubspec.yaml
+4
View File
@@ -12,5 +12,9 @@ dependencies:
async: ^2.4.1
vm_service: ^8.1.0
# We use 'any' version constraints here as we get our package versions from
# the dart-lang/sdk repo's DEPS file. Note that this is a special case; the
# best practice for packages is to specify their compatible version ranges.
# See also https://dart.dev/tools/pub/dependencies.
dev_dependencies:
lints: any
pkg/dev_compiler/pubspec.yaml
+2
View File
@@ -5,6 +5,7 @@ publish_to: none
environment:
sdk: '>=2.15.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
_fe_analyzer_shared: any
_js_interop_checks: any
@@ -21,6 +22,7 @@ dependencies:
source_maps: any
source_span: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
browser_launcher: any
expect: any
pkg/expect/pubspec.yaml
+1
View File
@@ -11,6 +11,7 @@ description: >-
environment:
sdk: '>=2.12.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
meta: any
smith: any
pkg/front_end/pubspec.yaml
+5 -3
View File
@@ -8,27 +8,29 @@ publish_to: none
environment:
sdk: '>=2.13.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
_fe_analyzer_shared: any
kernel: any
package_config: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
analyzer: any
args: any
async_helper: any
build_integration: any
compiler: any
dart2wasm: any
dart_style: any
dart2wasm: any
dev_compiler: any
expect: any
json_rpc_2: any
path: any
test: any
test_reflective_loader: any
test: any
testing: any
vm: any
vm_service: any
vm: any
web_socket_channel: any
yaml: any
pkg/frontend_server/pubspec.yaml
+2
View File
@@ -6,6 +6,7 @@ publish_to: none
environment:
sdk: "^2.15.0"
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
_fe_analyzer_shared: any
args: any
@@ -19,6 +20,7 @@ dependencies:
usage: any
vm: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
mockito: any
test: any
pkg/js/pubspec.yaml
+4
View File
@@ -9,5 +9,9 @@ environment:
dependencies:
meta: ^1.7.0
# We use 'any' version constraints here as we get our package versions from
# the dart-lang/sdk repo's DEPS file. Note that this is a special case; the
# best practice for packages is to specify their compatible version ranges.
# See also https://dart.dev/tools/pub/dependencies.
dev_dependencies:
lints: any
pkg/js_ast/pubspec.yaml
+1
View File
@@ -5,6 +5,7 @@ publish_to: none
environment:
sdk: '>=2.16.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
expect: any
lints: any
pkg/js_runtime/pubspec.yaml
+2 -1
View File
@@ -5,6 +5,7 @@ publish_to: none
environment:
sdk: '>=2.12.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
expect: any
_fe_analyzer_shared: any
expect: any
pkg/js_shared/pubspec.yaml
+2 -1
View File
@@ -5,6 +5,7 @@ publish_to: none
environment:
sdk: '>=2.12.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
expect: any
_fe_analyzer_shared: any
expect: any
pkg/kernel/pubspec.yaml
+1
View File
@@ -8,6 +8,7 @@ publish_to: none
environment:
sdk: '>=2.12.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
args: any
expect: any
pkg/language_versioning_2.7_test/pubspec.yaml
-1
View File
@@ -11,4 +11,3 @@ publish_to: none
environment:
sdk: '>=2.7.0 <3.0.0'
pkg/modular_test/pubspec.yaml
+5 -3
View File
@@ -2,18 +2,20 @@ name: modular_test
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
description: >
Small framework to test modular pipelines.
This is used within the Dart SDK to define and validate modular tests, and to
execute them using the modular pipeline of different SDK tools.
Small framework to test modular pipelines. This is used within the Dart SDK to
define and validate modular tests, and to execute them using the modular
pipeline of different SDK tools.
environment:
sdk: '>=2.16.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
args: any
package_config: any
yaml: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
async_helper: any
expect: any
pkg/native_stack_traces/pubspec.yaml
+4
View File
@@ -13,5 +13,9 @@ dependencies:
args: ^2.0.0
path: ^1.8.0
# We use 'any' version constraints here as we get our package versions from
# the dart-lang/sdk repo's DEPS file. Note that this is a special case; the
# best practice for packages is to specify their compatible version ranges.
# See also https://dart.dev/tools/pub/dependencies.
dev_dependencies:
lints: any
pkg/nnbd_migration/pubspec.yaml
+4 -2
View File
@@ -6,10 +6,11 @@ publish_to: none
environment:
sdk: '>=2.14.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
_fe_analyzer_shared: any
analyzer: any
analyzer_plugin: any
analyzer: any
args: any
cli_util: any
collection: any
@@ -20,9 +21,10 @@ dependencies:
source_span: any
yaml: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
analyzer_utilities: any
http: any
lints: any
test: any
test_reflective_loader: any
test: any
pkg/scrape/pubspec.yaml
+3 -1
View File
@@ -6,10 +6,12 @@ publish_to: none
environment:
sdk: ^2.13.0
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
args: any
analyzer: any
args: any
path: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
lints: any
pkg/smith/pubspec.yaml
+4 -1
View File
@@ -2,7 +2,10 @@ name: smith
description: Shared code for working with the Dart SDK's tests and test runner.
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
environment:
sdk: "^2.12.0"
sdk: '^2.12.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
expect: any
pkg/sourcemap_testing/pubspec.yaml
+2
View File
@@ -6,6 +6,7 @@ publish_to: none
environment:
sdk: '>=2.16.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
_fe_analyzer_shared: any
collection: any
@@ -15,5 +16,6 @@ dependencies:
source_maps: any
source_span: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
lints: any
pkg/status_file/pubspec.yaml
+3 -1
View File
@@ -5,9 +5,11 @@ publish_to: none
environment:
sdk: "^2.12.0"
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
path: any
args: any
path: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
expect: any
pkg/telemetry/pubspec.yaml
+2
View File
@@ -6,6 +6,7 @@ publish_to: none
environment:
sdk: '>=2.12.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
http: any
meta: any
@@ -13,5 +14,6 @@ dependencies:
stack_trace: any
usage: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
test: any
pkg/test_runner/pubspec.yaml
+3
View File
@@ -5,9 +5,11 @@
name: test_runner
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
environment:
sdk: "^2.9.0"
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
args: any
dart2js_tools: any
@@ -18,6 +20,7 @@ dependencies:
status_file: any
webdriver: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
analyzer: any
expect: any
pkg/vm/pubspec.yaml
+2
View File
@@ -6,6 +6,7 @@ publish_to: none
environment:
sdk: '>=2.15.0 <3.0.0'
# Use 'any' constraints here; we get our versions from the DEPS file.
dependencies:
args: any
build_integration: any
@@ -15,6 +16,7 @@ dependencies:
kernel: any
package_config: any
# Use 'any' constraints here; we get our versions from the DEPS file.
dev_dependencies:
expect: any
json_rpc_2: any
pkg/vm_service/pubspec.yaml
+5 -1
View File
@@ -11,6 +11,10 @@ environment:
dependencies:
# We use 'any' version constraints here as we get our package versions from
# the dart-lang/sdk repo's DEPS file. Note that this is a special case; the
# best practice for packages is to specify their compatible version ranges.
# See also https://dart.dev/tools/pub/dependencies.
dev_dependencies:
async: any
expect: any
@@ -19,5 +23,5 @@ dev_dependencies:
mockito: any
path: any
pub_semver: any
test: any
test_package: any
test: any
pkg/vm_snapshot_analysis/pubspec.yaml
+5 -1
View File
@@ -14,6 +14,10 @@ dependencies:
collection: ^1.15.0
path: ^1.8.0
# We use 'any' version constraints here as we get our package versions from
# the dart-lang/sdk repo's DEPS file. Note that this is a special case; the
# best practice for packages is to specify their compatible version ranges.
# See also https://dart.dev/tools/pub/dependencies.
dev_dependencies:
lints: any
test: ^1.16.8
test: any
pkg/wasm_builder/pubspec.yaml
-2
View File
@@ -5,5 +5,3 @@ description: Generate binary Wasm modules
environment:
sdk: '>=2.12.0'
dependencies:
tools/package_deps/bin/package_deps.dart
+25 -38
View File
@@ -251,41 +251,39 @@ class Package implements Comparable<Package> {
fail = true;
}
// Validate that we don't have relative deps into third_party.
// TODO(devoncarew): This is currently just enforced for publishable
// packages.
if (publishable) {
for (PubDep dep in [..._declaredPubDeps, ..._declaredDevPubDeps]) {
if (dep is PathPubDep) {
var path = dep.path;
if (path.contains('third_party/pkg_tested/') ||
path.contains('third_party/pkg/')) {
out(' Prefer a semver dependency for packages brought in via DEPS:');
out(' $dep');
fail = true;
}
}
}
}
// Validate that published packages don't use path deps.
if (publishable) {
// Validate that deps for published packages use semver (but not any).
for (PubDep dep in _declaredPubDeps) {
if (dep is PathPubDep) {
out(' Published packages should use semver deps:');
out(' $dep');
fail = true;
}
if (dep is SemverPubDep) continue;
out(' Published packages should use semver deps:');
out(' $dep');
fail = true;
}
// Validate that dev deps for published packages use an 'any' constraint.
for (PubDep dep in _declaredDevPubDeps) {
if (dep is AnyPubDep) continue;
out(' Prefer an `any` constraint for dev dependencies');
out(' $dep');
fail = true;
}
} else {
// Validate that non-publishable packages use an 'any' constraint.
for (PubDep dep in [..._declaredPubDeps, ..._declaredDevPubDeps]) {
if (dep is AnyPubDep) continue;
out(' Prefer an `any` constraint for unpublished packages');
out(' $dep');
fail = true;
}
}
// Validate that the version of any package dep'd in works with our declared
// version ranges.
for (PubDep dep in [..._declaredPubDeps, ..._declaredDevPubDeps]) {
if (dep is! SemverPubDep) {
continue;
}
if (dep is! SemverPubDep) continue;
ResolvedDep? resolvedDep = sdkDeps.resolve(dep.name);
if (resolvedDep == null) {
@@ -322,17 +320,6 @@ class Package implements Comparable<Package> {
}
}
// Validate that non-published packages use relative a (relative) path dep
// for pkg/ packages.
if (!publishable) {
for (PubDep dep in [..._declaredPubDeps, ..._declaredDevPubDeps]) {
if (dep is AnyPubDep) continue;
out(' Prefer `any` dependencies for unpublished packages');
out(' $dep');
fail = true;
}
}
if (!fail) {
print(' No issues.');
}
tools/verify_docs/README.md
-1
View File
@@ -123,4 +123,3 @@ For example:
// final BuildContext context;
// final String userAvatarUrl;
```