dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

64479 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Nicholas Shahan 9df061524f [tests] Update expected error NoSuchMethodError --> Error 
Most (all?) implementations now throw ArgumentError since the
StreamIterator constructor no longer accepts null but the actual
type is not specified.
https://dart-review.googlesource.com/c/sdk/+/98001.

Change-Id: I10a24a67aa7353552c56d435ef206a2bc4f842fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100987
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-05-02 19:26:55 +00:00
Liam Appelbe 6819a4db02 test_matrix.json changes for ABI tests 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: I7e9b5dcaf0d13c1e5b7b3354f5398b48d8cfc484
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99374
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-05-02 19:16:15 +00:00
Zichang Guo 482c36d9ae [vm/debugger] Remove script soucre look up in debugger 
When resolving column breakpoint, debugger will lookup the character in the source of script to make sure the column has been specified within the range of a valid identifier.
With this CL, column breakpoint will be resolved previous safepoint position, if requested column falls within [saftpoint, next_safepoint/end of line(smaller one)]. For example, setting column breakpoint on left bracket of a function call might be resolved to function call now. Setting on the end of line will resolved to previous safepoint.

BUG: https://github.com/dart-lang/sdk/issues/36642
Change-Id: I16427772fde4c653da7629e3340282ef1d9046eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100404
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
 2019-05-02 18:43:55 +00:00
Aart Bik 98f67ff3d4 [dart/fuzzer] Mechanism for target functions 
Rationale:
Runtime dispatch on various target functions.
Also adds new target function (which found an
issue) and prepares Dart VM setup.

https://github.com/dart-lang/sdk/issues/36818

Change-Id: I80e2d567087b435404331e2539f2cda19cadb04e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100989
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2019-05-02 18:12:19 +00:00
Brian Wilkerson 3646be6fb5 Add a previously missed test and cleanup test names 
Change-Id: I441c0ce4e636480c3e544a292a3620cbb4a745d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-02 18:00:59 +00:00
Brian Wilkerson 36b2520ca9 Add a test of creating a subtype of Never 
Change-Id: I9d28868667667cca5eb122e33226b21850b062bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101067
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-02 17:53:59 +00:00
Ben Konyi ded5c3efd5 [ VM / Service ] Fixed HTTP requests with params not working correctly when auth codes are enabled 
Change-Id: Ia6dbab2c8e46cdd1fce659f55ee16f3ad98e5d6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101021
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-05-02 17:38:49 +00:00
Konstantin Shcheglov 946c38d881 Build local elements for variable initializers. 
R=brianwilkerson@google.com

Change-Id: Ice81c47a812ec2421cb6516b6fbec340ed239d22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-02 17:20:11 +00:00
Brian Wilkerson 5bac4d9b0c Reland "Add support for recording context information with analysis errors, with one example" 
This reverts commit b9bf239c65.

Reason for revert: The angular and angular plugins have been updated so as to make this safe.

Original change's description:
> Revert "Add support for recording context information with analysis errors, with one example"
> 
> This reverts commit 6114435ea5.
> 
> Reason for revert: Broke angular and angular_analyzer_plugin
> 
> Original change's description:
> > Add support for recording context information with analysis errors, with one example
> > 
> > Change-Id: Iba1c48163ce264d85a68bcb9f70e5025a7cdbfbb
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100563
> > Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> > Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
> 
> TBR=scheglov@google.com,brianwilkerson@google.com
> 
> Change-Id: I275c6e4473de73199ea9b5e490379ba58aec1d43
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100628
> Reviewed-by: Paul Berry <paulberry@google.com>
> Commit-Queue: Paul Berry <paulberry@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ib1b7e63a459e63bcbf02f26bcf167ddad45295b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101004
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-02 17:07:03 +00:00
Konstantin Shcheglov 158a52ee3f Change the message for FLUTTER_REMOVE_WIDGET. 
R=brianwilkerson@google.com

Bug: https://github.com/Dart-Code/Dart-Code/issues/1647
Change-Id: I6061e3432c267dad550e57789aea522cc8fb2d87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101006
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-05-02 17:00:53 +00:00
Brian Wilkerson 40a06c3a77 Implement the type Never 
Change-Id: Icbf407bc19f602c8382946b1e735905cc165c59c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100993
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-05-02 16:31:23 +00:00
Paul Berry 4fd9312586 Convert session.dart to triple-slash comment style 
Change-Id: Idb5120b19ed6737b7c41b97327876113f11829d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101065
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-02 16:31:03 +00:00
Konstantin Shcheglov af4bc38490 Fix for building named function types. 
R=brianwilkerson@google.com

Change-Id: Idc0b192579db4189b0335b44d2468f87701b43fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101005
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-02 16:19:30 +00:00
Konstantin Shcheglov 6ac709a2d0 Infer mixin type arguments. 
R=brianwilkerson@google.com

Change-Id: I089bd79c52fc345d1e51045221d02c2342dca0d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101064
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-05-02 14:29:51 +00:00
Johnni Winther 1577b95c93 [CFE] Substitute types in unevaluated as-expressions and instantiations 
As expressions and instantiations lose the connection to the current type environment when put into an unevaluated constant expression. This leaves type variables unsubstituted when the expressions are lazily evaluated leading to invalid compile-time errors. This is avoided by substituting the type variable when creating the unevaluated constant. If the type variables are not substituted by concrete types, this is flagged as a valid compile-time error during the lazy evaluation.

Change-Id: I46264da4332ea1d5b783531d89a5e6f85b8f90e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100963
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-05-02 13:14:21 +00:00
Sergey G. Grekhov 8c2390089e [co19] DEPS updated 
Change-Id: I4c7e62401f9ca3e40f9320772602ca8a247b4eff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100642
Reviewed-by: Sergey Grekhov <sgrekhov@unipro.ru>
 2019-05-02 09:08:33 +00:00
Lasse R.H. Nielsen dd19353abb Update test of operator >>>. 
Change-Id: Idd8c6dfcf875a53c536aa3535561f259cf7bcd1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98005
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-02 09:04:18 +00:00
Jens Johansen dcc157633d Offset from class when reporting errors on synthetic constructors 
Bug: 36669
Change-Id: I11b5312e4023cd7368a4a3e36cff66398dadd69c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100960
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-05-02 06:57:43 +00:00
Konstantin Shcheglov 54f9835abf The function type might be null in GenericTypeAlias. 
R=brianwilkerson@google.com

Change-Id: Ia7004239b42171a20e724d80c6f0c4c60b1173f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100986
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-05-02 03:53:44 +00:00
danrubel 1682b4aac5 replace parser language version comment processing 
This CL removes duplicate language version processing from parser
now that the scanner does this work.

In addition...
- update parser tests to listen for languageVersion scanner event
- remove languageVersion field from CompilationUnitImpl and AstBuilder
- add Scanner.buildConfig for translating a FeatureSet into a ScannerConfiguration
- remove old language version parser tests
- cleanup parser nnbd tests

Change-Id: I6ead6a3ab6d5d424e9a7dfbf69da110e43c63982
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100990
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-02 00:55:43 +00:00
Aart Bik aceefaf846 [dart/vm]: fix bug in TextBuffer capacity 
Rationale:
Ensuring capacity computation was off by one (due to trailing '\0')
if the initial buffer size was zero. Granted, this can only happen
after a Steal(), but since API did not exclude reuse after this
operation, it is better to just handle this than crash.

https://github.com/dart-lang/sdk/issues/36818

Change-Id: I4e404c4361da03e24364280fb01a308fbf7ace6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100991
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-05-01 22:26:41 +00:00
Liam Appelbe 1ea3e418b5 Bump oldest supported ABI version 
Bug: https://github.com/dart-lang/sdk/issues/36820
Change-Id: Ibdfe4e1b7431b87be155c6559ce2db019f8a54e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100992
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-05-01 22:26:33 +00:00
Konstantin Shcheglov 143ebf1c1c Compute default types for type parameters of GenericTypeAlias. 
R=brianwilkerson@google.com

Change-Id: Ifbfa8e240b078285660b80fbb02914bc6666b753
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100985
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-01 20:06:39 +00:00
Konstantin Shcheglov 2209d8f0c0 Run VariableResolverVisitor during resolution. 
R=brianwilkerson@google.com

Change-Id: I435cc99a249ea940631ea5ddcea5964cca7ddd1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-01 20:06:26 +00:00
Konstantin Shcheglov a7c0a75442 Disable DeclarationResolver tests with summary2. 
R=brianwilkerson@google.com

Change-Id: I83ad273ba2a0862e659f407f5749e7ae11b507c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-01 20:06:05 +00:00
Konstantin Shcheglov f7b73e9c4b Read linked bundles from ByteStore. 
R=brianwilkerson@google.com

Change-Id: I5be61a2d03c57d1b6bd7a765e50b235ef3f8af5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-05-01 20:05:59 +00:00
Konstantin Shcheglov 2279d88f1f Pass CompilationUnitElement to LocalElementBuilder when building locals. 
R=brianwilkerson@google.com

Change-Id: Ib3c3e7fc76e075eeb312b967948ca92b212b6cf2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100984
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-01 20:05:54 +00:00
danrubel a62ab22c48 remove languageVersionField and update scanner tests 
Change-Id: I5fbb25d5f743fc00fe188da02390a67ded8b1c69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-01 18:01:19 +00:00
Brian Wilkerson 52608e3174 Convert more tests to DriverResolutionTest 
Change-Id: Ib1c3018362f868626d788bc63ba33e5fe5900d8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101001
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-01 17:02:19 +00:00
Sigmund Cherem 73639f9e1f pkg/modular_test: follow up cleanup 
* resultKind -> resultId (missed this when I renamed dataKind to dataId)
* refactor test/pipeline_common.dart: made the test strategy use generic steps so the concept of
concat/lowercase/replace-join now is encapsulated in pipeline_common, while memory_pipeline_test
and io_pipeline_test know how to create steps that apply an opaque function.

Change-Id: I9e425845931db8722a51c1044f6b74b0c8c26ae4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100940
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-05-01 16:38:59 +00:00
Konstantin Shcheglov 49dfd6f4df Build elements for constructor initializers. 
R=brianwilkerson@google.com

Change-Id: Ic41e6ec93571f0407184f8b8e8271517e1e1ec59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-05-01 16:22:39 +00:00
Konstantin Shcheglov f66ef921ac Write and read comment references. 
R=brianwilkerson@google.com

Change-Id: If7d0e97ec98cc7ee2a5ac1c664cb296762911a69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100930
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-01 14:38:38 +00:00
Konstantin Shcheglov b6997deb3e Resolve typed constant initializers separately. 
R=brianwilkerson@google.com

Change-Id: Id54b57a40004de0c9adc345e1f944fc89b568e68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100929
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-01 14:19:20 +00:00
Johnni Winther 8053c43dde Compute static types for for-in loops 
Change-Id: I47e98eaf6df7d04286cb737bfdff135e6c0d34d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100843
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-05-01 14:06:39 +00:00
Dan Rubel b9c87ebbda Add scanner languageVersionChanged callback 
Change-Id: I64835e303efd83ac1f7cb0015407be8c196a5249
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-01 13:07:15 +00:00
Paul Berry fa274ec059 Make each NullabilityNode track those nodes that are downstream of it. 
This allows more migration tool unit tests to be simplified so that
they don't have to refer to ConstraintVariable objects directly
anymore.

In order to make this work, a few other changes were also necessary:

- Make a derived class for NullabilityNodes that arise from
  conditional expressions.

- Add a getter to reveal whether a NullabilityNode is known a priori
  to be non-nullable.

Change-Id: I8a68b627ce9e807a50d371369985f52848903a2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100922
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-05-01 12:42:14 +00:00
Jens Johansen 407378879b Error reporting and ~no location data 
We shouldn't crash and reporting something as being on line 1 of a file
because we don't know where in the file it is, doesn't seem right.

Change-Id: Ia8d6145e21a136903771d876633036b292ea12ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100842
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-05-01 10:24:46 +00:00
Johnni Winther 8d4816b7ff Reimplement member usage tracking 
We now track member usage in terms of static, dynamic and super access
for reads, writes and invocations. The information collected during
closed world computation is now the basis for the potential member usage
in codegen, thus ensuring that we cannot conclude in codegen that for
instance a field is read dynamically when the closed world knows that
it is never read dynamically.

Closes #36516

Change-Id: I3a1cb87c71268c34bcd67e14a035d9d1be324ab0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100840
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-05-01 08:58:34 +00:00
Jens Johansen b36734f4da Fix crash when duplicate fields have annotations 
Fixes #36793.

Change-Id: I007699978219dc642e23951ab78858504a192c03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100646
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-05-01 06:38:36 +00:00
Jens Johansen 30e21f3dc0 Don't crash when additional exports contain duplicate names 
Fixes #36647

Change-Id: I45019b2113fde5bcd1f5e4227f7a1d86c570001f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100645
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-05-01 06:38:34 +00:00
Brian Wilkerson 9670b2ccb9 Update the server API to support context messages 
Change-Id: Ic07ef7d01125ca76f72e8c0e370181ea4f6f7cb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100825
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2019-05-01 01:31:44 +00:00
Ryan Macnak 58c6d78712 [vm] Check Zones are only [un]chained on the correct side of a safepoint transition. 
Fix order in Dart_CreateIsolate and some tests.

Change-Id: Iceb748be3f7aa6b68ce7abb7f65a3c54ad63c1d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100795
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-05-01 00:36:14 +00:00
Matthew Dempsky 4ce3aa7af1 [vm] Replace ^= assignments with = where possible 
Change-Id: I04ac2e9c4b8bb654b7c660e728be3867aa4e1513
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100923
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Matthew Dempsky <mdempsky@google.com>
 2019-05-01 00:04:44 +00:00
Konstantin Shcheglov 2e24a992c7 Support for 'nullabilitySuffix' in linked types. 
R=brianwilkerson@google.com

Change-Id: I08853e2a699cc2270f120247424503a2c5a7cac3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100924
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-30 23:02:02 +00:00
Brian Wilkerson 481d6b9f30 Fix the windows bots 
Change-Id: Ia3f796a174c03912975b37fb9904eea0a05f04c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100926
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-30 22:53:22 +00:00
Aart Bik ee1192e693 [dart/vm] Extended graph checker 
Rationale:
Added more sanity checks on def-use and use-def
data structures in the IR, as well as some smi
sanity checks.
Change-Id: I3451cf45050dc305b35dd7da6f6b96d287de4887
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100727
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-04-30 22:36:52 +00:00
Aart Bik a32fee5d8e [dart/vm] GenericCheckBound (AOT) may throw 
Rationale:
Previous CL inadvertently removed the may-throw tag
from the AOT version of check bound. But, unlike its
speculative counterpart, this non-speculative check
will throw when out of bounds. Optimizations like LICM
rely on this property for correctness. Found with fuzzing!

https://github.com/dart-lang/sdk/issues/36803

Change-Id: I05952f423ffa1917a08dbb6191d0d1533450bc9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100921
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-04-30 22:32:07 +00:00
Alexander Markov 3b22a7ae46 [vm/profiler] Fix native stack walker to properly skip PC = 0xFF..FF 
Fixes flaky service/get_cpu_profile_timeline_rpc_test test failure on debug/simdbc64
(Error "../../runtime/vm/profiler_service.cc: 290: error: expected: start_ < end_".)

Fixes https://github.com/dart-lang/sdk/issues/31794
Possible fix for https://github.com/dart-lang/sdk/issues/28736

Change-Id: I0119830d966aa24713c8572e28e4fc67e6d0de49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100920
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-04-30 22:27:12 +00:00
Brian Wilkerson a30819a2f6 Add a diagnostic associated with the default List constructor 
Change-Id: I41ba3e34c2f209c27bf83015feed0a2ce7918ea0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100789
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-30 22:24:02 +00:00
Ryan Macnak ac4fd50446 [vm, compiler] Check for length overflow when eliminating write barriers for variable-length objects. 
Bug: https://github.com/dart-lang/sdk/issues/36778
Change-Id: I03bd00dd5a035309807e16911dcd7602b4de5e44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100900
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
 2019-04-30 21:36:07 +00:00