9486e99114
[vm/compiler] Forward typed data view constructor arguments.
...
Also adds tests for load optimizer fixes in 836c04fhttps://github.com/dart-lang/sdk/issues/36570
Change-Id: Ie8ea7f944bc789b4c0894f9d96010113fb3ec4b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99466
Commit-Queue: Teagan Strickland <sstrickl@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2019-05-06 10:12:48 +00:00
28faf8c7ca
Merge GraphBuilder into KernelSsaGraphBuilder
...
+ avoid use of `compiler` and `backend`
+ make members of KernelSsaGraphBuilder private when possible
Change-Id: Ia069a8c3b4167c1ae55554baadb857975aeff67f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101287
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-05-06 08:53:24 +00:00
5b569a62d2
Remove code for supporting for generating code with compile time error
...
We don't support that currently and if we want to at some point in the future,
I'd rather implement it from scratch, and the current implementation tightly
couples various parts of the compiler to the `Compiler` object.
Change-Id: I6934df41bb363ea9a693a8181b5a0355774ba4b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101286
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-05-06 08:53:24 +00:00
ba3dba3a00
Remove JavaScriptConstantTask and JavaScriptConstantCompiler
...
Change-Id: I85faab292604b977de2812a6530f7e3403d870bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101285
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-05-06 08:53:24 +00:00
7ea75ab0e0
Const fields doesn't introduce setters; look for setter
...
Fixes #28268 .
Change-Id: I43ccc4072be2fba3ee9273d451fc767876191e16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100964
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-05-06 07:09:24 +00:00
67df3ff878
Remove old commented out code.
...
R=brianwilkerson@google.com
Change-Id: I73e7356514d9500f517fd315f477f9bca56cc776
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-05 15:43:29 +00:00
7ec4621108
cleanup scanner configuration flags
...
* rename enableGtGtGt to enableTripleShift
* remove unused enableGtGtGtEq field
Change-Id: I0fa881c45619067ec3a292acbff984db555aa43e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-05-04 17:14:46 +00:00
81ced1c9bf
Make a separate file for tests of implicit_this_reference_in_initializer
...
Change-Id: I98838dee538158a3776cdeedc195d74f00ece9d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101323
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-04 14:50:26 +00:00
e5575ba64a
In summary2/ast_resolver, get featureSet from enclosing unit
...
Change-Id: I6a40a1199c9ba25336b49f9ea1246178d627630b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101343
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-05-04 00:42:10 +00:00
4679e6bf03
fix analyzer/ddc triple shift assignment
...
Change-Id: I7418f7bcfee2e198fc825e6d8f551a4824b8a4e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101223
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Mark Zhou <markzipan@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-04 00:00:39 +00:00
86d47dc5b4
Fixing some tests that are failing in all/most backends.
...
Change-Id: I91bac2a5597b654082c734decdb948c21d1f5e59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100927
Reviewed-by: Leaf Petersen <leafp@google.com >
2019-05-03 23:36:30 +00:00
836ace6fcb
[vm/bytecode] Avoid recalcualting class hierarchy for each dilp file
...
Compilation time in package-split mode with bytecode on a large app:
Before: 98 seconds
After: 37 seconds
Issue: b/131915611.
Change-Id: Ibc0ea460c9bb78d33441f91e977a914f97e8ce7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101325
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-05-03 23:34:28 +00:00
1ef3818f79
[ VM / Service ] Added resolved_url field to frames in _CpuProfileTimeline response
...
The resolved_url field for Dart frames will contain the resolved url for
the script associated with the frame's function. This field is NULL for
native methods.
Fixes #36718
Change-Id: I8f15c9d02eb6d3628706338a8a1dd0e76e51eb9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100725
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com >
2019-05-03 22:27:08 +00:00
e0e5c85f48
[dartdevc] Always print errors when running ddb script
...
This ensures that errors are printed to the console when running in node and the
main method is async. Previously errors were being swallowed because node exits
with exit code zero in this circumstance.
Other minor cleanup to remove unused variables, imports, and flags.
Change-Id: I1dac156bbe7aa204a6034cb56ef8e9353568d400
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101340
Reviewed-by: Vijay Menon <vsm@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2019-05-03 22:24:18 +00:00
8bc1b2b41c
[dart/fuzzer] Restrict libFuzzer to linux
...
Rationale:
Mac and possibly Windows build don't love fuzzing yet.
Change-Id: Ided9734285197e51145102532e1f59550e261bcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101342
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Aart Bik <ajcbik@google.com >
2019-05-03 20:37:48 +00:00
f06c42d2b6
[vm,debugger] remove column number check in GetBreakpointLocation
...
Once breakpointLocation has been resolved into token position, line breakpoint and column breakpoint should be the same. Then check only token position to remove possible duplicates.
Also some variable renaming. A "bpt" could be class "Breakpoint" or class "BreakpointLocation" in different part of functions. Rename the variables to reduce confusion.
Bug: https://github.com/dart-lang/sdk/issues/35368
Change-Id: I0875b5b48300a800acacf55440b65d892f4e9301
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101060
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Zichang Guo <zichangguo@google.com >
2019-05-03 20:05:28 +00:00
0707abbaf0
[vm] Remove unnecessary indirection in AlternativeGenerationList
...
Change-Id: I2f3da7d68cf1b9b568e3841cd8b7c8a79d467e3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101063
Reviewed-by: Teagan Strickland <sstrickl@google.com >
Commit-Queue: Matthew Dempsky <mdempsky@google.com >
2019-05-03 18:43:22 +00:00
bdc91968a2
[ VM / Service ] Updated JSONWriter::PrintValue(double) to use double_conversion instead of Printf.
...
Fixes #31737
Change-Id: If70b7b6bdd1e977bda310a2b0566dcd48c6b3c6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101101
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2019-05-03 18:07:27 +00:00
58ef1db2ba
Enable the MOVE_FILE refactoring in the Analysis Server edit_domain.dart
...
Change-Id: I8859c6aa4144f4b5328c23a22b78e400706668c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Danny Tuppeny <dantup@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2019-05-03 17:19:14 +00:00
3f90f04a74
Prepare to publish analyzer 0.36.3
...
Change-Id: Ibe4fb287ff6774fa71fd9d5e5a67b0f3f8b8c530
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-03 16:57:54 +00:00
3020127fc4
Change resynthesis test expectations to use new Function syntax.
...
This is necessary in order for resynthesis tests to be unambiguous in
the presence of NNBD, because with the old syntax, it wasn't clear
whether a type like `() -> int?` meant `int? Function()` or `int
Function()?`. In a future CL, we'll make a similar change
FunctionType.toString().
Change-Id: Iedf6162de53c7fe57f858913d8e82faac17971c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101242
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-05-03 16:51:09 +00:00
dbe80f3397
Add tests for late and final variables without an initializer
...
Change-Id: I65c40b9e994e602f6133e100d0e8896cb9dce75c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101071
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-05-03 14:51:54 +00:00
797e288796
Clarify how ParameterElement getters behave in the presence of required.
...
Change-Id: I6f3056669b6760667b2f6ffe158435af1b1fbbd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101243
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-03 14:34:39 +00:00
974babb5f1
Remove named argument nnbd from summary testing methods.
...
These tests now use the FeatureSet mechanism to opt in and out of NNBD.
Change-Id: Id836833d4479e396e8db2b3646d28da339ed5674
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101076
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-03 14:29:41 +00:00
f3d8b420a0
Consolidate all NNBD enables in summary_common.dart.
...
Change-Id: I3cc0363f82674fd1a59ff0c3e2d11e46a72a0d4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101075
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-05-03 14:29:41 +00:00
c38b65d2bc
Use FreshTypeParameters from type_algebra with summary2.
...
FunctionTypeImpl.fresh() works in inscrutable ways, and does not work
correctly for synthetic FunctionType(s).
This change breaks 2 or 3 tests with summary2, because of using
FunctionTypeImpl.recoverTypeArguments() in ErrorVerifier
_checkForImplicitDynamicInvoke().
CheckerTest | test_implicitDynamic_function
CheckerTest | test_implicitDynamic_method
I prototyped a way to stop recovering type arguments some time ago.
https://dart-review.googlesource.com/c/sdk/+/98984
R=brianwilkerson@google.com
Change-Id: I0077e9d91663912cbd4f6c1bf0c2acea5a5056e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-03 14:26:34 +00:00
f931d0e5ab
Read bounds of function type type parameters.
...
R=brianwilkerson@google.com
Change-Id: Icdb0c2e0c02c8f1299d4cf3f6198c26c330f61f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-03 14:21:38 +00:00
836c04f3d2
[vm/compiler] Ensure aliasing between *[C|S] and X[C'|S'] for S < S'.
...
Previously when computing aliasing during load propagation we only
propagated aliasing from X[C'|S'] to *[C''|S''] for S' < S''.
The code incorrectly assumed that this propagation is symmetric (which
it is not) and expected that *[C|S] would be cross aliased with X[C'|S']
when *[C|S] is visited.
Now we split symmetric and non-symmetric parts of the aliasing
computation: X[C'|S'] propagates aliasing to X[C''|S''] for S' < S'' -
which is symmetric. Separately if X is an aliased instance we propagate
aliasing from X[C'|S'] to *[C|S] for all sizes S.
Change-Id: Iccd4c73a18ffd3f60fd179df43a6b117e0844b64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101281
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-05-03 14:18:28 +00:00
fb7137ba6f
Fix isAbstract when MethodDeclaration is lazy.
...
R=brianwilkerson@google.com
Change-Id: Id03af715acdd446e5210f8fc4efbc0a2ca641fd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101202
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-03 14:13:33 +00:00
f9b68f72f4
Fix copy-paste error with optionalNamed.
...
R=brianwilkerson@google.com
Change-Id: Ic657a6af242a4a279772f746aabc1c2596cfa904
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-03 14:10:23 +00:00
0130ffed1b
[vm/compiler] Check for errors when loading test scripts.
...
Change-Id: Iccec96b86ac9bca5bb53e8dc0fb2aa30fde24fd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101261
Auto-Submit: Teagan Strickland <sstrickl@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
2019-05-03 13:54:23 +00:00
8866165950
[dartdevc] Reify bottom as Null
...
Fixes https://github.com/dart-lang/sdk/issues/36832
Change-Id: Ie0869ca350d1951e0736a9d6c92da4a7984117ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101180
Commit-Queue: Vijay Menon <vsm@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2019-05-03 13:39:43 +00:00
c14496a9ee
[infra] Prevent front end unit tests from being approved.
...
This change adds a disguised test.py which the testing infrastructure does
not recognize, effectively ensuring the test results from the front end
unit tests are not uploaded to the database, preventing them from being
approved. As such those tests will be invisible to the testing
infrastructure and will not show up on dashboards.
Change-Id: Ia28976e7cd94284eee968b215a0023a6db52d9c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94753
Reviewed-by: William Hesse <whesse@google.com >
2019-05-03 12:38:22 +00:00
102f4addda
Include the static type in the receiver type of dynamic invoke
...
- and preserve the original receiver type information during type propagation updates.
Change-Id: I20087b282a3d018947043d7a3ab7c45f003eaee6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100966
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-05-03 07:52:22 +00:00
03776172c1
Read VariableDeclaration type during checking for implicitly typed.
...
R=brianwilkerson@google.com
Change-Id: Ide32d69775df15aa3524893734a11dc7299bdc72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-02 23:22:33 +00:00
d5eba9b77d
Remove error if a final field without initializer is marked as late
...
Change-Id: Ibc81d71bc6ec2d223583dcbcb39b2311a49eda0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101220
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-05-02 23:06:49 +00:00
5393ce7d35
[vm, service] Fix parameter handling for profiler timeline RPCs.
...
Add missing required parameter "tags" to internal invocation in Dart_WriteProfileToTimeline.
Add service tests for accessing the profiler samples as timeline events.
Fix the profiler for threads spawned from the Mac eventhandler. Compare 5d02929fa0https://github.com/dart-lang/sdk/issues/26416
Bug: https://github.com/dart-lang/sdk/issues/36830
Change-Id: I5b3cb8f3530da081057090879c6ab820deba1510
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100988
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2019-05-02 23:05:39 +00:00
97122d162e
Separate abi versions out from create_sdk into their own target.
...
Bug: https://github.com/dart-lang/sdk/issues/36820
Change-Id: If9861095f07085e7e88d547cfc052ea033011d4a
Fixes: https://github.com/dart-lang/sdk/issues/36820
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101080
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Liam Appelbe <liama@google.com >
2019-05-02 22:30:49 +00:00
a43d36cdd9
Support for '===' and '!==' tokens.
...
R=brianwilkerson@google.com
Change-Id: I15edd0d2f34e4dd3e88960681c37bf469ee34472
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101079
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-02 21:56:00 +00:00
ff0f2a6b2e
Refactoring renaming of some tests in move_file_test.dart and sorting of the tests
...
Change-Id: I14d132c070b866da0a1373fc0f807f868f3024a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101078
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
Auto-Submit: Jaime Wren <jwren@google.com >
2019-05-02 21:40:24 +00:00
0586be25a4
Read partOf directive metadata lazily.
...
R=brianwilkerson@google.com
Change-Id: Ida31471bde95b6693a357bcdf6aa94cc96eb587e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-02 21:37:25 +00:00
0950a540d7
Convert summary_common.dart to triple-slash comment style
...
Change-Id: Ife2401515d2a755082a5021631880f8d79e637c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101074
Commit-Queue: Paul Berry <paulberry@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-02 21:37:18 +00:00
14d548f239
Add a toString() method for FeatureSet
...
Change-Id: Ie15939d50410c7a9a4490a29e332be7d9bd5f0af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101073
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-02 21:30:43 +00:00
e25aefc8d6
Consolidate all NNBD enables in resynthesize_common.dart.
...
I elected not to provide an `sdkVersion` argument to FeatureSet for
these tests, on the grounds that if any new features are added to the
SDK before NNBD, we want to make sure that those features are
compatible with the NNBD summary behavior.
Change-Id: I62e383e903b5756dcbb8cb498e71c4e739731d3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101070
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-02 21:29:13 +00:00
48a7e24e39
Store lineStarts with units.
...
R=brianwilkerson@google.com
Change-Id: I570b172f6feae88c122536e4032860b7c9e01ebc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101077
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-02 21:08:34 +00:00
70e00c9a37
Handle ClassTypeAlias without valid Function.
...
R=brianwilkerson@google.com
Change-Id: Ibc160658b75f7d5a450548e12aa5dc96be674f06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101072
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-02 21:01:30 +00:00
b8fb787994
Add a test for uses of the default List constructor
...
Change-Id: I3b1452186e00f930d5da7c64f3a64f08cd6f4589
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101066
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-05-02 20:46:55 +00:00
a334395edf
Switch to using FeatureSet in summary tests
...
Change-Id: I16b13a2509836485417013da48d5b1ae4c92f618
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101069
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-02 20:46:13 +00:00
dd1ae4c2d8
Fix the order during building library scopes.
...
We should add local declarations to the export scope first.
R=brianwilkerson@google.com
Change-Id: I0f918be9ea16519c5670fb24236c85d1755f9eea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-02 20:13:50 +00:00
4a31d8b62b
Additional tests in move_file_test.dart - the analysis server tests for the MOVE_FILE refactoring.
...
Change-Id: Icddbdf0da237b43af2513ec2407ec774218360f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101068
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-02 19:56:51 +00:00
Stevie Strickland