Commit Graph

1321 Commits

Author SHA1 Message Date
antonm@google.com 1834e21180 Reapply change which was reverted by mistake.
R=ricow@google.com

Review URL: https://codereview.chromium.org//10951025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12543 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 09:15:20 +00:00
antonm@google.com 13de87215b Triaging dart2dart co19 tests.
TBR=smok@google.com

Review URL: https://codereview.chromium.org//10950022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12537 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 08:24:46 +00:00
ricow@google.com 81aafa62d9 Refactor utils/compiler/buildbot.py (partly to fix IE bots, partly because it needs it)
This change will:
Disallow bots starting with web-

Support the new naming schema for the ie bots (I explicitly set this
to html|all, but we can change it to a generic identifier if you like)

Introduces a new BuildInfo class that we return from GetBuildInfo
instead of a huge tupple; I want to start passing this around instead
of explicitly giving all the arguments to e.g., TestCompiler, but
currently I don't do it due to our special cases.

Removes the ie sharding todos since we now have an explicit way of passing allong which tests we want based on the name (I am not stating that this is a good solution, but until we have more bots to shard across I think this is better than what we had)
Review URL: https://codereview.chromium.org//10937024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12535 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 08:06:02 +00:00
ricow@google.com e4d7741572 Fix sharding index extraction for in browser testing.
Review URL: https://codereview.chromium.org//10942021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12531 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 05:10:31 +00:00
ricow@google.com 89a6921836 Change utils/compiler/buildbot.py to use our new naming schema.
Additionally, some cleanup and update of comments regarding return tupples and parameters. 
Review URL: https://codereview.chromium.org//10944010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12530 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 05:03:54 +00:00
nweiz@google.com b162605f23 Add tests for updating a git repo to a bad/different pubspec.
BUG=5241

Review URL: https://codereview.chromium.org//10937018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12520 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 22:30:43 +00:00
nweiz@google.com bb468499d4 Don't extract the name of a package from its description.
Instead, the pubspec is considered to be the canonical name. This has the side
effect of requiring that all dependencies have a pubspec with a name field.

BUG=5205

Review URL: https://chromiumcodereview.appspot.com//10938003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12517 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 22:09:37 +00:00
nweiz@google.com a46ca5f049 Re-mark pub_(install|update)_hosted_test as flaky.
BUG=5065

Review URL: https://codereview.chromium.org//10941021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12516 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 22:09:01 +00:00
nweiz@google.com 665f07f786 Mark pub_(install|update)_hosted_test as unflaky.
Issue 4974 purports to have fixed the error that was causing this flakiness. If
these tests continue to be flaky, issue 4974 should be re-opened.

BUG=5065

Review URL: https://chromiumcodereview.appspot.com//10950013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12514 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 21:41:45 +00:00
ager@google.com 1159462fc6 Switch from interfaces to abstract classes in dart:io.
Add a bunch of default argument values to the abstract classes
so they are picked up by dartdoc.

R=sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//10938010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12484 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 10:54:37 +00:00
lrn@google.com 99749ca619 This reapplies the change to remove "dynamic" from Object.
TBR=kasperl@google.com

Review URL: https://codereview.chromium.org//10908291

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12449 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 19:14:49 +00:00
lrn@google.com 54d6cbda76 Revert "Remove Object.dynamic."
Some test expectations were missing.

TBR=kasperl@google.com

Review URL: https://codereview.chromium.org//10933122

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12433 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 12:10:29 +00:00
lrn@google.com 9cc07e2f3f Remove Object.dynamic.
Review URL: https://codereview.chromium.org//10914286

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12432 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 12:00:44 +00:00
efortuna@google.com 9163dfe93c revert 1204. Will investigate when I get a chance.
TBR=rnystrom
Review URL: https://codereview.chromium.org//10928216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12413 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-15 01:21:41 +00:00
rnystrom@google.com 383488ec4f Update unittest to new package layout.
Review URL: https://codereview.chromium.org//10917275

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12404 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 21:12:17 +00:00
rnystrom@google.com 659a57df3e Revert "Make unittest follow the new package layout."
This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01.

Review URL: https://codereview.chromium.org//10911318

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12400 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 19:43:10 +00:00
rnystrom@google.com 2ba81033a6 Make unittest follow the new package layout.
Review URL: https://codereview.chromium.org//10918240

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12396 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 18:22:24 +00:00
ahe@google.com a6f34e5738 Hack to accept, but not use, colors option
BUG=http://dartbug.com/4996

Committed on behalf of Matthew Butler <butler.matthew@gmail.com>.

Review URL: https://codereview.chromium.org//10911311

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12384 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 13:34:02 +00:00
rnystrom@google.com 05dadf490e Reorganize dartdoc to new package layout.
Review URL: https://codereview.chromium.org//10919260

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12338 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 16:49:48 +00:00
johnniwinther@google.com 16f8dd92e9 Changed final to const in apidoc.
Review URL: https://codereview.chromium.org//10914255

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12311 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 10:51:15 +00:00
ahe@google.com 722e7ce28d Add --step_name option to test.dart.
Review URL: https://chromiumcodereview.appspot.com//10905208

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12296 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 04:19:11 +00:00
rnystrom@google.com e11b3b82fe Make args package follow new layout.
Review URL: https://codereview.chromium.org//10919249

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12284 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 21:31:42 +00:00
bak@google.com 26a215b25a Changed interfaces to abstract classes in utils.
Review URL: https://chromiumcodereview.appspot.com//10915231

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12263 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 13:30:26 +00:00
iposva@google.com bcb6bcc85a - Simplify pub.status file.
- Mark pub_update_hosted_test as flaky.
Review URL: https://chromiumcodereview.appspot.com//10933041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12246 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 08:58:41 +00:00
rnystrom@google.com 3317817025 Support both new and old style package layouts.
Update the tests to all use the new layout.

Review URL: https://chromiumcodereview.appspot.com//10916190

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12224 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 21:55:47 +00:00
nweiz@google.com e24a805cac Look for git.cmd on Windows.
BUG=4947

Review URL: https://chromiumcodereview.appspot.com//10905202

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12222 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 21:17:41 +00:00
ahe@google.com 3436e0ce12 Mark pub test as flaky
Review URL: https://chromiumcodereview.appspot.com//10918165

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12162 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 07:19:01 +00:00
nweiz@google.com db5a92899e Add a 30s timeout for all HTTP requests in Pub.
Review URL: https://chromiumcodereview.appspot.com//10928041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12151 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 23:29:12 +00:00
nweiz@google.com 441f25547f Pub: fix the 'system_cache' library
There were 2 small errors:

1. The Version class is used, but the 'version' library wasn't imported.
2. The arguments to the PackageId constructor were passed in wrong order.

BUG=

Review URL: https://chromiumcodereview.appspot.com//10928071

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12147 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 19:58:01 +00:00
antonm@google.com a1770a8bbd Sync .gitignore with the corresponding svn properties.
R=ahe@google.com

Review URL: https://chromiumcodereview.appspot.com//10914176

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12122 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 15:44:25 +00:00
ahe@google.com ebd6307d57 Scrub step names to avoid breaking buildbot features.
Review URL: https://chromiumcodereview.appspot.com//10919182

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12096 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-09 18:06:38 +00:00
eub@google.com 4fa1021915 Incorporate handwritten dartdoc comments into API docs.
Review URL: https://chromiumcodereview.appspot.com//10918112

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12056 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 19:38:54 +00:00
antonm@google.com 123a2620f7 Do not rename assert syntax.
TBR=lrn@google.com,smok@google.com

Review URL: https://chromiumcodereview.appspot.com//10914150

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12048 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 17:11:14 +00:00
ahe@google.com c8ca545f23 Update status file for dart2dart.
Review URL: https://chromiumcodereview.appspot.com//10908147

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12047 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 17:01:24 +00:00
ngeoffray@google.com 94f1c2ed10 Change our 'is int' check to use Math.floor instead of a smi check.
Review URL: https://chromiumcodereview.appspot.com//10912147

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12018 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 12:05:34 +00:00
kasperl@google.com 9beb871852 Get rid of a lot of () for getters.
R=bak@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10919146

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12017 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 11:50:07 +00:00
gram@google.com a1eecbbc65 Added support for layout render tests. These use expected values for the text render output from DumpRenderTree. When running a test in DRT the testrunner will see if there is a file with a .render extension in the same directory as the test file and with the same base file name. If so it will do additional checks of the rendered layout.
Here is a simple example test:

#library('sample');
#import('dart:html');
#import('pkg:unittest/unittest.dart');

main() {
  group('foo', () {
    test('test 1', () {
      document.body.nodes.add(new Element.html("<p>Test 1</p>"));
    });
    test('test 2', () {
      document.body.nodes.add(new Element.html("<p>Test 2</p>"));
    });
  });
}

And a sample matching .render file:

[foo test 1]
RenderBlock {P} at (0,0) size 284x20
  RenderText {#text} at (0,0) size 38x19
    text run at (0,0) width 38: "Test 1"
[foo test 2]
RenderBlock {P} at (0,0) size 284x20
  RenderText {#text} at (0,0) size 38x19
    text run at (0,0) width 38: "Test 2"

Note that the render content is only the content inside the <body> element, not including the body element itself.

testrunner can generate render files itself if you use the --generate-renders flag.

Also in this change - rename Configuration.log to trace, to avoid clash with the math log() function.
Review URL: https://chromiumcodereview.appspot.com//10914049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11994 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-06 21:51:24 +00:00
eub@google.com bc23d1bc59 Allow apidoc to skip MDN database.json entries that are bogus.
With a TODO to fix the underlying MDN scraper and database.json. :-P
Review URL: https://chromiumcodereview.appspot.com//10915125

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11985 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-06 20:29:16 +00:00
ngeoffray@google.com b5fe256172 Improvements for checked mode: check when intializing fields, and when assigning to fields.
Review URL: https://chromiumcodereview.appspot.com//10910092

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11962 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-06 16:03:25 +00:00
ngeoffray@google.com fce3e2ec01 Fix checked mode on browser.
Review URL: https://chromiumcodereview.appspot.com//10912109

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11933 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-06 10:48:22 +00:00
efortuna@google.com f19c48c69b Remove dom_deprecated from everywhere but lib/dom and lib/html.
Review URL: https://chromiumcodereview.appspot.com//10918063

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11908 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 22:22:31 +00:00
ahe@google.com f60c22adb8 Disable browser dart2js checked mode tests. Too broken.
Review URL: https://chromiumcodereview.appspot.com//10911107

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11896 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 19:01:38 +00:00
ahe@google.com ccc5a66fbc One more problem with checked mode in browsers.
Review URL: https://chromiumcodereview.appspot.com//10912104

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11892 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 18:43:56 +00:00
ahe@google.com 2cb2b0161a Disable checked mode browser tests on platforms where they break test framework.
Review URL: https://chromiumcodereview.appspot.com//10919099

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11885 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 16:21:37 +00:00
ahe@google.com c19adedfa5 Test dart2js checked mode.
Review URL: https://chromiumcodereview.appspot.com//10911094

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11873 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 12:02:53 +00:00
ahe@google.com e82ca32178 Improve [relativize] for Windows.
Review URL: https://chromiumcodereview.appspot.com//10914094

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11864 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 09:35:12 +00:00
nweiz@google.com e36237835a Use a bare git repository for the repo cache.
This also allows remote branch names to be used in the `ref` field for Git
dependencies.

BUG=4892

Review URL: https://chromiumcodereview.appspot.com//10913077

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11856 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 01:35:27 +00:00
nweiz@google.com dab90c79b4 Emit a non-zero exit code when Pub fails.
BUG=4922

Review URL: https://chromiumcodereview.appspot.com//10911085

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11855 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 01:16:21 +00:00
rnystrom@google.com 29e9417404 One more error code to check.
Review URL: https://chromiumcodereview.appspot.com//10916106

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11854 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 00:45:05 +00:00
rnystrom@google.com b33db2545f Use right errno on Linux.
Review URL: https://chromiumcodereview.appspot.com//10909073

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11853 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 00:30:35 +00:00