Commit Graph

500 Commits

Author SHA1 Message Date
rnystrom@google.com 616ab7e943 Handle deleting broken symlinks on Windows.
BUG=https://code.google.com/p/dart/issues/detail?id=9192

Review URL: https://codereview.chromium.org//12716024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20501 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-26 00:50:23 +00:00
rnystrom@google.com 7aafe74407 Mark right test as flaky.
BUG=

Review URL: https://codereview.chromium.org//12872006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20398 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-22 18:29:59 +00:00
nweiz@google.com c9724a390f Ignore lockfile entries where the source is wrong.
BUG=7262

Review URL: https://codereview.chromium.org//12995013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20395 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-22 18:12:14 +00:00
nweiz@google.com 5d68e6b5fc Mark pub_update_test as flaky.
BUG=9357

Review URL: https://codereview.chromium.org//12995004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20357 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-21 22:03:51 +00:00
nweiz@google.com 30afbfd9c0 Provisionally un-flake pub tests.
Now that pub is using scheduled_test, it should at least be clearer what's going
on if these tests start flaking again.

BUG=8511,8868

Review URL: https://codereview.chromium.org//12422015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20291 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-20 21:21:06 +00:00
nweiz@google.com cc340dc736 Increase the scheduled_test timeout for Git tests on Windows.
Review URL: https://codereview.chromium.org//12668014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20289 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-20 21:09:17 +00:00
nweiz@google.com 84dd8a51e0 "new Map()" -> "new Map.from()" in pub.
BUG=8511

Review URL: https://codereview.chromium.org//12580008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20265 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-20 01:03:23 +00:00
nweiz@google.com db9ff1e404 Use scheduled_test for Pub tests.
This was originally committed as r20250. Due to issue 9294, this failed on
Windows. This commit works around that issue.

BUG=8511

Review URL: https://codereview.chromium.org//12437022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20264 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-20 00:50:58 +00:00
nweiz@google.com 32db9c0cf6 Revert "Use scheduled_test for Pub tests."
This reverts r20250, which was failing on Windows.

BUG=8511

Review URL: https://codereview.chromium.org//12782005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20253 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 22:22:55 +00:00
nweiz@google.com 82cbc2db3a Use scheduled_test for Pub tests.
BUG=8511

Review URL: https://codereview.chromium.org//12794007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20250 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 21:58:53 +00:00
nweiz@google.com 83d896d80b Fix a couple broken tests in pub/validator_test.
These tests were marked as test() rather than integration() and so their
schedules weren't getting run at all.

Review URL: https://codereview.chromium.org//12659008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20238 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 20:37:03 +00:00
rnystrom@google.com 78a4088f03 Actually make status file do something.
Review URL: https://codereview.chromium.org//12712013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20123 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 23:17:27 +00:00
rnystrom@google.com 5def0d4962 Disable failing test on Windows until I can fix it.
BUG=https://code.google.com/p/dart/issues/detail?id=9192

Review URL: https://codereview.chromium.org//12422010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20118 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 22:51:16 +00:00
rnystrom@google.com 2f2b30eb0e Handle broken symlinks when creating package dirs.
BUG=https://code.google.com/p/dart/issues/detail?id=8343

Review URL: https://codereview.chromium.org//12772005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20116 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 22:07:18 +00:00
rnystrom@google.com 4a465ef855 Remove support for SDK dependencies.
BUG=https://code.google.com/p/dart/issues/detail?id=6354

Review URL: https://codereview.chromium.org//12790006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20098 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 18:33:05 +00:00
lrn@google.com 844cd39fad Change getRange to sublist. Make getRange deprecated.
This changes the exception behavior of getRange. It used to accept
a length of zero, no matter what start value. Now the start value
must be a valid list index.

Review URL: https://codereview.chromium.org//12817003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20064 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 09:15:39 +00:00
nweiz@google.com a9a8d42063 Add a SafeHttpServer shim to work around issue 9140.
Review URL: https://codereview.chromium.org//12633015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20054 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 22:12:19 +00:00
keertip@google.com a455e0d9cd add cache list command to pub
Review URL: https://codereview.chromium.org//12755024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19977 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 22:29:00 +00:00
rnystrom@google.com 0122b2954e Dev dependencies.
BUG=dartbug.com/5358

Review URL: https://codereview.chromium.org//12433014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19966 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 19:40:25 +00:00
floitsch@google.com 482b2f34e8 Move Options to dart:io.
Review URL: https://codereview.chromium.org//12794002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19927 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 13:12:00 +00:00
nweiz@google.com 845e550cbb Properly handle errors from the OAuth2 token endpoint in pub.
This also adds more detailed HTTP logging to pub.

BUG=8849

Review URL: https://codereview.chromium.org//12428012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19734 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 21:57:27 +00:00
nweiz@google.com c71bb58877 Update pub to use the latest dart:io stream APIs.
Review URL: https://codereview.chromium.org//12613010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19729 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 21:46:08 +00:00
floitsch@google.com dd48256fe5 Remove deprecated StringBuffer.add, addAll and addCharCode.
Review URL: https://codereview.chromium.org//12473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19690 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 13:07:18 +00:00
lrn@google.com bead146749 Renamed StreamSink to EventSink. Renamed signalError to addError.
Review URL: https://codereview.chromium.org//12610006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19683 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 11:31:19 +00:00
sgjesse@google.com b6096848b1 Make IOSink implement StringSink
Besides adding the StringSink methods I also added writeBytes and
deprecated both add and addString.

To handle the encoding of strings the IOSike has an encoding
property. This property is mutable in situation when it makes sense to
change encoding of what is written. The exception here is for HTTP
where the encoding is determined from the header and the encoding
cannot be changed.

R=ajohnsen@google.com, ager@google.com, nweiz@google.com

BUG=

Review URL: https://codereview.chromium.org//12504006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19676 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 10:06:28 +00:00
rnystrom@google.com b3e5168249 Add a failing test for handling broken symlinks.
BUG=8343

Review URL: https://codereview.chromium.org//12500005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19580 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 20:55:53 +00:00
rnystrom@google.com 50d1fc7a99 Delete files synchronously.
BUG=8868

Review URL: https://codereview.chromium.org//12481003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19517 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-05 21:32:35 +00:00
gram@google.com 9b40e6b13e Fix issue with async callbacks that get called synchronously while running test case function causing the test to be marked as complete prematurely.
Added an optional id to completion matchers that can be used in error messages (this was invaluable in tracking down the above problem).

Re-enable pub tests. https://code.google.com/p/dart/issues/detail?id=8862
Review URL: https://codereview.chromium.org//12393017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19339 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 21:49:15 +00:00
ricow@google.com 85b572e7d7 Mark flaky pub tests
Review URL: https://codereview.chromium.org//12377042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19284 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 09:08:20 +00:00
gram@google.com 621650b0e8 Disable breaking tests while I investigate the issue. I don't really want to revert;
I want to understand this as it may indicate some other problem.
Review URL: https://codereview.chromium.org//12387033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19271 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 01:38:57 +00:00
nweiz@google.com a903dfd3a4 Remove the wrapStream workaround for issue 8310.
Review URL: https://codereview.chromium.org//12374033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19266 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:24:21 +00:00
nweiz@google.com 2a0c74a18d Make pub warning-clean.
Review URL: https://codereview.chromium.org//12382031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19265 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:21:58 +00:00
gram@google.com 017d21bdc0 Unit test changes:
- add back KevMoo's assertions now that the bugs they exposed ar efixed
- remove onTestResult methods from a couple of configs; these did nothing other
  than prevent the base class implementation from being called which is wrong.
- fix the TestFunction signature
- change from ExpectException, which is deprecated, to TestFailure.
Review URL: https://codereview.chromium.org//12335113

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19166 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 19:57:40 +00:00
amouravski@google.com edee0d7e8e Updated an error message to inform users that their packages were not installed
when their SDK version does not match.

Review URL: https://codereview.chromium.org//12315059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19026 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 03:12:02 +00:00
rnystrom@google.com 1d62e0a077 Disable test on Windows for now.
Review URL: https://codereview.chromium.org//12313114

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19016 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 23:20:47 +00:00
rnystrom@google.com b88ebea7c3 Handle shared path dependencies.
BUG=https://code.google.com/p/dart/issues/detail?id=8775

Review URL: https://codereview.chromium.org//12335076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19012 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 23:00:16 +00:00
lrn@google.com 3c0ac360e7 Remove deprecated string features.
Make String.codeUnits return a List.

Review URL: https://codereview.chromium.org//12282038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18960 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 10:48:09 +00:00
nweiz@google.com c8f6014ae7 Move pkg/path to pkg/pathos.
Review URL: https://codereview.chromium.org//12316056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18906 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 18:45:55 +00:00
rnystrom@google.com df8647c43f Allow whitespace in version constraints.
BUG=http://code.google.com/p/dart/issues/detail?id=7140

Review URL: https://codereview.chromium.org//12310029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18851 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 19:47:44 +00:00
rnystrom@google.com e3e5d46f32 Make sure package names are URL encoded.
If you happen to have a weird package name like "/* blah *?" you
would get a nasty HTTP error when it tried to jam that in a URL.
Instead, this will give you a friendlier 'package "/* blah */" not found error."
BUG=http://code.google.com/p/dart/issues/detail?id=7466

Review URL: https://codereview.chromium.org//12328021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18849 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 18:59:48 +00:00
sgjesse@google.com 488b016a2f Merge IO v2 branch to bleeding edge
R=ager@google.com, ajohnsen@google.com, whesse@google.com

BUG=

Review URL: https://codereview.chromium.org//12316036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18820 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 11:58:11 +00:00
rnystrom@google.com 8b37852e8a Use relative symlinks for self links and secondary "packages" dirs.
This lets you move a package directory without breaking all of those links.
BUG=http://code.google.com/p/dart/issues/detail?id=8342

Review URL: https://codereview.chromium.org//12321020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18785 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-20 21:17:16 +00:00
rnystrom@google.com e28a669679 Make some name validation errors warnings.
BUG=http://code.google.com/p/dart/issues/detail?id=8632

Review URL: https://codereview.chromium.org//12313014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18783 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-20 21:11:47 +00:00
nweiz@google.com d64b7d392a Use the correct set of reserved identifiers in pub validations.
We had been using the set listed in the spec as "BUILT_IN_IDENTIFIER", but
apparently those are the built-in identifiers that are valid for user use. Now
we're using the set listed in the spec as "reserved words".

BUG=8628

Review URL: https://codereview.chromium.org//12301032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18716 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 19:55:40 +00:00
rnystrom@google.com a1702c3578 Support relative paths in path dependencies.
BUG=http://code.google.com/p/dart/issues/detail?id=8527

Review URL: https://codereview.chromium.org//12285010


Review URL: https://codereview.chromium.org//12294039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18715 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 19:49:46 +00:00
rnystrom@google.com 5ed85458d1 Revert "Support relative paths in path dependencies."
This reverts commit 0b0da0d44dde213647e7281bf0914c59fc552b27.

BUG=

Review URL: https://codereview.chromium.org//12280019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18606 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-16 02:00:45 +00:00
rnystrom@google.com 8514e448b7 Support relative paths in path dependencies.
BUG=http://code.google.com/p/dart/issues/detail?id=8527

Review URL: https://codereview.chromium.org//12285010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18605 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-16 01:45:39 +00:00
rnystrom@google.com b12e27a4d2 Get rid of join() and encapsulate File and Directory in io.dart.
Review URL: https://codereview.chromium.org//12253054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18551 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 01:13:07 +00:00
rnystrom@google.com 10f7ad94ae Clean up some warnings and deprecated calls.
Review URL: https://codereview.chromium.org//12262056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18550 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 01:10:07 +00:00
rnystrom@google.com ba326cd770 Get rid of old redundant methods in io.dart.
Now that we have pkg/path, we can ditch the old methods in io.dart
that do the same thing.

Review URL: https://codereview.chromium.org//12255016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18500 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 01:14:31 +00:00