dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

19280 Commits

Author SHA1 Message Date
Daco Harkes a43c525de2 Reland "[vm/ffi] Support Windows 64 bit" 
Enables dart:ffi on Windows 64 bit.

Note that function_stress_test.dart fails in two different ways, these are known bugs. https://github.com/dart-lang/sdk/issues/36138

Relanding: Fixed compilation on Android.

Closes: https://github.com/dart-lang/sdk/issues/35771
Change-Id: I7d0c8b64ca8c1726b7d264d4fd9213299a9f7df6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96781
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2019-03-13 11:47:37 +00:00
Johnni Winther f307524421 Support native member annotations through ir constants 
Change-Id: I247385c951d3a794afe7e4066b3b1d1ea14a76b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96641
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-13 09:08:27 +00:00
Peter von der Ahé 69c1d1096d Update test as combined member signature would fail 
Change-Id: Ifc336b706fa1315f206f2214eb233489bd21c763
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96645
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-03-13 06:46:21 +00:00
Zichang Guo 0bd674c374 [VM-Runtime] set environment when creating detached process 
environ variable should be updated if user provides environment. It only update for normal processes.
Bug= https://github.com/dart-lang/sdk/issues/36132

Change-Id: I2a4639ed53e7376534578a0b1b251025ffaa2278
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96147
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
 2019-03-12 21:09:35 +00:00
Vyacheslav Egorov 23eb57c2bf Revert "[vm/ffi] Support Windows 64 bit" 
This reverts commit 7f812dea1a.

Reason for revert: Flutter build is broken on Golem.

Original change's description:
> [vm/ffi] Support Windows 64 bit
> 
> Enables dart:ffi on Windows 64 bit.
> 
> Note that function_stress_test.dart fails in two different ways, these are known bugs. https://github.com/dart-lang/sdk/issues/36138
> 
> Closes: https://github.com/dart-lang/sdk/issues/35771
> Change-Id: I73012123f2bd90b737fdc1c87c9a9630c20d5660
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95647
> Commit-Queue: Daco Harkes <dacoharkes@google.com>
> Reviewed-by: Samir Jindel <sjindel@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=kustermann@google.com,sjindel@google.com,dacoharkes@google.com

Change-Id: I5be4538e3c99632a852e4dfb856248eb437fb3ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96683
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2019-03-12 19:55:17 +00:00
Daco Harkes 7f812dea1a [vm/ffi] Support Windows 64 bit 
Enables dart:ffi on Windows 64 bit.

Note that function_stress_test.dart fails in two different ways, these are known bugs. https://github.com/dart-lang/sdk/issues/36138

Closes: https://github.com/dart-lang/sdk/issues/35771
Change-Id: I73012123f2bd90b737fdc1c87c9a9630c20d5660
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95647
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-03-12 17:30:26 +00:00
Vyacheslav Egorov b3927f66df [gardening] Mark tests that crash as crashing 
This blocks crash uploading which should resolve redness on Mac
which produces huge core dumps.

Change-Id: Iad3f5e1be246d0de6db0aa3eee47b2f6777f5889
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96658
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
 2019-03-12 16:31:22 +00:00
Johnni Winther 6a2aa920cd Support pragma annotations through ir constants 
Change-Id: I40b2662a00596ca9ebbb5301f99b541806e71515
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96280
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-12 09:28:32 +00:00
Mark Zhou 3cf7d6a9c7 [tests] Changing expected cast errors to type errors for collections tests 
Change-Id: I0e48dba7b1612994075629c43331794bfb2d2530
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96421
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
 2019-03-11 21:56:41 +00:00
Johnni Winther 440b4cd84e Insert implicit casts when setting interface targets 
This preserves the invariant that method invocations and property sets
with an interface target handle static types at the call site.

This is a prerequisite to improving dart2js with implicit checks.
With this we can mark dynamic invocations a statically safe and
discover when instance methods don't need to check parameter types.

Change-Id: Ife7a3f947952b3c1f73316b922b2aa107343068e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95400
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-11 13:08:34 +00:00
Johnni Winther 231c5c138e Create codegen work item for all members 
Ensures that constants of effectively constant instance fields are
registered also with --omit-implicit-checks.

Change-Id: Icc31799f1cc5f565321c832780f30c711e9c8c50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96160
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-03-08 23:46:55 +00:00
Johnni Winther 068aa0d2e7 Support eagerly initialized static fields. 
Change-Id: I4265fe9bcfccc6a99627e57705868a7ee1da828d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94749
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-08 20:48:35 +00:00
Dmitry Stefantsov 1ce3e8af71 Reland "[cfe] Handle spread map entries of static type Null" 
This is a reland of ccd2c85a1a

Original change's description:
> [cfe] Handle spread map entries of static type Null
> 
> Change-Id: I164b3fa471deb65da93ecfd60ee836ec22eb93e1
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96080
> Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
> Reviewed-by: Kevin Millikin <kmillikin@google.com>

Change-Id: I4519970d8259481e137424f3506b7fb97307b14a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96134
Reviewed-by: Régis Crelier <regis@google.com>
 2019-03-08 19:05:19 +00:00
Nicholas Shahan d2d098405f [tests] Fix some control flow collections tests 
- Remove tests that expect ForElements in const collections.
- Add missing value (or was it the key) in map.

Change-Id: Ic61cbb4326a105618ae4ea169655411359c52045
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96020
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-03-08 17:27:38 +00:00
Régis Crelier afccd8cbc7 Revert "[cfe] Handle spread map entries of static type Null" 
This reverts commit ccd2c85a1a.

Reason for revert: very red bots, gardener not going to blindly approve all redness

Original change's description:
> [cfe] Handle spread map entries of static type Null
> 
> Change-Id: I164b3fa471deb65da93ecfd60ee836ec22eb93e1
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96080
> Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
> Reviewed-by: Kevin Millikin <kmillikin@google.com>

TBR=dmitryas@google.com,askesc@google.com,kmillikin@google.com

Change-Id: Ia8f60993222851a73291662f75556b2e4111a6f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96123
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-03-08 17:19:35 +00:00
Lasse R.H. Nielsen 2e9ff26527 Fix overflow bug in BigInt implementations. 
Fixes #36105

Bug: http://dartbug.com/36105
Change-Id: I9adf70d11474f844d2a4fbf5fcc3754562b1cf65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95644
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-03-08 16:11:08 +00:00
Dmitry Stefantsov ccd2c85a1a [cfe] Handle spread map entries of static type Null 
Change-Id: I164b3fa471deb65da93ecfd60ee836ec22eb93e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96080
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-08 15:46:31 +00:00
Dmitry Stefantsov 52ff930338 [cfe] Desugar map spread entries in non-const map literals 
Change-Id: Ie8f6cc0294888716f4e0349ba07320e684e26e1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95640
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-08 12:08:42 +00:00
Johnni Winther b8069cbeca Refactor computation of modular data 
Add ModularStrategy as a step towards loading modular data from disk.

Change-Id: I9d0baebef8899794742164be4350bedbd3da5b68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95650
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-08 08:36:07 +00:00
Johnni Winther 889d5d9240 Fix type error in node_tracer 
From https://dart-review.googlesource.com/c/sdk/+/94749
This is triggered by set literal testing.

Change-Id: I151f9154410790820e1f4d6301b0ccde52a72767
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95441
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-08 08:21:47 +00:00
Brian Wilkerson a47ffd2b50 Fix some errors in the control flow collections tests 
Change-Id: I87ba6b3d2860439c33b62c02e8f9294d65d31abc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95900
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-03-07 21:54:55 +00:00
Aart Bik 5c7b07f783 [dart/vm] Fix bug in kernel binary flow graph builder 
Rationale:
Found by DartFuzz. One of the trickier bugs I had to debug.
While building the flow graph from kernel, the finalizer
builder expects the program context to be in the same state
as when the finalizer was seen first, not the context seen
by the breaking/continuing statement. This was done partially,
but only partially. Finding loop context or breakable
and switchable blocks was missing. Something only
a fuzzer can find :-)

https://github.com/dart-lang/sdk/issues/36076

Change-Id: Ie63912c5fad4d3c15f6559b60cc102b237949957
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95720
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-03-07 20:16:18 +00:00
Samir Jindel bdb07f4a1f [vm/ffi] Fix garbage collection of ffi.Pointer subtypes. 
Fixes https://github.com/dart-lang/sdk/issues/36125.

Change-Id: Ib9069d1e15684c785b86954ed8c14e5fdde35fec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95652
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2019-03-07 15:56:08 +00:00
Daco Harkes 2d3b1055d3 [vm/ffi] remove RuntimeError/Fail expectation from status files 
Change-Id: Iaff947c213ac6cff666202fca16b3775bcc10413
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95782
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-03-07 13:16:06 +00:00
Daco Harkes b71f6afd2c [vm/ffi] enable function stress test on macos 
Change-Id: I92f676ac6c9733123b7cccf4dc24cb723a2b0594
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95655
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-03-07 08:20:08 +00:00
Ryan Macnak 975cc65c17 [vm, interpreter] Implement interpreter stubs for IA32. 
Change-Id: I7bb7e51cb46868abcc10c7dcc7cbf1db1ccdc35c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95264
Reviewed-by: Régis Crelier <regis@google.com>
 2019-03-06 21:09:30 +00:00
Daco Harkes 7a98559781 [vm/ffi] make Pointer.toString() uniform on all operating systems 
Change-Id: I805c8b3c56a18a253c5005945cab47d5a6aa26cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95648
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
 2019-03-06 16:48:09 +00:00
Samir Jindel a85e481d3d [vm/gardening] Fix status file for entrypoints_verification_test. 
Fixes https://github.com/dart-lang/sdk/issues/35957

Change-Id: I215538cfa8dcda733bf29aaa3fa2a73817663bb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95646
Commit-Queue: Samir Jindel <sjindel@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2019-03-06 13:56:36 +00:00
Johnni Winther ea6e83004b Use @pragma instead of package:meta/dart2js in tests 
Change-Id: I16c0ed6f391a417d8faa55e68cde902d91e3db32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95220
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-06 08:32:05 +00:00
Bob Nystrom 57f16820cd Add tests for "await" inside spread, if, and for. 
These don't try to comprehensively cover every interaction of async
and the new syntax, but they should test that an implementation handles
an await appearing in all the various places in the new syntax where an
expression is permitted.

Change-Id: I4852815002fcad6697f3bad4103693b1d4288d06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94121
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-03-06 00:10:04 +00:00
Samir Jindel ed8357cf83 Re-land "[vm/ffi] Stress tests for FFI functions."" 
We will only run the tests on supported configurations. Issues are open
to expand coverage.

This reverts commit 1d3a0d5129.

Change-Id: I28d90f36a97914dc0cb04c39046cb4bdafe1740b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95023
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-03-05 14:17:08 +00:00
Johnni Winther 204651f3ab Replace package:expect annotations with @pragma 
Change-Id: Ib43d0d71a3ee8b0f0e6d676e6a3e448a107b7ca5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95180
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-05 11:00:17 +00:00
Aske Simon Christensen 99093c0610 [fasta] Required but not inferred constant context. 
Add a new kind of constant context in the body builder for expressions
that must be constant but where constness is not inferred.

This context is used for parameter default values and initializing
expressions for non-final fields in classes containing at least one
const constructor.

Fixes https://github.com/dart-lang/sdk/issues/34191

Change-Id: I200ca88586b19335b185dad0839dfad4eef1f75f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93520
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-03-05 09:23:57 +00:00
Aske Simon Christensen 822ebdd1e0 [fasta] Wrap non-const variable accesses inside const expressions. 
Change-Id: I8761031da2419a47a947a02721d4ffd86ac7c531
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93504
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-03-05 09:23:57 +00:00
Johnni Winther 013cf68624 Replace js_helper annotations with @pragma 
@ForceInline is still used by dart:html, will be removed in a later CL.

Change-Id: I480325fe91cc6baefb17ead49f839442e023d441
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95160
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-05 08:56:18 +00:00
Jenny Messerly 5a8bdc7f34 [dartdevc] fix #36052, missing key in map should result in null 
Change-Id: Ic32fb8689fd2163e162b80ad4682e9b10ba4eaee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94920
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Auto-Submit: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2019-03-05 01:15:30 +00:00
Bob Nystrom b88e6dd910 Fix the type argument on the deep flattening spread test. 
Change-Id: Icba0904c88a18901c0a2d423a8ce7ab7af8413fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94941
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2019-03-04 19:20:53 +00:00
Sergey G. Grekhov 2c087433db [co19] DEPS and status files updated 
Change-Id: I75e42be513c65799bcb9332a5c4614c00461ec85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94283
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-04 15:35:31 +00:00
Johnni Winther 95cfa6c583 Support native class and js-interop annotations through ir constants 
Change-Id: I8e9deb1392dc98d958f13611a984e422b028265c
Reviewed-on: https://dart-review.googlesource.com/c/95032
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-04 08:40:15 +00:00
Régis Crelier c2a48ee065 [VM] Fix bigint left shift that could cause heap corruption when intrinsified. 
The size of the result digit array was not computed correctly.
When 64-bit intrinsics are used, one extra digit pair must be allocated.

Change-Id: Id3ca3a16ef24b598e44bf25221d400b9be71248a
Reviewed-on: https://dart-review.googlesource.com/c/94683
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-03-01 18:59:10 +00:00
Johnni Winther 9201b906ee Convert ir.Constant to ConstantValue 
Needed for passing the --enable-experiments=constant-update-2018 option to start working on ir.Constant nodes.

Change-Id: I4f3d8fa6a59ddbda1635fe2da64591bcffcb0f12
Reviewed-on: https://dart-review.googlesource.com/c/95030
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-01 18:46:00 +00:00
Dmitry Stefantsov 2c8f70cde3 [cfe] Add type inference for spreads in set literals 
Change-Id: I60250ec4ba7dba2381d84328095d38cf47b4ea8b
Reviewed-on: https://dart-review.googlesource.com/c/94548
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-01 15:17:13 +00:00
Johnni Winther ba4cfb8613 Initial computation of initializer complexity through the scope visitor. 
Change-Id: I2951624a0ad901c7c518b6e5d2f147dceae870cc
Reviewed-on: https://dart-review.googlesource.com/c/94382
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-01 08:37:12 +00:00
Alexander Markov 1d3a0d5129 Revert "[vm/ffi] Stress tests for FFI functions." 
This reverts commit b186a270e4.

Revert "[vm] Fix windows build after "[vm/ffi] Stress tests for FFI functions.""

This reverts commit 3dcc0c69a1.

Revert "[vm] Update status file for standalone_2/ffi/function_stress_test"

This reverts commit 9d609426b2.

Revert "[gardening] Skip ffi/negative_function_test on asan bot"

This reverts commit 223f407af5.

Reasons for revert:
1) timeouts on app-kernel-linux-debug-x64 bot when it
tries to deflake new tests.
2) crash dump archiving fails on vm-kernel-asan-linux-release-x64
when trying to archive crash dumps from these tests.

Issue: https://github.com/dart-lang/sdk/issues/36033
Issue: https://github.com/dart-lang/sdk/issues/36034
Change-Id: Ifa338fb96b490e8137a8aa6a4a62f4a6f9e6ea83
Reviewed-on: https://dart-review.googlesource.com/c/94963
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
 2019-03-01 01:37:09 +00:00
Alexander Markov 223f407af5 [gardening] Skip ffi/negative_function_test on asan bot 
This newly added test causes crash dump archiving to fail on
vm-kernel-asan-linux-release-x64 bot. This causes bot to fail
although the test failure was approved.

The test was added in b186a270e4.

Issue: https://github.com/dart-lang/sdk/issues/36033
Issue: https://github.com/dart-lang/sdk/issues/36034
Change-Id: I9ac201124db239d9c4bcce176c54e66cfdf1b54e
Reviewed-on: https://dart-review.googlesource.com/c/94961
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-02-28 23:44:49 +00:00
Brian Wilkerson 48ee388791 Fix a typo in a shared test 
Change-Id: I096e459ffeae70f944d03715081c3b9f653b01a6
Reviewed-on: https://dart-review.googlesource.com/c/94843
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-02-28 21:25:49 +00:00
Aart Bik a10b0d8763 [vm/compiler] LICM and CSE improvements 
Several improvements
(1) makes implicit control dependence of a null check
    explicit by means of data dependence (already
    done for bounds checks); also see the doc in
    runtime/docs/compiler/data_dep_for_control_dep.md
(2) improves CSE properties of various IL nodes
(3) allows LICM on invariant code that may-throw
    as long as the visible behavior is preserved

https://github.com/dart-lang/sdk/issues/35323
https://github.com/dart-lang/sdk/issues/34684

Change-Id: Icb4520a649da38eddc3d7c85af21427d3c64d22e
Reviewed-on: https://dart-review.googlesource.com/c/93822
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-02-28 19:29:06 +00:00
Samir Jindel 9d609426b2 [vm] Update status file for standalone_2/ffi/function_stress_test 
Change-Id: I15eba297fb13a57ea4a9cd70364916ceba20ee3a
Reviewed-on: https://dart-review.googlesource.com/c/94755
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-02-28 17:42:53 +00:00
Samir Jindel b186a270e4 [vm/ffi] Stress tests for FFI functions. 
Change-Id: I75251b92688b70b4d14eda7b1fddef0fe94c60fe
Reviewed-on: https://dart-review.googlesource.com/c/94384
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
 2019-02-28 16:40:36 +00:00
Johnni Winther 9a4c49f301 Update field analysis tests to prepare for eager initializer improvements 
Change-Id: Ie9611ed269a42be4d7c406739cf935d569d8606a
Reviewed-on: https://dart-review.googlesource.com/c/94297
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-28 10:32:06 +00:00