dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

19280 Commits

Author SHA1 Message Date
Daco Harkes 185c0f3e89 [gardening] status file entry for entrypoints_verification_test 
Issue: https://github.com/dart-lang/sdk/issues/35957
Change-Id: Ic2cfbe25718f1511bb1ae33b785ea9bdff910274
Reviewed-on: https://dart-review.googlesource.com/c/93405
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2019-02-15 09:16:50 +00:00
Ryan Macnak 0e62060be4 [test] Mark standalone_2/io/arguments_test as failing due to a bug in the test harness. 
Change-Id: Id1e445f61b4421d1a43e31bcb4e2a455129c5e40
Reviewed-on: https://dart-review.googlesource.com/c/93380
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-02-15 01:36:51 +00:00
Samir Jindel 3b2144fa93 [vm] Respect entry-point annotation on constructors during obfuscation. 
Change-Id: Ia61d582fb6dd647b8fcab051b57ff08682076d9d
Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-mac-release-simarm64-try, vm-kernel-precomp-win-release-x64-try, vm-kernel-precomp-obfuscate-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/93225
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-02-14 20:18:19 +00:00
Liam Appelbe 223eaa6fbb Report noSuchMethod forwarders as synthetic in the mirror api 
Fixes http://dartbug.com/34982

Bug: http://dartbug.com/34982
Change-Id: I0302586c5f0e58dd66e238bd32088ebe1c150c0e
Reviewed-on: https://dart-review.googlesource.com/c/93124
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-02-14 18:42:19 +00:00
Samir Jindel ae7bf9e999 [vm] Support closurization of methods through @pragma entry-points. 
Fixes dartbug.com/35720.

Also enable native extensions in AOT.
Increases Flutter Gallery snapshot size by 0.19%.

Change-Id: I1b24c3b9a49a13fd48452e9a89595516a7f01780
Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-mac-release-simarm64-try, vm-kernel-precomp-win-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/92283
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-02-14 17:47:28 +00:00
Samir Jindel a5d396cd25 [vm/extensions] Fix native extensions in hot-reload and running from snapshot. 
This is a re-land of "[vm/extensions] Fix Loader::ReloadNativeExtensions(...)."

The native extension test was failing in hot-reload: this has been fixed.

Change-Id: Ic18da8cfbc6a3dba8aac09d654dce616487a67d7
Reviewed-on: https://dart-review.googlesource.com/c/92800
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
 2019-02-14 17:47:28 +00:00
Martin Kustermann 4daabe69c3 [vm/gardening] Mark convert/base64_test/01 as flaky 
Issue https://github.com/dart-lang/sdk/issues/35948

Change-Id: Ib0358706e96ceda5d49d7a3496354eb903d8a40d
Reviewed-on: https://dart-review.googlesource.com/c/93223
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2019-02-14 16:42:48 +00:00
Daco Harkes 3abc7d34d7 [vm/ffi] Remove platform specific logic from DynamicLibrary.open 
Change-Id: Id69e17563c4d64f6ead5e143077a7364520f65a0
Reviewed-on: https://dart-review.googlesource.com/c/93173
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-02-14 16:08:28 +00:00
Sergey G. Grekhov 70e300fea0 [co19] DEPS updated 
Change-Id: I487933deef8968e2c82904a895ea948831fcd9ff
Reviewed-on: https://dart-review.googlesource.com/c/92700
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-02-14 09:02:50 +00:00
Nicholas Shahan 80798fad97 [tests] Add missing parenthesis on <list|map|set>Equals() calls 
Change-Id: I2d4fc114ad01ba075c644285d7e87b89570f626b
Reviewed-on: https://dart-review.googlesource.com/c/92661
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-02-13 23:51:37 +00:00
Daco Harkes 4510fa08ca [vm / library] reduce dart:ffi test recursion depth 
Change-Id: Iaa5ff60388398fcf5cf89b5e91e931f76f8f6572
Reviewed-on: https://dart-review.googlesource.com/c/93085
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-02-13 16:59:56 +00:00
Daco Harkes 76f531e742 [vm / library] dart:ffi status file entry for flaky dartkb crash 
Issue: https://github.com/dart-lang/sdk/issues/35935
Change-Id: I938bb508f5d320fc21500c6478a2f32bb4e6a673
Reviewed-on: https://dart-review.googlesource.com/c/93084
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-02-13 16:35:36 +00:00
Daco Harkes 0651c8c4fd [vm / library] dart:ffi status file entry for reload crash 
issue: https://github.com/dart-lang/sdk/issues/35933
Change-Id: I8d0d5f50ce65747aa8cfe7b36888d87173ea7b4b
Reviewed-on: https://dart-review.googlesource.com/c/93028
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-02-13 13:59:57 +00:00
Daco Harkes 4fa1e3a3ca [vm / library] dart:ffi status file entry for appjitk crashes 
Issue: https://github.com/dart-lang/sdk/issues/35934
Change-Id: I64475d76b1ad8687f1b48278b9e0e4adca2e4f7c
Reviewed-on: https://dart-review.googlesource.com/c/93030
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-02-13 13:58:11 +00:00
Daco Harkes 7d46d4b5cb [vm / library] Foreign function interface prototype 
Prototype for `dart:ffi` on Linux/MacOS x64 in JIT mode.
`dart:ffi` is experimental and its API is likely to change in the future.
Progress and design decisions are tracked in https://github.com/dart-lang/sdk/projects/13


issue: https://github.com/dart-lang/sdk/issues/34452
Change-Id: Ifa4566388e42c8757f154741d11e303465ef305d
Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-mac-release-simarm64-try, vm-kernel-precomp-win-release-x64-try, vm-kernel-mac-debug-x64-try, vm-kernel-asan-linux-release-x64
Reviewed-on: https://dart-review.googlesource.com/c/80124
Reviewed-by: Samir Jindel <sjindel@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
 2019-02-13 12:42:47 +00:00
Lasse R.H. Nielsen 671865cd1a Fix JSON parser. 
JSON parser was not rewritten when integers became fixed-size, so
some large integers could overflow silently and give the wrong
result, as could some doubles where the pre-decimal point digits
overflowed an `int`. Also added overflow protection for exponent.

Change-Id: I02941272c36fba4b9226e324936aebd4a5c5aa3b
Reviewed-on: https://dart-review.googlesource.com/c/91521
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-02-13 11:06:35 +00:00
Peter von der Ahé 857d834e64 Remove obsolete expectMoreSpecific parameter 
Change-Id: I6d5ff79ba0eec022812da14201fb30ae2625d355
Reviewed-on: https://dart-review.googlesource.com/c/92126
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-02-13 10:51:55 +00:00
Konstantin Shcheglov f841096701 Fix for crash if MixinDeclaration has a const constructor. 
R=brianwilkerson@google.com

Bug: https://buganizer.corp.google.com/issues/124304191
Change-Id: I78f07338c3ac4c254986fb2b19a00bb5fd4201b7
Reviewed-on: https://dart-review.googlesource.com/c/92860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-12 22:16:12 +00:00
Sigmund Cherem 6588eaf794 Fix calls to generator-bodies to correctly model elided parameters 
Bug: https://github.com/dart-lang/sdk/issues/35924
Change-Id: If4e2597c1e92f12675f537a1cfba4cb14f9551d8
Reviewed-on: https://dart-review.googlesource.com/c/92862
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-02-12 21:58:31 +00:00
Sigmund Cherem c507acfae4 Fix Js-interop factory calls which broke when eliding optional parameters. 
The issue derives from the fact that `parameterStructure` has only the preserved parameters,
however the SSA was emitting values for all arguments.

I fixed this by emitting all parameters. I also noticed that the parameter order should
probably be the native-ordering here as well (it doesn't matter for the factory, but it may
matter for other static native calls, if any)

Bug: https://github.com/dart-lang/sdk/issues/35916
Change-Id: I2e93c7f8e3baf5c9285107d23786bb3bf4f3a511
Reviewed-on: https://dart-review.googlesource.com/c/92626
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-02-12 18:53:43 +00:00
Nicholas Shahan d93ef933d5 [tests] Add 'spread-collections' flag 
Some of the new control flow collections tests are using the spread operator.

Change-Id: Id050025342692a5e3d88471840c4f0ca5cdab5da
Reviewed-on: https://dart-review.googlesource.com/c/92480
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-02-11 19:52:19 +00:00
Aart Bik 32603d5626 [vm/compiler] improve equality constant folding 
Rationale:
Static calls were formerly unexplored in our constant
folding. This is a first step towards making the
constant folder aware of semantics of recognized methods.

https://github.com/dart-lang/sdk/issues/35882

Change-Id: Id6e366f4d25f08a618931fc3c8a8c065f6358feb
Reviewed-on: https://dart-review.googlesource.com/c/92410
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-02-09 01:09:39 +00:00
Kevin Millikin be79eb4517 Ship experiment 'set-literals' 
Change-Id: Ief182017752b87ef099ac5140ff781cbb14d76a9
Reviewed-on: https://dart-review.googlesource.com/c/92125
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2019-02-08 16:17:55 +00:00
William Hesse 65ac1d08d9 Dartdevc co19 tests - skip co19_2 tests that time out 
Change-Id: Ibb27bda2462c673f2e3442fcb80c41ee5e62154a
Reviewed-on: https://dart-review.googlesource.com/c/92425
Reviewed-by: William Hesse <whesse@google.com>
 2019-02-08 13:33:41 +00:00
Johnni Winther 60527d7b97 Support computation of ResolutionImpact through ImpactData based on kernel 
This is a pre-step to modularizing the world impact computation.

Change-Id: I4f59f9767e7399fdcf9a070074864e6873b61a52
Reviewed-on: https://dart-review.googlesource.com/c/92044
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-08 12:02:33 +00:00
Johnni Winther 30d760e0c9 Add unittest of allocator analysis for the K model 
This is a prestep towards tracking initialization through field
initializers with the aim at discovering effectively constant instance
fields.

Change-Id: Iefc36382589e4fbe03e1bc4314230f62fb925b9a
Reviewed-on: https://dart-review.googlesource.com/c/92265
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-02-08 10:09:49 +00:00
Johnni Winther 45f55183c5 Refactor processing of pragma annotations 
Change-Id: I3d4efdab560557d5d9bbab748d003cd360efbe3d
Reviewed-on: https://dart-review.googlesource.com/c/92264
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-08 09:55:28 +00:00
Jenny Messerly 246430bc8c [dartdevc] wait for async callbacks to complete in tests 
This change ensures that DDC tests won't accidentally "pass", and then
silently fail or timeout later, when the async tests actually run.

Change-Id: Id18d3343e5dadcf266f39568a93381daf4c54e1c
Reviewed-on: https://dart-review.googlesource.com/c/92247
Reviewed-by: Mark Zhou <markzipan@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
 2019-02-08 01:30:58 +00:00
Aart Bik 9c0a73f943 [dart/vm] Skip finalization error for now 
https://github.com/dart-lang/sdk/issues/35885

Change-Id: I79a1c77459b1cf1cdae563cd6e29697e641a57ff
Reviewed-on: https://dart-review.googlesource.com/c/92385
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-02-07 23:38:08 +00:00
Aart Bik 5a7ecfbabe [dart/vm] Skip finalization error for now 
https://github.com/dart-lang/sdk/issues/35885

Change-Id: I4d46badddd211b859a7724c4030f83996a5877c9
Reviewed-on: https://dart-review.googlesource.com/c/92402
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-02-07 22:21:08 +00:00
Martin Kustermann 20f12ad874 [gardening] Re-add two status file lines after landing d05000af4d 
Change-Id: I38d6b618365353762b7dce3dbf588b0cbb1611f7
Reviewed-on: https://dart-review.googlesource.com/c/92291
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2019-02-07 18:07:54 +00:00
Martin Kustermann d05000af4d [gardening] Remove flaky markers and close issues for tests not appearing in flakiness dashboard 
Closes https://github.com/dart-lang/sdk/issues/28374
Closes https://github.com/dart-lang/sdk/issues/28502
Closes https://github.com/dart-lang/sdk/issues/29012
Closes https://github.com/dart-lang/sdk/issues/29111
Closes https://github.com/dart-lang/sdk/issues/29136
Closes https://github.com/dart-lang/sdk/issues/29324
Closes https://github.com/dart-lang/sdk/issues/29465
Closes https://github.com/dart-lang/sdk/issues/29524
Closes https://github.com/dart-lang/sdk/issues/33716
Closes https://github.com/dart-lang/sdk/issues/35012
Closes https://github.com/dart-lang/sdk/issues/35092

Change-Id: Ifa7a34646efadd92a86b4ae62c828e6adcec2c3a
Reviewed-on: https://dart-review.googlesource.com/c/92288
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-02-07 16:46:14 +00:00
Johnni Winther 33bc628235 Treeshake unread fields 
Change-Id: I188df5fd18163e5b32213a364d0fc163300db7b9
Reviewed-on: https://dart-review.googlesource.com/c/92130
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-07 09:58:19 +00:00
Johnni Winther c591454dd3 Inline unprovided optional parameters 
Change-Id: I61c82216965062feee8e01ba2533d0ea7c0052ef
Reviewed-on: https://dart-review.googlesource.com/c/90700
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-07 08:44:49 +00:00
William Hesse 392a869ee4 [infra] Skip all co19_2 tests that are timing out on dartdevc. 
The deflaking phase of testing is breaking when trying to handle
too many timing-out tests at once, stopping the builder runs.
Skipping them until we can debug the problem.

Change-Id: Id3243d8123465ca119262028dfe04d18d41b48c6
Reviewed-on: https://dart-review.googlesource.com/c/92139
Reviewed-by: Vijay Menon <vsm@google.com>
 2019-02-06 17:25:25 +00:00
Kevin Millikin 8f821d408e Fix status files for dartkp 
These expectations were for a stale version of the precompiled
runtime.

Change-Id: Ie4bafb50b89e76df4e782d240674968f078a6c6c
Reviewed-on: https://dart-review.googlesource.com/c/92135
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-02-06 13:38:21 +00:00
Kevin Millikin 6b73a02937 Fix status files for simarm and simarm64 
Change-Id: I965b0eef9566a5c35e3b94dbe2a5cd1f86eaa250
Reviewed-on: https://dart-review.googlesource.com/c/92133
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-02-06 13:16:00 +00:00
Kevin Millikin c2778062e7 Add UI as code status file entries for simarm 
Change-Id: I54076c4f0350e325729e780bbf0a191e46ca36cd
Reviewed-on: https://dart-review.googlesource.com/c/92127
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-02-06 12:02:18 +00:00
Kevin Millikin 2b8560f4b2 [Fasta] Add spread and control-flow collection flags 
Also stop skipping the corresponding tests.  Add status file entries
for Fasta and VM configurations.

Change-Id: Iecc1e048915df598ba69ac79261cfc836d38f95a
Reviewed-on: https://dart-review.googlesource.com/c/92045
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-02-06 10:30:18 +00:00
Kevin Millikin 0828d2c786 [Fasta] Implement exact types for Set literals 
Set literals have an exact type of Set<T> for some T.  An implicit
downcast to a subtype is a static error.

Change-Id: I922b078b1b9e595243520e73c7130c23fe91f454
Reviewed-on: https://dart-review.googlesource.com/c/91640
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-02-05 07:43:52 +00:00
Alexander Markov b59d5a2be9 [vm] Relax assertion about duplicated direct implementors 
When mixin application is transformed, mixin is added to the end of
interfaces list. This may cause assertion failure if the same class
is used as mixin and mentioned among implemented interfaces.
This CL relaxes that assertion for mixins as this duplication is very
rare and seems harmless.

Note that it would not be valid to remove duplicated interface/mixin
from the list of interfaces, as it would break dart:mirrors in this case:
dart:mirrors needs to reflect duplicated interface/mixin both in
ClassMirror.superinterfaces (which is populated from the
list of interfaces without last element) and ClassMirror.mixin (the last
element in the list of interfaces).

Fixes https://github.com/dart-lang/sdk/issues/35854

Change-Id: I9b986f7759a76cb6f963ebd837e9ea26f6242f8e
Reviewed-on: https://dart-review.googlesource.com/c/91961
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-02-05 00:35:02 +00:00
Alexander Markov 8231cdb7a3 [gardening] Update status for issue 35854 
Issue: https://github.com/dart-lang/sdk/issues/35854
Change-Id: Iea1fca6d203741cf7b7962c90c2170e91910a651
Reviewed-on: https://dart-review.googlesource.com/c/91960
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2019-02-04 22:53:42 +00:00
Alexander Markov 569ee07f91 [vm] Cleanup class finalization checks 
Change-Id: If262b5fd271ce8fa0aaa49959f808792f66578cd
Reviewed-on: https://dart-review.googlesource.com/c/90580
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-02-04 21:00:49 +00:00
Aske Simon Christensen 8a45b5eb57 Move environment handling into the front-end constant evaluator. 
Change-Id: Id01bad9d9dbb7d5f6104a0f633d8303fecfa29db
Reviewed-on: https://dart-review.googlesource.com/c/91227
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-02-04 13:31:30 +00:00
Johnni Winther e4b809f0e6 Add unit testing of (some) invoke dynamic specializers 
Change-Id: I7c3b100da899050a7eb234d53a70d235b3186675
Reviewed-on: https://dart-review.googlesource.com/c/91829
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-02-04 10:24:03 +00:00
Johnni Winther 0fd1679620 Sort named parameters in native methods by declaration. 
Change-Id: Ic4a7f9ad6cf0d362b6582a59c783cc05cc404a31
Reviewed-on: https://dart-review.googlesource.com/c/91828
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-02-04 10:02:23 +00:00
Bob Nystrom c4dcd85b3a Tests for control flow collections. 
Change-Id: I41050143611bdb816b5d91a6cd6f668536b613df
Reviewed-on: https://dart-review.googlesource.com/c/91600
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-02-02 00:34:01 +00:00
Johnni Winther 68d110ac2a Add test for codegen of optional parameters on native functions. 
Change-Id: Ice329d52be74f98653e5434b148b2b2c8f46c7d6
Reviewed-on: https://dart-review.googlesource.com/c/91661
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-01 09:23:55 +00:00
Bob Nystrom ec343169e7 Skip the spread tests on platforms that aren't using the new test workflow. 
These statuses should be more specific, but this should get the bots
green first.

Change-Id: Ifa734f74f866974332b2926398f2a01eb0707ac7
Reviewed-on: https://dart-review.googlesource.com/c/91767
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2019-02-01 00:30:38 +00:00
Bob Nystrom 9f8a9dc9f4 First stab at tests for "Spread Collections". 
I'm sure there's mistakes since I can't parse the tests, much less run
them, but I did my best.

Is there anything else you think we should add? I feel like the tests
around inference are weak, but I don't know what else would help.

Change-Id: If4b573acad4395310ad6fc3477861f8d28c16255
Reviewed-on: https://dart-review.googlesource.com/c/89085
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-01-31 22:09:15 +00:00