Commit Graph

25510 Commits

Author SHA1 Message Date
rnystrom@google.com 578c415134 Add logging system to pub and sprinkle some logging in.
We'll have to tune which things we log over time, but this covers
most IO operations which is where almost all of our problems come
from.

This patch also means that going forward you should no longer call
print() or printError() (which is gone) directly. Instead:

print() -> log.message()
printError() -> log.error()

That ensures all messages will correctly get added to the log's
transcript.

Review URL: https://codereview.chromium.org//11437019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15827 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:29:23 +00:00
nweiz@google.com 29318c2f5c Revert "Stop working around issue 6984."
Review URL: https://codereview.chromium.org//11464015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15825 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:09:19 +00:00
alanknight@google.com a6c56f84cb Create mock pub links for all packages under pkg, not a hard-coded list
Review URL: https://codereview.chromium.org//11444015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15811 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 22:09:34 +00:00
nweiz@google.com 01dd8fcb4e Stop working around issue 6984.
Review URL: https://codereview.chromium.org//11464006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15804 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 20:50:21 +00:00
alanknight@google.com 5df2b86dff Initial version of a serialization framework
Review URL: https://codereview.chromium.org//11293283

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15796 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 18:13:36 +00:00
nweiz@google.com 4ba4e92937 Handle OAuth2 AuthorizationExceptions in pub.
BUG=6950

Review URL: https://codereview.chromium.org//11416352

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15747 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-05 19:47:32 +00:00
nweiz@google.com 00780eb118 Make the oauth2 lib handle OAuth2 401 errors.
BUG=6813

Review URL: https://codereview.chromium.org//11316325

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15713 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-04 22:50:12 +00:00
nweiz@google.com 1855849da1 No longer work around issue 7013 and 7014 in pkg/http.
Review URL: https://codereview.chromium.org//11411327

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15657 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-03 21:14:07 +00:00
dgrove@google.com ab13795554 remove htmlescape.
TBR=efortuna@google.com
Review URL: https://codereview.chromium.org//11415241

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15610 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 23:04:17 +00:00
dgrove@google.com c5fa064ac4 Eliminate htmlescape package.
Review URL: https://codereview.chromium.org//11434063

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15609 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 22:57:34 +00:00
scheglov@google.com eef3848e9e Rollback removing Skip for DartC
TBR

For some reason this causes dart2js failures, but should not in theory.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11416298

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15607 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 22:36:51 +00:00
dgrove@google.com 33abe0ef0a Add authors and homepages to packages.
Review URL: https://codereview.chromium.org//11418267

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15601 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 21:16:01 +00:00
scheglov@google.com e6640e35eb Remove 'skip' status from some of the tests.
About 100 of them.
More 100+ tests could be added, but because of http://code.google.com/p/dart/issues/detail?id=5064 most of them fail.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11412280

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15599 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 21:11:41 +00:00
ahe@google.com 231fa25b3f Enable pkg/args_test on Dartium.
Review URL: https://codereview.chromium.org//11415225

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15583 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 12:44:46 +00:00
ahe@google.com e85ec5ce4a Fix package root deps to avoid cyclic dependencies when following symlinks.
Review URL: https://codereview.chromium.org//11316269

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15573 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 11:07:07 +00:00
nweiz@google.com 5c7323f35d Keep around a copy of the http.Request that triggered each Response.
Review URL: https://codereview.chromium.org//11348309

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15555 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 00:09:18 +00:00
nweiz@google.com 2c1d51db1c Make pkg/http use HttpClient.shutdown(force: true).
Review URL: https://codereview.chromium.org//11434018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15485 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 00:47:09 +00:00
nweiz@google.com 558ffd19bf Work around issue 6984.
This ensures that before an HTTP response is closed, its corresponding
request is drained of input.

Review URL: https://codereview.chromium.org//11348285

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15476 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 22:43:10 +00:00
nweiz@google.com 295a066707 Use Futures.forEach in http.
BUG=

Review URL: https://codereview.chromium.org//11411241

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15475 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 22:39:33 +00:00
nweiz@google.com 748bbee8e7 Add http and oauth2 as SDK packages.
Review URL: https://codereview.chromium.org//11419207

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15466 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 19:35:59 +00:00
nweiz@google.com 06e7344e22 Make #maxRedirects and #followRedirects work for the dart:io HTTP client.
Review URL: https://codereview.chromium.org//11414195

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15433 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 01:54:16 +00:00
blois@google.com 2688c60a05 Dartifying members.
Updating dart:html to generate members which follow the Dart naming guidelines.

BUG=4830

Review URL: https://codereview.chromium.org//11418075

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15405 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 17:38:23 +00:00
whesse@google.com 34771fb64c Clean up svn:ignore property and .gitignore in dart, dart/pkg, dart/runtime, and dart/samples.
Review URL: https://codereview.chromium.org//11421093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15392 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 14:07:53 +00:00
ahe@google.com d5337f6b1e Mark flaky tests as such.
Review URL: https://codereview.chromium.org//11348244

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15376 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 09:47:04 +00:00
scheglov@google.com 5d7261d837 Issue 6790. Support for '--name=value' options style.
http://code.google.com/p/dart/issues/detail?id=6790

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11411136

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15312 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 16:32:30 +00:00
scheglov@google.com 1277895b47 Issue 6836. Using undeclared identifier in static context is now warning.
http://code.google.com/p/dart/issues/detail?id=6836

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//11280135

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15311 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 16:18:35 +00:00
sgjesse@google.com 7805f03972 Generate an error for active connections when the HTTP client is shutdown
Before the underlying sockets where just silently closed causing no more IO events on active connections no matter what state they where in.

Also added an optional "force" argument to HttpClient.shutdown. If that is false (the default) The HttpClient will not close active connections until they are done. This causes all pkg/http and pub tests to pass.

R=ager@google.com, nweiz@google.com

BUG=dart:6594

Review URL: https://codereview.chromium.org//11411121

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15275 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-23 09:28:34 +00:00
lrn@google.com 22309b260c Remove NullPointerException.
Accessing non-existing members on null now throws NoSuchMethodError.
Throwing a null value fails by throwing a NullThrownError.
Methods checking for null now generally throw new ArgumentError(null).

Committed: https://code.google.com/p/dart/source/detail?r=15061

Review URL: https://codereview.chromium.org//11415028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15136 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-20 09:21:52 +00:00
nweiz@google.com 70e056e7ae Refactor http.Client and http.BaseClient to allow http.Client in type annotations.
Review URL: https://codereview.chromium.org//11308111

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15124 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 23:54:31 +00:00
nweiz@google.com 6b0b1fb262 Add TODOs about narrowing JSON catch clauses to the OAuth2 package.
Review URL: https://codereview.chromium.org//11308110

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15120 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 23:17:00 +00:00
nweiz@google.com a99dde64ec Fix OAuth2 tests, and disable them on non-dart:io platforms.
TBR

Review URL: https://codereview.chromium.org//11412083

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15116 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 22:38:44 +00:00
nweiz@google.com ed9a474a50 Add a package for authenticating via OAuth2.
Review URL: https://codereview.chromium.org//11420025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15115 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 22:23:33 +00:00
ahe@google.com 6535d87291 Skip pkg/args_test on Dartium.
We still need to set up a package-root for Dartium.

Review URL: https://codereview.chromium.org//11316078

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15083 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 14:08:44 +00:00
ahe@google.com 31d6cd05b7 Add dependency on make_links.py.
Review URL: https://codereview.chromium.org//11411064

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15071 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 11:39:03 +00:00
ahe@google.com f4ca9548c9 Allow tests to specify a package root.
Use a shared package root if none is specified.

Committed: https://code.google.com/p/dart/source/detail?r=15064

Review URL: https://codereview.chromium.org//11359187

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15070 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 11:35:57 +00:00
ahe@google.com 88a921030d Revert "Allow tests to specify a package root."
Revert "Add dependencies for bots that doesn't build everything."

This reverts r15066 and r15064.

Review URL: https://codereview.chromium.org//11414055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15068 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 10:42:55 +00:00
ahe@google.com adb2d591a2 Update status file because dartc doesn't implement --package-root option.
Review URL: https://codereview.chromium.org//11316075

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15067 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 10:37:23 +00:00
lrn@google.com 0c8dce77f1 Revert "Remove NullPointerException."
Crashes in the x64 VM.

Review URL: https://codereview.chromium.org//11417058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15065 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 09:59:59 +00:00
ahe@google.com 89cc5a2d23 Allow tests to specify a package root.
Use a shared package root if none is specified.

Review URL: https://codereview.chromium.org//11359187

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15064 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 09:51:17 +00:00
lrn@google.com e211c2f0ee Remove NullPointerException.
Accessing non-existing members on null now throws NoSuchMethodError.
Throwing a null value fails by throwing a NullThrownError.
Methods checking for null now generally throw new ArgumentError(null).

Review URL: https://codereview.chromium.org//11415028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15061 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 08:51:49 +00:00
nweiz@google.com f4e557d746 Move CurlClient to Pub so that it can access resources.
This CL also enables tests for the client on Linux and OS X.

Review URL: https://codereview.chromium.org//11299028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15047 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-17 01:15:45 +00:00
ager@google.com 3fb41705e5 Rename File.readAsText to File.readAsString. There is no Text type in Dart
and the methods return Strings.

R=sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//11412033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15011 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-16 13:10:15 +00:00
nweiz@google.com f1624e45a5 Make the HTTP MockClient work with GET requests.
Review URL: https://codereview.chromium.org//11293289

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14976 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-15 20:44:32 +00:00
sgjesse@google.com 8a948455a0 Revert "Re-enable test pkg/http/test/request_test Windows"
This reverts r14946

TBR=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//11348069

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14966 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-15 14:55:47 +00:00
sgjesse@google.com 3d83ee6059 Re-enable test pkg/http/test/request_test Windows
R=ager@google.com

BUG=dart:6594

Review URL: https://codereview.chromium.org//11348058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14946 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-15 08:25:40 +00:00
lrn@google.com 4a18bbf916 Remove deprecated exception classes.
Review URL: https://codereview.chromium.org//11360224

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14843 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 12:22:54 +00:00
ajohnsen@google.com ab69873a42 Make RegExp constructor non-const.
Another take of https://codereview.chromium.org/11410033/ with status changes applied for co19 tests.

BUG=

Review URL: https://codereview.chromium.org//11369210

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14837 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 10:18:06 +00:00
ajohnsen@google.com ec9fee9858 "Reverting 14829-14832"
BUG=

Review URL: https://codereview.chromium.org//11312203

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14833 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 07:28:13 +00:00
ajohnsen@google.com 8dc3edd7ce Make RegExp's constructor non-const.
BUG=

Review URL: https://codereview.chromium.org//11410033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14829 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 06:48:43 +00:00
nweiz@google.com 47393b62a0 Add an HTTP client based on Curl.
Review URL: https://codereview.chromium.org//11394003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14811 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-12 22:01:14 +00:00