d444060c32
Add explicit cast to avoid bug in analyzer.
...
Review URL: https://codereview.chromium.org//76233003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30405 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-19 12:22:48 +00:00
33ec174278
Combine unmodifiable_collection package into collection_helpers.
...
Avoids some duplicated code, and makes everything much simpler.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//70073003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30402 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-19 12:11:24 +00:00
8d3c15767b
Growable typed data buffers.
...
Like growable lists, but with typed data.
Added to package:collection_helpers.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//26695002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30396 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-19 11:32:35 +00:00
9d6ecc1505
"Reverting 30387"
...
There are some issues on IE with pushState, Event.returnValue, and styles. Strangely, http://todomvc.com/architecture-examples/polymer/index.html which this was ported from has none of these issues. :|
Review URL: https://codereview.chromium.org//76013002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30388 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-19 05:16:12 +00:00
773917fa80
Update TodoMVC based on https://github.com/polymer/todomvc
...
Other than the TodoMVC changes, this has 2 polymer fixes:
* removes incorrect linter messages
* fix issue 12434 -- external stylesheets did not work
port is of d33386ccd4c84cb5b89391bd958e97c5de7c2a01
R=sigmund@google.com
Review URL: https://codereview.chromium.org//60353013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30387 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-19 04:28:45 +00:00
2ab5f798a6
Resolve comments lazily and re-evaluate inherited comments for subclasses
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//63193006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30379 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 22:05:45 +00:00
308aae7ea0
Don't rely on a package having a library by the same name in order to associate a readme
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//73893006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30375 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-18 21:29:10 +00:00
9552f94822
Ensure that errors have stack traces attached.
...
This adds a stack trace argument to all [completeError] and [addError]
calls in pub and associated libraries.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//68493003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30332 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-16 01:19:39 +00:00
557d1d5062
Fix an analyzer error in http and barback.
...
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//62443006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30331 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-16 01:13:04 +00:00
69f1243709
Add a missing import to mac_os_watcher.
...
TBR
Review URL: https://codereview.chromium.org//68523020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30330 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-16 01:10:23 +00:00
205f55ad4a
Remove debugging prints from the Mac OS directory watcher.
...
R=rnystrom@google.com
BUG=15024
Review URL: https://codereview.chromium.org//63643008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30329 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-16 01:05:45 +00:00
1c828f6820
Fix the Mac OS directory watcher tests on the bots.
...
R=rnystrom@google.com
BUG=15024
Review URL: https://codereview.chromium.org//58903015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30328 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-16 00:54:50 +00:00
44f91e1401
Remove imports of mdv from stream examples
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//74063004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30327 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-16 00:39:28 +00:00
d018e7308e
Serialize binary barback assets using typed arrays.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//68103027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30324 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-16 00:09:30 +00:00
4cc0570ff2
pkg/unittest: remove overriding stack variable
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//58903013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30322 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-15 22:54:13 +00:00
b48f06fefa
Initial polymer_expressions benchmarks
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//73523004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30320 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-15 22:44:27 +00:00
baee87f63d
Work around issue 11901 in stack_trace.
...
For some reason, timer_impl.dart in dart:async has the incorrect URL
in VM stack traces. This adds manual handling for that in the
stack_trace package.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//63393004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30318 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-15 22:16:10 +00:00
78c89f7ad9
Add isWithin to pkg/path.
...
R=rnystrom@google.com
BUG=14980
Review URL: https://codereview.chromium.org//59483008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30317 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-15 22:05:14 +00:00
1bface13de
Re-mark directory_watcher/mac_os_test as passing.
...
As before, this test is expected to fail. It's only failing on the
bots so we need to get the debug information from the bots to figure
out how to fix it.
This also adds some additional debug information to help clarify some
confusing output from the most recent failing log.
R=rnystrom@google.com
BUG=15024
Review URL: https://codereview.chromium.org//64383004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30315 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-15 21:43:50 +00:00
ce5cdfac54
Change test expectations for pkg/template_binding_test.
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//71303006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30303 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-15 13:20:44 +00:00
9cdf6615f2
Mention that OAuth2 currently only works with dart:io.
...
R=rnystrom@google.com
BUG=7445
Review URL: https://codereview.chromium.org//61393004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30296 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 23:52:37 +00:00
22866f1284
Support root-relative paths on Windows.
...
On Windows, a leading slash in a path means that that path should be
relative to the current drive. So for example, `join(r"C:\foo",
r"\bar")` should return "C:\bar".
R=rnystrom@google.com
BUG=14918
Review URL: https://codereview.chromium.org//68503011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30295 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 22:50:41 +00:00
08c253a629
Remove use of deprecated mirror functions from Polymer.
...
BUG=http://dartbug.com/14931
BUG=http://dartbug.com/14878
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//68113022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30292 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 21:44:08 +00:00
f916163f94
update shadow_dom polyfill:
...
ShadowDOM is at revision cfd420b8334ceb0341c72b6d6d4fdc8f87dd68c3
observe-js is at revision 441f944c7fcde0fd75ef6a0bda4567ec38abd589
WeakMap is at revision 67bd3b198a131748c73cd274532d69692f1a8c24
platform is at revision d19a1b74a6fc29e8745ad2c8710bc57fb93d6d15
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//68113020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30282 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 18:44:11 +00:00
e7aab3f862
fix analyzer error
...
Review URL: https://codereview.chromium.org//72683004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30279 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 18:29:10 +00:00
c93868eaac
Make sure 'enumerate' changes when the underlying collection changes.
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//71353012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30278 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 17:52:23 +00:00
d6f7dc4586
Put flaky test pkg/directory_watcher/mac_os_test in status file.
...
BUG=dartbug.com/15024
R=vegorov@google.com
Review URL: https://codereview.chromium.org//62333023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30272 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 17:14:32 +00:00
e545ffef5d
Remove uses of Selenium and webdriver from test scripts.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//68213016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30269 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 12:30:35 +00:00
51f7a5feac
Don't rely on a sandbox directory for pkg/path PWD tests.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//68893017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30261 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 00:38:43 +00:00
ecbb2e99a2
Properly support UNC paths in pkg/path.
...
This treats the entire "\\server\share" component as the root.
R=rnystrom@google.com
BUG=7323
Review URL: https://codereview.chromium.org//59133009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30257 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-13 23:00:50 +00:00
b1b03df203
Have pkg/path track the current working directory if it changes.
...
R=rnystrom@google.com
BUG=11100
Review URL: https://codereview.chromium.org//58903005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30256 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-13 23:00:30 +00:00
e7ba1a8663
Roll forward r30205.
...
Unlike previous versions of this CL, the debug info will only be printed when
running directory_watcher/mac_os_test, so it won't break the pub bots.
R=rnystrom@google.com
BUG=15042
Review URL: https://codereview.chromium.org//71353011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30254 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-13 21:56:52 +00:00
85bc44d154
"Reverting 30205"
...
Review URL: https://codereview.chromium.org//69863003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30217 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-13 03:03:33 +00:00
eca75496b9
Filter only .html files in web, keep those in lib/. This is as a temporary
...
solution for dartbug.com/15038. Once dartbug.com/14187 is fixed, we can remove
this extra check.
Note: because anything in lib/ is copied under build/packages/foo, I noticed
that the editor will not display any warnings there (they are considered the
same as warning from other packages). So even with this new filter, we still
achive our goal of keeping the build output warning free.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//70433003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30216 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-13 02:25:16 +00:00
5a33f0b1e8
Be sure we don't forward an error to a closed event stream.
...
R=rnystrom@google.com
BUG=15034
Review URL: https://codereview.chromium.org//68253010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30210 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 22:17:01 +00:00
03d5a89194
Add back Reflectable annotations.
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org//68133010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30208 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 21:23:16 +00:00
83ca26e7de
Properly detect whether we're running on a buildbot.
...
BUILDBOT_BUILDERNAME is only set for bots using annotated steps, which
isn't all of them. This detects whether the username is "chrome-bot"
instead.
This check is currently only being used to decide whether to use
unittest's compact VM config or the default config.
R=rnystrom@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//58933006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30206 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 20:32:16 +00:00
b58d984659
Add a bunch of debugging prints to the Mac OS watcher.
...
This reverts r30184, which in turn reverted r30181. It correctly detects whether
it's running on a buildbot in a way that will work for the vm-mac-release bot.
This is a temporary CL intended to help provide information about a test failure
that's only reproducing on the build bot. It will be rolled back as soon as
sufficient information is gathered.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//69933007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30205 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 20:08:41 +00:00
9d8ce37bfe
New analyzer snapshot.
...
Also insert empty lines between class and unit members.
Remove some more extra parentheses.
R=brianwilkerson@google.com , devoncarew@google.com
BUG=
Review URL: https://codereview.chromium.org//68233003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30203 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 19:33:57 +00:00
dba0abf95e
Make subclasses in packages have the right link. Sort by name.
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//68363003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30202 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 19:23:29 +00:00
c528bf9f9d
SDK constraint and README for barback.
...
BUG=https://code.google.com/p/dart/issues/detail?id=14862
R=jmesserly@google.com , nweiz@google.com
Review URL: https://codereview.chromium.org//63363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30200 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 18:57:17 +00:00
d0153d69b5
Mark pkg/watcher/test/directory_watcher/polling_test as flaky
...
R=whesse@google.com
Review URL: https://codereview.chromium.org//69153005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30194 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 13:32:34 +00:00
0a5afb6654
Revert "Add a bunch of debugging prints to the Mac OS watcher."
...
This reverts r30181. This CL causes the pub tests to fail due to excess output,
so I didn't want to leave it in the build overnight. In addition, it didn't seem
to be working; no additional output was being printed in the tests. It's
possible BUILDBOT_BUILDERNAME isn't being set on vm-mac-release.
This also marks the directory_watcher/mac_os_test as flaky.
R=rnystrom@google.com
TBR
Review URL: https://codereview.chromium.org//68203008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30184 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 02:23:05 +00:00
f4533a552b
Add utility methods for sending non-form data in pkg/http.
...
R=rnystrom@google.com
BUG=8380
Review URL: https://codereview.chromium.org//65583004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30183 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 01:59:39 +00:00
ea9d92f3f4
Fix a synchronous event bug in futureStream.
...
R=rnystrom@google.com
TBR
Review URL: https://codereview.chromium.org//68713004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30182 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 01:56:18 +00:00
f289c34b8f
Add a bunch of debugging prints to the Mac OS watcher.
...
This should help debug the intermittent, difficult-to-reproduce issues
on the vm-mac-release bot.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//68293005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30181 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 01:43:38 +00:00
0a4fb91145
Properly close watcher streams during tests.
...
This also makes [futureStream] pass cancellations through to the underlying
stream, and adds the ability for it to return broadcast streams.
R=rnystrom@google.com
BUG=14943
Review URL: https://codereview.chromium.org//66293008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30180 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 01:42:00 +00:00
db4cfbd3bf
Work around a flake in the Mac OS watcher test on the bots.
...
Issues 14373 and 14793 were tag-teaming to cause no_subscription_test
to fail for the Mac OS watcher occasionally.
This also marks directory_watcher/mac_os_test as timing out, apparently due to
issue 14943.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//59143006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30174 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-11 21:26:11 +00:00
d7c3ee487b
Fix a typo in path_set_test.
...
I'd have sworn I fixed this in the orignal CL.
R=rnystrom@google.com
TBR
Review URL: https://codereview.chromium.org//67973003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30173 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-11 21:20:51 +00:00
28ef6879f5
Fix some analyzer warnings and hints in pkg/watcher.
...
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//69013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30172 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-11 21:02:06 +00:00
lrn@google.com