Commit Graph

25510 Commits

Author SHA1 Message Date
lrn@google.com a6d4c0b996 Code cleanup (mostly io lib and some http lib).
- Unused function removed,
- Make properties always appear before methods,
- Use dart idioms where possible.

BUG=
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//124753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31602 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 12:03:11 +00:00
kustermann@google.com fea1fe4570 Status file updates for PASSing tests
Review URL: https://codereview.chromium.org//127883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31599 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 09:38:38 +00:00
blois@google.com fcfba211c3 Disabling Angular tests while some reliability issues get worked out
Tests are failing intermittently. Also tests are taking ~1min each to compile and appear to be slowing down the bots quite a bit.
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//127343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31596 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 01:16:59 +00:00
rnystrom@google.com 247a436a58 I guess Linux doesn't iterate over folders alphabetically.
R=nweiz@google.com

Review URL: https://codereview.chromium.org//127033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31591 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 23:39:17 +00:00
terry@google.com 6d41224b82 Fixed single quote escaping
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//126063003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31578 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 21:32:07 +00:00
alanknight@google.com 4b6fb5546a Fix serialization doc bug, update to use class literals in a few more places
R=sethladd@google.com

Review URL: https://codereview.chromium.org//126383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31577 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 21:23:42 +00:00
rnystrom@google.com 288f99189b Don't test for file differences in the polling watcher.
The non-polling forms don't do this, so this makes the polling
style behave the same. It also has two important benefits:

1. On Windows, this avoids opening the files being watched.
   Since opening a file prevents it from being deleted on
   Windows, this causes the watcher to interfere with the
   files and leads to some flaky tests and buggy user
   behavior.

2. It saves some time and memory since we don't need to store
   the SHA1 for every file being watched.

BUG=http://dartbug.com/13026, http://dartbug.com/15431
R=nweiz@google.com

Review URL: https://codereview.chromium.org//122573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31574 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 21:09:58 +00:00
kevmoo@google.com 2c286cf7d0 pkg/http_server: fix broken test
R=sigmund@google.com

Review URL: https://codereview.chromium.org//126453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31573 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 21:03:18 +00:00
kevmoo@google.com 4f64d474ef pkg/http_server more virtual dir test cleanup
Preparing for https://code.google.com/p/dart/issues/detail?id=15893 fix

R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//120343005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31567 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 19:37:27 +00:00
pquitslund@google.com b8ce88220a Fix to handle loop variables not declared in the for.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//118333003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31554 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 17:02:08 +00:00
lrn@google.com 48b3b3a626 Add missing signatures for add and addAll to priority queue.
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//121583004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31541 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 13:10:07 +00:00
kustermann@google.com e2f93bdef1 Mark two samples as slow on the pkgbuild test suite
R=ricow@google.com

Review URL: https://codereview.chromium.org//125923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31540 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 12:50:20 +00:00
kustermann@google.com dc24212755 Added PkgBuildTestSuite (aka 'pkgbuild')
This CL adds
 - support for fetching dependencies via 'pub get' of samples/packages
 - support for building applications/samples via 'pub build' (or a custom
   build.dart file)
 - pkg/pkgbuild.status: Status files for all package checkouts/builds
 - the '--use-public-packages' option to test.dart
 - the CleanDirectoryCopyCommand, PubCommand, ModifyPubspecYamlCommand commands

The test suite can be executed with:
 $ ./tools/test.py -mrelease --use-sdk pkgbuild
 $ ./tools/test.py -mrelease --use-sdk --use-public-packages pkgbuild

R=ricow@google.com

Review URL: https://codereview.chromium.org//122443003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31535 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 09:36:27 +00:00
lrn@google.com 9701b33281 Add priority queue to package:collection.
R=ajohnsen@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//110483006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31532 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 07:58:57 +00:00
blois@google.com fb63b6ba9f Disabling some Angular tests in unchecked mode.
The tests require checked mode (some of them have an explicit check for checked mode).

TBR
BUG=

Review URL: https://codereview.chromium.org//125663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31530 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 01:42:47 +00:00
blois@google.com ba857ec76f Disabling Angular tests on everything except for DRT
Appear to be a lot of browser-specific failures, our test matrix is different than Angulars. So will need to investigate & fix a bunch of them.
TBR
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//115523009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31529 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 01:07:29 +00:00
blois@google.com 9d8df56a98 Adding Shadow DOM polyfill to Angular tests
Some of the Angular tests require shadow dom, so adding the polyfill to all of the HTML tests.

Updated files are:
 - pkg/pkg.status
 - third_party/pkg/update_angular.sh

All others are auto-generated.

BUG=15929
R=sigmund@google.com

Review URL: https://codereview.chromium.org//112953006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31527 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 00:43:48 +00:00
nweiz@google.com e2f1ff9e27 Work around issue 15920 in pkg/stack_trace.
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//112953004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31526 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 00:39:31 +00:00
blois@google.com 3779e0770e Adjusting test status for Angular
Working on the proper fix, just changing expectations for now.

TBR
BUG=

Review URL: https://codereview.chromium.org//120513006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31525 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 00:00:25 +00:00
nweiz@google.com 4ae3bbcf13 Update oauth2's dependency on http.
OAuth2 was upgraded to support the new HTTP API prior to the new
conventions for package versioning, and the upgraded version hasn't
been released yet.

R=rnystrom@google.com
BUG=15809

Review URL: https://codereview.chromium.org//98163005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31523 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 23:55:51 +00:00
alanknight@google.com 03f9261304 Update Intl version
BUG=
R=dgrove@google.com

Review URL: https://codereview.chromium.org//110893010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31522 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 23:39:11 +00:00
blois@google.com 9e35fd81c3 Adding Angular and dependent packages for testing
This adds Angular tests to run in Dart's test suite.

Notes-
 - All files under pkg/third_party/angular_test are auto-generated by update_angular.sh
 - All files under third_party/pkg/angular are from Angular sources (with the exception of REVISION)

Modifed / Created files:
 - third_party/pkg/update_perf.sh
 - third_party/pkg/update_route_hierarchical.sh
 - third_party/pkg/update_perf.sh
 - third_party/pkg/update_all.sh
 - third_party/pkg/update_di.sh
 - third_party/pkg/update_js.sh
 - third_party/pkg/update_angular.sh
 - pkg/pkg.status

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//124053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31518 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 23:09:58 +00:00
alanknight@google.com 4046f00b8a Add a LICENSE file
BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//125293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31514 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 22:28:44 +00:00
pquitslund@google.com ad48998e7e Formatter fixes (symbols, natives, function type aliases, oh my).
Last stragglers that make a run over the SDK go green (modulo patch files that is).

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//124863004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31513 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 22:22:53 +00:00
alanknight@google.com de473484ec Update intl pubspec for new analyzer version
R=dgrove@google.com

Review URL: https://codereview.chromium.org//121043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31507 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 21:35:19 +00:00
pquitslund@google.com bff4cb2a13 Formatter support for metadata.
As per the spec:

"Metadata can appear before a library, class, typedef, type parameter, constructor, factory, function, field, parameter, or variable declaration and before an import or export directive."

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//125253005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31502 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 19:15:08 +00:00
scheglov@google.com 9841d6b210 Remove debug output and copy java_io.dart into resources.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//115523004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31496 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 18:24:11 +00:00
pquitslund@google.com b85d86bb23 Function Decl formatter fixes (external and getters/setters) --- (dartbug.com/15914).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//102763007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31491 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 17:51:40 +00:00
vsm@google.com 5e3937addf Changes for Chrome 32
Once we're ready to switch ... some paths have changed from 31.

R=jacobr@google.com

Review URL: https://codereview.chromium.org//93933014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31486 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 17:12:25 +00:00
pquitslund@google.com 49d306b1e0 Formatter workaround for missing abstract keyword in ClassTypeAliases (dartbug.com/15912).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//125103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31484 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 17:11:36 +00:00
kevmoo@google.com a8dc1227be pkg/http_server: follow on to r31466
missed up one test, fixed whitespace

R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//102743004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31471 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 12:10:53 +00:00
ajohnsen@google.com 989f6e1d5d Fix Directory path in VirtualDirectory, so it always ends with a platform-specific seperator. That'll make sure Uri.resolve always works.
BUG=http://code.google.com/p/dart/issues/detail?id=15764
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//125003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31469 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 10:44:14 +00:00
kevmoo@google.com 3a73a2ed5c pkg/http_server: virtual dir test cleanup
...and test util tweaks

R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//124693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31466 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-05 22:21:16 +00:00
kevmoo@google.com e2607cff65 pkg/http_server: removed unused imports
R=sigmund@google.com

Review URL: https://codereview.chromium.org//123283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31464 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-04 04:05:11 +00:00
pquitslund@google.com 2f1411eada Fix and test for leading comment handling (dartbug.com/15876).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//109153006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31453 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-03 22:29:25 +00:00
pquitslund@google.com ec7d3bf800 Path fix for data-driving formatting tests.
R=brianwilkerson@google.com, kustermann@google.com

Review URL: https://codereview.chromium.org//119583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31445 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-03 19:40:53 +00:00
pquitslund@google.com 45ef7ffacc Style guide acceptance tests.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//119323005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31444 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-03 19:03:11 +00:00
scheglov@google.com 6acc230eb9 Attempt to fix VM build.
I need to be able to find SDK location both locally and on bot.

TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//119323009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31442 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-03 17:47:55 +00:00
brianwilkerson@google.com e3e5f44bad Capture and print times for the isInstanceOf method.
I'm not sure how to test these changes without re-running the translator, but I'll be happy to do so if someone can show me how.

Jaime: will it break anything to write an additional piece of timing information?

R=danrubel@google.com, jwren@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//123533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31441 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-03 17:28:27 +00:00
scheglov@google.com fb931a0028 New analyzer snapshot.
Without Angular.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//123763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31440 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-03 16:31:28 +00:00
sigmund@google.com 80a24e7d47 Remove <script></script> comment in dart.js, which would allow people to inline
the code in page. People playing with inlining scripts in HTML should load the
compiled code directly, but this doesn't hurt.

R=dgrove@google.com

Review URL: https://codereview.chromium.org//99943006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31434 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-02 22:38:45 +00:00
kevmoo@google.com 7082aea796 pkg/args: adding LICENSE file
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//121753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31391 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-27 19:03:22 +00:00
kevmoo@google.com 6809af473b flagging pkg/args and pkg/logging as dev+1
should be publishing with bumped version due to package constraint changes

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//102833012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31388 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-27 17:20:00 +00:00
kevmoo@google.com 9f551695e1 pkg/polymer: bumping build version, flagging dev release
Per Siggi's comments in https://codereview.chromium.org/103783005/

R=sigmund@google.com

Review URL: https://codereview.chromium.org//121563002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31384 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-27 16:14:41 +00:00
blois@google.com b0b5cd1ce5 Adding Angular's DI package & Dart unittests which test it.
The non-Angular files which are being modified with this CL are:
pkg/third_party/di/test/di_test.dart
third_party/pkg/README
third_party/pkg/di/update.sh

DI is sync'd to revision 297d20694808a060c5275235aa3399dce7b87943.

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//107003007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31361 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-21 00:16:13 +00:00
kevmoo@google.com d31141e045 pkg/polymer: remove css_lib dependency
Subsumes https://codereview.chromium.org/63693002/

R=sigmund@google.com

Review URL: https://codereview.chromium.org//103783005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31346 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-20 19:47:33 +00:00
lrn@google.com 1b4478e73c Add license to unmodifiable_collection pkg to be able to upload.
Review URL: https://codereview.chromium.org//110973004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31323 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-20 08:02:52 +00:00
lrn@google.com 30683bdc79 Fix typo in failure-branch of stream iterator test.
Also increment pkg/async version to fix broken first upload.

Review URL: https://codereview.chromium.org//94013005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31322 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-20 07:58:49 +00:00
sigmund@google.com 21df38fb55 Fix printing of compact_vm_config when test status change
R=nweiz@google.com

Review URL: https://codereview.chromium.org//101753006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31315 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-20 02:12:48 +00:00
nweiz@google.com 4b2a6bf2d5 Implement _UnorderedEquals in terms of _UnorderedMatches in pkg/unittest.
R=sigmund@google.com

Review URL: https://codereview.chromium.org//116273006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31314 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-20 02:05:07 +00:00