dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

25510 Commits

Author SHA1 Message Date
Danny Tuppeny 5ce5d697da Implement LSP code folding 
Change-Id: I2b076b1792c229cbbce610d7a195fa03eb29e6bd
Reviewed-on: https://dart-review.googlesource.com/c/89503
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-16 16:03:23 +00:00
Danny Tuppeny b47524d5b0 Ensure all unhandled exceptions are recorded on the server 
Change-Id: Ib88236d1fed67a9c482be639d15fd7586375482c
Reviewed-on: https://dart-review.googlesource.com/c/89510
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-01-16 15:49:45 +00:00
Peter von der Ahé 8ba2de2344 Sort context for conflicting inherited members 
Change-Id: I3a1893c6ea268b4bb1518aa8f098b3524aa4f1ba
Reviewed-on: https://dart-review.googlesource.com/c/88957
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2019-01-16 15:46:22 +00:00
Kevin Millikin 215f6620e7 [Kernel] Signal errors on static fields in constant contexts 
Fasta allows some non-const static field access in constant contexts
which leads to the constant evaluator trying to evaluate them.  Signal
an error instead of crashing.  This will double-report errors for the
cases that Fasta already catches, and we should fix that
double-reporting.

Fix unbounded recursion in printing unevaluated constants (writeNode
called visitUnevaluatedConstant which called defaultConstant which
called writeNode...).

Fix a spurious trailing comma in printing of instance constants.

Change-Id: Idff3169a3a56432ad67c27ff9c267ef355c4c1dc
Reviewed-on: https://dart-review.googlesource.com/c/89514
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-01-16 15:07:58 +00:00
Peter von der Ahé 9b5eabdaca Fix crash in color support 
Change-Id: Ibf1ad2a77ba5d1de3ae66ca64c43fe1b22a5da0a
Reviewed-on: https://dart-review.googlesource.com/c/89513
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-01-16 11:43:24 +00:00
William Hesse a533753bec Remove --fast-startup flag support from testing scripts and status files 
Change-Id: Icfb4aa228c0f13bf9fce25aeb7bacbf1e38497ee
Reviewed-on: https://dart-review.googlesource.com/c/89582
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-01-16 11:32:44 +00:00
Kevin Millikin 5f10aed19c [Kernel] Don't print static fields in instance constants 
Instance constants don't have any of the class's static fields, so we
should not try to print them.

Change-Id: Id52bf7c25c805a21cf3a48c58efe84a720d0d2dd
Reviewed-on: https://dart-review.googlesource.com/c/89508
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2019-01-16 10:34:33 +00:00
Peter von der Ahé bdb51e2837 Improve input path handling and remove extra schemas. 
Change-Id: I02a403284a2cc71cac908be4a7ec9f858cb5db47
Reviewed-on: https://dart-review.googlesource.com/c/89509
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2019-01-16 10:17:03 +00:00
Peter von der Ahé 0604110806 Reduce expectations on thrown exception 
Change-Id: Ic1421c7d3164c581d1f69f6c032edd6ca0b9f519
Reviewed-on: https://dart-review.googlesource.com/c/89504
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-01-16 10:17:03 +00:00
Johnni Winther 966e007b63 Pass CallStructure on dynamic and static use in ResolutionWorldBuilder 
This is a preparation for using the collected call structures to inline
optional parameters that are never passed a call sites.

Change-Id: I9603f931967cbab53e9593dc19b29ad3ce717fa3
Reviewed-on: https://dart-review.googlesource.com/c/89549
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-01-16 09:16:19 +00:00
Johnni Winther 3e7801294e Remove unneeded code in OrderedTypeSet 
* _supertypes was accidentally a multiset instead of a set, but is no
  longer needed (types.tail contains the same set)
* _reporter and reportMultiInheritanceIssue is no longer needed

Change-Id: Ic8310fe79f604a280938689a92c4868d8ed24ab4
Reviewed-on: https://dart-review.googlesource.com/c/89520
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-01-16 08:22:09 +00:00
Kevin Millikin 8a91948c03 [Kernel] Properly signal compilation errors for constants 
Instead of simply printing a message, properly signal a Fasta problem for
constant errors.  This causes 68 tests (presumably missing compile-time
errors) to start passing with --enable-experiment=constant-update-2018.

Change-Id: Ia9f1809305bbef7b4652ce49acf6fb9c18408207
Reviewed-on: https://dart-review.googlesource.com/c/89580
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-01-16 08:15:34 +00:00
Sam Rawlins 492df72739 Fix fasta test under windows 
Change-Id: If9db5a0a9d67aa2ae369aabef44a70da06d41ac2
Reviewed-on: https://dart-review.googlesource.com/c/89764
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-01-16 04:23:33 +00:00
Dan Rubel 4ec9dbf1d0 Add set literal spread collection parsing support 
Change-Id: I12f4675a3a034a82acc16c4d189b001d52c23039
Reviewed-on: https://dart-review.googlesource.com/c/89681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-01-16 01:48:36 +00:00
lambdabaa 2195a70249 Make sure that path is correct on all test platforms 
In CL https://dart-review.googlesource.com/c/sdk/+/89441 I added
assertions to check the elementUri for completion suggestions.
However, in the case of a file elementUri as in
local_reference_contributor_test.dart, we need to normalize the
file path for other operating systems (eg windows).

R=brianwilkerson@google.com

Change-Id: I88436fc3cf93aad98f072b4cd75d66217a3faabd
Reviewed-on: https://dart-review.googlesource.com/c/89761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-01-15 22:32:52 +00:00
Dan Rubel b55bc09f1f Add list literal spread collection parsing support 
Change-Id: I96098e35baf44660b3f7a49952fde64def9998c7
Reviewed-on: https://dart-review.googlesource.com/c/89680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-01-15 21:16:05 +00:00
Konstantin Shcheglov 4074ebd0a0 Partial implementation of the unified specification of definite assignment, type promotion, and reachability analysis. 
Tests marked with the "new test" comment would not pass without the
unified specification, i.e. with type promotion implementation that
currently works in analyzer, or definite assignment analysis that I
implemented earlier.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I9ba6fde991567e9a2761a7606af28ca1e260de54
Reviewed-on: https://dart-review.googlesource.com/c/89260
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-01-15 21:09:20 +00:00
Paul Berry a55b6fc183 Remove unused import 
Change-Id: Ibd8c23f691a68f5bea5964b10029b5d7bca53b38
Reviewed-on: https://dart-review.googlesource.com/c/89721
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-15 20:14:37 +00:00
Sam Rawlins 3154bb0d37 Stop using external deprecated members in front_end 
Change-Id: I3fa03de568f72bfc3adb46efcfa2b61b781c706b
Reviewed-on: https://dart-review.googlesource.com/c/89020
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-01-15 18:55:10 +00:00
lambdabaa ff06d233aa Set CompletionSuggestion.elementUri everywhere in analysis server that element is already being set. 
This CL is a follow-up to https://dart-review.googlesource.com/c/sdk/+/88428
which added a new, optional elementUri to the CompletionSuggestion type
in analysis server protocol. Here, we're aiming to set the elementUri
whenever we have that information readily available.

R=brianwilkerson@google.com

Change-Id: I6dcf8a4029928432a80fc02ed97ee614eb75d986
Reviewed-on: https://dart-review.googlesource.com/c/89441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-01-15 17:34:22 +00:00
Terry Lucas edca6169c1 Fixed a number of dart:html P1 issues. 
- Fixed HTML API's with callback typedef to correctly convert Dart function to JS function.
- Expose HttpStatus from dart:html
- Expose DomName ondblclick and dblclickEvent for Angular analyzer.
- Fixed removeAll should be Iterable<Object> to match Set's removeAll not Iterable<E>.
- Fixed a number of DataTransferItem, Entry, FileEntry and DiretoryEntry returning NativeJavaScriptObject needed type registered in DDC.
- Added ability to allow local file access from Chrome browser added -local in ddb.

R=vsm@google.com

Fixes #30278
Fixes #35484
Fixes #34318
Fixes #35510

Change-Id: Ide8c04716c54045e837781d489562f27b694b109
Reviewed-on: https://dart-review.googlesource.com/c/89340
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2019-01-15 17:21:50 +00:00
Danny Tuppeny ff5e5b6896 Regenerate LSP classes from spec + update README 
The README was missing some methods (recent additions?) and also not quite in the same order - this fixes that. Also re-generates the classes based on current spec (mostly comments updates, but also non-nullability for `targetSelectionRange`.

Change-Id: I0dd4e24daf51b659783058362339550ec46fa1c8
Reviewed-on: https://dart-review.googlesource.com/c/89641
Commit-Queue: Danny Tuppeny <dantup@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Danny Tuppeny <dantup@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-15 16:51:19 +00:00
Dan Rubel 21edbbbac6 Add spread collection token to scanner 
Change-Id: I1932d7c7fa6daba244ad2d93ddc7e2de18100fee
Reviewed-on: https://dart-review.googlesource.com/c/89600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-01-15 16:42:39 +00:00
Sam Rawlins 030fa85cea Fix windows tests 
Change-Id: I4e032684be2d07f663f9b0a32e133129bb1f1c7f
Reviewed-on: https://dart-review.googlesource.com/c/89562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-01-15 16:06:49 +00:00
danrubel 23b5aee978 Update dartfix NNBD to handle more situations 
This CL updates the dartfix NNBD implementation to skip types
in extends, implements, on, and with clauses
in addition to addressing comments in
https://dart-review.googlesource.com/c/sdk/+/89046

Change-Id: Ifa491ac3ffd2b2ef24b1e649c1355df65adefc13
Reviewed-on: https://dart-review.googlesource.com/c/89403
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-01-15 15:52:54 +00:00
danrubel fe6b384ff5 revise dartfix protocol version check 
Change-Id: I655773791189dd5cf133ade8a48ed39ff48b6345
Reviewed-on: https://dart-review.googlesource.com/c/89402
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-15 15:52:54 +00:00
Danny Tuppeny 61e81217f0 Update LSP status doc (rename is complete + tested in VS Code) 
Change-Id: Ifce985123efcfec658218c3a4fbe4b6a2102b0bc
Reviewed-on: https://dart-review.googlesource.com/c/89544
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-01-15 15:10:42 +00:00
Danny Tuppeny daead8dff8 Add test for LSP rename that edits multiple files 
Change-Id: I2132f63f75e7a910ebf9667d26e98598cea0e894
Reviewed-on: https://dart-review.googlesource.com/c/89540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-15 15:10:42 +00:00
Danny Tuppeny bdade89081 Improve testing of document versions in LSP renames 
Change-Id: Ibbf562d6a99d73c00fc17521eb8576da4c708c06
Reviewed-on: https://dart-review.googlesource.com/c/89522
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-15 15:10:42 +00:00
Aske Simon Christensen ecc1411685 Print constant table when printing libraries. 
Change-Id: Ia474f3ddbe23be14d40789b0587ceeee92813106
Reviewed-on: https://dart-review.googlesource.com/c/89548
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-01-15 15:10:33 +00:00
Peter von der Ahé 999c2a7582 Check for conflict with static members 
Change-Id: I7966f2211104b54bfa4f2b026ad8a706d3f2bd6c
Reviewed-on: https://dart-review.googlesource.com/c/88956
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2019-01-15 14:41:04 +00:00
Peter von der Ahé 3f44bd1bf9 Check for conflicts in mixins 
Change-Id: I5443508d8454b2c903b65e253ecda223485787ad
Reviewed-on: https://dart-review.googlesource.com/c/88945
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-15 14:41:04 +00:00
Peter von der Ahé aa59b20b4b Don't report conflicts twice 
Change-Id: I9dca391da6a2afc747fcf73656ab0224201cb097
Reviewed-on: https://dart-review.googlesource.com/c/88943
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-15 14:41:04 +00:00
Peter von der Ahé 3ef8c296bd Improve detection of conflicts with inherited members and setters 
Change-Id: Ifb2fc2ca2e3d812a8e2a56e4fc43c8cfd02f15d5
Reviewed-on: https://dart-review.googlesource.com/c/88942
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-15 14:41:04 +00:00
Peter von der Ahé 50fa633c4a Report InheritedMembersConflict correctly 
Notice that no conflict is reported when an inherited
setter is in conflict with an inherited member. This is
implemented in a later CL.

Before we would only use InheritedMembersConflict when merging
interfaces, but as the new test cases demonstrate, that's not
sufficient.

Change-Id: I690dde1b59499d3ee0967b3f118b0b3b58898442
Reviewed-on: https://dart-review.googlesource.com/c/88941
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-01-15 14:41:04 +00:00
Brian Wilkerson c25c30dc32 Remove some unused imports 
Change-Id: Icb593d0ab2d9044fe1b083c782cf504d6c519493
Reviewed-on: https://dart-review.googlesource.com/c/89443
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-15 14:26:24 +00:00
Kevin Millikin d9944433af [Kernel] Clean up error reporting in constant evaluation 
Make the constant evaluator take an explicit error reporter so we have
to opt in to using the "simple" one that reports errors in an ad hoc
way.  This is the start of a change to use Fasta-controlled error
messages throughout and eventually get rid of the simple error
handler, and to continue constant evaluation after the first constant
error.

Change-Id: If6b1801edab6063754b642cf4a603abf9d63103a
Reviewed-on: https://dart-review.googlesource.com/c/89501
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-01-15 11:34:42 +00:00
Danny Tuppeny 04131e7fa0 Implement some more LSP rename tests 
Change-Id: Idd0f3734b20f716d5e92f13c3a85f716c226fc5b

Typo

Change-Id: Ica50195f94f8c57be0e16edde75e6e287b45c06b
Reviewed-on: https://dart-review.googlesource.com/c/89365
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-01-15 08:58:13 +00:00
Sam Rawlins c54bc11770 Split DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE off; fixes #30084 and 
fixes https://github.com/dart-lang/linter/issues/1349

Bug: https://github.com/dart-lang/sdk/issues/30084
Change-Id: I4954b883c1baf019a62776fec108eac60960b22e
Reviewed-on: https://dart-review.googlesource.com/c/88881
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-15 03:25:27 +00:00
Konstantin Shcheglov 3a4294963c Resolve type names and set nullability for other types. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I72965d0072cab7e19453616b8aef88604ff7812d
Reviewed-on: https://dart-review.googlesource.com/c/89080
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-15 02:50:45 +00:00
Liam Appelbe df0671d664 [VM] Experimental flags in the dart CLI 
Blocked on https://dart-review.googlesource.com/c/sdk/+/88840

Bug: https://github.com/dart-lang/sdk/issues/35602
Change-Id: I72b1cf574c9cb3d1dac2fbd8dfeb0f3fd80e330e
Reviewed-on: https://dart-review.googlesource.com/c/89042
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-01-15 01:02:07 +00:00
Konstantin Shcheglov 387a644008 Issue 33930. Fix resynthesizing function typed field formal parameter types. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/33930
Change-Id: I81c14cf5edf67eaeb253daefce3b91f0002b36a2
Reviewed-on: https://dart-review.googlesource.com/c/89440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-01-14 22:08:01 +00:00
Sam Rawlins b58aa3bcb2 Add PubWorkspace, integrate it into ContextBuilder, and therefore fix sealed test 
Also add a superclass to BasicWorkspace and PubWorkspace, since the bulk of their
implementation is shared; Only find() and findPackageFor() need to be separate;
the package mapping and resolving can be shared.

Change-Id: I13932d6947d6dc28fc7223594e5bd2526f12f573
Reviewed-on: https://dart-review.googlesource.com/c/89167
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-14 21:36:49 +00:00
Kevin Moore a60a06ff7d Update pkg:expect to use @alwaysThrows annotation on fail functions 
Change-Id: I4e87b2044fe429b42d8e96213f415437a7f2d1da
Reviewed-on: https://dart-review.googlesource.com/c/89421
Commit-Queue: Kevin Moore <kevmoo@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2019-01-14 21:17:38 +00:00
Konstantin Shcheglov fafd3d0f18 Make bottom, dynamic, void types nullable. Add withNullability() method. Apply proposed substitution rules for type parameters. 
This is a portion of https://dart-review.googlesource.com/c/sdk/+/89080,
but only with types change, without resolution changes.

Change-Id: I41af50089974928e58fb32ecf6622076cd9e3d5b
Reviewed-on: https://dart-review.googlesource.com/c/89172
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-01-14 21:10:37 +00:00
Konstantin Shcheglov 7bac8e631f Issue 35551. Log more information to debug the issue. 
I don't know how to reproduce this issue.
So, I have to add logging to gather more information.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/35551
Change-Id: I6c7de530a76998697577bd088f74bd2e9ac79cc4
Reviewed-on: https://dart-review.googlesource.com/c/89420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-01-14 21:09:37 +00:00
Konstantin Shcheglov 957f3e239e Restore including transitive files into exception dumps. 
We need this data.
RE https://github.com/dart-lang/sdk/issues/35551

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I55e4a83f07eda618e857ac8a577c254a51a82219
Reviewed-on: https://dart-review.googlesource.com/c/89400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-01-14 20:04:39 +00:00
Jenny Messerly 9df4f42a2f [dartdevc] handle a null stack trace passed to async errors 
Under certain conditions, we receive a null stack trace passed to a then
callback of an awaited Future. If that happens, the original stack trace
is now recovered from the error object. This matches dartdevc behavior
prior to the commit f68ae70e8e, for this
case. Fixes #33331

Change-Id: I8a4a295bdde18d4339420a7ba6443d83d4e00abb
Reviewed-on: https://dart-review.googlesource.com/c/89060
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Auto-Submit: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2019-01-14 19:57:24 +00:00
Samir Jindel 4d77c7b3a6 [vm] Remove redundant type-checks from core libraries. 
In conjunction with previous revisions, this improves several Flutter microbenchmarks by 2-4%.

Change-Id: Ic864fd586dc57d87b80cebd6ceace0a8165fa82b
Reviewed-on: https://dart-review.googlesource.com/c/88702
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-01-14 19:56:37 +00:00
Konstantin Shcheglov 6c76fe21b5 Issue 25860. Fix for changeFile() directly after removeFile(). 
Reverts 561d892d29

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/flutter/flutter/issues/25860
Change-Id: I2a7d725d3637754c096b088c85e862ec2917dc71
Reviewed-on: https://dart-review.googlesource.com/c/89380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-01-14 19:17:13 +00:00