a5d396cd25
[vm/extensions] Fix native extensions in hot-reload and running from snapshot.
...
This is a re-land of "[vm/extensions] Fix Loader::ReloadNativeExtensions(...)."
The native extension test was failing in hot-reload: this has been fixed.
Change-Id: Ic18da8cfbc6a3dba8aac09d654dce616487a67d7
Reviewed-on: https://dart-review.googlesource.com/c/92800
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Auto-Submit: Samir Jindel <sjindel@google.com >
2019-02-14 17:47:28 +00:00
69a952b195
remove parseSetLiterals flag from tests
...
Change-Id: I1b042f436c2c0dc96317df5d0bba535a9aa605fc
Reviewed-on: https://dart-review.googlesource.com/c/93126
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-02-14 16:38:09 +00:00
6a5c9597c6
Revert adding enclosingLibrary to ast.dart
...
Change-Id: Iacc24b512d1ff40bd54e37ba0ad0611fa46234b7
Reviewed-on: https://dart-review.googlesource.com/c/93169
Auto-Submit: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2019-02-14 15:49:08 +00:00
8333c8a4d0
Revert adding dart:ffi to devc libraries
...
Change-Id: I7d22c7fdff780ad6c1f302ae041865849be2f011
Reviewed-on: https://dart-review.googlesource.com/c/93170
Auto-Submit: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Samir Jindel <sjindel@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Samir Jindel <sjindel@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2019-02-14 13:58:48 +00:00
e9f239777f
Split test so Kernel ClassHierarchy isn't required
...
Change-Id: I61d860ac4b11b056545dc2ec4f5fe80bc055e49d
Reviewed-on: https://dart-review.googlesource.com/c/93166
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2019-02-14 13:38:38 +00:00
25ee9b9d47
Rename test
...
Change-Id: Iae6e583120cb16d9ceb624554037d31ddb13ac0f
Reviewed-on: https://dart-review.googlesource.com/c/93163
Reviewed-by: Jens Johansen <jensj@google.com >
2019-02-14 13:38:38 +00:00
837145a7c7
Properly restore state of _inConditionalControlFlow upon entering new function/method.
...
Each function and method starts in unconditional control flow. This
should allow more assertions to be recognized as demonstrating
non-null intent.
Change-Id: I5f6437a3009ebf6c91972e267c8a136a2b2fa77f
Reviewed-on: https://dart-review.googlesource.com/c/93129
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-02-14 12:58:09 +00:00
dfda06061a
Restore state safely in migration visitors.
...
When the migration tool is run in permissive mode, its visitors try to
catch exceptions and continue running. This means that when the
visitors make temporary state changes before recursive calls, they
have to restore the state inside `finally` blocks.
This should hopefully result in slightly saner behavior when running
the migration tool in permissive mode.
Change-Id: I46e07684526314befad860c4e065ec2c7f6d8b11
Reviewed-on: https://dart-review.googlesource.com/c/93127
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-02-14 12:58:09 +00:00
7ff5be0ceb
Convert LUB test to use type parser
...
Change-Id: I4833793fb12bb2ca5c0b0118bfc3bf525573f66a
Reviewed-on: https://dart-review.googlesource.com/c/93031
Reviewed-by: Jens Johansen <jensj@google.com >
2019-02-14 09:02:20 +00:00
92460b8923
Migration: use non-null assertions as a hint for parameters that should not be nullable.
...
Change-Id: I30d98fa28840dacb8df4fb038b49c491b347854f
Reviewed-on: https://dart-review.googlesource.com/c/93063
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-02-14 01:08:37 +00:00
46aa511b49
Improve the message when using a prefix to reference an undefined name (issue 35936)
...
Change-Id: Iae25bdffc992e0a50687ab54c56118cd13dfa26f
Reviewed-on: https://dart-review.googlesource.com/c/93121
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-02-13 23:37:37 +00:00
f4ec983fec
Migrate the rest of element_test from task model.
...
R=brianwilkerson@google.com
Change-Id: Iebc0b21b96ebef17503bf3ef672fbaf702144368
Reviewed-on: https://dart-review.googlesource.com/c/93142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-13 23:00:02 +00:00
94d8e730fb
Remove parser enableSetLiterals flag
...
Change-Id: I5e806f2e4a1dd368417802f7b4ff18bc1b4d0250
Reviewed-on: https://dart-review.googlesource.com/c/92843
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-02-13 22:57:12 +00:00
9b45c14c65
First stage cleanup of MapLiteral2 and SetLiteral2
...
Change-Id: I73ec2e6fa4509539f86dd906bcb411e6267c77aa
Reviewed-on: https://dart-review.googlesource.com/c/93143
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-02-13 22:51:57 +00:00
486238df49
Remove the UX experiment 1 flag from the Dart Analysis Server.
...
This work lead to https://github.com/JetBrains/intellij-plugins/pull/597 which will land in the Dart Plugin, 2019.1.x versions.
PR that introduced this experiment: https://dart-review.googlesource.com/c/sdk/+/75402/
Change-Id: Ia3c3a1e28da190346407504c35c57b98534d9a2c
Reviewed-on: https://dart-review.googlesource.com/c/93122
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2019-02-13 22:49:09 +00:00
9ca9e66c1b
[dartdevc] fix #35928 , type literals are now instantiated to bounds
...
This only affects the Analyzer backend; DDC+Kernel was already correct.
Change-Id: Ia388ce06e67b673c90dacbc36a5db710f0436859
Reviewed-on: https://dart-review.googlesource.com/c/92921
Reviewed-by: Vijay Menon <vsm@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Vijay Menon <vsm@google.com >
Auto-Submit: Jenny Messerly <jmesserly@google.com >
2019-02-13 21:22:37 +00:00
7a63d31151
Improve the message when importing a deprecated library (issue 35922)
...
Change-Id: Id37c87c0dc007a55c01dfabb2d3b4639f82ea9cc
Reviewed-on: https://dart-review.googlesource.com/c/93066
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-02-13 20:18:56 +00:00
30f9f5b1c7
Add SetOrMapLiteral to support the code-as-ui features
...
Change-Id: I6d3023855fea6da859af0815bfae6857f1546cb9
Reviewed-on: https://dart-review.googlesource.com/c/93062
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-02-13 20:14:24 +00:00
1c534d852c
Clean up the tutorial related to implementing a visitor
...
Change-Id: I04b4fc38ecb558edcc946b3fad122febec57ed2a
Reviewed-on: https://dart-review.googlesource.com/c/93065
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
2019-02-13 19:44:16 +00:00
7f2f840a91
Don't include constants of private enums.
...
R=brianwilkerson@google.com
Change-Id: I477db71282da118a74844c7c3d8d7c5b992d61b1
Reviewed-on: https://dart-review.googlesource.com/c/93067
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-13 19:41:06 +00:00
5d71308b78
[vm/tools] Don't duplicate "problems" metadata into split package files.
...
Add utility for enumerating libraries in a kernel binary.
Bug: MI4-1794
Change-Id: Iad65f236ef9d0d184323ffd2af92d311a97e525c
Reviewed-on: https://dart-review.googlesource.com/c/92865
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Zach Anderson <zra@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2019-02-13 19:16:36 +00:00
c92d5ca288
Migrate ClassElementImplTest from task model.
...
R=brianwilkerson@google.com
Change-Id: Idefac96fd017174f5de78e906b91273b9596f494
Reviewed-on: https://dart-review.googlesource.com/c/93100
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-13 19:14:26 +00:00
def7e2dac7
Migrate ConstantVisitorTest from task model.
...
R=brianwilkerson@google.com
Change-Id: I7822f13a4438e7460e136d56ad3b5abf6fd1b11d
Reviewed-on: https://dart-review.googlesource.com/c/92925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-13 16:43:41 +00:00
c8a2a7b719
[vm/ffi] Move FFI transformations from pkg/kernel to pkg/vm.
...
Change-Id: I8bc0c60ceb98ad88aca31934b6eaaf1e55128a10
Reviewed-on: https://dart-review.googlesource.com/c/93081
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Samir Jindel <sjindel@google.com >
2019-02-13 15:53:35 +00:00
d1bf6ae7d2
Track nonNullIntent in unconditional control flow.
...
In a future CL this will be used to prevent nullability from being
propagated into function parameters where it's clearly not intended.
Change-Id: I34430162db33f99e850ca2c11e5bca8736feb94f
Reviewed-on: https://dart-review.googlesource.com/c/93041
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-02-13 15:46:46 +00:00
13c4b160ba
Add migration tool support for bare "return;" statements
...
Change-Id: I10e2adeaf3c682ccac011b307c43052178b0974a
Reviewed-on: https://dart-review.googlesource.com/c/93040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-02-13 15:46:46 +00:00
809d8123d3
[vm] Add FFI library to more targets and Flutter file libraries.json (in patch).
...
Change-Id: I65421efbc708b5192f871a0dae5f739352c5c3d9
Reviewed-on: https://dart-review.googlesource.com/c/93080
Reviewed-by: Samir Jindel <sjindel@google.com >
2019-02-13 15:01:23 +00:00
cf5a7cf36a
Simplify class_hierarchy_test: Move tests of getLegacyLeastUpperBound to own file
...
Change-Id: Iff64676644f17c32dea2b01e0c25e92af1f63774
Reviewed-on: https://dart-review.googlesource.com/c/93024
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2019-02-13 14:35:15 +00:00
a92ddcf34b
Add package:expect/matchers_lite.dart
...
Change-Id: I671f317ee2c806380584646c75412762e549418e
Reviewed-on: https://dart-review.googlesource.com/c/93023
Reviewed-by: Jens Johansen <jensj@google.com >
2019-02-13 14:35:15 +00:00
0dfac95dac
Simplify class_hierarchy_test: don't use package:test
...
Change-Id: I68319c20230b1194ef372fed4526bfcbb3b50442
Reviewed-on: https://dart-review.googlesource.com/c/93022
Reviewed-by: Jens Johansen <jensj@google.com >
2019-02-13 14:35:15 +00:00
5bf0065b46
Simplify class_hierarchy_test: don't use package:test_reflective_loader
...
Change-Id: I4eb3678ddda2b020404fba9adcc658362df8ebfa
Reviewed-on: https://dart-review.googlesource.com/c/93021
Reviewed-by: Jens Johansen <jensj@google.com >
2019-02-13 14:35:15 +00:00
f954c0535c
Simplify class_hierarchy_test: remove abstract class
...
Change-Id: I805325a165a8d0540c3c839b656cc39fb898228a
Reviewed-on: https://dart-review.googlesource.com/c/92980
Reviewed-by: Jens Johansen <jensj@google.com >
2019-02-13 14:35:15 +00:00
a200ef3124
Don't include main in computeTransitiveClosure
...
Entry will do.
Change-Id: I2f70e389249b8c411ae24ec39b341044d58a226d
Reviewed-on: https://dart-review.googlesource.com/c/91823
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2019-02-13 14:15:05 +00:00
3196b87f10
Incremental compiler: Include right libraries when entry point is translated
...
Without this CL the incremental compiler could potentially return too
few libraries (or possibly 0 libraries):
If the entry point is translated to a package-URI and there is no main,
the entry-library when doing the transitive closure cannot be found and the
output will be no libraries.
If the entry point is translated to a package-URI and there is a main,
the entry-library when doing the transitive clusire is only found because
of the otherwise unneeded `mainMethod` parametesr.
This CL adds tests and fixes the problem.
Change-Id: Icea72eb892cb0d16f0d86e3729e29ce026fa7073
Reviewed-on: https://dart-review.googlesource.com/c/92430
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2019-02-13 13:26:37 +00:00
7d46d4b5cb
[vm / library] Foreign function interface prototype
...
Prototype for `dart:ffi` on Linux/MacOS x64 in JIT mode.
`dart:ffi` is experimental and its API is likely to change in the future.
Progress and design decisions are tracked in https://github.com/dart-lang/sdk/projects/13
issue: https://github.com/dart-lang/sdk/issues/34452
Change-Id: Ifa4566388e42c8757f154741d11e303465ef305d
Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-mac-release-simarm64-try, vm-kernel-precomp-win-release-x64-try, vm-kernel-mac-debug-x64-try, vm-kernel-asan-linux-release-x64
Reviewed-on: https://dart-review.googlesource.com/c/80124
Reviewed-by: Samir Jindel <sjindel@google.com >
Auto-Submit: Daco Harkes <dacoharkes@google.com >
2019-02-13 12:42:47 +00:00
bffa51efa2
Add ClassHierarchyBuilder.getKernelTypeAsInstanceOf
...
Change-Id: I81a1a139f9d18f0b07e0719a924f0952c1759790
Reviewed-on: https://dart-review.googlesource.com/c/92128
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2019-02-13 10:51:55 +00:00
857d834e64
Remove obsolete expectMoreSpecific parameter
...
Change-Id: I6d5ff79ba0eec022812da14201fb30ae2625d355
Reviewed-on: https://dart-review.googlesource.com/c/92126
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-02-13 10:51:55 +00:00
9c1b50b1aa
Copy inferred mixin application type arguments to builder hierarchy
...
Change-Id: I31e6e6e6d71fc7d3995c83ac3b11a03153d565a6
Reviewed-on: https://dart-review.googlesource.com/c/92124
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-02-13 10:51:55 +00:00
f815b4cba7
Add Loader.computeTypeBuilder
...
Change-Id: Ida90356e4675b95bdeebe2962aa7359e64c6bc93
Reviewed-on: https://dart-review.googlesource.com/c/92123
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-02-13 10:51:55 +00:00
a31a72521b
Don't include declarations of the library itself.
...
These declarations are already available through the library element
model.
R=brianwilkerson@google.com
Change-Id: I9d3d274a8bf4ad28c10f04afc30fa11436cd0f6a
Reviewed-on: https://dart-review.googlesource.com/c/92848
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-13 05:43:23 +00:00
f21fafd411
Migrate SimpleResolverTest from task model.
...
R=brianwilkerson@google.com
Change-Id: Icb45287e7f63f5139468eed5b84c45822f6da5ed
Reviewed-on: https://dart-review.googlesource.com/c/92846
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-12 23:14:22 +00:00
80e43c6a75
Remove the Modification class; use SourceEdit instead.
...
Change-Id: I7afca644ec761a201c490a711293ea6f2710b035
Reviewed-on: https://dart-review.googlesource.com/c/92847
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-12 23:00:03 +00:00
3e5a4f1a5d
Sort declarations in file inferred_type_test.dart
...
Change-Id: I07aaa0604477ec827cac9696832ca83649067c93
Reviewed-on: https://dart-review.googlesource.com/c/92845
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-02-12 22:23:51 +00:00
1e72e9c985
Fix tests now that set literal support is enabled by default.
...
Fixes #35870 .
Change-Id: Ie250961f12a720a4ffbfc114df55a18518bf0426
Reviewed-on: https://dart-review.googlesource.com/c/92864
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-12 22:23:51 +00:00
f841096701
Fix for crash if MixinDeclaration has a const constructor.
...
R=brianwilkerson@google.com
Bug: https://buganizer.corp.google.com/issues/124304191
Change-Id: I78f07338c3ac4c254986fb2b19a00bb5fd4201b7
Reviewed-on: https://dart-review.googlesource.com/c/92860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-12 22:16:12 +00:00
80c8848624
Support for enums in available suggestions, getDetails, boost relevance.
...
R=brianwilkerson@google.com
Change-Id: I24edb0266280f8f2b8312c7af66039d8b26fdc7c
Reviewed-on: https://dart-review.googlesource.com/c/92841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-12 22:15:41 +00:00
6588eaf794
Fix calls to generator-bodies to correctly model elided parameters
...
Bug: https://github.com/dart-lang/sdk/issues/35924
Change-Id: If4e2597c1e92f12675f537a1cfba4cb14f9551d8
Reviewed-on: https://dart-review.googlesource.com/c/92862
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2019-02-12 21:58:31 +00:00
3f96de7855
Cleanup intermediate control flow collection structures in AstBuilder
...
Change-Id: I8aed607943dea39e5fe393ddf5f5ca00eddb1b42
Reviewed-on: https://dart-review.googlesource.com/c/92840
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-12 21:48:28 +00:00
ca32bef641
Add migration support for the @required annotation.
...
If a named parameter is annotated as `@required`, then this overrides
the NamedNoDefaultParameterHeuristic; the parameter is considered
required regardless of what happens at call sites. A duplicate
`@required` annotation is not inserted.
Change-Id: Ib1385d0a65dd9001bb7abede9de2a319f65a1f86
Reviewed-on: https://dart-review.googlesource.com/c/92844
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-02-12 21:47:28 +00:00
8d5958bd9a
Migrate ErrorResolverTest.
...
R=brianwilkerson@google.com
Change-Id: I2593ca49a3c8b1a0281bcdc993628e11aa1bc7bf
Reviewed-on: https://dart-review.googlesource.com/c/92842
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-12 20:39:14 +00:00
Samir Jindel