dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

25510 Commits

Author SHA1 Message Date
Johnni Winther 204651f3ab Replace package:expect annotations with @pragma 
Change-Id: Ib43d0d71a3ee8b0f0e6d676e6a3e448a107b7ca5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95180
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-05 11:00:17 +00:00
Sigurd Meldgaard ca24e7aa10 [vm] Allow no main method when doing type flow analysis 
Change-Id: I97fce485ad1792766d34ad365b359b44c8aacb61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95385
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2019-03-05 10:38:38 +00:00
Aske Simon Christensen c769743f67 [CFE] Transform constants in annotations on all parameters. 
The constant transformer would only transform optional parameters,
since these are the only ones that can contain default values. This
caused it to miss annotations on required positional parameters.

Change-Id: I49bfc84a1a533cec87db557306fdeb3569156947
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93981
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-03-05 10:18:37 +00:00
Kevin Millikin 718b36ed73 [cfe] Use for-in instead of List.addAll for list spread 
The translation of `...e` into `list.addAll(e`) is not correctly
typed.  `List.addAll` requires its argument to have type `Iterable<E>`
where E is the list's element type.  Spread only requires that the
elements of e have type E.

Instead translate `...e` into `for (E elt in e) list.add(elt);`.

Change-Id: I9a5794048d33901a2b0dfae2e592a031d1155be8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95381
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2019-03-05 09:28:27 +00:00
Aske Simon Christensen 99093c0610 [fasta] Required but not inferred constant context. 
Add a new kind of constant context in the body builder for expressions
that must be constant but where constness is not inferred.

This context is used for parameter default values and initializing
expressions for non-final fields in classes containing at least one
const constructor.

Fixes https://github.com/dart-lang/sdk/issues/34191

Change-Id: I200ca88586b19335b185dad0839dfad4eef1f75f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93520
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-03-05 09:23:57 +00:00
Aske Simon Christensen 822ebdd1e0 [fasta] Wrap non-const variable accesses inside const expressions. 
Change-Id: I8761031da2419a47a947a02721d4ffd86ac7c531
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93504
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-03-05 09:23:57 +00:00
Johnni Winther 013cf68624 Replace js_helper annotations with @pragma 
@ForceInline is still used by dart:html, will be removed in a later CL.

Change-Id: I480325fe91cc6baefb17ead49f839442e023d441
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95160
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-05 08:56:18 +00:00
Jens Johansen 1a88421d39 Allow to change .package uri in incremental compiler 
Change-Id: Ic36fd000e2a3ea2870460b68821c7404f6e62a1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95140
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-03-05 07:39:31 +00:00
Jens Johansen 2695cdfbb1 Change incremental compiler to take entry points (plural) 
Change-Id: I03203cdeb11ab7bc6116779642909ebc7220c619
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95122
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-03-05 07:39:31 +00:00
Konstantin Shcheglov 3124125008 Move Flutter utility methods into a class, which can be instantiated either with regular package:flutter, or with package_flutter_web. 
The factory constructors does not yet choose one, will do in a
following CL.

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/36056
Change-Id: I7fabe9da571ea80ce993d9303217ccd8b085e8a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95283
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-05 05:51:41 +00:00
Jenny Messerly 5a8bdc7f34 [dartdevc] fix #36052, missing key in map should result in null 
Change-Id: Ic32fb8689fd2163e162b80ad4682e9b10ba4eaee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94920
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Auto-Submit: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2019-03-05 01:15:30 +00:00
Brian Wilkerson 643895befc Fix two failing tests on the bots (TBR) 
Change-Id: I607ae4c59b85e8720e1efbc1d60842168318d410
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-05 00:45:35 +00:00
Konstantin Shcheglov 24d28e8f48 Write SetOrMapLiteral instead of MapLiteral or SetLiteral. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ib02e203893c3945f17c9ea20486f3dd421d8e94d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95301
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-04 22:42:16 +00:00
Brian Wilkerson c86a9ece5f First cut at upward inference for the ui-as-code features 
Change-Id: I5d63e9433deed3baa1a2df44e04b57782da6c9b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95062
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-04 22:00:46 +00:00
Konstantin Shcheglov 2329fccdb9 Use visitForStatement2() and read as ForStatement2 and its parts. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I57dc7d816d9984a247b4c5e78f1f792230174604
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-04 21:52:20 +00:00
Mike Fairhurst a7a4c95df7 Summarize SetOrMapLiteral 
Change-Id: Ic0356500fc9381a05bc91fb8bd9bead877de01cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94348
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
 2019-03-04 21:47:21 +00:00
Paul Berry 1abcbe1318 Eliminate uses of old AST node types from parts of the analyzer 
This CL covers the following subdirectories:
- pkg/analyzer/test/util
- pkg/analyzer/test/src/summary
- pkg/analyzer/test/src/dart/resolution
- pkg/analyzer/test/src/dart/ast
- pkg/analyzer/test/src/dart/analysis

Change-Id: I2a04f348906501ef99ba6a3162d04efcbb64c235
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95262
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-04 21:21:24 +00:00
lambdabaa 1c27b817fc New protocol to inspect analysis server state at code completion time 
This change adds a new, experimental completion domain request
`completion.listTokenDetails`. Its purpose is to allow
other programs to observe and make smarter decisions contingent
upon analyzer's internal knowledge of a Dart program.

Bug: 36083
Change-Id: I5ab477221efeac076eccc873a29cf6feae91052e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95100
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-04 20:33:44 +00:00
Paul Berry 62df51cb34 Eliminate uses of old AST node types from parts of the analyzer 
This CL covers the following subdirectories:
- pkg/analyzer/test/dart/element
- pkg/analyzer/test/generated

Change-Id: If550fef4c625efca7a295d59fbe08f6b5be4407f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95261
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-04 19:19:13 +00:00
Paul Berry 7d8ffe0daf Eliminate uses of old AST node types from pkg/analyzer/lib/src/test_utilities 
Change-Id: I5cfa3aa36e97c2fcb0d3969f483c04763bbcc882
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-04 18:12:22 +00:00
Konstantin Shcheglov 2e463506b7 Read more nodes from serialized AST. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I1d271707fc8a7b8ea86a0051efe3429d689c70af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94992
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-04 17:44:41 +00:00
Paul Berry 819f44532c Eliminate uses of old AST node types from pkg/analyzer/lib/src/task/strong 
Change-Id: I2e0dabfcf15a150b52a84be803057a0a9ebeec1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95201
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-04 17:28:01 +00:00
Paul Berry 095e651ff2 Eliminate uses of old AST node types from pkg/analyzer/lib/src/services 
Change-Id: I5aefe213b22e9200aa2e3f24ae065ef9fc0f214c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-04 16:14:16 +00:00
Danny Tuppeny 15f1fc212c Add a flag to allow only analyzing project folders that contain open files 
Change-Id: I7239043292315871d77739858b8342c434ac837c
Reviewed-on: https://dart-review.googlesource.com/c/93430
Commit-Queue: Danny Tuppeny <dantup@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-04 10:29:16 +00:00
Aske Simon Christensen bc2b78886d [CFE] handle set literals in constant evaluator. 
Change-Id: I9dc5f7a3d2e7bc0f53e0370042bc59d688a8c4b3
Reviewed-on: https://dart-review.googlesource.com/c/95021
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-04 10:20:56 +00:00
Aske Simon Christensen 2b2e71770c [kernel] Add SetConstant node to Kernel. 
Change-Id: I83da1afc9f15009c650a871a51ca8171b482d4df
Reviewed-on: https://dart-review.googlesource.com/c/94863
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-04 10:20:56 +00:00
Johnni Winther 95cfa6c583 Support native class and js-interop annotations through ir constants 
Change-Id: I8e9deb1392dc98d958f13611a984e422b028265c
Reviewed-on: https://dart-review.googlesource.com/c/95032
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-04 08:40:15 +00:00
Johnni Winther 62d22083ac Flatten native member resolver 
Change-Id: I1bd775d23fd184f00232693549943c4082926564
Reviewed-on: https://dart-review.googlesource.com/c/95031
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-04 08:40:15 +00:00
Kevin Millikin 053dfbb2ac [cfe] Compile list spread elements into block expressions 
Change-Id: Ic869cbfb2f3dc13a56be771acf0e12df850ff3c6
Reviewed-on: https://dart-review.googlesource.com/c/94748
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-03-04 08:29:56 +00:00
Brian Wilkerson 1e0d514469 Address comments from a previous CL 
Change-Id: I2a0ba9ae0b7c6b1e6e72de6fee5ac2bc7dfc5598
Reviewed-on: https://dart-review.googlesource.com/c/94987
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-03-02 15:59:12 +00:00
Konstantin Shcheglov 156790474e Allocate fieldOffsets once, in computeFieldOffsets(). 
At this point we know exactly how many offsets we have, so we can
allocate it and avoid growing. This make writing large data structures
about 25% faster.

R=paulberry@google.com

Change-Id: I884b0e3633bb4ea19a41ef1ceefaf1b427d0389e
Reviewed-on: https://dart-review.googlesource.com/c/95044
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-02 03:20:51 +00:00
Brian Wilkerson 4a144e631f Fix production of outline for incomplete generic function types (issue 36059) 
Change-Id: Ie8e5279fb7b9094377197ee9d0f568f8baad3d10
Reviewed-on: https://dart-review.googlesource.com/c/95080
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-02 01:37:32 +00:00
Konstantin Shcheglov 4bd3e4b561 Write more AST nodes to summary. 
There are probably still some nodes missing, but with this we can
write resolved analyzer/lib/ and analysis_server/lib/.

Reading is still mostly unimplemented.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I3c2e8a61a1d0f3ce5fbe8307b52e2094bc96fcb1
Reviewed-on: https://dart-review.googlesource.com/c/95064
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-02 00:24:41 +00:00
Vijay Menon fa2d32e80a [ddc] Add api to query loaded libs 
Change-Id: Ib82292081b1e7c1b08af9b57f8c8a0aef16cd0d8
Reviewed-on: https://dart-review.googlesource.com/c/94990
Auto-Submit: Vijay Menon <vsm@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
 2019-03-02 00:16:41 +00:00
Jenny Messerly 5a335957f2 [analyzer] fix #33119, add strict-raw-types flag 
When the flag is enabled, warnings are issued for raw types, for
example `List`.

Raw types (those without explicit type arguments) are allowed if any
of these are true, otherwise they are reported:

- none of the type arguments are `dynamic`.
- the type was inferred from a downwards context.
- the class/typedef has `@optionalTypeArgs` from package:meta.

Change-Id: I1e70dba5b3bf6118b274bbf72843e3578dbaa8fd
Reviewed-on: https://dart-review.googlesource.com/c/75629
Auto-Submit: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-03-02 00:02:01 +00:00
Jenny Messerly 76d31a251e [dartdevc] fix hot restart static field reset 
Fields are not currently getting reset after the 2nd time, unless the
module is reloaded. This moves the tracking to initialized fields,
rather than defined fields, which is more difficult to clear.

Change-Id: Ie25c151d16872fd330798aa3b7fb7ab0d8d14fc1
Reviewed-on: https://dart-review.googlesource.com/c/95060
Auto-Submit: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2019-03-01 23:56:01 +00:00
Paul Berry 5f9bd87689 Eliminate uses of old AST node types from parts of the analyzer 
This CL covers the following subdirectories:
- pkg/analyzer/lib/src/dart/resolver
- pkg/analyzer/lib/src/dart/element

Change-Id: I3b20573b31b933936d1b541e7055ff21d2282288
Reviewed-on: https://dart-review.googlesource.com/c/94988
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-01 22:43:31 +00:00
Paul Berry 38d675287c Eliminate uses of old AST node types from parts of the analyzer 
This CL covers the following subdirectories:
- pkg/analyzer/lib/src/dart/analysis/dependency
- pkg/analyzer/lib/src/dart/constant

Note that some uses of MapLiteral and SetLiteral remain in these
directories to support cloning of old AST data structures.

Change-Id: I825ee8923f9d1a5a937f83293370c2628d28f590
Reviewed-on: https://dart-review.googlesource.com/c/95042
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-01 22:35:11 +00:00
Konstantin Shcheglov 298866ed94 Write / read resolved AST to / from flat buffers. 
AstBinaryWriter does not yet support all node types, but a lot of them,
and can successfully write many large Dart files, including itself.
Whether it does it correctly, we cannot say yet, because AstBinaryReader
supports much smaller set of node types. I plan to add all nodes in
following CLs, and run over larger bodies of code.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Iaa2a5c743bd1659ea30c93632028d3a475736bf5
Reviewed-on: https://dart-review.googlesource.com/c/94684
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-01 19:48:02 +00:00
Konstantin Shcheglov 863f7df7aa Include debug info when dart:core is not resolved. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/35226
Change-Id: I3064e1f2affae9b6fdd34b3740882cd06f293cba
Reviewed-on: https://dart-review.googlesource.com/c/94983
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-03-01 19:25:00 +00:00
Brian Wilkerson f00fe7a289 Rework of downward inference for the ui-as-code features 
Change-Id: Idfc815d976343a6ad015beaa6074ca5c979f8c3b
Reviewed-on: https://dart-review.googlesource.com/c/94700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-03-01 19:23:36 +00:00
Régis Crelier c2a48ee065 [VM] Fix bigint left shift that could cause heap corruption when intrinsified. 
The size of the result digit array was not computed correctly.
When 64-bit intrinsics are used, one extra digit pair must be allocated.

Change-Id: Id3ca3a16ef24b598e44bf25221d400b9be71248a
Reviewed-on: https://dart-review.googlesource.com/c/94683
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-03-01 18:59:10 +00:00
Johnni Winther 9201b906ee Convert ir.Constant to ConstantValue 
Needed for passing the --enable-experiments=constant-update-2018 option to start working on ir.Constant nodes.

Change-Id: I4f3d8fa6a59ddbda1635fe2da64591bcffcb0f12
Reviewed-on: https://dart-review.googlesource.com/c/95030
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-01 18:46:00 +00:00
Paul Berry 644026da51 Eliminate uses of old AST node types from AstFactory 
Change-Id: I6bfb37b9a1e1477a27e5a60ba6120876ae5ecb9d
Reviewed-on: https://dart-review.googlesource.com/c/94804
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-03-01 18:03:25 +00:00
Alexander Aprelev a681a6297a [vm/incremental compiler] Add reject/compile_expresson test for incremental compiler. 
Change-Id: I79fd20e89ad3b9b5372725d60ba3c2b2d7213944
Reviewed-on: https://dart-review.googlesource.com/c/94366
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Auto-Submit: Alexander Aprelev <aam@google.com>
 2019-03-01 17:15:00 +00:00
Dmitry Stefantsov 2c8f70cde3 [cfe] Add type inference for spreads in set literals 
Change-Id: I60250ec4ba7dba2381d84328095d38cf47b4ea8b
Reviewed-on: https://dart-review.googlesource.com/c/94548
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-01 15:17:13 +00:00
Dmitry Stefantsov b36c56ff84 [cfe] Add type inference for spreads in list literals 
Change-Id: I4076fe82a0b4c0780dc53cc51f9abba3b1d85e8c
Reviewed-on: https://dart-review.googlesource.com/c/94520
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-01 15:17:13 +00:00
Dmitry Stefantsov e4aa4325b7 [fasta] Enable spread collections in unit tests 
Change-Id: Id417704bdd15f8244f16fd61715f43910f678f7f
Reviewed-on: https://dart-review.googlesource.com/c/94541
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-01 15:17:13 +00:00
Aske Simon Christensen 1471b8e444 Revert "[CFE] Move constant evaluation number semantics handling to front end." 
This reverts commit c2b466b09f.

Reason for revert: Broke precompiled, DDC and others.

Original change's description:
> [CFE] Move constant evaluation number semantics handling to front end.
> 
> JavaScript number semantics is currently implemented as the simplistic
> version previously present in DDC. This is a starting point for fully
> detailed JS number semantics.
> 
> Change-Id: Id728b3dacec892a5cbf7ece0d9faea51427f5f9b
> Reviewed-on: https://dart-review.googlesource.com/c/94746
> Commit-Queue: Aske Simon Christensen <askesc@google.com>
> Reviewed-by: Sigmund Cherem <sigmund@google.com>

TBR=sigmund@google.com,askesc@google.com

Change-Id: I732c75b72df0e0f084ad2784349bee346ae5b7ed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/95027
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-03-01 14:34:15 +00:00
Jens Johansen 6e06047004 AST to Text more resilient in writeAdditionalExports 
Change-Id: If2a3e87f935e75421802358b028894a8fbb093d9
Reviewed-on: https://dart-review.googlesource.com/c/95025
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-03-01 14:24:53 +00:00