Commit Graph

25510 Commits

Author SHA1 Message Date
danrubel 7ec4621108 cleanup scanner configuration flags
* rename enableGtGtGt to enableTripleShift
* remove unused enableGtGtGtEq field

Change-Id: I0fa881c45619067ec3a292acbff984db555aa43e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2019-05-04 17:14:46 +00:00
Paul Berry 81ced1c9bf Make a separate file for tests of implicit_this_reference_in_initializer
Change-Id: I98838dee538158a3776cdeedc195d74f00ece9d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101323
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-05-04 14:50:26 +00:00
Paul Berry e5575ba64a In summary2/ast_resolver, get featureSet from enclosing unit
Change-Id: I6a40a1199c9ba25336b49f9ea1246178d627630b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101343
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2019-05-04 00:42:10 +00:00
danrubel 4679e6bf03 fix analyzer/ddc triple shift assignment
Change-Id: I7418f7bcfee2e198fc825e6d8f551a4824b8a4e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101223
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-04 00:00:39 +00:00
Alexander Markov 836ace6fcb [vm/bytecode] Avoid recalcualting class hierarchy for each dilp file
Compilation time in package-split mode with bytecode on a large app:
Before: 98 seconds
After: 37 seconds

Issue: b/131915611.
Change-Id: Ibc0ea460c9bb78d33441f91e977a914f97e8ce7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101325
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2019-05-03 23:34:28 +00:00
Nicholas Shahan e0e5c85f48 [dartdevc] Always print errors when running ddb script
This ensures that errors are printed to the console when running in node and the
main method is async. Previously errors were being swallowed because node exits
with exit code zero in this circumstance.

Other minor cleanup to remove unused variables, imports, and flags.

Change-Id: I1dac156bbe7aa204a6034cb56ef8e9353568d400
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101340
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
2019-05-03 22:24:18 +00:00
Jaime Wren 58ef1db2ba Enable the MOVE_FILE refactoring in the Analysis Server edit_domain.dart
Change-Id: I8859c6aa4144f4b5328c23a22b78e400706668c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Danny Tuppeny <dantup@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
2019-05-03 17:19:14 +00:00
Paul Berry 3f90f04a74 Prepare to publish analyzer 0.36.3
Change-Id: Ibe4fb287ff6774fa71fd9d5e5a67b0f3f8b8c530
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-05-03 16:57:54 +00:00
Paul Berry 3020127fc4 Change resynthesis test expectations to use new Function syntax.
This is necessary in order for resynthesis tests to be unambiguous in
the presence of NNBD, because with the old syntax, it wasn't clear
whether a type like `() -> int?` meant `int? Function()` or `int
Function()?`.  In a future CL, we'll make a similar change
FunctionType.toString().

Change-Id: Iedf6162de53c7fe57f858913d8e82faac17971c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101242
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2019-05-03 16:51:09 +00:00
Paul Berry 797e288796 Clarify how ParameterElement getters behave in the presence of required.
Change-Id: I6f3056669b6760667b2f6ffe158435af1b1fbbd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101243
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-05-03 14:34:39 +00:00
Paul Berry 974babb5f1 Remove named argument nnbd from summary testing methods.
These tests now use the FeatureSet mechanism to opt in and out of NNBD.

Change-Id: Id836833d4479e396e8db2b3646d28da339ed5674
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101076
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-05-03 14:29:41 +00:00
Paul Berry f3d8b420a0 Consolidate all NNBD enables in summary_common.dart.
Change-Id: I3cc0363f82674fd1a59ff0c3e2d11e46a72a0d4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101075
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2019-05-03 14:29:41 +00:00
Konstantin Shcheglov c38b65d2bc Use FreshTypeParameters from type_algebra with summary2.
FunctionTypeImpl.fresh() works in inscrutable ways, and does not work
correctly for synthetic FunctionType(s).

This change breaks 2 or 3 tests with summary2, because of using
FunctionTypeImpl.recoverTypeArguments() in ErrorVerifier
_checkForImplicitDynamicInvoke().

CheckerTest | test_implicitDynamic_function
CheckerTest | test_implicitDynamic_method

I prototyped a way to stop recovering type arguments some time ago.
https://dart-review.googlesource.com/c/sdk/+/98984

R=brianwilkerson@google.com

Change-Id: I0077e9d91663912cbd4f6c1bf0c2acea5a5056e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-05-03 14:26:34 +00:00
Konstantin Shcheglov f931d0e5ab Read bounds of function type type parameters.
R=brianwilkerson@google.com

Change-Id: Icdb0c2e0c02c8f1299d4cf3f6198c26c330f61f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-05-03 14:21:38 +00:00
Konstantin Shcheglov fb7137ba6f Fix isAbstract when MethodDeclaration is lazy.
R=brianwilkerson@google.com

Change-Id: Id03af715acdd446e5210f8fc4efbc0a2ca641fd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101202
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-05-03 14:13:33 +00:00
Konstantin Shcheglov f9b68f72f4 Fix copy-paste error with optionalNamed.
R=brianwilkerson@google.com

Change-Id: Ic657a6af242a4a279772f746aabc1c2596cfa904
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-05-03 14:10:23 +00:00
Vijay Menon 8866165950 [dartdevc] Reify bottom as Null
Fixes https://github.com/dart-lang/sdk/issues/36832

Change-Id: Ie0869ca350d1951e0736a9d6c92da4a7984117ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101180
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2019-05-03 13:39:43 +00:00
Johnni Winther 102f4addda Include the static type in the receiver type of dynamic invoke
- and preserve the original receiver type information during type propagation updates.

Change-Id: I20087b282a3d018947043d7a3ab7c45f003eaee6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100966
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2019-05-03 07:52:22 +00:00
Konstantin Shcheglov 03776172c1 Read VariableDeclaration type during checking for implicitly typed.
R=brianwilkerson@google.com

Change-Id: Ide32d69775df15aa3524893734a11dc7299bdc72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-02 23:22:33 +00:00
Brian Wilkerson d5eba9b77d Remove error if a final field without initializer is marked as late
Change-Id: Ibc81d71bc6ec2d223583dcbcb39b2311a49eda0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101220
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-05-02 23:06:49 +00:00
Konstantin Shcheglov a43d36cdd9 Support for '===' and '!==' tokens.
R=brianwilkerson@google.com

Change-Id: I15edd0d2f34e4dd3e88960681c37bf469ee34472
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101079
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-02 21:56:00 +00:00
Jaime Wren ff0f2a6b2e Refactoring renaming of some tests in move_file_test.dart and sorting of the tests
Change-Id: I14d132c070b866da0a1373fc0f807f868f3024a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101078
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
2019-05-02 21:40:24 +00:00
Konstantin Shcheglov 0586be25a4 Read partOf directive metadata lazily.
R=brianwilkerson@google.com

Change-Id: Ida31471bde95b6693a357bcdf6aa94cc96eb587e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-02 21:37:25 +00:00
Paul Berry 0950a540d7 Convert summary_common.dart to triple-slash comment style
Change-Id: Ife2401515d2a755082a5021631880f8d79e637c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101074
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-02 21:37:18 +00:00
Paul Berry 14d548f239 Add a toString() method for FeatureSet
Change-Id: Ie15939d50410c7a9a4490a29e332be7d9bd5f0af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101073
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-05-02 21:30:43 +00:00
Paul Berry e25aefc8d6 Consolidate all NNBD enables in resynthesize_common.dart.
I elected not to provide an `sdkVersion` argument to FeatureSet for
these tests, on the grounds that if any new features are added to the
SDK before NNBD, we want to make sure that those features are
compatible with the NNBD summary behavior.

Change-Id: I62e383e903b5756dcbb8cb498e71c4e739731d3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101070
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-05-02 21:29:13 +00:00
Konstantin Shcheglov 48a7e24e39 Store lineStarts with units.
R=brianwilkerson@google.com

Change-Id: I570b172f6feae88c122536e4032860b7c9e01ebc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101077
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-02 21:08:34 +00:00
Konstantin Shcheglov 70e00c9a37 Handle ClassTypeAlias without valid Function.
R=brianwilkerson@google.com

Change-Id: Ibc160658b75f7d5a450548e12aa5dc96be674f06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101072
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-02 21:01:30 +00:00
Paul Berry a334395edf Switch to using FeatureSet in summary tests
Change-Id: I16b13a2509836485417013da48d5b1ae4c92f618
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101069
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-05-02 20:46:13 +00:00
Konstantin Shcheglov dd1ae4c2d8 Fix the order during building library scopes.
We should add local declarations to the export scope first.

R=brianwilkerson@google.com

Change-Id: I0f918be9ea16519c5670fb24236c85d1755f9eea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-02 20:13:50 +00:00
Jaime Wren 4a31d8b62b Additional tests in move_file_test.dart - the analysis server tests for the MOVE_FILE refactoring.
Change-Id: Icddbdf0da237b43af2513ec2407ec774218360f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101068
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-02 19:56:51 +00:00
Brian Wilkerson 3646be6fb5 Add a previously missed test and cleanup test names
Change-Id: I441c0ce4e636480c3e544a292a3620cbb4a745d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-05-02 18:00:59 +00:00
Konstantin Shcheglov 946c38d881 Build local elements for variable initializers.
R=brianwilkerson@google.com

Change-Id: Ice81c47a812ec2421cb6516b6fbec340ed239d22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-02 17:20:11 +00:00
Brian Wilkerson 5bac4d9b0c Reland "Add support for recording context information with analysis errors, with one example"
This reverts commit b9bf239c65.

Reason for revert: The angular and angular plugins have been updated so as to make this safe.

Original change's description:
> Revert "Add support for recording context information with analysis errors, with one example"
> 
> This reverts commit 6114435ea5.
> 
> Reason for revert: Broke angular and angular_analyzer_plugin
> 
> Original change's description:
> > Add support for recording context information with analysis errors, with one example
> > 
> > Change-Id: Iba1c48163ce264d85a68bcb9f70e5025a7cdbfbb
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100563
> > Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> > Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
> 
> TBR=scheglov@google.com,brianwilkerson@google.com
> 
> Change-Id: I275c6e4473de73199ea9b5e490379ba58aec1d43
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100628
> Reviewed-by: Paul Berry <paulberry@google.com>
> Commit-Queue: Paul Berry <paulberry@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ib1b7e63a459e63bcbf02f26bcf167ddad45295b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101004
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-05-02 17:07:03 +00:00
Konstantin Shcheglov 158a52ee3f Change the message for FLUTTER_REMOVE_WIDGET.
R=brianwilkerson@google.com

Bug: https://github.com/Dart-Code/Dart-Code/issues/1647
Change-Id: I6061e3432c267dad550e57789aea522cc8fb2d87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101006
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-05-02 17:00:53 +00:00
Brian Wilkerson 40a06c3a77 Implement the type Never
Change-Id: Icbf407bc19f602c8382946b1e735905cc165c59c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100993
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2019-05-02 16:31:23 +00:00
Paul Berry 4fd9312586 Convert session.dart to triple-slash comment style
Change-Id: Idb5120b19ed6737b7c41b97327876113f11829d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101065
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-02 16:31:03 +00:00
Konstantin Shcheglov af4bc38490 Fix for building named function types.
R=brianwilkerson@google.com

Change-Id: Idc0b192579db4189b0335b44d2468f87701b43fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101005
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-02 16:19:30 +00:00
Konstantin Shcheglov 6ac709a2d0 Infer mixin type arguments.
R=brianwilkerson@google.com

Change-Id: I089bd79c52fc345d1e51045221d02c2342dca0d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101064
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-05-02 14:29:51 +00:00
Johnni Winther 1577b95c93 [CFE] Substitute types in unevaluated as-expressions and instantiations
As expressions and instantiations lose the connection to the current type environment when put into an unevaluated constant expression. This leaves type variables unsubstituted when the expressions are lazily evaluated leading to invalid compile-time errors. This is avoided by substituting the type variable when creating the unevaluated constant. If the type variables are not substituted by concrete types, this is flagged as a valid compile-time error during the lazy evaluation.

Change-Id: I46264da4332ea1d5b783531d89a5e6f85b8f90e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100963
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-05-02 13:14:21 +00:00
Jens Johansen dcc157633d Offset from class when reporting errors on synthetic constructors
Bug: 36669
Change-Id: I11b5312e4023cd7368a4a3e36cff66398dadd69c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100960
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2019-05-02 06:57:43 +00:00
Konstantin Shcheglov 54f9835abf The function type might be null in GenericTypeAlias.
R=brianwilkerson@google.com

Change-Id: Ia7004239b42171a20e724d80c6f0c4c60b1173f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100986
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-05-02 03:53:44 +00:00
danrubel 1682b4aac5 replace parser language version comment processing
This CL removes duplicate language version processing from parser
now that the scanner does this work.

In addition...
- update parser tests to listen for languageVersion scanner event
- remove languageVersion field from CompilationUnitImpl and AstBuilder
- add Scanner.buildConfig for translating a FeatureSet into a ScannerConfiguration
- remove old language version parser tests
- cleanup parser nnbd tests

Change-Id: I6ead6a3ab6d5d424e9a7dfbf69da110e43c63982
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100990
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2019-05-02 00:55:43 +00:00
Konstantin Shcheglov 143ebf1c1c Compute default types for type parameters of GenericTypeAlias.
R=brianwilkerson@google.com

Change-Id: Ifbfa8e240b078285660b80fbb02914bc6666b753
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100985
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-01 20:06:39 +00:00
Konstantin Shcheglov 2209d8f0c0 Run VariableResolverVisitor during resolution.
R=brianwilkerson@google.com

Change-Id: I435cc99a249ea940631ea5ddcea5964cca7ddd1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-01 20:06:26 +00:00
Konstantin Shcheglov a7c0a75442 Disable DeclarationResolver tests with summary2.
R=brianwilkerson@google.com

Change-Id: I83ad273ba2a0862e659f407f5749e7ae11b507c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-01 20:06:05 +00:00
Konstantin Shcheglov f7b73e9c4b Read linked bundles from ByteStore.
R=brianwilkerson@google.com

Change-Id: I5be61a2d03c57d1b6bd7a765e50b235ef3f8af5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-05-01 20:05:59 +00:00
Konstantin Shcheglov 2279d88f1f Pass CompilationUnitElement to LocalElementBuilder when building locals.
R=brianwilkerson@google.com

Change-Id: Ib3c3e7fc76e075eeb312b967948ca92b212b6cf2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100984
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-05-01 20:05:54 +00:00
danrubel a62ab22c48 remove languageVersionField and update scanner tests
Change-Id: I5fbb25d5f743fc00fe188da02390a67ded8b1c69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2019-05-01 18:01:19 +00:00
Brian Wilkerson 52608e3174 Convert more tests to DriverResolutionTest
Change-Id: Ib1c3018362f868626d788bc63ba33e5fe5900d8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101001
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-05-01 17:02:19 +00:00