dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

1421 Commits

Author SHA1 Message Date
Konstantin Shcheglov f575c099b0 Run all *_driver tests also with Kernel. (attempt #2) 
With previous changes that fix finding dart:core on Windows and
flakyness of reporting import errors, I'd like to reland this CL.

Attempt #1: https://dart-review.googlesource.com/c/sdk/+/7624

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: If5ab2c5ebe2204df6643ee42cbee5b49fb2d8c31
Reviewed-on: https://dart-review.googlesource.com/7961
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-24 18:27:27 +00:00
Konstantin Shcheglov 8e94406288 Remove DirectoryBasedSourceContainer and its test. 
This is the only test from pkg/analyzer/test/test_all.dart suite
that fails on my Windows machine. Given that the class has not been
used for ages, it is easier to remove it.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/21772
Change-Id: I110825f44915dde354af22e73e2d376231c08b0d
Reviewed-on: https://dart-review.googlesource.com/7943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-23 16:41:24 +00:00
Konstantin Shcheglov 3b632329f7 Fix source_factory_test to pass on Windows. (attempt #2) 
Attempt #1 was: https://dart-review.googlesource.com/c/sdk/+/7843

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/26828
Change-Id: Id5cb82883d25e5b51b8304cd152497535d7db48a
Reviewed-on: https://dart-review.googlesource.com/7940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-23 00:19:09 +00:00
Konstantin Shcheglov e929620072 Revert "Fix source_factory_test to pass on Windows." 
This reverts commit 11d2dfb915.

Reason for revert: There is still one failing test.
See https://build.chromium.org/p/client.dart/builders/analyzer-win7-release-be/builds/7264/steps/analyzer%20unit%20tests/logs/stdio

Original change's description:
> Fix source_factory_test to pass on Windows.
> 
> R=​brianwilkerson@google.com, paulberry@google.com
> 
> Bug: https://github.com/dart-lang/sdk/issues/26828
> Change-Id: I368bbeb1f96c970192b2004685297acce2fddd69
> Reviewed-on: https://dart-review.googlesource.com/7843
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com

Change-Id: I4f4e2f9a0c34fed26726a1d48ab1068ca8b6e16b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/26828
Reviewed-on: https://dart-review.googlesource.com/7920
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-22 22:25:18 +00:00
Konstantin Shcheglov 11d2dfb915 Fix source_factory_test to pass on Windows. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/26828
Change-Id: I368bbeb1f96c970192b2004685297acce2fddd69
Reviewed-on: https://dart-review.googlesource.com/7843
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-22 20:56:58 +00:00
William Hesse 2274739c3c Revert addition of kernel tests to analyzer unit tests 
These tests have flaky failures on the buildbots and commit queue.
Revert "Run all *_driver tests also with Kernel."

This reverts commit d2f887e37b.

Revert "Adjusted status for analyzer/test/generated/strong_mode_kernel_test"

This reverts commit 055654e96d.

Revert "Made status for strong_mode_kernel_test broader (flaky)."

This reverts commit 824c3f56cc.

Bug:
Change-Id: I341762671efc31f168df2f5806653d9548bd43ae
Reviewed-on: https://dart-review.googlesource.com/7708
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-22 11:37:21 +00:00
Erik Ernst 824c3f56cc Made status for strong_mode_kernel_test broader (flaky). 
Change-Id: Ia5ee7c6a06b34959760aef6771d608ad4431ffeb
Reviewed-on: https://dart-review.googlesource.com/7705
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-22 10:06:22 +00:00
Erik Ernst 055654e96d Adjusted status for analyzer/test/generated/strong_mode_kernel_test 
See https://github.com/dart-lang/sdk/issues/30863 for further
information.

Change-Id: I54adc4956db294e00c019366a83af082c029aae4
Reviewed-on: https://dart-review.googlesource.com/7704
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-22 09:20:09 +00:00
Konstantin Shcheglov d2f887e37b Run all *_driver tests also with Kernel. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I92a0f5f2192c20276b166a9211ab1064bc6f2b82
Reviewed-on: https://dart-review.googlesource.com/7624
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-21 22:44:39 +00:00
Alexander Thomas 55f98fef95 Change status for flaky tests 
Bug:
Change-Id: I2544efc246ce285222aa569990f23106dcee4d09
Reviewed-on: https://dart-review.googlesource.com/7557
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2017-09-21 20:46:18 +00:00
Florian Loitsch 38bf70d7ac Use generic functions in zones. 
Migrated from https://chromiumcodereview.appspot.com/2893893002/

Change-Id: I0bd6dc1438eb1e6762e7760a08b5a760b07d4b10
Reviewed-on: https://dart-review.googlesource.com/4942
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
 2017-09-20 15:46:06 +00:00
Johnni Winther 6976262fa1 [gardening] Skip analyzer/test/generated/non_error_resolver_kernel_test 
Change-Id: Ia175864e0bfa19c86d56d5135a6197a9917bedff
Reviewed-on: https://dart-review.googlesource.com/6861
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-19 10:34:25 +00:00
Konstantin Shcheglov 44c43773c9 Attempt to fix Windows bots for non_error_resolver_kernel_test. 
TBR

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I2b764c7a5bf020f0983c1e9abb226091c888571b
Reviewed-on: https://dart-review.googlesource.com/6768
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-09-19 01:36:34 +00:00
Konstantin Shcheglov cd2d54e1f3 Mark non_error_resolver_kernel_test as failing on Windows. 
R=brianwilkerson@google.com

Bug:
Change-Id: Id52df29076684b47b98d532d61ba4671b93eb2a7
Reviewed-on: https://dart-review.googlesource.com/6647
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-18 19:24:49 +00:00
Konstantin Shcheglov f43c54ff22 Issue 30785. Fix for file URI on Windows in KernelContext. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/30785
Change-Id: Iacf9cda1f26a696a745802d14183d9f06e485324
Reviewed-on: https://dart-review.googlesource.com/6640
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-09-18 16:59:06 +00:00
Karl Klose 5bfb095aa6 Mark analyzer unit test as failing on Windows 
R=whesse@google.com

Change-Id: I4c20ca6aef3057a14e4930725dca80a13729a2c8
Reviewed-on: https://dart-review.googlesource.com/6468
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-18 13:06:46 +00:00
Konstantin Shcheglov 50c964b819 Add option for AnalysisDriver to use KernelDriver and KernelResynthesizer. 
Run NonErrorResolverTest_Driver tests with this option enabled.
We fail 163 out of 478 tests, or 35%.

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Iac6154a14a1357fe239b0140f9f66de792825693
Reviewed-on: https://dart-review.googlesource.com/6340
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-18 02:09:14 +00:00
Harry Terkelsen b7666dd327 dart2js: Remove lookup map support 
Change-Id: Id435dc0f54165285c0d291d2e1c984da92bfd22a
Reviewed-on: https://dart-review.googlesource.com/5284
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
 2017-09-12 20:16:12 +00:00
Ben Konyi 531fe49e94 Updated status file to expect lookup_map_test to pass on dart2js-jsshell. 
TBR=asiva@google.com
Bug:
Change-Id: Ib362b6dab5ce0bb34402e21a5a84e66dd924c0a7
Reviewed-on: https://dart-review.googlesource.com/4640
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-09 00:29:31 +00:00
Dmitry Stefantsov 0cf1f7685d Update status for front_end/test/mixin_export_test 
Commit 48503c8720 introduces test case
pkg/front_end/test/mixin_export_test.dart that passes on d8, but doesn't
work in browsers.  An issue is created for that (dartbug.com/30576).
This CL changes the status for the tests on browsers.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3008893002 .
 2017-08-30 12:00:57 +02:00
Sigmund Cherem f4f13fe561 Skip mixin_export_test when using --use-sdk 
Review-Url: https://codereview.chromium.org/3007793002 .
 2017-08-29 12:30:28 -07:00
Peter von der Ahé bf55954dd1 Ensure front_end test cases aren't mistaken for tests. 
Review-Url: https://codereview.chromium.org/3003403002 .
 2017-08-25 14:26:57 +02:00
Kevin Millikin bae72c382a Fix the script analyzer/tool/generate_files 
* The script had stopped working due to a pair of changes in Dart.
  First, building Dart no longer produces a packages directory to use
  as a package-root.

  Second, generated Dart files are now formatted and the formatting
  code relies on invoking Dart from the Dart SDK in order to find
  dartfmt.  (Specifically: invoking Dart from the build directory does
  not work because there is no dartfmt there, and invoking Dart via
  sdk/bin/dart from the SDK repository does not work because it is a
  shell script that invokes Dart from the build directory.)

* Enable the test that the generated summary code has not changed.

* Regenerate the generated summary code.

BUG=
R=paulberry@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2997703002 .
 2017-08-11 12:05:47 +02:00
Sigmund Cherem 8d4af85333 Remove use of cwd in d8 preamble 
Fixes #30279
BUG= https://github.com/dart-lang/sdk/issues/30279
R=sra@google.com

Review-Url: https://codereview.chromium.org/2993153003 .
 2017-08-07 15:54:08 -07:00
Sigmund Cherem c80402ab67 Update .status file after move of byte_store 
TBR=paulberry@google.com

Review-Url: https://codereview.chromium.org/2993853002 .
 2017-08-07 12:16:43 -07:00
Sigmund Cherem 62f4509aa0 Update status file for libraries_specification_test 
The test fails in `d8` for unrelated reasons.
TBR=paulberry@google.com

Review-Url: https://codereview.chromium.org/2995593002 .
 2017-08-07 10:09:12 -07:00
Siva Annamalai 53cf85abc8 Fix for issue 29819 https://github.com/dart-lang/sdk/issues/29819 when a 'dill' file is loaded directly into the VM, set mode to dart front end mode and use that when reloading files too, this ensures that we reload correctly. 
Adjust pkg.status to account for the hot_reload_e2e_test passing.

R=aam@google.com

https://github.com/dart-lang/sdk/issues/29819
Review-Url: https://codereview.chromium.org/2990833002 .
 2017-07-27 10:06:54 -07:00
Erik Ernst 94669b4811 Added status for d8 failures, cf. issue 30279. 
Review-Url: https://codereview.chromium.org/2988023002 .
 2017-07-27 16:08:51 +02:00
Bob Nystrom 796eb21071 Move the status file parser into its own package. 
This required munging a bit of test.dart code too to tease out some
dependencies, but the changes are minor. I considered moving all of
test.dart out into a package and making the status file library a
public one that other packages in the repo could import but this seemed
like the less intrusive change.

R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2984203002 .
 2017-07-25 15:29:59 -07:00
Sigmund Cherem 0d49519988 Mark front-end analyze tests as passing again. Actual fixes were submitted in strong mode checker and dart2js (Fixes #30244) 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2990553002 .
 2017-07-24 17:33:32 -07:00
William Hesse 33f919f8c7 Update status for correct fasta test. 
Previous commit changed the status for the wrong test.

BUG=https://github.com/dart-lang/sdk/issues/30244

Review-Url: https://codereview.chromium.org/2989543002 .
 2017-07-24 15:26:08 +02:00
William Hesse 1bfcfa4560 Update status for failing tests 
Issues have been filed for these tests.

BUG=https://github.com/dart-lang/sdk/issues/30245
BUG=https://github.com/dart-lang/sdk/issues/30244

Review-Url: https://codereview.chromium.org/2991523002 .
 2017-07-24 14:18:09 +02:00
Siva Annamalai 000bec45ac Account for kernel files being passed in directly on the command line this fixes issue 30212 (https://github.com/dart-lang/sdk/issues/30212) 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2985563003 .
 2017-07-21 08:27:39 -07:00
Bob Nystrom 012774c78e Remove Dartium support from test.dart. 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2981223002 .
 2017-07-20 12:46:50 -07:00
Siva Annamalai 23e3f55188 Adjust status file for some fasta front end test which are failing (see issue 30212). 
Review-Url: https://codereview.chromium.org/2984663002 .
 2017-07-19 19:21:41 -07:00
Paul Berry 554c908082 Mark ast_builder_test as slow. 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2978133002 .
 2017-07-17 15:41:52 -07:00
Paul Berry 582e512051 Mark resynthesize_kernel_test as slow. 
This should fix the Windows analyzer bots.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2975293002 .
 2017-07-14 10:05:17 -07:00
Paul Berry c9b42f6a41 Remove the "kompile" mode of running the front end. 
This mode was needed in the early days of the front end when we were
contemplating the idea of building the analyzer AST representation of
code first, and then converting it to kernel.  Now that we build
kernel directly, it is no longer needed.

Further CLs will follow to remove code that is no longer used after
this change.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2980013002 .
 2017-07-13 10:52:55 -07:00
Sigmund Cherem b71bd543a9 Reapply "Tweak public APIs and use them in patch_sdk, dart2js, and kernel-service."" 
Original CL had a bug that wasn't visible unless you delete your
out/ReleaseX64/patched_sdk folder.

Patchset #1 is the original CL, patchset #2 shows the fix.

This reverts commit 4aadfe09df.

BUG=

Review-Url: https://codereview.chromium.org/2976543002 .
 2017-07-07 15:32:24 -07:00
Sigmund Cherem 4aadfe09df Revert "Tweak public APIs and use them in patch_sdk, dart2js, and kernel-service." 
Reason: broke VM bots, still investigating.

This reverts commit 610d081947.

TBR= paulberry@google.com

Review-Url: https://codereview.chromium.org/2979463002 .
 2017-07-07 15:21:37 -07:00
Sigmund Cherem 610d081947 Tweak public APIs and use them in patch_sdk, dart2js, and kernel-service. 
This CL tweaks the public APIs in package:front_end, and
starts using those APIs outside the package. For example, this
removes 9 uses of DillTarget, so it is not longer mentioned
outside pkg/front_end and the analyzer_target.

Actual changes:
 - in package:front_end

   * added kernel_generator_impl: new file contains code that
     used to be in kernel_generator. Code has some modifications:
     it uses a single canonical-root when loading summaries, and
     it supports generating both outlines and kernel in one go.

   * removed code that didn't belong here:
     a. most of calculating deps for .GN moved to patch_sdk
     b. vm-specific outcomes moved to kernel-service

   * updated how `native` is implemented, so we can more easily
     support dart2js and ddc

   * updated how we check where `int`, `bool`, etc can be implemented.

   * added support "hermetic mode" in modular builds
     ('chaseDependencies = false' option)

   * moved `trim` step out of fasta, and for now call it only within
     the public API. This is not yet exposed, and I stopped covering it in
     most tests (now only covered in shaker tests). The plan is to add
     tests for the public API covering this in the future.

   * removed `uriToSource` when serializing outlines

   * added unit tests for public APIs

 - patch_sdk
   * use the public API to craete platform.dill, outline.dill (now
     500K insted of 3Mb because it excludes sources), and vmservice_io.dill
   * moved here logic internal to .GN

 - kernel service
   * use the public API
   * moved here logic that depends on VM internals (e.g. status enum,
     compilation results)

 - package:compiler
   * use the public API in tools and unit tests
   * simplified patched-sdk generation: no more extending fasta's internals

 - package:kernel
   * fix bug in deserialization: initializers and other lists were
     overwritten accidentally with external definitions.
   * updated unit tests, moved shared logic to frontend/src/fasta/testing

R=johnniwinther@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2953703002 .
 2017-07-07 15:14:22 -07:00
Dmitry Stefantsov e429520d05 Add timeout to possible outcomes of pkg/analyzer_cli/test/driver_test 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2965313002 .
 2017-07-07 10:28:42 +02:00
Devon Carew 8e45759a67 Add initial version of analytics and crash reporting package. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2954733002 .
 2017-06-29 16:46:54 -07:00
Zachary Anderson ac16656161 Remove MIPS support 
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2858623002 .
 2017-06-22 08:49:22 -07:00
Brian Wilkerson ab8158f582 Revert status change after disabling problematic test 
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2951773003 .
 2017-06-21 08:45:12 -07:00
Brian Wilkerson fe368f956c Mark a test as slow to try to fix the bots 
Review-Url: https://codereview.chromium.org/2943363002 .
 2017-06-19 09:56:45 -07:00
Florian Loitsch 37291e867f Mark analyzer/task_dependency_grap test as slow. 
Review-Url: https://codereview.chromium.org/2943683002 .
 2017-06-16 14:00:10 +02:00
Peter von der Ahé 3cc27ab40a [gardening] Mark test as slow. 
Review-Url: https://codereview.chromium.org/2942603002 .
 2017-06-14 15:21:30 +02:00
Peter von der Ahé 1a66215a8e Skip testing/test/analyze_test on browsers. 
Review-Url: https://codereview.chromium.org/2934953005 .
 2017-06-13 17:13:03 +02:00
Devon Carew c7373ec565 Fix a status file. 
BUG=

Review-Url: https://codereview.chromium.org/2929193002 .
 2017-06-09 11:54:13 -07:00