dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

1421 Commits

Author SHA1 Message Date
Devon Carew fbd9c4e7a6 Fix a build mode test breakage from a recent DEPS update. 
Bug: https://github.com/dart-lang/sdk/issues/33814
Change-Id: Ibff9db2c71eb8aeb32c6da0f6b63f4ce44f5f12e
Reviewed-on: https://dart-review.googlesource.com/64600
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-07-11 18:12:44 +00:00
danrubel 89d6f50465 Fix override completion suggestion when fasta parser enabled 
Change-Id: I72a066c8a1a71fe4fa037ff86d19e19ed56371d5
Reviewed-on: https://dart-review.googlesource.com/64480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-07-11 15:43:12 +00:00
danrubel 647c72e0e5 Fix keyword completion with fasta parser enabled 
Change-Id: I9c7417168d27b13eae46bce90d6a61b447f0556c
Reviewed-on: https://dart-review.googlesource.com/64421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-07-11 14:25:54 +00:00
Lasse R.H. Nielsen 2efe3447ee Update DEPS to remove dependencies on upper-case constants 
Change-Id: I5839a92d9790abcf35011b7ab3cdd3e05dbfa45c
Reviewed-on: https://dart-review.googlesource.com/63950
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-07-11 09:45:33 +00:00
Devon Carew 94ca9b35af Mark four tests as slow. 
Change-Id: Ic7edca2b34fffb282770c8af7d10fe5b4826054e
Reviewed-on: https://dart-review.googlesource.com/64280
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-07-10 05:20:08 +00:00
Devon Carew 6dfc4ef663 Remove old dart2analyzer not strong status file entries. 
Change-Id: I8e7775ce9a3d6fd14ee9d1b9d79be2f6df23cd01
Reviewed-on: https://dart-review.googlesource.com/63801
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-07-07 04:14:20 +00:00
Devon Carew 31cd00b12c Mark the analysis server integration tests as slow. 
Change-Id: Ic501bc36724c10a00d1ee7e8fc28308f7c5e497f
Reviewed-on: https://dart-review.googlesource.com/63900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-07-06 00:16:41 +00:00
Devon Carew 5d2405f112 Update the status file for slow tests. 
Change-Id: Ib10fb573b0bfa0a5dd2685671e913e9fe762a1f9
Reviewed-on: https://dart-review.googlesource.com/63760
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-07-04 13:21:30 +00:00
Devon Carew eeb54497cf More slow test status file updates 
Change-Id: Ic6e20bc3a5310fd33608e8bccc03d50548214bc7
Reviewed-on: https://dart-review.googlesource.com/63702
Reviewed-by: Devon Carew <devoncarew@google.com>
 2018-07-04 01:38:48 +00:00
Devon Carew 6218c0fbb3 Mark analyzer tests as slow. 
Change-Id: I93668451b495af026557b3f08ed5b4aed20b919b
Reviewed-on: https://dart-review.googlesource.com/63689
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-07-03 21:41:15 +00:00
Devon Carew 46bfa7297e Have the regular analyzer bots test in dart 2 mode. 
Change-Id: I91bf09600d0e5f099737be0363228cad6d0b5329
Reviewed-on: https://dart-review.googlesource.com/63642
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-07-03 19:12:36 +00:00
Sigmund Cherem b7b24e9bbe Update dart2js-strong status across several suites 
Change-Id: I7550e3221bcfdb4f9281b2be96af8579848c5a69
Reviewed-on: https://dart-review.googlesource.com/63504
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-07-03 00:27:31 +00:00
Devon Carew ed6c09636f Remove old entries from pkg/pkg.status. 
Change-Id: I6625eda145979bcd627774ae33bd401eb99e6885
Reviewed-on: https://dart-review.googlesource.com/63502
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-07-03 00:19:26 +00:00
Sigmund Cherem 87550f4632 Add dart2js-strong entry in pkg.status 
TBR=sra@google.com

Change-Id: Id5bf90f1a614ecd3f4816bed5d9d0f12b7ee4953
Reviewed-on: https://dart-review.googlesource.com/63263
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-06-29 18:41:49 +00:00
Devon Carew d40e5543a3 Allow test/services/correction/fix_test to timeout. 
Change-Id: I0608cbabfe7a6af98c2430e2350a9aab3d018db6
Reviewed-on: https://dart-review.googlesource.com/63021
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-06-29 15:26:19 +00:00
Dan Rubel 08d3ca0ad3 Update status file 
This addresses a comment in https://dart-review.googlesource.com/c/sdk/+/62681

Change-Id: I41c908e60ebab47cdd5654c0be3d3f83188b3e9e
Reviewed-on: https://dart-review.googlesource.com/62940
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-06-28 19:58:41 +00:00
danrubel 7a5714ad0f Update compile_time_error_code_kernel_test 
Change-Id: Idae979cfb48a3fce8db09802e90d48ce1daa1dad
Reviewed-on: https://dart-review.googlesource.com/62681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-28 19:52:31 +00:00
Devon Carew e7da604c11 More updates for -DuseFastaParser. 
Change-Id: If0850d4e6c2f937f95e8b00c4718ab0370e5decf
Reviewed-on: https://dart-review.googlesource.com/62447
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-06-27 17:30:17 +00:00
Bob Nystrom a4c7cf388f First stab at a parsing library for named configurations. 
Change-Id: I1a2660914715d529b0233645b109b13c2fa9171a
Reviewed-on: https://dart-review.googlesource.com/61121
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-06-26 22:17:08 +00:00
Devon Carew ada8188b73 Update pkg/pkg.status with the latest -DuseFastaParser status. 
Change-Id: I0964506057defd27fc1335408a9751a0b18cb95d
Reviewed-on: https://dart-review.googlesource.com/62020
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-06-25 15:03:24 +00:00
Devon Carew dce00bc836 - fix a strong mode type error 
- mark a test as slow

Change-Id: I124c711e54b4bb4e3c7d68fb3a3f35be34be9151
Reviewed-on: https://dart-review.googlesource.com/61401
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-06-20 21:56:17 +00:00
Devon Carew 7d9ac9dca5 Add a --use-fasta-parse flag to test.py; add a 'analyzer-use-fasta-parser' buildbot configuration. 
Change-Id: I802df6b5fbfe963a466ce49f29d2bb0c84f14d25
Reviewed-on: https://dart-review.googlesource.com/60810
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-06-20 15:10:54 +00:00
asiva bc7220a4fd [VM] Turn dart2 on by default on the command line VM 
- make Dart2 the default option for the command line VM
- add option --no-preview-dart-2 as a fallback option to run dart1
- change test scripts to use the executable dart for testing dart2 mode instead of
pkg/vm/tool/dart2
- adjust numerous build and test configurations

Change-Id: Id813fa5b71a89c7ec9335d3f6e83cfc9f35f86e7
Reviewed-on: https://dart-review.googlesource.com/58240
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-06-18 22:31:32 +00:00
Jens Johansen 1a08341730 Analyzer status file update 
Change-Id: Ie1e15259e856cab96dd57fbc51da23f0e3845714
Reviewed-on: https://dart-review.googlesource.com/60421
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-06-15 07:50:23 +00:00
Jenny Messerly 1ef4399df0 Run dartfmt --fix for dart2 on pkg/dev_compiler 
This uses optional new/const and `=` in named argument defaults.

All changes are automated, except for:

- utils/dartdevc/BUILD.gn: run DDC build scripts with --preview-dart-2
- pkg/dev_compiler/tool/patch_sdk.dart: add a TODO that Analyzer doesn't
  supporting implicit const in libraries.dart
- pkg/dev_compiler/tool/input_sdk/libraries.dart: was not formatted due
  to the aforementioned Analyzer bug
- tools/bots/test_matrix.json: run DDC sourcemap suite in Dart 2 mode
- pkg/pkg.status: skip pkg/dev_compiler if running in Dart 1 mode

Change-Id: I9b80ccba0c2cc7b66efc662a0b16562e3660aee3
Reviewed-on: https://dart-review.googlesource.com/60402
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2018-06-15 00:28:13 +00:00
Jens Johansen 2716b6f9a6 Add test to frontend_server that mimics the flutter benchmarks 
Change-Id: I1c968e5fb62fa42a38cf4e7d69683c6790385797
Reviewed-on: https://dart-review.googlesource.com/49902
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-06-14 09:38:28 +00:00
Alexander Thomas 5616ec9d6d [infra] Mark analysis/package_root_test as flaky on linux 
Change-Id: I611aa7bc9b96a8bd322333814dce35f44f61ac0d
Reviewed-on: https://dart-review.googlesource.com/59092
Reviewed-by: William Hesse <whesse@google.com>
 2018-06-07 14:31:12 +00:00
Emily Fortuna c911a1bef6 Clean up additional dart2js strong mode runtime error and don't add method type variable in dart 1 version. 
Change-Id: I8f8a62fe2b4fcc00c05fbab22ed9e7a55eb95ccf
Reviewed-on: https://dart-review.googlesource.com/57523
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-05-31 18:52:06 +00:00
Sigmund Cherem 8c0f5747a0 Add build_integration package and move multi_root_file_system there. 
This is following the design discussion we had a few months ago.

Change-Id: I48b2e82af33d10b9cd1e599e1b3a4e8e419417c8
Reviewed-on: https://dart-review.googlesource.com/56035
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-22 20:09:24 +00:00
Paul Berry 3466823189 Enable analyzer testing of pkg in strong mode. 
Fixes #33116.
Fixes #28649.

Change-Id: I881eef1d23909b09c856515edbf8b5cee1821824
Reviewed-on: https://dart-review.googlesource.com/55302
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-05-16 16:31:42 +00:00
Janice Collins e0ddab3c4c Fix bots after preview-dart2 was switched on by default. 
Change-Id: I7ddb03e62d0f921b1745e471944d6f850533ea91
Reviewed-on: https://dart-review.googlesource.com/52823
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-26 20:09:56 +00:00
Kevin Millikin c844011647 Don't skip pkg/kernel/test/metadata_test 
This test seems to pass now so there's no reason to skip it.
Closes https://github.com/dart-lang/sdk/issues/31900

Change-Id: Id0716847dd874435811e85f43a8f036028b52a88
Reviewed-on: https://dart-review.googlesource.com/52426
Reviewed-by: Karl Klose <karlklose@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-04-25 17:01:19 +00:00
Alexander Thomas 3851591642 [infra] Keep comments intact when updating status files. 
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.

Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-04-10 19:03:21 +00:00
Jens Johansen 2e366e8c9a [fasta] Refactor incremental_load_from_dill_test 
Split into 2:
- One with a "smoke-test" of dart2js.
- One with several small examples that has caused problems in the past.

The latter of the two is now based on package:testing and the test-cases
are saved as yaml files.

Change-Id: I8b588e9b42edc73f58a07292a1226e37cc458d89
Reviewed-on: https://dart-review.googlesource.com/45505
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-03-22 08:57:36 +00:00
Sigmund Cherem d6294bc6b5 Round 6 of status updates: remaining issues in d8, safari, ie11, ff (hopefully) 
TBR=efortuna@google.com

Change-Id: Id84ed1a13646a27015d3aa20ad0d3c0c7d08522c
Reviewed-on: https://dart-review.googlesource.com/46564
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-14 19:25:29 +00:00
Martin Kustermann 846d18414c Use platform.dill for more fasta tests, skip shaker test 
Issue https://github.com/dart-lang/sdk/issues/32530
Issue https://github.com/dart-lang/sdk/issues/32531

Change-Id: Ie31a9e4d82fb942e48aa9a9c89c45eefb132702f
Reviewed-on: https://dart-review.googlesource.com/46520
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-03-14 16:27:37 +00:00
Sigmund Cherem af1f26fd48 Status fixes round 5: chrome mac & windows 
TBR=efortuna@google.com

Change-Id: I69db60955cd22aca48981bb84a2637a28c385cc4
Reviewed-on: https://dart-review.googlesource.com/46422
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-03-14 16:16:34 +00:00
Sigmund Cherem 9c9497bda0 Status updates round 3: chrome-faststarup, ff, ff-faststartup 
TBR=efortuna@google.com

Change-Id: I06b535f7273c3ac85173bf4f0286e02d09897c8e
Reviewed-on: https://dart-review.googlesource.com/46420
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-14 06:16:19 +00:00
Peter von der Ahé 8a9956d4a7 [dart2js] Handle Windows file names correctly. 
Closes https://github.com/dart-lang/sdk/issues/31899

Change-Id: I0577e9cd5bab7083df53ccbee7ffb2258f08a442
Reviewed-on: https://dart-review.googlesource.com/46080
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-03-13 09:15:48 +00:00
Sigmund Cherem 932a99a731 Prepare pkg.status to enable dart2js CFE by default 
TBR=sra@google.com

Change-Id: I041af103a50c534ba278a61c1eefb689e5f58d6f
Reviewed-on: https://dart-review.googlesource.com/45366
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-03-07 01:30:21 +00:00
Peter von der Ahé 9f56e28372 Mixin Applications with a Vengeance 
Change-Id: I213f99234f29abd7e2ec03dc8451ed6dd16f3d03
Reviewed-on: https://dart-review.googlesource.com/45021
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-03-06 15:15:57 +00:00
Jens Johansen 2f10ab76f7 Mark incremental_load_from_dill_test slow on Windows 
incremental_load_from_dill_test is sometimes slow on Windows. Mark it as such.

Change-Id: I11bf1bac275829f5bb612ab6f8b80d646cc31a3e
Reviewed-on: https://dart-review.googlesource.com/44780
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-03-02 14:49:40 +00:00
Danny Tuppeny 0e48dce272 Mark integration tests as skip on Windows due to timeouts 
Bug: https://github.com/dart-lang/sdk/issues/32356
Change-Id: I78613615c2de2869535810536464d3dc04f1f45b
Reviewed-on: https://dart-review.googlesource.com/44542
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-01 16:36:16 +00:00
Danny Tuppeny a3b2c5addb Update status for analysis server tests on Windows 
Various tests are currently flaky so marked with Pass, Slow/RuntimeError.

Bug: https://github.com/dart-lang/sdk/issues/32355
Bug: https://github.com/dart-lang/sdk/issues/32356
Change-Id: I86755a5eeb72ad92eaa22f950306e745c14e67fc
Reviewed-on: https://dart-review.googlesource.com/44260
Reviewed-by: William Hesse <whesse@google.com>
 2018-03-01 13:52:32 +00:00
William Hesse d002e2f6f3 Update status for 3 analysis server unit tests on Windows 
Bug: https://github.com/dart-lang/sdk/issues/32355
Change-Id: Ide2a8e5051e42b529c5b302978f28246ce087cf4
R: athom@google.com
Reviewed-on: https://dart-review.googlesource.com/44203
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
 2018-02-28 15:51:17 +00:00
Danny Tuppeny 6eeac05d48 Unskip analysis server tests on windows 
All path issues have been fixed and pass locally.

Bug: https://github.com/dart-lang/sdk/issues/32226
Change-Id: I782bd0a661a10f78cb672e79a000f637aa9e46a6
Reviewed-on: https://dart-review.googlesource.com/44063
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2018-02-28 14:18:55 +00:00
Konstantin Shcheglov fae3a83629 Remove typed_mock 
Bug: https://github.com/dart-lang/sdk/issues/32271
Change-Id: I32d7708f269b9618f6a031f0323f5cea646066f3
Reviewed-on: https://dart-review.googlesource.com/42862
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-02-21 22:22:32 +00:00
Paul Berry 6539760609 Fix analyzer bots 
Change-Id: I4a0ed3b51854442994ca45235050434249b73299
Reviewed-on: https://dart-review.googlesource.com/40241
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-09 09:25:08 +00:00
Paul Berry cca7b4419d Replace $builder_tag == strong with $strong in status files 
The `$builder_tag == strong` annotations were added before test.py
supported `$strong`.  Now that `$strong` is supported, it's better to
use it directly to avoid confusion.

Change-Id: I715edecaee1e36ab8a26dbc96a6aa056e1be018f
Reviewed-on: https://dart-review.googlesource.com/39600
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-07 11:50:10 +00:00
Peter von der Ahé 861550a28c Read patch files in strong mode 
Closes https://github.com/dart-lang/sdk/issues/28822

Change-Id: I05e1d9885a39efca131d78d06cfd8a0e84276bb9
Reviewed-on: https://dart-review.googlesource.com/36641
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-02-05 14:35:36 +00:00