dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

159 Commits

Author SHA1 Message Date
danrubel 1a9801e9fa mark ExperimentalFeature bogus_enabled and bogus_disabled as deprecated 
... and update comment and test output to indicate how files should be
regenerated from tools/experimental_features.yaml

Change-Id: I369b93c35b91f7a93c915f0abf9cebdd00c13f8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106003
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Dan Rubel <danrubel@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-06-13 21:30:05 +00:00
Dan Rubel 4a27605fdc generate kernel experimental flags 
Change-Id: I9430d95c012b752bc4ca0530d79252b8b032a26b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104841
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Auto-Submit: Dan Rubel <danrubel@google.com>
 2019-06-06 14:03:29 +00:00
Sam Rawlins b22cd05c51 Reland fix for #28233: add hint for missing returns to function expressions 
The bulk of this change is actually correcting missing returns in the Dart SDK.

Bug: https://github.com/dart-lang/sdk/issues/28233
Change-Id: I52bcbc6c6f4a129d3fc22003f4448a7c3d4487ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100301
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-05-22 18:12:30 +00:00
Aske Simon Christensen dbea5c6884 [fasta] Commandline option to leave environment constants unevaluated. 
Also, outdated description of -D option corrected.

Change-Id: Ie1dc011adc3ce2f5293826c96f22700a6528c9a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96880
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-03-14 11:30:07 +00:00
Daco Harkes 12fcb9136c [cfe] Make resolveInputUri available for pkg/vm 
use function suggested by ahe


[gardening] fix incremental compiler file encoding on Windows

Change-Id: I50fd02389afabe4903d9d88d009d58330515f825
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95642
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-03-06 15:31:09 +00:00
Aske Simon Christensen 120328aff7 [fasta] Commandline option to enable asserts 
Since Fasta is only concerned with compile-time behavior, the option
only affects asserts in initializers in const constructors when
evaluated during constant evaluation.

Change-Id: I534cc7cc1f33f9b34d15550d38ea930ed7ac6709
Reviewed-on: https://dart-review.googlesource.com/c/94740
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Auto-Submit: Aske Simon Christensen <askesc@google.com>
 2019-02-28 12:11:16 +00:00
Peter von der Ahé cffdd356ed BenchMaker: Don't obfuscate dart:async 
Change-Id: Ia48daaee3d8a0c3a2e580c54074598cd49a8fea8
Reviewed-on: https://dart-review.googlesource.com/c/94287
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-02-26 11:59:43 +00:00
Peter von der Ahé 1171c4735b BenchMaker: Ensure all classes are serialized 
Change-Id: I06b4ca890f74858ce3e910ba4017f7bc622c0839
Reviewed-on: https://dart-review.googlesource.com/c/94285
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-02-26 11:59:43 +00:00
Peter von der Ahé 47555a25b8 Fix detection of implicit bounds 
Change-Id: I5fa2ae94f23f5452cdc5f5afe4360ce879c23082
Reviewed-on: https://dart-review.googlesource.com/c/94282
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-02-26 11:59:43 +00:00
Peter von der Ahé 7f2a83ee07 BenchMaker: collect used type parameters 
Change-Id: If6c18e66eded0ebe73575cca28dd77e5ae374890
Reviewed-on: https://dart-review.googlesource.com/c/93950
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-02-22 13:01:09 +00:00
Peter von der Ahé b3c9aa624e BenchMaker: print call operators 
Change-Id: I83560b19e3f3ce3b535bc5a69c953a8df6a5f668
Reviewed-on: https://dart-review.googlesource.com/c/93948
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-02-22 13:01:09 +00:00
Peter von der Ahé 74f0a36579 BenchMaker: Print function type arguments correctly 
Change-Id: Ieeae9ed53d86c2c2409be67397fad300f04849dc
Reviewed-on: https://dart-review.googlesource.com/c/93947
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-02-22 13:01:09 +00:00
Peter von der Ahé 6b29680b12 Enable collection of type checks for benchmarking 
Change-Id: Iea59fcac1e56e3335f08c2a8dd7accc2b883547a
Reviewed-on: https://dart-review.googlesource.com/c/93946
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-02-22 13:01:09 +00:00
Aske Simon Christensen ac95355fdb Compiler option for environment defines 
Change-Id: I50f0085ebbc2c9a3af26769a0004bfb8361d85f2
Reviewed-on: https://dart-review.googlesource.com/c/91340
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-02-07 16:15:52 +00:00
Peter von der Ahé bdb51e2837 Improve input path handling and remove extra schemas. 
Change-Id: I02a403284a2cc71cac908be4a7ec9f858cb5db47
Reviewed-on: https://dart-review.googlesource.com/c/89509
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2019-01-16 10:17:03 +00:00
Peter von der Ahé 0604110806 Reduce expectations on thrown exception 
Change-Id: Ic1421c7d3164c581d1f69f6c032edd6ca0b9f519
Reviewed-on: https://dart-review.googlesource.com/c/89504
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-01-16 10:17:03 +00:00
Sam Rawlins 492df72739 Fix fasta test under windows 
Change-Id: If9db5a0a9d67aa2ae369aabef44a70da06d41ac2
Reviewed-on: https://dart-review.googlesource.com/c/89764
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-01-16 04:23:33 +00:00
Sam Rawlins 3154bb0d37 Stop using external deprecated members in front_end 
Change-Id: I3fa03de568f72bfc3adb46efcfa2b61b781c706b
Reviewed-on: https://dart-review.googlesource.com/c/89020
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-01-15 18:55:10 +00:00
Aske Simon Christensen 90d22365d1 Convenience function to parse a list of experimental flags 
Change-Id: Iaf25e53136bbe740756c7b047976a2483a12c8df
Reviewed-on: https://dart-review.googlesource.com/c/88840
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-01-11 10:07:29 +00:00
Aske Simon Christensen 0f1b9439b5 Use 'no-' prefix to disable an experiment. 
Change-Id: I597a98802f6900d57ed4583c35b20790738e2f3a
Reviewed-on: https://dart-review.googlesource.com/c/88712
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-01-09 11:44:48 +00:00
Aske Simon Christensen 451fdc41e6 Experimental flags in Fasta 
Change-Id: Ifc807059d9b434934e077f8fe5845d723807640c
Reviewed-on: https://dart-review.googlesource.com/c/87843
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-01-03 13:45:36 +00:00
asiva dff358223e [VM/Runtime] Delete flag --sync-async and it's uses. 
Remove all references to the --sync-async flag which was added as a transition step
when the feature was being introduced.

Change-Id: Ic5b1c8c8b3e2d92a70d954d401afeddfd43f5e92
Reviewed-on: https://dart-review.googlesource.com/c/87381
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-12-20 23:37:45 +00:00
Peter von der Ahé bbeee457e3 Add message parameter key for names 
Change-Id: I1a01b3cc1bb3c9bc8da502f3b00db4d38fa9ee8b
Reviewed-on: https://dart-review.googlesource.com/c/87587
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-20 18:06:34 +00:00
Kevin Millikin 87f309463a Stop using asynchronous async in Fasta 
Change all the places that still used old-style asynchronous async in
Fasta.  These were mostly in testing.

Change-Id: I102209aa54c7c6e658b9d6ec98167af62bf12f3e
Reviewed-on: https://dart-review.googlesource.com/c/87074
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-12-14 08:17:35 +00:00
Kevin Millikin a8493e1b50 Flip the default value of the Kernel syncAsync flag 
In Kernel's TargetFlags, this flag still defaulted to false.  Flip the
default to true and update all client code in the SDK.  The
expectation is that many of the places that now pass false explicitly
really just want the default, but that will be verified separately and
then the flag will be removed.

Change-Id: I2a38eb53f280f21f59bb1d2e88c42516f827fd39
Reviewed-on: https://dart-review.googlesource.com/c/85448
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-12-12 14:23:54 +00:00
Jens Johansen c2bd36e94d Add --omit_platform as option to fasta. 
Change-Id: I9f8b7b89a0440bbff8b466ed2e4f2af73c72c023
Reviewed-on: https://dart-review.googlesource.com/c/84428
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-11-30 07:48:15 +00:00
Aske Simon Christensen c9aaa7a654 Re-formulation of type bound violation error messages 
Change-Id: I7f0b99c184b02f6910da054b877b5b5bee86f6bc
Reviewed-on: https://dart-review.googlesource.com/c/85346
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-11-29 13:27:16 +00:00
Aske Simon Christensen c959bd98af Print origins of types in bullet points below error messages. 
This gets rid of the useless '#lib1::' prefixes on types in error
messages and instead adds a line to the error message for each
interface type appearing in the message stating where that type
originates.

Name clashes are disambiguated by appending markers like '/*1*/' and
'/*2*/' to the types whenever two interface types with the same name
appear in the same message.

The commonly used core types 'bool', 'num', 'int', 'double', 'String'
and 'Null' are excluded from the origin list unless they take part in a
name clash.

Change-Id: I017ea376d4f6ff2d4f3b36487774463f03bb3301
Reviewed-on: https://dart-review.googlesource.com/c/84604
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-11-29 13:27:16 +00:00
Aske Simon Christensen 5198e49ffd Use new type labeler API in message generation. 
For now, it uses a dummy implementation that retains the old behavior.

Change-Id: Iab358b73af470b99d5bd0ed59028d96d26bae47f
Reviewed-on: https://dart-review.googlesource.com/c/84603
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-11-29 13:27:16 +00:00
Jens Johansen 1ec63ec7d5 Only one source of truth for uriToSource 
Previously we had several places where different uriToSource was used.
This was both weird and led to errors when something refering to
some state was used to look up in another state.
This CL makes it so we only have one source of truth.

To not include sdk sources when serializing a component that only mixes
something from the sdk in, (or extends it or...), the serialization is
changed slightly to keep track of which uris come from actual
implementation. Before the sdk sources was explicitly removed in the
incremental compiler, but we want to limit those kinds of things,
which is why we're doing it differently here.

Fixes #35215.

Bug: 35215
Change-Id: Iaa5618fcb0ea42b13aba7720f34a87a85144e047
Reviewed-on: https://dart-review.googlesource.com/c/85175
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-11-28 10:57:01 +00:00
Peter von der Ahé 9137fe26ac Remove deprecated_problems.dart 
Change-Id: I5f6cad8077b9faaf2164dd0f3f1f5d54c59ed0b7
Reviewed-on: https://dart-review.googlesource.com/c/78203
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-16 08:02:49 +00:00
Peter von der Ahé 54ef78b7c5 Remove non-strong vm dill files from SDK 
Change-Id: Ia9337ec090333902ea8fc2492f2ffdac1bcff2d1
Reviewed-on: https://dart-review.googlesource.com/c/79520
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-10-12 12:42:57 +00:00
Kevin Millikin 2fa1143600 Check classes at mixin applications 
When a declared mixin is applied to a class, the class must implement
the superclass constraint interfaces named in the mixin declaration.

Change-Id: I6ace9fe244c1c87860b69c2c5e68f2c31ae73d7c
Reviewed-on: https://dart-review.googlesource.com/c/79206
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Daniel Hillerström <hillerstrom@google.com>
 2018-10-12 08:34:07 +00:00
Peter von der Ahé 244e6c7ffc Infer package URIs 
Closes https://github.com/dart-lang/sdk/issues/33076

Change-Id: I73db84eadaf3ba723c2f1323f9b883077a4df9df
Reviewed-on: https://dart-review.googlesource.com/c/78246
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-11 17:41:50 +00:00
Peter von der Ahé 49d7fb39ac Temporarily ignore --strong option in flutter builds 
Change-Id: Ib9f80ef29cc301b0a8354bcaeddaf47177784d9c
Reviewed-on: https://dart-review.googlesource.com/c/79203
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-10-11 09:40:09 +00:00
Alexander Markov 5deb1c6e81 [vm] Remove strong mode and sync-async flags from pkg/vm 
Change-Id: Icd2920274ca4c402b38e5774bb408d6b5e529169
Reviewed-on: https://dart-review.googlesource.com/c/79082
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-10-10 20:11:35 +00:00
G?nter Z?chbauer 2da0b9f4f1 fix some typos 
Closes #34738
https://github.com/dart-lang/sdk/pull/34738

GitOrigin-RevId: d211bbacfe65355cf7304c990ffb6c79d7a229cf
Change-Id: If690e6d378e543b300e1f6a353ceae73e39c29db
Reviewed-on: https://dart-review.googlesource.com/c/78900
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-10-10 19:15:30 +00:00
Peter von der Ahé f1d902f4a0 Ignore --supermixin and -D options 
Change-Id: Ia817ad9236ee0947a87faa4c570eedc239a1a84a
Reviewed-on: https://dart-review.googlesource.com/c/78542
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-10 13:38:57 +00:00
Peter von der Ahé 8c872e0e3a Remove TargetFlags.strongMode 
Change-Id: Ibf8661e5444d16666c54f1d81c626893b000521a
Reviewed-on: https://dart-review.googlesource.com/c/78986
Commit-Queue: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-10 12:11:41 +00:00
Peter von der Ahé ee97806084 Replace strongMode with legacyMode in CompilerOptions 
Also, remove --strong and --strong-mode flags (use --legacy-mode
flag to enable legacy mode).

Change-Id: I577ab5f755a2bee88f0f4d63915a6e852e792f06
Reviewed-on: https://dart-review.googlesource.com/c/79000
Commit-Queue: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-10 12:04:26 +00:00
Aske Simon Christensen eacf720d2b Functions to demangle mixin application class names 
Demangle all names in messages to avoid printing mangled names in
user-facing output.

Point messages about implicit mixin application classes at the subclass
name for consistency with named mixin application classes.

Change-Id: I90973986c422f271af99e18b3deb5847adf4d430
Reviewed-on: https://dart-review.googlesource.com/c/77380
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-10-03 14:56:43 +00:00
Peter von der Ahé 158290349a Reject diagnostics with missing arguments 
That is, arguments that are null or empty.

Change-Id: I9b580f44ed960f2a0270c91fd8c98b9b43c7ceed
Reviewed-on: https://dart-review.googlesource.com/76604
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-02 13:59:20 +00:00
Peter von der Ahé b36f4fffc4 Allow multiple analyzer codes 
Change-Id: I0f942389f52b8302bac8b1bd0cedee1e35811056
Reviewed-on: https://dart-review.googlesource.com/76940
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-09-27 11:52:37 +00:00
Peter von der Ahé fe39691269 Don't use --no-preview-dart-2 
Fixes https://github.com/dart-lang/sdk/issues/34548

Change-Id: Ia6b4a3cdc4b6c39e0aa0fb649940b2bd126a619e
Reviewed-on: https://dart-review.googlesource.com/76120
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-09-24 09:20:01 +00:00
Dmitry Stefantsov 346895eb35 Choose the right platform in the command-line fasta tool in strong mode 
Change-Id: I6d51c0fafdab4277796b5861de9312b440e072dd
Reviewed-on: https://dart-review.googlesource.com/75740
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-09-20 14:50:16 +00:00
Peter von der Ahé 6fe272314d Tweak parameters of ProcessedOptions 
Change-Id: Id7aa47d9119da3ab21a1130253b4735c160a2459
Reviewed-on: https://dart-review.googlesource.com/74740
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-09-19 08:13:45 +00:00
danrubel 25d14df016 Auto generate more ParserErrorCodes 
Specifically:
* CONTINUE_OUTSIDE_OF_LOOP
* EXTERNAL_CLASS
* EXTERNAL_ENUM
* STATIC_CONSTRUCTOR

Also:
* Exclude classes that are already auto generated from the list of those
  that could be translated,
* Print summary after checking for manual changes
* Generate error codes before checking if manual changes need to be made

And address comments in
* https://dart-review.googlesource.com/c/sdk/+/74040
* https://dart-review.googlesource.com/c/sdk/+/74240

Change-Id: I573215d58e14749edd02a2416389df3047841002
Reviewed-on: https://dart-review.googlesource.com/74520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-09-11 21:01:46 +00:00
danrubel c7960df357 Generate analyzer error codes from messages.yaml 
With this change, analyzer error codes can be generated from messages.yaml
and those error codes easily translated from the corresponding fasta error.

Each fasta error code in messages.yaml that has an "index:" field
(see prior CL https://dart-review.googlesource.com/c/sdk/+/74040)
now has an Analyzer error code automatically generated
with the information in messages.yaml. In addition
a list of all indexed errors is generated so that a fasta error
code can be quickly translated into an Analyzer error code.

Change-Id: I2d534b7349590ddd54996f564db786c6ffe259b3
Reviewed-on: https://dart-review.googlesource.com/74240
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-09-10 23:07:19 +00:00
danrubel d32c8e4793 Generate error code index from "index:" field in messages.yaml 
Change-Id: I4bebce34d136cf7a89c8b15696c907d1f69bede0
Reviewed-on: https://dart-review.googlesource.com/74040
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-09-10 22:29:41 +00:00
Peter von der Ahé fa14dbcdfc Format constants and remove dart2jsCode 
Change-Id: Ia04066782292f0c49a56689056c69b0481f3aacb
Reviewed-on: https://dart-review.googlesource.com/72021
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-08-30 08:05:31 +00:00