dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

301 Commits

Author SHA1 Message Date
Jens Johansen 31599c1e64 No --mode=legacy in incremental_perf_test 
Fixes #37302.

Change-Id: I69f07848ab20922628df0d01ea7b9c75fe8a5bb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106905
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-06-24 13:45:52 +00:00
danrubel 1a9801e9fa mark ExperimentalFeature bogus_enabled and bogus_disabled as deprecated 
... and update comment and test output to indicate how files should be
regenerated from tools/experimental_features.yaml

Change-Id: I369b93c35b91f7a93c915f0abf9cebdd00c13f8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106003
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Dan Rubel <danrubel@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-06-13 21:30:05 +00:00
Dan Rubel 4a27605fdc generate kernel experimental flags 
Change-Id: I9430d95c012b752bc4ca0530d79252b8b032a26b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104841
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Auto-Submit: Dan Rubel <danrubel@google.com>
 2019-06-06 14:03:29 +00:00
Kevin Millikin 907f31e6de Reland "[cfe] Build some annotations during outlining" 
Reland the change to build some annotations during outlining, with a
bug fix.  Annotations from patch classes and procedures were not
applied to the actual class or procedure, which is fixed.

The original commit was reviewed at
https://dart-review.googlesource.com/c/sdk/+/103806

The revert was reviewed at
https://dart-review.googlesource.com/c/sdk/+/104220

The original commit message was:

    During the outline phase, after top-level type inference, compile
    annotations for libraries, classes, fields, procedures, and
    constructors.

Change-Id: I836160ddad4114ded72701e8a3938f703228931c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104560
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-06-03 10:20:15 +00:00
Vyacheslav Egorov 39ec9fc4f3 Revert "[cfe] Build some annotations during outlining" 
This reverts commit 1df5fb3d57.

Reason for revert: large regressions on Flutter microbenchmarks. Reverting to prevent this reaching Flutter.

Original change's description:
> [cfe] Build some annotations during outlining
> 
> During the outline phase, after top-level type inference, compile
> annotations for libraries, classes, fields, procedures, and
> constructors.
> 
> Change-Id: I95ca65fd58ad88d9452a28d5a0652bee44aeda3a
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103806
> Commit-Queue: Kevin Millikin <kmillikin@google.com>
> Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

TBR=alexmarkov@google.com,dmitryas@google.com,askesc@google.com,kmillikin@google.com

Change-Id: I67c0719f9175c1bd75b609d7d5c0cea5c294bd6d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104220
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2019-05-30 08:46:55 +00:00
Kevin Millikin 1df5fb3d57 [cfe] Build some annotations during outlining 
During the outline phase, after top-level type inference, compile
annotations for libraries, classes, fields, procedures, and
constructors.

Change-Id: I95ca65fd58ad88d9452a28d5a0652bee44aeda3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103806
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-05-30 07:29:12 +00:00
Sam Rawlins b22cd05c51 Reland fix for #28233: add hint for missing returns to function expressions 
The bulk of this change is actually correcting missing returns in the Dart SDK.

Bug: https://github.com/dart-lang/sdk/issues/28233
Change-Id: I52bcbc6c6f4a129d3fc22003f4448a7c3d4487ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100301
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-05-22 18:12:30 +00:00
Paul Berry e2d0f5a50b Add featureSet parameter to Parser constructor. 
And deprecate old parser configuration setters.

Change-Id: Ib1507b8d2b20be7c883061e2a92ec9205d6a378f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100664
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-29 16:42:19 +00:00
Paul Berry 3d0cdc8956 Switch perf.dart completely over to Fasta parser. 
The only remaining code in perf.dart that was using the legacy
analyzer parser was in parseDirectives, which is part of setup, and
not part of the code being performance tested, so there should be no
effect on the benchmark.

Change-Id: I4676b10c367d477499c96f5220e622bb390752a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100680
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-29 13:04:38 +00:00
asiva 98dddc9daa [tests] Ensure that --enable-asserts is used whereever checked was used previously 
Change-Id: Ia88c03a8dd36237f3c819a3a892f8f17ecf7f00b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97604
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-22 19:51:41 +00:00
asiva 1bab46b06f [vm] Remove support for '-c', '--checked' flags and '--enable-checked-mode' 
1. Remove support for the following flags '-c', '--checked' and '--enable-checked-mode'
2. Cleanup some of the tests and test scripts where these options were being passed.

https://github.com/dart-lang/sdk/issues/34660

Change-Id: I4d8aa0d14bd054cfba08d78a411a0df4fc829df1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97550
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-03-22 17:08:56 +00:00
Sigmund Cherem a8c94d0b52 Remove tools we no longer need to manage status files 
Change-Id: Ia106c48cdbecaa8eec722ee11cbc9b6813989477
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96860
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-03-14 19:16:24 +00:00
Aske Simon Christensen dbea5c6884 [fasta] Commandline option to leave environment constants unevaluated. 
Also, outdated description of -D option corrected.

Change-Id: Ie1dc011adc3ce2f5293826c96f22700a6528c9a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96880
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-03-14 11:30:07 +00:00
Peter von der Ahé f200c37553 Enable extra VM options in fasta script 
Change-Id: Ib7f68bee7155dcf4ad49d6b17bea6eb071f31f8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96646
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-03-13 06:46:21 +00:00
Daco Harkes 12fcb9136c [cfe] Make resolveInputUri available for pkg/vm 
use function suggested by ahe


[gardening] fix incremental compiler file encoding on Windows

Change-Id: I50fd02389afabe4903d9d88d009d58330515f825
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95642
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-03-06 15:31:09 +00:00
Aske Simon Christensen 120328aff7 [fasta] Commandline option to enable asserts 
Since Fasta is only concerned with compile-time behavior, the option
only affects asserts in initializers in const constructors when
evaluated during constant evaluation.

Change-Id: I534cc7cc1f33f9b34d15550d38ea930ed7ac6709
Reviewed-on: https://dart-review.googlesource.com/c/94740
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Auto-Submit: Aske Simon Christensen <askesc@google.com>
 2019-02-28 12:11:16 +00:00
Peter von der Ahé cffdd356ed BenchMaker: Don't obfuscate dart:async 
Change-Id: Ia48daaee3d8a0c3a2e580c54074598cd49a8fea8
Reviewed-on: https://dart-review.googlesource.com/c/94287
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-02-26 11:59:43 +00:00
Peter von der Ahé 1171c4735b BenchMaker: Ensure all classes are serialized 
Change-Id: I06b4ca890f74858ce3e910ba4017f7bc622c0839
Reviewed-on: https://dart-review.googlesource.com/c/94285
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-02-26 11:59:43 +00:00
Peter von der Ahé 47555a25b8 Fix detection of implicit bounds 
Change-Id: I5fa2ae94f23f5452cdc5f5afe4360ce879c23082
Reviewed-on: https://dart-review.googlesource.com/c/94282
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-02-26 11:59:43 +00:00
Peter von der Ahé 7f2a83ee07 BenchMaker: collect used type parameters 
Change-Id: If6c18e66eded0ebe73575cca28dd77e5ae374890
Reviewed-on: https://dart-review.googlesource.com/c/93950
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-02-22 13:01:09 +00:00
Peter von der Ahé b3c9aa624e BenchMaker: print call operators 
Change-Id: I83560b19e3f3ce3b535bc5a69c953a8df6a5f668
Reviewed-on: https://dart-review.googlesource.com/c/93948
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-02-22 13:01:09 +00:00
Peter von der Ahé 74f0a36579 BenchMaker: Print function type arguments correctly 
Change-Id: Ieeae9ed53d86c2c2409be67397fad300f04849dc
Reviewed-on: https://dart-review.googlesource.com/c/93947
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-02-22 13:01:09 +00:00
Peter von der Ahé 6b29680b12 Enable collection of type checks for benchmarking 
Change-Id: Iea59fcac1e56e3335f08c2a8dd7accc2b883547a
Reviewed-on: https://dart-review.googlesource.com/c/93946
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-02-22 13:01:09 +00:00
Aske Simon Christensen ac95355fdb Compiler option for environment defines 
Change-Id: I50f0085ebbc2c9a3af26769a0004bfb8361d85f2
Reviewed-on: https://dart-review.googlesource.com/c/91340
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-02-07 16:15:52 +00:00
Peter von der Ahé bdb51e2837 Improve input path handling and remove extra schemas. 
Change-Id: I02a403284a2cc71cac908be4a7ec9f858cb5db47
Reviewed-on: https://dart-review.googlesource.com/c/89509
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2019-01-16 10:17:03 +00:00
Peter von der Ahé 0604110806 Reduce expectations on thrown exception 
Change-Id: Ic1421c7d3164c581d1f69f6c032edd6ca0b9f519
Reviewed-on: https://dart-review.googlesource.com/c/89504
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-01-16 10:17:03 +00:00
Sam Rawlins 492df72739 Fix fasta test under windows 
Change-Id: If9db5a0a9d67aa2ae369aabef44a70da06d41ac2
Reviewed-on: https://dart-review.googlesource.com/c/89764
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-01-16 04:23:33 +00:00
Sam Rawlins 3154bb0d37 Stop using external deprecated members in front_end 
Change-Id: I3fa03de568f72bfc3adb46efcfa2b61b781c706b
Reviewed-on: https://dart-review.googlesource.com/c/89020
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-01-15 18:55:10 +00:00
Aske Simon Christensen 90d22365d1 Convenience function to parse a list of experimental flags 
Change-Id: Iaf25e53136bbe740756c7b047976a2483a12c8df
Reviewed-on: https://dart-review.googlesource.com/c/88840
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-01-11 10:07:29 +00:00
Aske Simon Christensen 0f1b9439b5 Use 'no-' prefix to disable an experiment. 
Change-Id: I597a98802f6900d57ed4583c35b20790738e2f3a
Reviewed-on: https://dart-review.googlesource.com/c/88712
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-01-09 11:44:48 +00:00
Aske Simon Christensen 451fdc41e6 Experimental flags in Fasta 
Change-Id: Ifc807059d9b434934e077f8fe5845d723807640c
Reviewed-on: https://dart-review.googlesource.com/c/87843
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-01-03 13:45:36 +00:00
asiva dff358223e [VM/Runtime] Delete flag --sync-async and it's uses. 
Remove all references to the --sync-async flag which was added as a transition step
when the feature was being introduced.

Change-Id: Ic5b1c8c8b3e2d92a70d954d401afeddfd43f5e92
Reviewed-on: https://dart-review.googlesource.com/c/87381
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-12-20 23:37:45 +00:00
Peter von der Ahé bbeee457e3 Add message parameter key for names 
Change-Id: I1a01b3cc1bb3c9bc8da502f3b00db4d38fa9ee8b
Reviewed-on: https://dart-review.googlesource.com/c/87587
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-20 18:06:34 +00:00
Peter von der Ahé cbe30dc0d5 Remove Target.disableTypeInference 
Change-Id: I440b07258a79796092e14abf816f257d9af40427
Reviewed-on: https://dart-review.googlesource.com/c/86357
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-19 17:21:51 +00:00
Peter von der Ahé a6e37888ee Merge legacy and disable inference modes 
Change-Id: I05d402414e63cd70675b39e5a5976a4d97dd9d0d
Reviewed-on: https://dart-review.googlesource.com/c/85956
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-19 17:21:51 +00:00
Kevin Millikin 87f309463a Stop using asynchronous async in Fasta 
Change all the places that still used old-style asynchronous async in
Fasta.  These were mostly in testing.

Change-Id: I102209aa54c7c6e658b9d6ec98167af62bf12f3e
Reviewed-on: https://dart-review.googlesource.com/c/87074
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-12-14 08:17:35 +00:00
Kevin Millikin a8493e1b50 Flip the default value of the Kernel syncAsync flag 
In Kernel's TargetFlags, this flag still defaulted to false.  Flip the
default to true and update all client code in the SDK.  The
expectation is that many of the places that now pass false explicitly
really just want the default, but that will be verified separately and
then the flag will be removed.

Change-Id: I2a38eb53f280f21f59bb1d2e88c42516f827fd39
Reviewed-on: https://dart-review.googlesource.com/c/85448
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-12-12 14:23:54 +00:00
Jens Johansen c2bd36e94d Add --omit_platform as option to fasta. 
Change-Id: I9f8b7b89a0440bbff8b466ed2e4f2af73c72c023
Reviewed-on: https://dart-review.googlesource.com/c/84428
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-11-30 07:48:15 +00:00
Aske Simon Christensen c9aaa7a654 Re-formulation of type bound violation error messages 
Change-Id: I7f0b99c184b02f6910da054b877b5b5bee86f6bc
Reviewed-on: https://dart-review.googlesource.com/c/85346
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-11-29 13:27:16 +00:00
Aske Simon Christensen c959bd98af Print origins of types in bullet points below error messages. 
This gets rid of the useless '#lib1::' prefixes on types in error
messages and instead adds a line to the error message for each
interface type appearing in the message stating where that type
originates.

Name clashes are disambiguated by appending markers like '/*1*/' and
'/*2*/' to the types whenever two interface types with the same name
appear in the same message.

The commonly used core types 'bool', 'num', 'int', 'double', 'String'
and 'Null' are excluded from the origin list unless they take part in a
name clash.

Change-Id: I017ea376d4f6ff2d4f3b36487774463f03bb3301
Reviewed-on: https://dart-review.googlesource.com/c/84604
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-11-29 13:27:16 +00:00
Aske Simon Christensen 5198e49ffd Use new type labeler API in message generation. 
For now, it uses a dummy implementation that retains the old behavior.

Change-Id: Iab358b73af470b99d5bd0ed59028d96d26bae47f
Reviewed-on: https://dart-review.googlesource.com/c/84603
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-11-29 13:27:16 +00:00
Jens Johansen 1ec63ec7d5 Only one source of truth for uriToSource 
Previously we had several places where different uriToSource was used.
This was both weird and led to errors when something refering to
some state was used to look up in another state.
This CL makes it so we only have one source of truth.

To not include sdk sources when serializing a component that only mixes
something from the sdk in, (or extends it or...), the serialization is
changed slightly to keep track of which uris come from actual
implementation. Before the sdk sources was explicitly removed in the
incremental compiler, but we want to limit those kinds of things,
which is why we're doing it differently here.

Fixes #35215.

Bug: 35215
Change-Id: Iaa5618fcb0ea42b13aba7720f34a87a85144e047
Reviewed-on: https://dart-review.googlesource.com/c/85175
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-11-28 10:57:01 +00:00
Peter von der Ahé 98987d2342 Talk about legacy mode, not strong mode in perf tools 
Change-Id: I5a718b3db7905709caf92ca994784ee64a87b7b3
Reviewed-on: https://dart-review.googlesource.com/c/84410
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-11-14 10:36:21 +00:00
Sigmund Cherem b484aada21 Remove library-root option - replace it with a libraries-spec option instead 
Change-Id: Ie1df52cdaa7ab4381a4c1b94c61a1210f0f31b5f
Reviewed-on: https://dart-review.googlesource.com/c/83641
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-11-09 22:40:28 +00:00
Peter von der Ahé 9137fe26ac Remove deprecated_problems.dart 
Change-Id: I5f6cad8077b9faaf2164dd0f3f1f5d54c59ed0b7
Reviewed-on: https://dart-review.googlesource.com/c/78203
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
 2018-10-16 08:02:49 +00:00
Peter von der Ahé 18cb217840 Remove CompilerOptions.onError and CompilationMessage 
Change-Id: Ia4ff435c6653c42fb27aecc46177a10ff8a8e4a2
Reviewed-on: https://dart-review.googlesource.com/c/78201
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-10-16 08:02:49 +00:00
Peter von der Ahé d4fac1684c Remove CompilerOptions.reportMessages 
Change-Id: I6b3e2f44ef89ba6a234fab97e08f56a69247d13f
Reviewed-on: https://dart-review.googlesource.com/c/77081
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-10-16 05:50:05 +00:00
Peter von der Ahé 54ef78b7c5 Remove non-strong vm dill files from SDK 
Change-Id: Ia9337ec090333902ea8fc2492f2ffdac1bcff2d1
Reviewed-on: https://dart-review.googlesource.com/c/79520
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-10-12 12:42:57 +00:00
Kevin Millikin 2fa1143600 Check classes at mixin applications 
When a declared mixin is applied to a class, the class must implement
the superclass constraint interfaces named in the mixin declaration.

Change-Id: I6ace9fe244c1c87860b69c2c5e68f2c31ae73d7c
Reviewed-on: https://dart-review.googlesource.com/c/79206
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Daniel Hillerström <hillerstrom@google.com>
 2018-10-12 08:34:07 +00:00
Peter von der Ahé 244e6c7ffc Infer package URIs 
Closes https://github.com/dart-lang/sdk/issues/33076

Change-Id: I73db84eadaf3ba723c2f1323f9b883077a4df9df
Reviewed-on: https://dart-review.googlesource.com/c/78246
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-10-11 17:41:50 +00:00