852ef37f71
Some mirrors fixes
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2415053004 .
2016-10-14 12:19:24 -07:00
ae5a566f98
Move minitest.dart into the expect package.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2416853003 .
2016-10-13 14:15:21 -07:00
2305865365
Start cleaning up the HTML tests.
...
My initial goal was just to move some of the HTML tests off unittest,
but that ended up slurping in some other changes as well. I haven't
finished going through all of the tests, but this puts the
infrastructure in place and fixes a batch of them. I'll do more next.
Changes:
- Add a "minitest" package. This shims just enough of the unittest/test
API to make it easy to swap it out for unittest without having to
rework the entire test.
- Go through the HTML tests from A-J and change them to use minitest
when possible. The ones that aren't possible use asynchrony.
Minitest doesn't support async tests (yet, maybe).
- Triage those tests and enable ones that are passing. Mark them failing
if failing. Filed a couple of tracking bugs for the common issues,
but for other cases, I just left a comment.
- In the process of this, I went ahead and make some of the affected
tests strong mode clean if they weren't already and it was easy.
- Synchronize changes between dev_compiler's fork of expect and
pkg/expect. We'll want to unfork those at some point. D-:
This gets dev_compiler from 1985 tests to 2042.
R=jacobr@google.com , vsm@google.com
Review URL: https://codereview.chromium.org/2413073002 .
2016-10-13 08:47:27 -07:00
96f485b075
Fix file name handling on windows
...
Paths on windows were having the drive letter (ex: c:\) recognized as
a URI scheme.
Fixes #27450
R=vsm@google.com
Review URL: https://codereview.chromium.org/2413823002 .
2016-10-12 14:30:15 -07:00
d8505ee264
Fix library name insert and access inconsistency on windows
...
Make naming of libraries on windows consistent with the behaivor on
linux and mac.
Fixes #27576
R=vsm@google.com
Review URL: https://codereview.chromium.org/2415653002 .
2016-10-12 14:14:00 -07:00
2495f6a060
Handle private members in dart:mirrors
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org/2410453002 .
2016-10-10 15:55:20 -07:00
9b6317d571
Stop using unittest in point_test and rectangle_test.
...
This also makes rectangle_test strong mode clean. Alas, the test isn't
passing because of another bug, but once that bug is fixed, it should.
R=vsm@google.com
Review URL: https://codereview.chromium.org/2407913002 .
2016-10-10 11:02:37 -07:00
b30571884f
Use expect instead of unittest for json_lib_test.
...
One step closer to removing the deprecated unittest.
R=vsm@google.com
Review URL: https://codereview.chromium.org/2402123002 .
2016-10-10 09:42:40 -07:00
0132d6114a
Fix for the missing new keyword on an external factory call.
...
Added a test for calling an external factory and updated expected test failures/errors from turning on the tests: js_typed_interop_test
Fixes #27443
R=jacob314@gmail.com , vsm@google.com
Review URL: https://codereview.chromium.org/2394103002 .
2016-10-06 10:24:38 -07:00
8846988b1d
Travis / chrome fixes
...
- Use google-chrome-stable by default
- Use google-chrome-unstable as Canary (instead of trying to determine last-known-good-revision - we has issues with that yesterday)
- Test chrome stable and unstable separately on travis
Try bot:
https://travis-ci.org/dart-lang/sdk/builds/165541943
R=kevmoo@google.com
Review URL: https://codereview.chromium.org/2396433007 .
2016-10-06 08:33:06 -07:00
ef973f7d56
Restore unittests
...
Fixes #27261
R=jmesserly@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org/2345853002 .
2016-10-05 16:58:53 -07:00
4b2d1e06f3
Workaround from Chromium breakage
...
We're installing the latest Chromium Canary on travis. It appears
broken on Linux. Pinning pending further investigation.
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2398843002 .
2016-10-05 16:32:11 -07:00
20e402c43d
Fix type errors in math.min() and math.max().
...
Really, this works around them, but the workaround is all round better
code.
Remove the Dart implementations of min() and max() and just forward to
the JS ones. In DDC, all numbers are double, so the type checks to
handle them specifically aren't meaningful. Also, we don't need the
other special case checks in there to help dart2js optimize them.
R=vsm@google.com
Review URL: https://codereview.chromium.org/2386493003 .
2016-09-30 13:18:07 -07:00
2c313a43ac
Fix some errors around []= in core types.
...
- Get rid of JSMutableIndexable since it isn't useful.
- Make JSIndexable generic. (I think dart2js already did.)
- Add .length to NativeTypedArray since it no longer inherits it from
JavaScriptIndexingBehavior.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2378423003 .
2016-09-30 13:03:10 -07:00
6144c10409
Fix analyzer error
...
Analyzer was complaining that final field was not set. The other constructor
does set, so doing so here as well. We may be able to remove this flag soon,
but I see downstream uses.
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2382463002 .
2016-09-28 10:21:15 -07:00
68d2121fd0
Use .packages instead of pubspec.yaml
...
This runs tests against sdk versions of packages instead of whatever
random version we have in pubspec.yaml.
Travis may be unhappy with the lack of a pubspec.yaml. Here's the try:
https://travis-ci.org/dart-lang/sdk/builds/163270204
R=jmesserly@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org/2371113004 .
2016-09-28 09:49:31 -07:00
3a4b32d957
Update STRONG_MODE.md ( #27391 )
...
Correct quotes.
2016-09-26 11:57:22 +02:00
1129d3d121
fix #27421 , DDC did not generate implicit super calls in some cases
...
this would happen when there was a chain of implicit super calls, leading to an implicit super with field initializers
R=vsm@google.com
Review URL: https://codereview.chromium.org/2365053003 .
2016-09-23 17:06:10 -07:00
361cd4c61c
fix #27408 , reverts "ignore dynamic in inference"
...
this reverts https://github.com/dart-lang/sdk/commit/8c25a41accf52265a89bcc2ffac3bdb7c271f9fb
R=vsm@google.com
Review URL: https://codereview.chromium.org/2360973004 .
2016-09-23 17:01:33 -07:00
ead14fbd74
Update global_compile tool
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2363053003 .
2016-09-23 13:30:18 -07:00
d10d77aada
Remove pubspec.lock
...
Otherwise we break whenever a dep gets updated.
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2370433002 .
2016-09-23 08:45:10 -07:00
adc71ab396
re-land fix #27110 with proper DDC side of changes
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2362563004 .
2016-09-22 15:47:55 -07:00
aae63b7e21
Regenerate DDC SDK
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2358323002 .
2016-09-21 16:39:24 -07:00
a22b3b6205
Runtime fixes on DDC tests
...
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2354383003 .
2016-09-21 16:12:30 -07:00
8e943b8c59
Fix tests
...
This fixed the original 5 static errors from this morning.
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2356413002 .
2016-09-21 13:59:55 -07:00
aa85651820
fix #27403 , use AST summaries in DDC
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2353133004 .
2016-09-20 17:55:09 -07:00
e825d6d63e
Update ddc pubspec.yaml
...
Fixing build ... should we be doing something differently? E.g., not check in the lock file?
TBR=jmesserly@google.com ,rnystrom@google.com
Review URL: https://codereview.chromium.org/2353193002 .
2016-09-20 15:08:05 -07:00
bad7f76374
Fix crashes due to attempts to create an identifier name containing the word <bottom>. Likely there is a better fix but this appears to work for now.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2354603003 .
2016-09-19 14:52:12 -07:00
a4734d4b33
fix #27353 , support @checked covariant parameters in DDC
...
Seems pretty straightforward. Just added a simple test for now.
R=leafp@google.com
Review URL: https://codereview.chromium.org/2340463009 .
2016-09-15 15:42:04 -07:00
7341e3d34c
Cleanup. Fix new analyzer errors due to recent strong mode changes.
...
BUG=
Review URL: https://codereview.chromium.org/2338323004 .
2016-09-15 10:45:05 -07:00
35e7c4c5f5
Always write the source map even if it is inlined. This simplifies bazel rules.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2342643003 .
2016-09-15 10:33:22 -07:00
ecc84b26a4
Break up another large file
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2342733002 .
2016-09-15 07:49:27 -07:00
1c957d548d
fix DDC build: some inference failures are reported now, so we need to update some test type annotations
...
Review URL: https://codereview.chromium.org/2347493002 .
2016-09-14 17:39:27 -07:00
d858c4f2ae
Fix build break.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2346573002 .
2016-09-14 13:07:34 -07:00
bda62939a2
Support generating inlined source maps and wrapping module contents within a JavaScript eval block to improve the debugging experience.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org/2337213003 .
2016-09-14 10:54:47 -07:00
9732138317
Testing support for FF and Safari
...
Also travis support for testing FF. See:
https://travis-ci.org/dart-lang/sdk/builds/159331789
On FF 48, 1965 out of 1979 tests are passing. Run locally:
DDC_BROWSERS=Firefox npm test
On Safari 10 (tech preview), it fails immediately due to a static method named "caller". We disallow it as a field, but not a method right now. If I hack that out, 1972 out of 1979 tests appear to pass.
Run locally by installing tech preview and running:
DDC_BROWSERS=Safari SAFARI_BIN=/Applications/Safari\ Technology\ Preview.app/Contents/MacOS/Safari\ Technology\ Preview npm test
R=jmesserly@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org/2334763002 .
2016-09-14 08:41:43 -07:00
1f10422fd5
Update uses of deprecated API in ddc
...
R=jmesserly@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/2338883002 .
2016-09-13 11:44:38 -07:00
ab47c33f3d
Bump pub version
...
We seem to be hitting an error on travis:
https://travis-ci.org/dart-lang/sdk/jobs/159136296
The pubspec for analyzer 0.28.2-alpha.0 from path has version 0.29.0-alpha.0.
The command "pub get" failed and exited with 65 during .
Looks like the analyzer version bumped forward and was incompatible
with the pubspec.lock entry? Is there a way to avoid this?
TBR=rnystrom@google.com ,jmesserly@google.com
Review URL: https://codereview.chromium.org/2336443002 .
2016-09-11 20:06:36 -07:00
e52613f151
Fix error message
...
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2329493002 .
2016-09-09 09:02:50 -07:00
33ff9a3d4f
Fix type errors in sort().
...
If a comparer isn't provided, it was silently assuming the element type
implements Comparable, even though that isn't required. Fixed to add a
manual cast at each comparison.
A stricter faster approach might be to check that the type argument
itself is a type that implements Comparable, but I don't know if that's
too pessimistic, or even possible to do.
R=vsm@google.com
Review URL: https://codereview.chromium.org/2311513002 .
2016-09-08 17:14:36 -07:00
8c7dd5cd04
Cast InternalMap to Map.
...
It's a tag interface that doesn't declare that it implements Map but all
classes that implement it also implement Map, so just do a cast.
R=vsm@google.com
Review URL: https://codereview.chromium.org/2304323002 .
2016-09-08 16:23:45 -07:00
b797899b35
ignore hints in DDC's build
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2316093003 .
2016-09-08 08:59:11 -07:00
6d31434983
Have setters use strict -> like methods
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2319233002 .
2016-09-07 14:01:14 -07:00
5968e2b9e9
configure travis notifications for DDC, take 2
...
deletes the obsolete travis.yml file
R=vsm@google.com
Review URL: https://codereview.chromium.org/2316983003 .
2016-09-07 11:57:23 -07:00
48817e61f7
fix strong mode messages in pkg/dev_compiler
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2314193002 .
2016-09-07 09:06:24 -07:00
ef14d1460c
configure travis notifications for DDC
...
Review URL: https://codereview.chromium.org/2317933002 .
2016-09-07 09:04:35 -07:00
d837bc1e67
Simple node runner
...
Handy utility to run a test from command line via node.
E.g.:
> node tool/run.js lib/math/math2_test
/Users/vsm/dart/sdk/pkg/dev_compiler/lib/js/amd/dart_sdk.js:1747
throw obj;
^
Expect.equals(expected: <true>, actual: <false>) fails.
> node tool/run.js lib/math/pi_test
pi_test seed: 29735
3.1405
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2318723002 .
2016-09-06 12:40:10 -07:00
38724f0626
Update web_command code so that it continues to use the legacy module loader. Drive by removal of misleading comments.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2303163002 .
2016-09-06 09:57:05 -07:00
df832444ed
Skip flaky (timeout) test
...
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2298883005 .
2016-09-01 16:02:51 -07:00
0c8cd45dea
Regen and fix expectations
...
Caught by travis :-)
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2300753006 .
2016-09-01 15:11:40 -07:00
Vijay Menon