Commit Graph

2256 Commits

Author SHA1 Message Date
Jacob Richman 1b339deab2 Support lazy JS types.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2515353003 .
2016-11-22 10:55:35 -08:00
Dan Rubel f109556fb7 remove unused DDC --package-paths options and MultiPackageResolver
R=vsm@google.com

Review URL: https://codereview.chromium.org/2527433002 .
2016-11-22 11:20:23 -05:00
Jennifer Messerly 180107cec3 add test, fixes #27807
this appears to have been already working correctly

R=vsm@google.com

Review URL: https://codereview.chromium.org/2517193004 .
2016-11-21 16:44:16 -08:00
Vijay Menon de9e3a3005 Set auto breakpoint at various errors
Any reason not to do this?  I generally find when framework code wraps these errors, it just complicates finding the original bug.  Better to just trap.

Perhaps should just inline the call to debugger though.  I put in dart.debugger with the thought of making it configurable.

R=jacobr@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/2519873004 .
2016-11-21 14:40:46 -08:00
Mohamed Hayibor 5595b9698d Fix typos 'overriden' to 'overridden' and '@mustCall super' to '@mustCallSuper' (#27853)
* fix overriden typos to overridden
* Fix @mustCall super to @mustCallSuper
2016-11-18 09:36:25 -08:00
Jennifer Messerly 37029a22de fix #27336, ddc with recursive generic class type args
R=vsm@google.com

Review URL: https://codereview.chromium.org/2516483002 .
2016-11-17 15:38:33 -08:00
Jennifer Messerly 365d9a000a fix #27784 and fix #27785, fromEnvironment constants in DDC
R=vsm@google.com

Review URL: https://codereview.chromium.org/2503803004 .
2016-11-16 12:20:43 -08:00
Jacob Richman fb467ef68a Fix _wrapDartFunction to call the JS set method directly. At one point this code was previously surprisingly generating a direct call to set instead of a call to dsetindex.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2504733002 .
2016-11-15 12:52:28 -08:00
Bob Nystrom 926df1e5b3 Rewrite build_pkgs.sh and build_test_pkgs.sh in Dart.
The bots need to run these before running the tests, so I'm porting them
to Dart so they'll run on Windows.

As a nice bonus, they're much faster now, I'm assuming because we use
one warmed up VM for all of the packages.

build_test_pkgs.sh on my machine went from ~12 seconds to ~4.

R=jmesserly@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2498673003 .
2016-11-15 11:14:37 -08:00
Vijay Menon 588f10ee8e Skip queryall_test on canary. See #27794
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2492903002 .
2016-11-15 09:49:05 -08:00
Jacob Richman 27287baa57 Only re-export the main methods. The ddc codegen doesn't depend on any other methods being exported and export code for top level fields and all JS interop types was broken. This change reduces code size of a large Angular2 app by 6%.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2500283002 .
2016-11-15 09:35:44 -08:00
Vijay Menon 9da150f2fb Mark two more tests as passing on DDC / FF
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/2498423002 .
2016-11-15 08:42:41 -08:00
Vijay Menon 5716000c23 Mark test as passing on FF
Now passing on FF 50.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/2506663002 .
2016-11-15 08:18:09 -08:00
Kevin Moore 48d02a0f87 update codereview.settings for DDC
R=vsm@google.com

Review URL: https://codereview.chromium.org/2505443002 .
2016-11-14 15:28:50 -08:00
Vijay Menon 22c27800b6 Support for debugging DDC tests under devtool
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2501183002 .
2016-11-14 15:21:12 -08:00
Vijay Menon bc980498a1 Fix ddc whitelist op
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2492523004 .
2016-11-09 15:23:04 -08:00
Jacob Richman 3356f82eb3 Fix crashing bug for closures of the form () { return; }
BUG=
R=jmesserly@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2484913004 .
2016-11-08 15:14:10 -08:00
Jennifer Messerly 8f04f902df fix #27771, create directory if needed
R=vsm@google.com

Review URL: https://codereview.chromium.org/2483753004 .
2016-11-08 10:21:31 -08:00
Jennifer Messerly 3995146b55 fix #27775, enum declaration where "name" is a property
R=vsm@google.com

Review URL: https://codereview.chromium.org/2488543002 .
2016-11-08 10:18:55 -08:00
Kevin Moore f05e2b0760 recompile for 4179bd7601
Review URL: https://codereview.chromium.org/2484853002 .
2016-11-07 11:02:36 -08:00
Kevin Moore 4179bd7601 Apply codec change from fb968553 to DDC copy
Closes https://github.com/dart-lang/sdk/pull/27724

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2481703003 .
2016-11-07 10:59:22 -08:00
Bob Nystrom 8daf4cfb73 Get the basics of deferred libraries working.
References to loadLibrary on a library prefix are compiled to a
helper function that returns a Future that always completes
successfully.

The deferred libraries aren't actually deferred, but code that uses
loadLibrary() now doesn't barf.

BUG=#27343
R=vsm@google.com

Review URL: https://codereview.chromium.org/2477673006 .
2016-11-07 10:41:23 -08:00
Vijay Menon d062fd7994 Fixes #27752
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2473143003 .
2016-11-03 18:01:05 -07:00
Jacob MacDonald 1aff39dd13 replace / with . in sourceUrl to prevent breaking relative source uris in source maps (#27730) 2016-11-03 12:22:55 -07:00
Vijay Menon 4874480d55 Move FF and Canary to green on travis
Try run is here:
https://travis-ci.org/dart-lang/sdk/builds/172400947

R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2467063002 .
2016-11-03 07:44:27 -07:00
Vijay Menon 69279d6b62 Fix summary path for tests
Should get travis back to green

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2470053002 .
2016-11-01 21:12:01 -07:00
Jennifer Messerly 2e8d011ca3 fix #27607, add dev_compiler summary to the SDK and move JS files
R=vsm@google.com

Review URL: https://codereview.chromium.org/2474523003 .
2016-11-01 18:17:43 -07:00
Vijay Menon 9d34f30c9c Build collection as a separate test pkg
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2462263002 .
2016-11-01 06:04:57 -07:00
Vijay Menon 830cf7c3ea Test packages with ddc on travis
Here's a setup to test build of various SDK packages with DDC and strong mode per commit on travis.

It's not an ideal setup:
- If deps / files change, this will need updating.
- It only breaks on error, not warning.
- It doesn't actually run any package tests.

I haven't gone through all packages either.  Might be worth automating something like this.

See try-run here:

https://travis-ci.org/dart-lang/sdk/builds/172066040

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2465923003 .
2016-11-01 06:01:45 -07:00
Vijay Menon 2d15b4ae74 Type-related fixes
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2468493003 .
2016-10-31 15:01:29 -07:00
Natalie Weizenbaum dddede61fe Allow trailing options in DDC. (#27691) 2016-10-31 14:23:58 -07:00
Vijay Menon e8fbfc4f0d Mark test as runtime failure
pkg collection is now clean.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2466533002 .
2016-10-31 06:00:59 -07:00
Jan-Hendrik Dolling 89560c68a0 change "the the" to the 2016-10-28 21:47:50 +02:00
Jennifer Messerly bdeb6023af fix #27672, call computeConstantValue for metadata
R=vsm@google.com

Review URL: https://codereview.chromium.org/2458693003 .
2016-10-27 14:05:54 -07:00
Jennifer Messerly 644c1dca75 fix #27429, html wrapper methods pass incorrect number of arguments
R=vsm@google.com

Review URL: https://codereview.chromium.org/2454173003 .
2016-10-27 13:16:00 -07:00
Vijay Menon f276f3422f Mark test strong clean for DDC
TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2457753002 .
2016-10-27 16:13:43 +02:00
Adão Júnior 205e9a58e1 DDC readme links pointing to current repository (#27662) 2016-10-26 10:50:46 -07:00
vsmenon 2cafc4d044 Update README.md 2016-10-24 09:01:50 +02:00
Jennifer Messerly ce76fc1fe5 fix #27644, allow "dart" and "dartx" to be renamed if needed
R=vsm@google.com

Review URL: https://codereview.chromium.org/2435223002 .
2016-10-21 11:48:19 -07:00
Jennifer Messerly 982f9f46ed fix #27642, static members should now work
R=vsm@google.com

Review URL: https://codereview.chromium.org/2440863002 .
2016-10-21 11:25:47 -07:00
Jennifer Messerly 95ef8bb59a fix #27643, failed to virtualize fields if an abstract one is mixed in
R=vsm@google.com

Review URL: https://codereview.chromium.org/2441693003 .
2016-10-20 16:31:06 -07:00
Vijay Menon ce963596f0 Emit API-only summaries
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2435203002 .
2016-10-20 16:21:53 -07:00
Jennifer Messerly cc1ad8cdde fix #27532, implementing a native type with fields
R=vsm@google.com

Review URL: https://codereview.chromium.org/2430953006 .
2016-10-20 15:59:18 -07:00
Jennifer Messerly 5111675810 fix #27631, get/set methods no longer shadow index operator
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2435163002 .
2016-10-20 15:45:29 -07:00
Brian Wilkerson 96750cd5cb Split out options from ContextBuilder
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2425423009 .
2016-10-20 11:03:11 -07:00
Alan Knight 47150f50d5 Use dart:html prefixes (e.g. webkitAudioNode) on other browsers
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2431443002 .
2016-10-19 16:43:41 -07:00
Jacob Richman 4f6ce11bc8 Emulate compiling a source file in the context of an existing library. Add --debugger-compile flag that performs permissive dynamic calls on private members. Polish web_command.dart adding the ability to evaluate code in the context of an existing library.
BUG=
R=brianwilkerson@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/2423313002 .
2016-10-18 16:34:48 -07:00
Nicholas Shahan 3f67c24cb8 Revert "Fix library name insert and access inconsistency on windows"
This reverts commit d8505ee264.

It was found to cause issues in the web file system when one file
was found to be within a root path.

R=jacobr@google.com

Review URL: https://codereview.chromium.org/2432603002 .
2016-10-18 16:25:03 -07:00
Vijay Menon a032a4c952 Revert "Fix file name handling on windows"
This appears to break on bazel.

BUG=
R=nshahan@google.com

Review URL: https://codereview.chromium.org/2422403002 .
2016-10-17 15:27:48 -07:00
Bob Nystrom 60a966605d Remove uses of unittest in the HTML tests where possible.
This finishes going through the dev_compiler HTML tests and switches
out unittest for minitest wherever possible.

In the process, it gets another 10 tests strong mode clean, and gets
several more passing, and more not skipped. With this CL, we're running
another 50 more HTML tests (though some are expected to fail, mostly
because of #27578).

R=jacobr@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2419863002 .
2016-10-14 13:44:19 -07:00