Commit Graph

899 Commits

Author SHA1 Message Date
Bob Nystrom 9b6317d571 Stop using unittest in point_test and rectangle_test.
This also makes rectangle_test strong mode clean. Alas, the test isn't
passing because of another bug, but once that bug is fixed, it should.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2407913002 .
2016-10-10 11:02:37 -07:00
Bob Nystrom b30571884f Use expect instead of unittest for json_lib_test.
One step closer to removing the deprecated unittest.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2402123002 .
2016-10-10 09:42:40 -07:00
nshahan 0132d6114a Fix for the missing new keyword on an external factory call.
Added a test for calling an external factory and updated expected test failures/errors from turning on the tests: js_typed_interop_test

Fixes #27443

R=jacob314@gmail.com, vsm@google.com

Review URL: https://codereview.chromium.org/2394103002 .
2016-10-06 10:24:38 -07:00
Vijay Menon ef973f7d56 Restore unittests
Fixes #27261

R=jmesserly@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/2345853002 .
2016-10-05 16:58:53 -07:00
Vijay Menon 68d2121fd0 Use .packages instead of pubspec.yaml
This runs tests against sdk versions of packages instead of whatever
random version we have in pubspec.yaml.

Travis may be unhappy with the lack of a pubspec.yaml.  Here's the try:

https://travis-ci.org/dart-lang/sdk/builds/163270204

R=jmesserly@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/2371113004 .
2016-09-28 09:49:31 -07:00
John Messerly 1129d3d121 fix #27421, DDC did not generate implicit super calls in some cases
this would happen when there was a chain of implicit super calls, leading to an implicit super with field initializers

R=vsm@google.com

Review URL: https://codereview.chromium.org/2365053003 .
2016-09-23 17:06:10 -07:00
John Messerly 361cd4c61c fix #27408, reverts "ignore dynamic in inference"
this reverts https://github.com/dart-lang/sdk/commit/8c25a41accf52265a89bcc2ffac3bdb7c271f9fb

R=vsm@google.com

Review URL: https://codereview.chromium.org/2360973004 .
2016-09-23 17:01:33 -07:00
Vijay Menon a22b3b6205 Runtime fixes on DDC tests
TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2354383003 .
2016-09-21 16:12:30 -07:00
Vijay Menon 8e943b8c59 Fix tests
This fixed the original 5 static errors from this morning.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2356413002 .
2016-09-21 13:59:55 -07:00
John Messerly aa85651820 fix #27403, use AST summaries in DDC
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2353133004 .
2016-09-20 17:55:09 -07:00
John Messerly a4734d4b33 fix #27353, support @checked covariant parameters in DDC
Seems pretty straightforward. Just added a simple test for now.

R=leafp@google.com

Review URL: https://codereview.chromium.org/2340463009 .
2016-09-15 15:42:04 -07:00
John Messerly 1c957d548d fix DDC build: some inference failures are reported now, so we need to update some test type annotations
Review URL: https://codereview.chromium.org/2347493002 .
2016-09-14 17:39:27 -07:00
Jacob Richman d858c4f2ae Fix build break.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2346573002 .
2016-09-14 13:07:34 -07:00
John Messerly 6d31434983 Have setters use strict -> like methods
R=leafp@google.com

Review URL: https://codereview.chromium.org/2319233002 .
2016-09-07 14:01:14 -07:00
John Messerly 48817e61f7 fix strong mode messages in pkg/dev_compiler
R=vsm@google.com

Review URL: https://codereview.chromium.org/2314193002 .
2016-09-07 09:06:24 -07:00
Vijay Menon df832444ed Skip flaky (timeout) test
TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2298883005 .
2016-09-01 16:02:51 -07:00
Vijay Menon 0c8cd45dea Regen and fix expectations
Caught by travis :-)

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2300753006 .
2016-09-01 15:11:40 -07:00
Vijay Menon 9af2fb0115 More DDC mirrors support
(Note, this is a straight migration of the old DDC repo CL. :-))

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2301973002 .
2016-09-01 10:13:31 -07:00
Vijay Menon b220f63954 Travis config
See try-run here: https://travis-ci.org/dart-lang/sdk/builds/156699868

R=kevmoo@google.com

Review URL: https://codereview.chromium.org/2301833002 .
2016-09-01 08:33:50 -07:00
John Messerly ade24133a1 remove unused DDC status files
TBR=vsm@google.com

Review URL: https://codereview.chromium.org/2298933004 .
2016-08-31 18:32:00 -07:00
Vijay Menon 367b3626f0 Mark test flaky
TBR'ing to get travis green

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2294333002 .
2016-08-31 09:51:18 -07:00
Vijay Menon 6a1a03add4 Make source map paths relative
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2288453002 .
2016-08-26 16:31:53 -07:00
John Messerly 8081afc785 fix travis bots
- increase timeout so we load all tests
- mark a few more failures
- skip unittest tests until we re-triage them

Review URL: https://codereview.chromium.org/2279053002 .
2016-08-25 13:23:14 -07:00
John Messerly c1139934a7 fix #626, add AMD module format and make it default
R=nweiz@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2249233002 .
2016-08-25 09:39:36 -07:00
Jacob Richman 87577db2b2 Add dart:js_util library and tests to ddc. This library is already added to dart2js and dartium.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2269963005 .
2016-08-24 09:13:06 -07:00
Vijay Menon 124e71473a Add mirrors tests
Doh!

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2265533002 .
2016-08-19 08:37:45 -07:00
Vijay Menon 0516f9f545 Regression test dart:mirrors
About 50 tests pass right now.  A bunch more fail.

See #199

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2256393002 .
2016-08-19 08:27:20 -07:00
Vijay Menon 8442efa4d3 Support call methods on functions
Fixes #624

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2255993002 .
2016-08-18 07:51:17 -07:00
John Messerly a076edad94 roll analyzer
R=vsm@google.com

Review URL: https://codereview.chromium.org/2254883002 .
2016-08-17 21:10:21 -07:00
John Messerly 90a8667c06 remove unused test baseline files 2016-08-16 08:22:18 -07:00
John Messerly 43fe94ae35 remove unused test expectation files
R=vsm@google.com

Review URL: https://codereview.chromium.org/2246353002 .
2016-08-16 08:19:18 -07:00
John Messerly 36273565e3 fixes #610, incorrect help output
R=nweiz@google.com

Review URL: https://codereview.chromium.org/2244703003 .
2016-08-12 15:06:41 -07:00
John Messerly 0aa5cbd128 fix #620, infer the input files from sources
also simplifies build of packages used by our tests
this caused a bunch of tests that use parts to start passing

R=nweiz@google.com

Review URL: https://codereview.chromium.org/2234343003 .
2016-08-11 13:19:36 -07:00
Vijay Menon 8fec051a8e Mark recursive_inheritance_test as passing
This will get the dev and master bots green.

Will need to bump the pubspec on analyzer (once published) to make stable green after this.

R=leafp@google.com

Review URL: https://codereview.chromium.org/2214263005 .
2016-08-05 09:35:01 -07:00
Vijay Menon 3ddb76b95c Reify type params on map literals
Fixes #621

R=jmesserly@google.com, leafp@google.com

Review URL: https://codereview.chromium.org/2211293002 .
2016-08-05 07:16:02 -07:00
Vijay Menon 0fd3e8821c Fix wrt analyzer tip
This sidesteps #618 for now.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2209473002 .
2016-08-02 14:42:06 -07:00
John Messerly e51f9de339 fixes #616, statics on callable functions
also fixes `this` for them

R=vsm@google.com

Review URL: https://codereview.chromium.org/2200913002 .
2016-08-01 17:12:37 -07:00
John Messerly 344124e4a1 fix optional params to mock methods, allow all signatures
switches to use the same technique as `dsend`

R=vsm@google.com

Review URL: https://codereview.chromium.org/2201973002 .
2016-08-01 16:21:59 -07:00
Vijay Menon b2353d7513 Fix analyzer error
This is breaking travis.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2199473002 .
2016-07-29 14:31:46 -07:00
John Messerly 0f29ee9618 Remove DDC custom error list now that strong mode analyzer handles it
R=leafp@google.com

Review URL: https://codereview.chromium.org/2102053003 .
2016-07-27 13:10:57 -07:00
John Messerly c3ee6dc5ee fix #606, allow specifying the summary file extension
R=paulberry@google.com

Review URL: https://codereview.chromium.org/2176763002 .
2016-07-22 11:39:35 -07:00
John Messerly c1e97b495f fix #603, support mock objects
if noSuchMethod is used to implement an abstract member, this will be detected and appropriate code will be generated.

R=leafp@google.com

Review URL: https://codereview.chromium.org/2158173003 .
2016-07-19 13:24:02 -07:00
Leaf Petersen 0315595d60 Check in codegen test expectations.
Codegen output is checked into repository to make codegen regressions
more visible (especially readability regressions).

BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2128353002 .
2016-07-07 15:57:22 -07:00
Leaf Petersen fceb82f49d Fix null aware generic invocation.
Fixes #600

BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2132763002 .
2016-07-07 13:07:17 -07:00
Andrew Krieger 87bcbf9147 Move type tagging logic out of setSignature
setSignature is only called for classes with constructors or static
members, so previously _runtimeType was only set explicitly on such
classes. Now _runtimeType is not set on any classes except for Object,
and all other types inherit _runtimeType from Object.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2076713002 .
2016-06-27 15:29:15 -07:00
John Messerly d27eda4ffc implement user-defined nSM, Object members on functions
fix #591 and fix #59

R=vsm@google.com

Review URL: https://codereview.chromium.org/2061373003 .
2016-06-22 17:18:52 -07:00
Vijay Menon e8e19b4c5a Verify status of statically failing tests
This should catch tests that suddenly start failing (or passing).

This is an admittedly contrived approach to track compilation failures in
the same runtime logic: the statically failing tests are now compiled
to a trivial output that throws a particular exception.  Ideally, we
wouldn't run these, but it's beneficial to keep status in the same
place.

On my laptop, this only adds ~8s to presubmit (which takes ~2:30 min).

Ideas on alternative approaches welcome.  :-)

R=jmesserly@google.com, leafp@google.com

Review URL: https://codereview.chromium.org/2079373002 .
2016-06-22 06:25:48 -07:00
John Messerly 430e8f15af Partial fix for call methods #542
This fixes the generated code to support these. Subtype checks are not fixed yet.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2069903002 .
2016-06-16 16:38:43 -07:00
Stan Manilov 715c845d85 Add a regression test for bug #587
BUG= https://github.com/dart-lang/dev_compiler/issues/587
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2075493002 .
2016-06-15 16:58:57 -07:00
John Messerly 477182e88d fix worker_test 2016-06-14 14:54:20 -07:00