dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

899 Commits

Author SHA1 Message Date
Vijay Menon 77cd33722b Mark test failing on FF 
Jacob: looks like you changed the test just before the holidays?

TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2610843002 .
 2017-01-04 05:53:57 -08:00
Bob Nystrom dca3e74882 blob_constructor_test is passing now. 
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2598853002 .
 2016-12-21 17:11:22 -08:00
Jacob Richman 7f26211c26 Correct handling of cross-frame functions in ddc. 
Misc fixes of dart:js support on ddc.
Work around issue with Blob constructor on ddc.
Fix incorrect dart:js test on dart2js (fixes https://github.com/dart-lang/sdk/issues/26197)

BUG=
R=alanknight@google.com, leafp@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2587203002 .
 2016-12-19 15:00:55 -08:00
Dan Rubel 13bd1ad0bf DDC/AnalyzerCLI common cmdline option processing 
Refactor DDC and Analyzer CLI command line option processing
to use common createContextBuilderOptions method
and ContextBuilderOptions to hold common options.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2584293003 .
 2016-12-19 16:24:20 -05:00
Jennifer Messerly 77f53f609f fixes #27385, implement virtual fields in DDC 
If a field is marked @virtual in Analyzer, DDC will allow it to be overridden as well

also fixes #28114, abstract getters/setters broke generation of forwarding getters/setters

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2571363002 .
 2016-12-15 11:39:25 -08:00
danrubel e321439470 cleanup Analyzer CLI and DDC arg parsing 
This removes the need to split arguments on '='
before calling the extractDefinedVariables method.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2581723002 .
 2016-12-15 12:16:20 -05:00
danrubel 5b84611856 refactor DDC to support --ignore-unrecognized-flags 
* add --ignore-unrecognized-flags to DDC
* refactor Analyzer CLI to use same filterUnknownArguments functionality
* remove now unused CommandLineParser and associated tests

R=brianwilkerson@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2578113002 .
 2016-12-15 10:46:09 -05:00
danrubel eea098a315 fix DDC codegen test 
TBR

Review-Url: https://codereview.chromium.org/2579693002 .
 2016-12-14 22:24:39 -05:00
danrubel 1d4334739c update DDC to use analyzer extractDefinedVariables 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2578463004 .
 2016-12-14 20:43:53 -05:00
Vijay Menon 392c242df9 Add dart:io stubs to ddc sdk, define dart.library.html 
Fixes #27302

R=brianwilkerson@google.com, jmesserly@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2578573003 .
 2016-12-14 12:34:33 -08:00
Bob Nystrom 6c757957db Move the dev_compiler strong mode tests into sdk/tests/. 
DDC's codegen test copies those files to a local "gen" directory so
that it can do stuff like splitting out the multitests before it
compiles them to JS.

I left all of that alone, so the rest of DDC's test infrastructure is
unchanged. The very first step that builds the "gen" directory just
copies from sdk/tests/..._strong/... instead and the rest is good to go.

I did not move not_yet_strong_tests.dart somewhere more accessible yet
because I'm not sure if kernel needs it or where it should go.

I did not create any status files because DDC doesn't need them and
there are no test suites for the new directories for the other
platforms.
 2016-12-09 11:09:55 -08:00
Vijay Menon e0e7efc351 Support callable classes where call is inherited 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2560983002 .
 2016-12-08 12:04:10 -08:00
Jennifer Messerly ef4baafae5 fixes #28032, await in cascade 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2559883002 .
 2016-12-07 14:00:18 -08:00
Vijay Menon 94e4a98671 Migrate tests for initializing formals 
BUG=#27894
R=eernst@google.com

Review URL: https://codereview.chromium.org/2534293002 .
 2016-12-07 10:58:02 -08:00
Vijay Menon 69f0218802 Mark test pass on Chrome 55 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/2554523002 .
 2016-12-05 05:55:44 -08:00
Vijay Menon 201c5b9297 Fix runtime strong mode error in ListMixin 
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2544163002 .
 2016-12-01 15:41:46 -08:00
Vijay Menon ec81359fc0 Fixes #27960 
For "m.call(..)", the function is "m".

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2539033004 .
 2016-12-01 15:38:46 -08:00
Alan Knight 1ff09b431f Keep only a single active stack trace, enables traces for thrown non-exceptions 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2545923002 .
 2016-12-01 13:41:08 -08:00
Vijay Menon 88c5dd5745 Better mirrors support for mixins and private fields 
This is generally motivated by pageloader usage.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2535273002 .
 2016-11-29 14:00:01 -08:00
Jacob Richman 1370b6bb46 Fix handling of static names for JS interop and improve test coverage. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2536823003 .
 2016-11-29 13:33:19 -08:00
Vijay Menon 22f85df76e Fix expectation 
I copied over the new version of the test for sdk/tests and dropped the 'negative'.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2536903005 .
 2016-11-29 10:28:27 -08:00
Brian Wilkerson 3e51e6d3c9 Fix reference to validate method 
R=paulberry@google.com

Review URL: https://codereview.chromium.org/2536233002 .
 2016-11-29 09:57:27 -08:00
Jacob Richman 1b339deab2 Support lazy JS types. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2515353003 .
 2016-11-22 10:55:35 -08:00
Jennifer Messerly 180107cec3 add test, fixes #27807 
this appears to have been already working correctly

R=vsm@google.com

Review URL: https://codereview.chromium.org/2517193004 .
 2016-11-21 16:44:16 -08:00
Mohamed Hayibor 5595b9698d Fix typos 'overriden' to 'overridden' and '@mustCall super' to '@mustCallSuper' (#27853) 
* fix overriden typos to overridden
* Fix @mustCall super to @mustCallSuper
 2016-11-18 09:36:25 -08:00
Jennifer Messerly 37029a22de fix #27336, ddc with recursive generic class type args 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2516483002 .
 2016-11-17 15:38:33 -08:00
Jennifer Messerly 365d9a000a fix #27784 and fix #27785, fromEnvironment constants in DDC 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2503803004 .
 2016-11-16 12:20:43 -08:00
Vijay Menon 588f10ee8e Skip queryall_test on canary. See #27794 
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2492903002 .
 2016-11-15 09:49:05 -08:00
Vijay Menon 9da150f2fb Mark two more tests as passing on DDC / FF 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/2498423002 .
 2016-11-15 08:42:41 -08:00
Vijay Menon 5716000c23 Mark test as passing on FF 
Now passing on FF 50.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/2506663002 .
 2016-11-15 08:18:09 -08:00
Jacob Richman 3356f82eb3 Fix crashing bug for closures of the form () { return; } 
BUG=
R=jmesserly@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2484913004 .
 2016-11-08 15:14:10 -08:00
Jennifer Messerly 8f04f902df fix #27771, create directory if needed 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2483753004 .
 2016-11-08 10:21:31 -08:00
Jennifer Messerly 3995146b55 fix #27775, enum declaration where "name" is a property 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2488543002 .
 2016-11-08 10:18:55 -08:00
Bob Nystrom 8daf4cfb73 Get the basics of deferred libraries working. 
References to loadLibrary on a library prefix are compiled to a
helper function that returns a Future that always completes
successfully.

The deferred libraries aren't actually deferred, but code that uses
loadLibrary() now doesn't barf.

BUG=#27343
R=vsm@google.com

Review URL: https://codereview.chromium.org/2477673006 .
 2016-11-07 10:41:23 -08:00
Vijay Menon 4874480d55 Move FF and Canary to green on travis 
Try run is here:
https://travis-ci.org/dart-lang/sdk/builds/172400947

R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2467063002 .
 2016-11-03 07:44:27 -07:00
Vijay Menon 69279d6b62 Fix summary path for tests 
Should get travis back to green

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2470053002 .
 2016-11-01 21:12:01 -07:00
Jennifer Messerly 2e8d011ca3 fix #27607, add dev_compiler summary to the SDK and move JS files 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2474523003 .
 2016-11-01 18:17:43 -07:00
Vijay Menon 2d15b4ae74 Type-related fixes 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2468493003 .
 2016-10-31 15:01:29 -07:00
Vijay Menon e8fbfc4f0d Mark test as runtime failure 
pkg collection is now clean.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2466533002 .
 2016-10-31 06:00:59 -07:00
Jennifer Messerly 644c1dca75 fix #27429, html wrapper methods pass incorrect number of arguments 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2454173003 .
 2016-10-27 13:16:00 -07:00
Vijay Menon f276f3422f Mark test strong clean for DDC 
TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2457753002 .
 2016-10-27 16:13:43 +02:00
Jennifer Messerly ce76fc1fe5 fix #27644, allow "dart" and "dartx" to be renamed if needed 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2435223002 .
 2016-10-21 11:48:19 -07:00
Jennifer Messerly 982f9f46ed fix #27642, static members should now work 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2440863002 .
 2016-10-21 11:25:47 -07:00
Jennifer Messerly 95ef8bb59a fix #27643, failed to virtualize fields if an abstract one is mixed in 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2441693003 .
 2016-10-20 16:31:06 -07:00
Jennifer Messerly cc1ad8cdde fix #27532, implementing a native type with fields 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2430953006 .
 2016-10-20 15:59:18 -07:00
Jennifer Messerly 5111675810 fix #27631, get/set methods no longer shadow index operator 
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2435163002 .
 2016-10-20 15:45:29 -07:00
Bob Nystrom 60a966605d Remove uses of unittest in the HTML tests where possible. 
This finishes going through the dev_compiler HTML tests and switches
out unittest for minitest wherever possible.

In the process, it gets another 10 tests strong mode clean, and gets
several more passing, and more not skipped. With this CL, we're running
another 50 more HTML tests (though some are expected to fail, mostly
because of #27578).

R=jacobr@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2419863002 .
 2016-10-14 13:44:19 -07:00
Bob Nystrom ae5a566f98 Move minitest.dart into the expect package. 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2416853003 .
 2016-10-13 14:15:21 -07:00
Bob Nystrom 2305865365 Start cleaning up the HTML tests. 
My initial goal was just to move some of the HTML tests off unittest,
but that ended up slurping in some other changes as well. I haven't
finished going through all of the tests, but this puts the
infrastructure in place and fixes a batch of them. I'll do more next.

Changes:

- Add a "minitest" package. This shims just enough of the unittest/test
  API to make it easy to swap it out for unittest without having to
  rework the entire test.

- Go through the HTML tests from A-J and change them to use minitest
  when possible. The ones that aren't possible use asynchrony.
  Minitest doesn't support async tests (yet, maybe).

- Triage those tests and enable ones that are passing. Mark them failing
  if failing. Filed a couple of tracking bugs for the common issues,
  but for other cases, I just left a comment.

- In the process of this, I went ahead and make some of the affected
  tests strong mode clean if they weren't already and it was easy.

- Synchronize changes between dev_compiler's fork of expect and
  pkg/expect. We'll want to unfork those at some point. D-:

This gets dev_compiler from 1985 tests to 2042.

R=jacobr@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2413073002 .
 2016-10-13 08:47:27 -07:00
Vijay Menon 2495f6a060 Handle private members in dart:mirrors 
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2410453002 .
 2016-10-10 15:55:20 -07:00