dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

4090 Commits

Author SHA1 Message Date
Konstantin Shcheglov 78da03cd97 Extract protocol_dart.dart APIs. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1398333002 .
 2015-10-12 06:58:34 -07:00
Paul Berry 9767634564 Fix manual editing of integration_test_methods.dart. 
In commit 9ad256cf18,
integration_test_methods.dart (an auto-generated file) was edited
manually.  The only necessary changes were to imports--the other changes
were the result of sorting declarations and running the formatter.

This CL replicates the necessary changes in the code generator and
re-runs it, un-doing the other changes.  This should fix the test
"pkg/analysis_server/tool/spec/check_all_test".

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1397353002 .
 2015-10-12 06:49:02 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
 2015-10-11 07:34:28 -07:00
pq 695256d586 Linter hookup into AS. 
Note the TODO to fix the extension manager interaction hijinx.  Really we should ensure that we are only using the one in engine.  At the moment, it's easy to get this wrong (as the initialization heroics herein testify).

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1392683003 .
 2015-10-09 13:40:07 -07:00
Keerti Parthasarathy 6352acfaa8 add completion tests 
BUG=
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1393693003 .
 2015-10-09 11:08:07 -07:00
Konstantin Shcheglov 6ae14b5774 Update required 'analyzer' version. 
The library 'dart:profile' was removed.
Without this new version I cannot start DAS from sources in IDEA.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1403493003 .
 2015-10-09 08:25:31 -07:00
Brian Wilkerson a296d57a5c Comment out debugging code 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1398503004 .
 2015-10-09 08:09:53 -07:00
Brian Wilkerson 190cc1ae82 Remove an unused test 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1396983004 .
 2015-10-09 08:09:04 -07:00
Brian Wilkerson 8f4c63c92b Restructure the public API for server 
R=danrubel@google.com, paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1392253002 .
 2015-10-09 07:57:00 -07:00
Konstantin Shcheglov abfa9bf46a Move getCamelWords() to the strings.dart file. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1394933003 .
 2015-10-08 21:31:27 -07:00
pq d6d2e6f3c6 Options plugin initialization fix. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1400473004 .
 2015-10-08 14:52:42 -07:00
pq e292918cff Back out options plugin notifications. 
Pending investigation of AbstractContextManagerTest failures.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1393383002 .
 2015-10-08 12:53:43 -07:00
Konstantin Shcheglov b4091099be Fix DAS, use all the Analyzer plugins. 
R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org/1398803002 .
 2015-10-08 12:35:21 -07:00
pq e19f10fbec Add context to OptionsProcessor callback API. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1392143002 .
 2015-10-08 10:47:06 -07:00
Konstantin Shcheglov 307612582b Show UsedLocalElements and parts ASTs on the status pages. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1392173002 .
 2015-10-07 21:41:17 -07:00
Brian Wilkerson 870d9196ee Add dependency information to the status pages 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1392863003 .
 2015-10-07 16:58:19 -07:00
Leaf Petersen 651221bb82 Resolve ordering issues. 
This CL changes the way that the task model does strong mode inference to use the strongly connected components in the import/export graph.  Library cycles are computed and inference is staged by forcing each stage of inference to happen across an entire library cycle at once, and to force all external dependencies of a library cycle to have completed inference before inference for the library cycle can begin.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1386023002 .
 2015-10-07 16:14:35 -07:00
pq 37d4be8f61 Improved AS benchmarking metrics. 
Notably:
  * adds support for multiple metrics via the `--metric` flag  (e.g., `--metric outline,navigation,highlighting`).
  * captures timings in a list in case there are multiple results (e.g., outline before and after resolution).

R=keertip@google.com

Review URL: https://codereview.chromium.org/1395573002 .
 2015-10-07 13:09:15 -07:00
Konstantin Shcheglov 63d8b70fce Add 'Add != null' quick fix. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24518

Review URL: https://codereview.chromium.org/1393953002 .
 2015-10-07 10:18:23 -07:00
pq fe76c6f3c4 Lint support for the new task model. 
Related bug: https://github.com/dart-lang/analyzer_cli/issues/64

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1385293002 .
 2015-10-06 16:45:45 -07:00
Paul Berry b76da2d61e Turn on the new task model by default in analysis server. 
The previous option for enabling the task
model ("--enable-new-task-model") is replaced with an option for
disabling it ("--disable-new-task-model").

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1390843002 .
 2015-10-06 13:49:52 -07:00
pq df52deea9f More pluggable AS benchmarks. 
R=keertip@google.com

Review URL: https://codereview.chromium.org/1387823005 .
 2015-10-06 13:02:46 -07:00
Dan Rubel d329551747 (TBR) fix completion test - see #24511 
Review URL: https://codereview.chromium.org/1384823005 .
 2015-10-06 14:40:27 -04:00
danrubel d14a963546 only send final completion notification 
This shaves 1 ms off the average completion notification response time

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1389473002 .
 2015-10-06 14:21:29 -04:00
Dan Rubel a96541b369 fix call to get current source - fixes #24509 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1385213002 .
 2015-10-06 13:36:28 -04:00
pq 90e975b656 Suppress scanner errors for non-existent URIs. 
Fixes #23754.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1378503003 .
 2015-10-06 10:25:50 -07:00
pq d21c6ef67e Benchmarking for navigation results. 
R=keertip@google.com

Review URL: https://codereview.chromium.org/1386003002 .
 2015-10-05 15:46:28 -07:00
Konstantin Shcheglov b107dec41a Spec change: include covering expressions into Extract Local protocol. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1388783003 .
 2015-10-05 14:44:32 -07:00
Brian Wilkerson 8e523195e6 Move refactoring APIs into provisional 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1387703003 .
 2015-10-05 12:51:57 -07:00
Brian Wilkerson 7bbd8c66a5 Move completion APIs to private location 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1383313002 .
 2015-10-05 11:57:35 -07:00
Brian Wilkerson ba318117d8 More documentation clean-up for server APIs 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1389713002 .
 2015-10-05 11:04:09 -07:00
pq 8697392367 AnalysisError hasFix attr (Implements #23874). 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1385523002 .
 2015-10-05 09:46:17 -07:00
Brian Wilkerson 04c5a5f199 Clean up hints 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1382403002 .
 2015-10-05 09:20:44 -07:00
Konstantin Shcheglov 147581cf34 Remove the 'name' and 'length' getters from IndexableObject. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1378843003 .
 2015-10-05 07:27:50 -07:00
Konstantin Shcheglov 0e7f4b5717 Fix hover documentation for parameters. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1384583007 .
 2015-10-05 07:04:20 -07:00
Konstantin Shcheglov e6053aa135 Rollback https://codereview.chromium.org/1380223003 
TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1390463002 .
 2015-10-04 17:07:10 -07:00
Konstantin Shcheglov 1af7b154af Issue 23694. Include 'docSummary' and 'docComplete' into CompletionSuggestion. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23694

Review URL: https://codereview.chromium.org/1380223003 .
 2015-10-04 16:16:45 -07:00
Konstantin Shcheglov 0b01edac17 More tests for 'Organize Directives'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1380893003 .
 2015-10-02 13:11:34 -07:00
Konstantin Shcheglov c06ad0db30 Issue 24420. Don't allow renaming in pub packages. 
There are no ideal solution for this.
But all our users want it somehow.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24420

Review URL: https://codereview.chromium.org/1380253003 .
 2015-10-02 13:09:55 -07:00
Brian Wilkerson 66a122a9db Stop defensively copying AST structures before resolution 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1383043002 .
 2015-10-02 12:38:18 -07:00
danrubel 04e21a2a7c Completions with exact prefix should be prioritized - fixes #23099 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1369033002 .
 2015-10-02 15:12:23 -04:00
danrubel 6e441f62e8 only suggest rethrow inside catch block - fixes #24214 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1360123003 .
 2015-10-02 15:10:14 -04:00
Konstantin Shcheglov 62fd9ac787 Issue 24487. Annotations with constructor resolution should produce navigation reginos to constructors. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24487

Review URL: https://codereview.chromium.org/1378713004 .
 2015-10-02 10:44:58 -07:00
danrubel 8eef458f9c add completion after export - fixes #24400 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1368173004 .
 2015-10-02 13:00:06 -04:00
danrubel a24ae72e74 suggest argument name completions for annotations - fixes #24296 and fixes #24259 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1362353003 .
 2015-10-02 12:54:22 -04:00
Konstantin Shcheglov 03e379de7a Compute Outline.kind/libraryName actually. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24279

Review URL: https://codereview.chromium.org/1380103005 .
 2015-10-01 13:09:38 -07:00
Florian Schneider c4d0ff8a4c pkg: Eliminate flaky analysis test failure. 
Running in debug mode (or any slower configuration) makes this test fail since
it waits for a max of 100 event loop iterations for the analysis results.

Instead wait without limit until results are ready, with checking every few milliseconds.

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1379153002 .
 2015-10-01 19:34:50 +02:00
Konstantin Shcheglov 9d48af9ee3 Specification change for the 'libraryName' and 'partOfLibraryName' fields in Outline. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1375163003 .
 2015-10-01 09:53:20 -07:00
Konstantin Shcheglov 7beaf28f32 Always include Object and its members into 'inherited'. 
Analyzing them honestly is too expensive.

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//1375313004 .
 2015-09-30 18:23:53 -07:00
Konstantin Shcheglov 184fe4ae58 Publish new version of analyzer and use it in AS. 
R=pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//1377233002 .
 2015-09-30 11:15:23 -07:00