dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

4090 Commits

Author SHA1 Message Date
Dmitry Olshansky 13bbbd0d79 Remove duplicate key in kindMap 
Got error on a buildbot because of that.
Strangely it was passing for some time
and then failed.

R=erikcorry@google.com

Review-Url: https://codereview.chromium.org/2697553002 .
 2017-02-13 13:26:26 +01:00
Konstantin Shcheglov 65559748eb AnalysisDriver.getUnitElement() should return a structure with a key. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2691433008 .
 2017-02-12 14:57:57 -08:00
Devon Carew 4667e59e85 Add integration tests for the execution domain. 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2691763002 .
 2017-02-12 11:23:33 -08:00
Brian Wilkerson 92550811ac Add conversion routines from the plugin API to the server API 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2689903002 .
 2017-02-12 08:19:13 -08:00
Konstantin Shcheglov ad8e38881b Fix for 'Rename Local' refactoring without tasks. 
R=devoncarew@google.com, brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2685783012 .
 2017-02-10 16:15:31 -08:00
Devon Carew d60a930ccd Commit updated metadata; this should reduce scm churn. 
BUG=
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2692573005 .
 2017-02-10 15:31:27 -08:00
Konstantin Shcheglov f120d02f92 Enable Dart for all modules. 
R=devoncarew@google.com
BUG=

Review-Url: https://codereview.chromium.org/2686183004 .
 2017-02-10 13:27:55 -08:00
Devon Carew 0fee414672 Suppress a few analysis warnings in the analyzer codebase. 
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2688253002 .
 2017-02-10 13:16:28 -08:00
Devon Carew 86a235e219 Add intellij metadata to the repo. 
BUG=
R=pquitslund@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2689673003 .
 2017-02-10 12:47:06 -08:00
Konstantin Shcheglov 663b7f665e Analysis.getHover should return the field's documentation for field formal parameters. 
Also return the parameter's element with completion suggestion.

R=brianwilkerson@google.com
BUG= https://github.com/flutter/flutter-intellij/issues/385

Review-Url: https://codereview.chromium.org/2681233005 .
 2017-02-10 08:49:40 -08:00
Konstantin Shcheglov 46eff8e389 Implement also 'execution.mapUri' for file to URI. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2681393004 .
 2017-02-10 08:48:02 -08:00
Devon Carew bc9cadac04 Add tests to vaildate the analysis server's integration test coverage. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2685883005 .
 2017-02-09 14:26:26 -08:00
Konstantin Shcheglov 0a09ff53c3 Include the field documentation for named field formal parameter completion suggestions. 
R=brianwilkerson@google.com, devoncarew@google.com
BUG= https://github.com/flutter/flutter-intellij/issues/385

Review-Url: https://codereview.chromium.org/2683233002 .
 2017-02-09 13:24:25 -08:00
Konstantin Shcheglov af539081cd When addSource() in tests, call both addFile() and changeFile(). 
This fixes the two failing tests.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2681733007 .
 2017-02-09 08:50:57 -08:00
Brian Wilkerson a191011c03 Update ChangeBuilder to the new driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2688513003 .
 2017-02-09 07:51:42 -08:00
Brian Wilkerson 5d0fa7dc21 Finish file rename operation (TBR) 
Review-Url: https://codereview.chromium.org/2685783005 .
 2017-02-08 13:56:56 -08:00
Konstantin Shcheglov 2f741af001 Fix for 'execution.mapUri' with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2682983002 .
 2017-02-08 08:40:59 -08:00
Brian Wilkerson a69189972c Add failing test 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2683793003 .
 2017-02-08 08:13:37 -08:00
Devon Carew 5f8341a388 Update the contributing file for the analysis server. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2685913002 .
 2017-02-08 08:13:20 -08:00
Brian Wilkerson 407985cbce Support merging with priority information 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2683673003 .
 2017-02-07 10:05:20 -08:00
Brian Wilkerson 37720f012f Use toList to copy lists and clean up errors and warnings 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2685613002 .
 2017-02-07 09:00:09 -08:00
Brian Wilkerson ccdf574d49 Add support for merging results from plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2678673002 .
 2017-02-07 08:06:59 -08:00
Konstantin Shcheglov 0c19c418c2 Add EvictingFileByteStore and make FileByteStore non-evicting. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2676363003 .
 2017-02-06 10:10:41 -08:00
Brian Wilkerson 06b3f47434 [Gardening] Remove an invalid (and flaky) test 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2681493002 .
 2017-02-06 10:09:03 -08:00
danrubel 1680c434f2 suggest method references in named expressions 
Fix https://github.com/dart-lang/sdk/issues/25386

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2679503002 .
 2017-02-06 12:59:05 -05:00
danrubel 02adcc9614 suggest catch and finally keywords 
After a try block that does not have a "catch" block,
suggest the "catch" keyword and nothing else.
After a "catch" block, suggest the "finally" keyword.

Fix https://github.com/dart-lang/sdk/issues/27560

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2662973007 .
 2017-02-06 12:57:57 -05:00
Konstantin Shcheglov 6e422fd0a7 Don't search for 'declaration' of elements, just name is usually enough. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2677833002 .
 2017-02-05 12:21:17 -08:00
Brian Wilkerson 9c9de9e48c Add code to locate a plugin within a package 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2671773007 .
 2017-02-05 11:58:05 -08:00
Brian Wilkerson 2f81decdd7 Add a test that server does not send errors when errors have been disabled 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2674863004 .
 2017-02-04 09:46:55 -08:00
Brian Wilkerson a8f65e61a9 Initial support for managing partial results from plugins 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2676593006 .
 2017-02-04 09:46:08 -08:00
Konstantin Shcheglov 7d2447d795 Replace computeNode() with AstProvider in search. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2672973002 .
 2017-02-03 10:40:44 -08:00
Konstantin Shcheglov f600f5f9de Stop using Element.computeNode() in refactorings and fixes. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2669353002 .
 2017-02-02 17:24:31 -08:00
Konstantin Shcheglov 69f9f781cc Implement Search.classMembers() using getFilesDefiningClassMemberName(). 
This fixes the performance problem you saw on class renames.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2674493004 .
 2017-02-02 10:48:19 -08:00
Dan Rubel f33c3c1676 complete named params in constructors 
This add completion suggestions for named parameters
in constructors and factories, and prevents other suggestions
such as type names, identifiers, etc when they are not appropriate.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2671533002 .
 2017-02-01 14:36:41 -05:00
Konstantin Shcheglov 811d0caad2 Don't send 'Response.refactoringRequestCancelle' if the request is null. 
Not sure how to reproduce this, but saw this in the exceptions log.
Just once, so must be a pretty event, but still.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2665403002 .
 2017-02-01 10:06:24 -08:00
Paul Berry 6f0f50dc1e Streamline AnalysisDriver status tracking. 
- Removed AnalysisDriver.status stream.  Outside of tests, we weren't
  using it.  Inside of tests, it was easy to switch to
  AnalysisDriverScheduler.status.

- Moved waitForIdle from AnalysisDriver to AnalysisDriverScheduler.

- Added a mechanism to ensure that AnalysisDriverScheduler.waitForIdle
  really waits for idle, even if AnalysisDriverScheduler.status hasn't
  been notified that we are analyzing yet.  This mechanism does the
  right thing even if we later discover that there is no analysis to
  be done (and so no event is ever sent to
  AnalysisDriverScheduler.status).

- Removed an unnecessary check from the loop in
  AnalysisDriverScheduler._run().

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2665263002 .
 2017-02-01 09:22:53 -08:00
Devon Carew 09725fc5c8 Show the platform version in the analysis server status page. 
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2661043004 .
 2017-01-31 18:33:40 -08:00
Konstantin Shcheglov 75fff1fdb6 Implement completion in WithDirective. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2665053004 .
 2017-01-31 15:06:54 -08:00
Konstantin Shcheglov 678021c7cf Fix SDK partitions leak in tests. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2668103002 .
 2017-01-31 13:04:13 -08:00
Brian Wilkerson fb5e367ca5 Update server generator 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2668733002 .
 2017-01-31 08:26:10 -08:00
Brian Wilkerson 058b5a9c5b Add missed return leading to an NPE 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2668523002 .
 2017-01-30 13:46:32 -08:00
Konstantin Shcheglov d29ba1e238 Store exceptions with transitive files context into ByteStore. 
The key under which the exception context is stored, is included into
ExceptionResult, so Analysis Server can include the key into the message.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2663903002 .
 2017-01-30 12:57:44 -08:00
Konstantin Shcheglov 6be5d918d0 Fix strong mode warning in the 'getter to method refactoring.' 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2662893002 .
 2017-01-30 08:53:13 -08:00
Konstantin Shcheglov 2acfb1d818 ContextBuilder should to throw when a root folder does not exist. 
Otherwise, removing an analysis root with .analysis_options file
causes an exception.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2660073002 .
 2017-01-29 09:37:24 -08:00
Kevin Moore c1a0b12159 use latest pkg/isolate 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2662723002 .
 2017-01-28 13:53:17 -08:00
Konstantin Shcheglov 8c738c2dad Revert "Revert "Enable the new analysis driver by default, use --disable-new-analysis-driver to disable."" 
This reverts commit 878775607c.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2658273002 .
 2017-01-27 12:13:04 -08:00
Konstantin Shcheglov 47967ac9f2 Guard against FunctionExpression nodes with null parameters. 
I see this exception in logs, but I was not able to find which Dart
code would cause this.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2664493004 .
 2017-01-27 11:57:08 -08:00
Janice Collins 93c3a194ad Better error message for missing async with await 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2662483003 .
 2017-01-27 10:48:27 -08:00
Konstantin Shcheglov f1f5d490d7 Fix MockSdk.fromFileUri() implementations. 
This should fix the test failure on Windows bot.

TBR

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2653753006 .
 2017-01-25 12:08:25 -08:00
Brian Wilkerson ed40bd3eca Add failing test for sort issue 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2655803004 .
 2017-01-25 09:06:49 -08:00