578629ad26
Add migration support for property accesses.
...
Also made some minor improvements to the handling of method calls.
Change-Id: I8728a7901cfe61f88563b71e290e9d5b303afda1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104486
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-03 14:51:34 +00:00
b1e28691d1
Only create hard edges for local variable/parameter references.
...
Exception: also create hard edges for the relation between a type
argument and the corresponding type parameter bound, because that
can't be fixed by a null check.
Change-Id: I71b21ddb11c1bb1060cb6f13efde13855770e2b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104485
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-06-03 14:51:34 +00:00
8776bdbf42
Rename migration visitors to reflect terminology in the design doc
...
Change-Id: I9e554356032700bbbac93df4e754fa1fc1c67041
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104484
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-03 14:51:34 +00:00
e31af09992
Remove NullabilityMigrationAssumptions class.
...
This was a lot of bookkeeping for very little added value. If we want
to experiment with changing the behavior of the migration tool in the
future, we should experimentally change it and see whether the quality
of the migration improves; it's not worth speculatively keeping
multiple behaviors around while the tool is being developed.
Change-Id: I9a59e2626be7e9e84a937e287421abcdc971aba5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104482
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-06-03 02:20:26 +00:00
709df79404
Clean up logic to decide whether to create hard edges
...
Previously we were creating hard edges for the default values of
optional parameters. This was incorrect; we don't want a hard edge
because we don't want evidence of non-nullability to propagate
upstream from an optional parameter to the const expression that sets
its default value.
Change-Id: I44e12ae96987fd7a9defc538b0704cf76262473f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104500
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-06-03 02:20:26 +00:00
01694dcca1
Handle nullability nodes for dynamic types more cleanly.
...
Rather than use an edge from `always` to ensure that these nodes are
nullable (which is error prone since it could be overridden by an
assertion), we simply place these nodes in the ordinary nullable state
at the time they are created.
As a side effect we can reduce the amount of code we have to plumb the
nullability graph through.
Change-Id: I46cf5b2026aeb2917cb35a7ad0d36a0a0562ecc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-06-03 02:20:26 +00:00
9aa88b1168
Add a const bool to make it easy to enable dumping the nullability graph
...
Change-Id: I6fc5c5f78cf1665f2551206979ebb5246f03c998
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104480
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-06-03 02:20:26 +00:00
c229555d87
Rework the graph representation for the migration tool based on the design doc.
...
Change-Id: I1777042926f83cd2f95da6c6db315a8d49c64df1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104422
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-06-03 02:20:26 +00:00
ca84a69609
Modify NullabilityNode to allow the 4 possible states from the design doc.
...
Change-Id: Ic28867227ad6080d693eff7576335e0a15bbe178
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104440
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-06-03 00:00:05 +00:00
2c4a2237d2
Disable search.getDeclarations with summary2.
...
It is unlinked summary based, we don't support it with summary2.
So, to not crash we return the empty list.
R=brianwilkerson@google.com
Change-Id: Ic220ae3526a3a3e2f06c60b4e25d7e7cef69af60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-01 18:21:48 +00:00
519ddc1ac4
Document that AVAILABLE_SUGGESTION_SETS also turns on existingImports.
...
R=brianwilkerson@google.com
Change-Id: I053c68eb541358f0bbd891ca16f1c5628e701096
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104342
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-01 17:27:03 +00:00
577ab8d631
Issue 37129. Check for missing importedLibrary.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/37129
Change-Id: I60f5c1382cdb19988e786fff81e8450a6de3888c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-01 17:26:41 +00:00
190599de78
Skip LSP cancellation handling for Notification requests
...
Change-Id: I0edf6206db66ed07390dafcd5ea72bb2397468fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-05-31 14:45:24 +00:00
5352c67478
Tweaks for 'Import Library' quick fixes to better reflect the expected behavior.
...
R=brianwilkerson@google.com
Change-Id: Ifdeb775636322382a40c800dc02d6f980e309369
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104061
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-30 00:56:09 +00:00
2ef2eb14d5
Fix FixesTest on Windows.
...
R=brianwilkerson@google.com
Change-Id: Ie56b0f876895f559f019b311be6460f95f7e37e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-30 00:19:49 +00:00
98a4dba4b3
Update Element.appendTo to more closely match Dart syntax
...
Change-Id: I74bf13f3b072c734b018517e6d06e182a0736bb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103961
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-05-29 17:06:40 +00:00
a332c414f1
Switch server to using DeclarationsTracker for 'Import Library' quick fixes.
...
We need this to stop using UnlinkedUnit with summary2.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Iaca2f19e6a168818e171f09e6eeda71a75854232
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-29 16:45:32 +00:00
fca2c82be0
Add support for cancelling requests in LSP server
...
Change-Id: I2a651b1e4f8509c7f10d245b2369aab842d08041
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103845
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-29 14:52:40 +00:00
2e51423c3d
Convert the way function types are displayed to better match the syntax of Dart
...
Change-Id: Id5068bd52b3a35c70cb0d2ccc735469e2f8a0d3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103701
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-05-28 20:48:51 +00:00
da3ead02c1
Issue 3446. Recurse into attributes to find children widgets.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/3446
Change-Id: Ifa83367c68b406b342e0f99195015d98eaedb049
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-28 20:09:25 +00:00
fc17a90bed
assist for sorting child properties last
...
Change-Id: Ia39f5b170858789897579f952ece03dcf6765e3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103860
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-28 20:00:05 +00:00
85c28b804d
Check LSP support for workspace/applyEdit before giving CodeActions that require it
...
Change-Id: I88af71be9788bd417a1f739f0f3e0efe930c2cd0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103842
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-05-28 14:10:26 +00:00
e4362612b0
Add support for dynamic registration for LSP
...
Change-Id: I55c7b2f7d683acab0f6aa4bdbcba3b155d2de32c
Change-Id: I6a0b13856053bd86e77637b9664c7fe41194c5f3
Change-Id: I7472cf93efc29585ccbcbd1e6c7b9f703872b3c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103532
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-05-27 17:36:20 +00:00
5b200ea3dc
remove unused import
...
Change-Id: Ib4b92a3cf453ed4f8945f62bf4213f03ceb8910d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-05-25 15:33:35 +00:00
03e415a4e8
Update the hover 'containingLibraryName' to not include the 'file:///' prefix.
...
This is a follow up on a comment in the previous change https://dart-review.googlesource.com/c/sdk/+/103481/ .
Change-Id: I0f377d6c7d68d55464a4e111a6a65715a82e0591
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103546
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2019-05-24 21:54:56 +00:00
4979a51a9c
Add information about existing imports to completion response.
...
This adds quite a lot of information though, because we send many
strings.
Before: 20686 characters.
After: 55345 characters.
Theoretically we could do better, and send information about existing
imports only once as well, so when the user continues typing in a
single file, without touching imports, we don't send any new data
about imports (maybe just a confirmation that it is still the same).
But I'm not sure if this is a worthwhile optimization.
Actually, even included suggestion sets have similar property - they
don't change for a given file, unless there are changes to other
libraries which we might want to include.
R=brianwilkerson@google.com
Change-Id: I2f55e2dc85508849146aa39eb279beabaec937c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103561
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-24 21:35:06 +00:00
e43d81af5f
Folders containing overlayed files should exist even if they do not exist on disk
...
Change-Id: I511b5075cb10b2594dce9dc33f165b64d9527043
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103565
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-05-24 20:47:46 +00:00
e42d4a1d89
fix missing returns in lambdas
...
Change-Id: I5005ffc057749468844d47e8e5c195871586bd57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103601
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-05-24 19:24:02 +00:00
9081f28fbb
[analyzer] fix a copy paste doc issue and 2 unused imports
...
Change-Id: I20f4ae5454c2bceafd3b86e279357dee3b321006
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103644
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2019-05-24 16:31:25 +00:00
dfbc3923e4
add default CompilerContext in analysis server
...
This should uncover the underlying error occurring in
Fix https://github.com/dart-lang/sdk/issues/37055
Change-Id: I633da211b943e5c4262a2f3d83ef0a2217c5b8a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-05-23 22:46:15 +00:00
5822645e66
Support for 'Wrap with Xyz' for expressions in ExpressionFunctionBody.
...
R=brianwilkerson@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/3500
Change-Id: I9e14d6cd1a79070fd489740a881199707be83e90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-23 20:00:26 +00:00
cd2188f2f5
DAS change in hover behavior- the containingLibraryName now returns the URI of the containing library instead of the (possibly non-existent) library name
...
Change-Id: Ief2a7615b92ca635c696d48f907677bae538577b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103481
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-23 19:06:19 +00:00
4fc86d726f
Fix some lints in LSP tests
...
Change-Id: Iff7e69d5d452a7bd405b727ab4966e1d71a89bda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103531
Auto-Submit: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-23 17:54:03 +00:00
cfdcfe2bfe
Update DeclarationsTracker when a context options change.
...
E.g. when .packages changes, we want to re-scan the context for new
available libraries. We also don't want to discard all context, and
resend everything.
R=brianwilkerson@google.com
Bug: https://github.com/Dart-Code/Dart-Code/issues/1723
Change-Id: I19ee71c1d021fb9bcda9d02d86b7cbb078704aa7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-21 18:43:36 +00:00
181685b852
Allow disabling individual server features.
...
Change-Id: I4d06eaf76300c6784b88bd64ad322c306a276488
Bug: https://github.com/dart-lang/sdk/issues/36881
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103182
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-21 18:40:26 +00:00
88f139db68
Fix NPEs when processing unknown kinds in LSP
...
Fixes https://github.com/dart-lang/sdk/issues/37016 .
Change-Id: I72eae50a03bb2c73678b65a07e6924a2a53d137e
Bug: https://github.com/dart-lang/sdk/issues/37016
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103131
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-05-21 13:30:10 +00:00
022adc5bc3
Implement using suggestion sets for LSP completions
...
Change-Id: I66d725c09492040be5e621d80270b12a21bb8192
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102704
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-20 10:09:41 +00:00
0f24e4b277
Wire up LSP completion resolution provider + sendWorkspaceEdit command
...
Change-Id: I424b4d9bbc64f6fea7a4d9b06e2180b3fbd21f86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-20 10:09:41 +00:00
b6ce27a141
Add LSP tests for suggestion sets (marked failing)
...
Change-Id: Iab8f632038f136963ea2e02fa9e9d76c66e32845
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102702
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-20 10:09:41 +00:00
7be23977f1
Minor LSP tweaks in preperation for included suggestionSets
...
Change-Id: I9dff56139754b8a182e906d64dd0bcc009c4b6fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-20 10:09:41 +00:00
42334a7f67
Infer when the bound of a type parameter needs to be nullable.
...
Change-Id: I6c500318a66e05a0b3d10c85f07660dfe37339ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-17 20:41:11 +00:00
8209013be3
Fix DartDoc section in Diagnostics server for LSP
...
Change-Id: I8bb40a08b7b6aa53c962bc5a86eb3e68a330a87c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-05-16 13:34:47 +00:00
14d21859e7
Make assertConnection failures easier to debug
...
Change-Id: I0f3934826c7464ec3d3c4f3d206a75ab53ce4ab7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-15 15:55:39 +00:00
6805bb52ea
Add implementation/tests for textDocument/Implementation
...
Fixes https://github.com/dart-lang/sdk/issues/36896
Change-Id: Ie450c6c5257ac13aa3c7b48343aa8b015b1dc4d8
Tweak tests to require all, plus fix empty classes
Change-Id: Iefff7e24c6b965f0a1bc5abf8adbac26ad38e3a0
Add implementation/tests for textDocument/Implementation
Change-Id: I640379d83aeb9baa73d04d98d39147e2b748d6c3
Bug: https://github.com/dart-lang/sdk/issues/36896
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102366
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-15 09:08:28 +00:00
3a7ce7a646
Enable declarations tracker for LSP to support dart doc macros
...
Change-Id: I614be91ecf7a1afc377afeee70e559cff324dc61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102368
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-05-15 08:16:18 +00:00
cdcc387084
Add LSP custom notifications for analyzing status
...
Change-Id: I0d26d274c9ccc472da81e45d0c9170104bbd9414
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102370
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-05-15 06:35:48 +00:00
f440f77dd3
Store the nullability graph in the nullability nodes rather than in maps.
...
This should improve performance by avoiding map lookups.
Change-Id: Ic22a4be7486be1b8e9c164e9133c81a4851146a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-13 22:31:44 +00:00
3ecb89ba8c
Move NullabilityGraph into nullability_node.dart.
...
This will allow NullabilityGraph and NullabilityNode to have shared
access to private data without having to expose it to all other
libraries.
Change-Id: Idbef9a60cdeb273cd5739c45d501370d89b653df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102403
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-05-13 22:31:44 +00:00
6080e546c9
Rearrange NullabilityNode class hierarchy.
...
Instead of making immutable nullability nodes derive from mutable ones
(forcing the mutation method to be overridden to thrown an exception),
we make sibling classes for mutable and immutable nodes. This will
allow additional mutation methods to be added in a less kludgy way.
Change-Id: Ib147583e0a9c4b56333ad9c56c3c725f02ab19ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102402
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-05-13 22:31:44 +00:00
bed74d6e97
Remove NullabilityGraph._upstream.
...
Its only purpose was to make NullabilityGraph.getUpstreamNodes fast to
compute, but that function was only used in unit tests anyway so there
was no need for it to be fast. (Minor exception: it was also used in
an assert statement, but I was able to change that to
Nullabilitygraph.getUnconditionalUpstreamNodes).
Change-Id: I8be18560c2f454908eb0e31d198fd22961a89278
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102388
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-05-13 19:23:51 +00:00
Paul Berry