651d589c2f
Remove flaky check from reanalyze_concurrent_test.
...
This should avoid sporadic false failures with this test. If in the
future we genuinely regress bug 21448, there is a danger that this
test won't catch it reliably, but that is mitigated by the fact that
(a) even flaky failures do get noticed, and (b) the bug was severe
enough that it probably would be noticed in manual testing. The extra
risk seems worth it to avoid the sporadic false failures we've been
seeing.
BUG=dartbug.com/21638
R=scheglov@google.com
Review URL: https://codereview.chromium.org//724403003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41870 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-20 22:52:30 +00:00
b8da9bc651
Format and sort analyzer and analysis_server packages.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//725143004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 22:23:53 +00:00
19bd923634
Remove unused fields from analysis_server.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//725153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41743 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-14 15:47:53 +00:00
e36820617a
Fix integration test to avoid new 'Unused local variable' hint.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//700323004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41580 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-06 19:49:40 +00:00
7225ac4794
Enable asynchrony test.
...
This test passes now that dartbug.com/21252 has been fixed.
R=danrubel@google.com
Review URL: https://codereview.chromium.org//700723006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41579 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-06 19:39:20 +00:00
772a0c6b22
Fix 'Unused local variable' hints in analyzer and analysis_server.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//709493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41576 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-06 18:32:54 +00:00
67071bd861
Refactor CompletionSuggestionKind
...
- Remove many CompletionSuggestionKinds that duplicate ElementKind
- Add two new CompletionSuggestionKinds: INVOCATION and IDENTIFIER
- regenerate Analysis Server Dart and Java API and docs
- rework Dart and Java tests
- remove/rename unused Dart and Java classes and methods
- remove unnecessary reference to SDK
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//684183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41396 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 16:09:56 +00:00
02dada3dec
Avoid analysis server crash when reanalyze invoked during analysis.
...
BUG=dartbug.com/21448
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//678413003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41372 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 21:15:59 +00:00
7014ca0b76
Rename package_root.dart test to package_root_test.dart
...
So that the test will be run on the buildbots.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//685843002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41370 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-28 21:10:17 +00:00
ba8b83eac8
Fix analysis server asynchrony test.
...
The test had two bugs: it neglected to account for the
"server.connected" notification, and it failed to allow the test to
run to completion before reporting success. The second bug sometimes
covered up the first, making it look like the test succeeded.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//683573003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41345 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 23:19:17 +00:00
a151361e2d
Add ENUM and ENUM_CONSTANT to the specification.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//677333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41307 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-26 22:01:29 +00:00
0251bcdcf6
Add package root support to analysis server.
...
Not yet hooked up in Dart editor.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//679763002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41292 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-24 20:29:24 +00:00
dc7d2249eb
Fix merge resolution in r41267.
...
Due to an incorrectly resolved merge, r41267 inadvertently
re-introduced the notificationProcessor parameter to Server.start(),
which was removed in r41246.
TBR=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//637283008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41272 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 20:43:16 +00:00
61c3ef6bd6
By default, don't use observatory during integration tests.
...
TBR=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//676623003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41268 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 19:31:48 +00:00
5d9ff4c570
Add support for attaching observatory to the server.
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//651243005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41267 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 19:18:08 +00:00
51fb6c5a9e
Issue 21377. Specify that navigation regions are sorted and implement it.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21377
Review URL: https://codereview.chromium.org//649853004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41261 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 17:18:13 +00:00
751e087262
Add package root setting to analysis server API.
...
The command does not have any effect yet.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//672003002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41253 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-23 00:11:36 +00:00
7611c5415a
Add an integration test to verify that server I/O is asynchronous.
...
Currently disabled, since server I/O is currently synchronous.
BUG=dartbug.com/21252
R=danrubel@google.com
Review URL: https://codereview.chromium.org//668953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41246 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-22 15:48:06 +00:00
6742866101
Add "checked mode compile time error" type to analysis server API.
...
This avoids a crash if the analyzer detects a checked mode compile
time error.
R=brianwilkerson@google.com , danrubel@google.com
Review URL: https://codereview.chromium.org//636313002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41000 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-08 20:52:29 +00:00
1f50bf550a
Remove special list behavior in analysis server protocol.
...
Previously, for optional lists, the absence of a list was treated by
the toJson and fromJson methods as equivalent to the presence of an
empty list. This disagreed with the API documentation in several
places and created the risk of null reference exceptions in clients.
This change makes optional lists behave just like optional fields of
any other type.
BUG=dartbug.com/21230
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//625413002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40939 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-06 16:32:14 +00:00
b4af87636b
Change integration test notifications to use structured objects.
...
This allows us to use completions when writing code to handle server
notifications in integration tests.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//631553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40916 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-06 01:04:51 +00:00
1363c77a02
Change integration test send...() methods to return structured objects.
...
This allows us to use completions when analyzing responses from the
server in integration tests.
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//628783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40909 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-04 17:37:47 +00:00
a5e47c8eb2
Change integration test send...() methods to use structured objects.
...
This is less error prone than using raw JSON, and requires less effort
when writing integration tests.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//621383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40904 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-03 18:52:47 +00:00
2d00d5e2c0
Specify when 'sortMembers' will return an error.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//604333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40719 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-26 17:12:15 +00:00
3bacc7ae1e
Use a separate request for 'Sort members' feature, not a refactoring.
...
As requested in https://codereview.chromium.org/609653002/
R=brianwilkerson@google.com , lukechurch@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//607813003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40713 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-26 15:53:47 +00:00
1f4682b962
Rework launch data
...
R=jwren@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//596893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40610 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-23 22:02:03 +00:00
855f8364d2
Issue 20910. Add SORT_MEMBERS refactoring to the server specification.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20910
Review URL: https://codereview.chromium.org//583843004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40573 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-22 21:54:03 +00:00
604a9e760d
Integration of MOVE_FILE into the server and a couple of fixes.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//583193005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40510 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-19 18:10:56 +00:00
eeb6c26d21
API proposal for the MOVE_FILE refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//587553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40499 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-19 16:20:29 +00:00
3e884db043
Index and search of import prefixes.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//582453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40397 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 20:19:39 +00:00
6cc9d7d887
add element to completion suggestion API
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//572373004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40360 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 23:17:24 +00:00
457050dd88
Add SourceFileEdit.time field.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//574573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40329 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 17:19:37 +00:00
2208ce5587
Split refactoring problems into init, options and final.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//576473003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40318 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 15:14:51 +00:00
9773f61186
Add LABEL ElementKind, completion and highlighting kinds.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//567273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40247 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 15:04:52 +00:00
e7bdefffba
update error handling to send response with stack trace
...
BUG=dartbug.com/20893
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//569743003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40237 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 12:30:07 +00:00
36dca53a87
fix path in generated comment
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//565773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40199 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 05:03:41 +00:00
a9a2c98d53
gracefully handle internal exceptions during request
...
- new SERVER_ERROR response code
- return SERVER_ERROR response if exception when processing request before request can be sent
- send server.error notification if exception occurs anytime while processing request or future work triggered by request
BUG=dartbug.com/20893
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//570453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40198 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 05:01:46 +00:00
f289a1abac
Fix exception in error processing; implement mapUri
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//560103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40109 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 19:54:49 +00:00
bad1890ab3
Implement "analysis.reanalyze" in analysis server.
...
This is accomplished by instructing the context manager to remove all
contexts and recreate them from scratch.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//553193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40106 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 19:20:09 +00:00
d7f0532f29
Add feedback for INLINE_METHOD refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//551963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39992 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 19:26:52 +00:00
4187ed6349
Add feedback for 'Inline Local' refactoring.
...
Also fix for the Java client tests.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//542333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39977 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 16:29:23 +00:00
44c2892f6f
Initial support for execution domain
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//544273003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39974 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 16:21:16 +00:00
29341b4e5e
Rename debug domain to execution
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//547753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39942 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-06 02:43:12 +00:00
77a6daa667
Add error condition INVALID_OVERLAY_CHANGE to analysis server.
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//545323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39925 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-05 19:23:55 +00:00
3661df5b0e
Include additional information into RenameFeedback.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//545943003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39918 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-05 16:39:15 +00:00
67cd1ab0e2
Decode RefactoringFeedback automatically.
...
The implementation is pretty ugly though.
1. I have to add Response into ResponseDecoder.
2. I have to hack EditGetRefactoringParams.fromRequest generation to feel the "id to kind" map.
It would be easier if we decided to return 'kind' in responses.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//541823004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39887 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 21:13:24 +00:00
3ddecb8c64
Use typed RefactoringOptions in the Dart version of the protocol.
...
R=jwren@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//537733002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39875 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 16:21:08 +00:00
9279b9fe81
Fix error handling in analysis.getError.
...
Analysis.getError now has the following behaviors:
- If the file in question does not exist, or is not subject to
analysis, a new error called GET_ERRORS_INVALID_FILE is generated.
- If the server's internal state (the set of active analysis contexts)
changes while the query is in process, the query is transparently
restarted; the client no longer receives a GET_ERRORS_ERROR error.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//532403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39871 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-04 14:34:43 +00:00
8d8ee25cff
Merge analysis_testing package into analysis_server.
...
Note that analysis_server already contains a file test/mocks.dart, so
the mocks.dart file from analysis_testing has been imported as
test/mocks2.dart. I will merge these two into a single file in a
future CL.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//533243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39814 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 18:11:42 +00:00
703df31e12
Rename ExecutableFile.offset to ExecutableFile.kind and fix documentation.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//528053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39774 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 20:13:03 +00:00
paulberry@google.com