Commit Graph

466 Commits

Author SHA1 Message Date
Brian Wilkerson 2ffa8de794 Add notification of analyzed files
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1232393005 .
2015-07-13 15:07:33 -07:00
Brian Wilkerson 10b7db100f Revert "Update Analysis Server highlight API and implementation."
This reverts commit 739847402b.

Rolling the wire protocol API version forward caused existing clients to break, so we're rolling it back until we can find a backward compatible way of adding the new functionality.

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1236433003 .
2015-07-13 09:49:55 -07:00
Konstantin Shcheglov d7c2f4550b Issue 23640. Implement 'analysis.getNavigation' request.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23640

Review URL: https://codereview.chromium.org//1232683003 .
2015-07-10 15:31:25 -07:00
Konstantin Shcheglov 739847402b Update Analysis Server highlight API and implementation.
I think this is a good enough compromise between the existing and IDEA granilarity.

Eclipse plugin CL will follow.

(IN)VALID_STRING_ESCAPE are not implemented yet.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1227143003 .
2015-07-09 11:19:44 -07:00
Konstantin Shcheglov 7e194d8fb5 Change navigation regions generation for constructors.
In IDEA we use navigation regions for resolution.
And so far all navigation regions are for separate identifiers.
This CL splits single regions like "new A.named()" into separate "A" and "named" regions.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1218183007.
2015-07-06 11:27:19 -07:00
danrubel 1647483615 move performance measurement to benchmark/integration
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1219023006.
2015-07-01 12:09:43 -04:00
danrubel d2bd01852f performance measurement improvements
* report mean, 90th, 99th, and std-dev
* increase analysis wait time to 60 seconds
* add option for analysis server localhost diagnostics
* report running old vs new task model
* do not check if src dir exists so that scripts are more portable
* set clientRequestTime for each request
* ensure dir paths have trailing separators

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1221893003.
2015-06-30 18:08:10 -04:00
danrubel d907a4265e (TBR) improve integration test failure message
BUG=

Review URL: https://codereview.chromium.org//1194393002.
2015-06-22 07:04:28 -04:00
Dan Rubel ab5371e9b7 analysis server performance measurement driver first cut
* reads instrumentation file (log file support later)
* tracks initial analysis elapse time
* skeleton structure for adding more operations and tracking

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1163713005
2015-06-04 10:11:59 -04:00
Brian Wilkerson 07dd6b7649 Add lineLength parameter to edit.format request (issue 23519)
R=jwren@google.com

Review URL: https://codereview.chromium.org//1154303005
2015-06-01 09:39:02 -07:00
scheglov@google.com 9efb25fa50 Use package:test_reflective_loader instead of reflective_tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1101003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45365 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 20:54:29 +00:00
brianwilkerson@google.com 4422b7c01e Fix error handling for formatting and update the spec
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1099633004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45296 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 20:57:33 +00:00
danrubel@google.com f117f67660 add optional importUri to completion suggestion
BUG=dartbug.com/23175
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1097083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45288 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 15:32:54 +00:00
paulberry@google.com 4af80fc1e7 Add an analysis server option to enable null-aware-operator support.
The option may be enabled in editor by setting the tracing option
"experimental/nullAwareOperators" (in com.google.dart.tools.core) to
true.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1063613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44909 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-06 14:53:00 +00:00
scheglov@google.com f11ca733d4 Fix 'getHover' integration test.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1054063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44862 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-02 17:16:44 +00:00
danrubel@google.com 62d8532dc5 Gracefully degrade if no source for completion
BUG=dartbug.com/22617
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1044463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44796 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-30 21:43:05 +00:00
brianwilkerson@google.com b396bc4c96 Support refresh of individual analysis roots (issue 22254)
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1047733004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44791 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-30 21:07:23 +00:00
danrubel@google.com a8eb426282 add UNKNOWN_SOURCE error code and remove 2 unused legacy error codes
BUG=dartbug.com/23039
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1042403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44787 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-30 20:12:29 +00:00
scheglov@google.com 0c21dc284c Add 'containingClassDescription' to HoverInformation.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1003193005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44483 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 22:05:05 +00:00
scheglov@google.com 2e77fcdd11 Add an optional 'typeParameters' to Element.
Also use it in Editor, e.g. in Outline.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//990343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44349 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 22:02:44 +00:00
brianwilkerson@google.com cd58e290c4 Reformat
R=paulberry@google.com

Review URL: https://codereview.chromium.org//969113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44151 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 22:43:12 +00:00
brianwilkerson@google.com 3750ba067f Return version with connected notification
R=jwren@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//943723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43892 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 20:45:01 +00:00
scheglov@google.com 6a78250c64 Issue 22476. Outline for enums.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22476

Review URL: https://codereview.chromium.org//934353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43853 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 21:37:27 +00:00
jwren@google.com a46fc6016d Addition of the --no-index flag to the analysis server spec.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//932883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43816 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 17:55:00 +00:00
brianwilkerson@google.com f473ae15a3 Spec changes for issue 22254
Review URL: https://codereview.chromium.org//882643004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43565 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:35:40 +00:00
brianwilkerson@google.com 4468038300 Rework requests in execution domain
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//904733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43556 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 15:49:44 +00:00
brianwilkerson@google.com fcd7fdb93a Fix ambiguous description
R=paulberry@google.com

Review URL: https://codereview.chromium.org//901063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43493 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 01:31:09 +00:00
brianwilkerson@google.com 6ddc37a5cc Disable analysis in hidden directories (fix for issue 22170)
R=paulberry@google.com

Review URL: https://codereview.chromium.org//880313006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43485 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 21:27:43 +00:00
pquitslund@google.com ba6742f9fe Formatter service API tweaks.
Some way to indicate no selection is required in the case where there is none.  I opted for the -1 convention not becuase I particularly like it but because, well, it's convention! :)

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//894863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43369 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:14:22 +00:00
brianwilkerson@google.com 81c90c6492 Specify mapUri for directories
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//896513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43364 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 22:45:50 +00:00
scheglov@google.com c93b24904d Issue 22157. Cancel a pending refactoring request on receiving a new one.
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22157

Review URL: https://codereview.chromium.org//884453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43201 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 19:24:19 +00:00
pquitslund@google.com b9f355d2a4 Library dependencies server API updates (to pass package maps).
R=brianwilkerson@google.com, jwren@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//874373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43193 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-27 17:23:09 +00:00
scheglov@google.com a23f1b3488 Fix the build by disabling asynchrony_test.
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//869343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43124 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 22:11:27 +00:00
danrubel@google.com 4f59e94ce1 update analysis server spec and regen files
this is needed to support new UpdateContentConsumer

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//868893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43088 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 23:14:09 +00:00
pquitslund@google.com 03aa9c33e5 Library Dependencies Analysis service API.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//861893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43077 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 21:26:28 +00:00
jwren@google.com bcad595a17 Revert "Addition of the optional FileReadMode into the server spec."
R=paulberry@google.com

Review URL: https://codereview.chromium.org//838243004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42965 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 17:39:32 +00:00
jwren@google.com 4d1507935d Addition of the optional FileReadMode into the server spec.
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//825393005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42921 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 18:01:46 +00:00
pquitslund@google.com 6fb12789e7 Analysis server format service wiring (and protocol doc update).
R=brianwilkerson@google.com, danrubel@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//833903005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42835 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 20:34:10 +00:00
scheglov@google.com a38a503d86 Replace @ReflectiveTestCase() with @reflectiveTest.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//849863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42821 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 17:11:24 +00:00
pquitslund@google.com f781ec6675 Add generateLints analysis option to the Server protocol API.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//806943004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42745 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 17:38:43 +00:00
danrubel@google.com 2005b07aea Change code completion relevance from CompletionRelevance.LOW/DEFAULT/HIGH to int
This allows the sever to return a more graduated relevance
and facilitates moving client side prioritization over to the server.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//845553005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42735 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 15:30:59 +00:00
scheglov@google.com 3f6fc86c14 Remove remaining references to Angular and Polymer from the analysis server.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//842753004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42713 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 19:37:19 +00:00
pquitslund@google.com e259b02b92 Adds LINTs to the server's generated protocol.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//838283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42711 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 19:05:48 +00:00
paulberry@google.com 94993d5cc1 Include required parameter names when completing a method call.
When a method such as "void m(int i, int j)" is completed, instead of
simply inserting "m()", we insert "m(i, j)", we highlight "i", and we
set up linked position groups for "i" and "j" so that the user can
press tab to move from one parameter to the next.

Optional parameters (both named and positional) are not handled by
this logic--the user must still enter them manually.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//837793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42667 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-07 16:57:39 +00:00
brianwilkerson@google.com ee26309ffb Add format API
R=pquitslund@google.com, rnystrom@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//809213003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42648 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 22:45:41 +00:00
scheglov@google.com 8affb6c015 Upgrade unittest to be able to use isNotEmpty.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//790363006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42380 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 04:07:37 +00:00
brianwilkerson@google.com b8c70eec87 Stop sending unwanted status and fix integration tests
R=paulberry@google.com

Review URL: https://codereview.chromium.org//789603007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42343 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 18:32:21 +00:00
brianwilkerson@google.com 77b819cd76 Report pub status
R=scheglov@google.com

Review URL: https://codereview.chromium.org//800913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42328 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 17:40:04 +00:00
brianwilkerson@google.com 1d4ba5fba7 Add paging support
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//769963003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42084 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-03 15:54:20 +00:00
scheglov@google.com 20d82e5135 Compressed/optimized navigation notification.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//766323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42049 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-01 22:21:28 +00:00