dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

196 Commits

Author SHA1 Message Date
Paul Berry f5ed63f2be Deprecate analysis option "cacheSize". 
This option has had no effect for quite some time.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2392983002 .
 2016-10-04 09:53:56 -07:00
Brian Wilkerson d947a7ba89 Async is no longer optional 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2361433002 .
 2016-09-21 08:29:34 -07:00
Brian Wilkerson 2d9e690e6c Fix newly introduced errors and warnings 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2357553003 .
 2016-09-21 08:01:04 -07:00
Brian Wilkerson 22040876bf Use declared variables to select the correct configuration for resolution 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2345773003 .
 2016-09-16 07:32:40 -07:00
Brian Wilkerson ecc84b26a4 Break up another large file 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2342733002 .
 2016-09-15 07:49:27 -07:00
Brian Wilkerson 6c448b6938 Move exception support to its own library 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2328043002 .
 2016-09-10 11:04:19 -07:00
Konstantin Shcheglov 09b851c97f Don't perform final fields and top-level variables type propagation. 
A similar feature is now implemented in strong mode, and users who
need it, should switch to strong mode.

When we are ready to drop propagated types altogethoer, we could
deprecate or remove UnlinkedVariable.propagatedTypeSlot in IDL.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/26794

Review URL: https://codereview.chromium.org/2288223003 .
 2016-08-29 15:18:12 -07:00
Brian Wilkerson c41427383b Deprecate DirectoryBasedDartSdk and transition existing uses to the new API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2242853002 .
 2016-08-12 09:18:12 -07:00
Konstantin Shcheglov 6df5ea27a5 Revert 6ad38498c8 (PARSED_UNIT). 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2231473002 .
 2016-08-09 10:14:18 -07:00
Konstantin Shcheglov 6ad38498c8 Extract unresolved AST parsing (PARSED_UNIT1) from full parsing, which includes UriBasedDirective(s) resolution. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2229603003 .
 2016-08-08 14:45:27 -07:00
Brian Wilkerson 5b26441dbf Convert server and cli and deprecate the old implementation 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2214613003 .
 2016-08-04 11:28:16 -07:00
Konstantin Shcheglov 6cceb72ea7 Don't report removed sources as changed in CacheConsistencyValidatorImpl. 
Also I believe we don't need this check anymore.
context.getLibrariesContaining(source).isEmpty &&
context.getLibrariesDependingOn(source).isEmpty)

1. It was not used in applyChanges(), which could probably cause losing
some dependencies.

2. Since https://codereview.chromium.org/2172143003 we record that
there are dependencies on the removed, so not existing, source. So,
when the source is added again, _sourceAvailable() will invalidate
its CONTENT and the whole transitive closure of its users.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2209493003 .
 2016-08-03 13:30:09 -07:00
Brian Wilkerson 16cc45417c Make analyzer strong-mode clean 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2196363003 .
 2016-08-01 11:55:15 -07:00
Brian Wilkerson 12dfb8b6ed Keep track of where objects are being referenced in memory status page 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2157613002 .
 2016-07-15 14:21:31 -07:00
Konstantin Shcheglov c706a355b1 Tweak for the type of the 'instances' variable. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2142593002 .
 2016-07-11 13:26:38 -07:00
Brian Wilkerson cfb3f57a97 Initial memory use status page 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2140583003 .
 2016-07-11 10:27:28 -07:00
Konstantin Shcheglov 1ce4c29f51 Validate only private sources, display statistics. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2131303002 .
 2016-07-08 10:07:04 -07:00
Brian Wilkerson 552d209a2a Add links to context information for SDK contexts 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2119713004 .
 2016-07-01 13:10:16 -07:00
pq 71b1359ac8 Option to enable analyzer trailing comma support (#26647). 
(Parser changes to follow.)

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2112073002 .
 2016-07-01 08:40:39 -07:00
Brian Wilkerson e7008947ca Make SDK contexts visible on status page 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2107313002 .
 2016-06-29 10:36:35 -07:00
Brian Wilkerson 3fbb349629 Update status pages to include newer properties 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2023273002 .
 2016-06-01 08:26:30 -07:00
Brian Wilkerson 62eb45dc32 Display additional context information in status pages 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2030573002 .
 2016-06-01 08:11:31 -07:00
Brian Wilkerson 08ce826f3b Gather and report stats on the number of times flushed results are recomputed 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2005403005 .
 2016-05-26 10:58:32 -07:00
Konstantin Shcheglov 0f0b38dab3 Implement stable resolution of generic types without type arguments to their bounds. 
R=brianwilkerson@google.com, leafp@google.com
BUG= https://github.com/dart-lang/sdk/issues/26265

Review URL: https://codereview.chromium.org/1927323002 .
 2016-04-29 08:25:55 -07:00
Brian Wilkerson 97c613aad4 More strong mode changes in analysis_server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1852113002 .
 2016-04-03 17:56:30 -07:00
Brian Wilkerson f9b575e5b3 More strong mode changes to analysis_server 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1855643002 .
 2016-04-01 18:00:04 -07:00
Konstantin Shcheglov d1104de8db Issue 26096. Explicitly compute the result that ensures that directives are resolved in units. 
In the past computing LIBRARY_ELEMENT2 also set elements for directives
in the defining unit AST. But when this unit is flushed and reparsed
we didn't set these directive elements again because LIBRARY_ELEMENT2
is valid. Now resolving directive ASTs to elements is an explicit
dependency.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/26096

Review URL: https://codereview.chromium.org/1854863002 .
 2016-04-01 14:00:38 -07:00
Brian Wilkerson 0d743fbacf Start making server strong mode clean 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1842063003 .
 2016-03-31 08:27:05 -07:00
Brian Wilkerson 0720a24af7 Add information to the status pages about the options for the context associated with the SDK being used by each context. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1814233006 .
 2016-03-19 16:25:15 -07:00
Konstantin Shcheglov bd76934452 Remove old index and search implementations. 
Also rename the new implementation files and classes to remove the
'2' suffix.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1801883002 .
 2016-03-14 12:19:40 -07:00
Brian Wilkerson 7d72c6e1f5 Deprecate the generated AST library and clean up imports 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1788223002 .
 2016-03-12 08:50:48 -08:00
Brian Wilkerson ef1c632679 Clean up some warnings (issue 25964) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1778663006 .
 2016-03-09 17:32:49 -08:00
Konstantin Shcheglov 4d48fa56d0 Listen for context add/remove and unit invalidation to update the index. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1783503004 .
 2016-03-09 14:52:19 -08:00
Brian Wilkerson c4d7f41650 Move folderMap from AnalysisContext to ContextManager 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1750683002 .
 2016-02-29 14:04:46 -08:00
Paul Berry 12a7ccaa52 Don't call deprecated "isPotentiallyMutated..." API from analysis server. 
Analysis server's use of this API was just for generating debug status
anyhow.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1711003002 .
 2016-02-18 10:20:48 -08:00
Brian Wilkerson 71e7ed86c0 Move scanner out of generated and clean up imports 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1693083004 .
 2016-02-14 07:48:44 -08:00
Paul Berry c43622e897 Use ElementAnnotation as the ConstantEvaluationTarget for annotations. 
Previously, we had a special class,
ConstantEvaluationTarget_Annotation, for this purpose.  It held on to
a the AST node for the annotation.  This was bad because it meant that
the presence of any ConstantEvaluationTarget_Annotation referring to a
given compilation unit would keep the entire compilation unit's AST in
memory.

Now we copy just the portions of the AST we need into
ElementAnnotation, just as we do for all other constant evaluation
targets.  In addition to saving memory, this paves the way for
supporting annotations in summaries, by making it possible to compute
the constant value of an annotation without having to consult the full
AST.

Fixes #25285.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1665353002 .
 2016-02-04 15:22:40 -08:00
pq 9bec38cca9 Enumerate resolvers on context status page. 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1665343002 .
 2016-02-04 14:29:31 -08:00
Brian Wilkerson 3ef79232ad Add indication of resolver provider to the status page 
R=jwren@google.com

Review URL: https://codereview.chromium.org/1653093002 .
 2016-02-01 11:36:07 -08:00
Paul Berry 201e980fd2 Rework recent changes to LineInfo to be backward compatible. 
Commit 1ecd06d39c introduced a new getter
to the LineInfo class, breaking clients such as linter that use
LineInfo in an `implements` clause.

This CL reworks the change to be backward compatible.  It may be
reverted once we are ready to roll to a new major version of analyzer.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1625783002 .
 2016-01-23 17:33:20 -05:00
Brian Wilkerson 1ecd06d39c Add a count of total lines to status performance page 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1622713002 .
 2016-01-22 14:37:29 -08:00
Brian Wilkerson d8df717622 Add list length information to the status pages 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1588083003 .
 2016-01-14 13:53:53 -08:00
danrubel 2ae3026c43 add enableAsync to analysis option file flags 
integrate enableAsync into analysis server
include enableAsync on context status page
update api spec to indicate that enableAsync is no longer deprecated

relys on landing https://codereview.chromium.org/1570183002/

fixes #25373

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1574523002 .
 2016-01-08 20:48:07 -05:00
Dan Rubel 99c3be6331 remove old completion API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1536073002 .
 2015-12-19 11:09:48 -05:00
pq 0a32c6b290 Status page diagnostics for elements and docs. 
Related to profiling the cost of storing element docs but the element counts themselves are generally interesting.

Background: https://github.com/dart-lang/sdk/issues/23694

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1537503002 .
 2015-12-16 15:47:51 -08:00
Brian Wilkerson 56fe38f0ab Clean up imports in analysis_server and analyzer_cli (and one missed in analyzer) 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1527793003 .
 2015-12-14 19:31:46 -08:00
pq 62656833d4 Wraps up the server-side of the 'Allow a user to configure which hints are "fatal"' ask (#24452). 
* migrates error filtering from a predicate to a process that can customize severities.
* moves filtering/processing from the `dart` task into the `getErrors` request and the errors notification.

See: https://github.com/dart-lang/sdk/issues/24452

(Pending a thumbs-up, support for CLI to follow.)

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1517723002 .
 2015-12-10 13:35:11 -08:00
Paul Berry 4c28eb6f67 Merge remote-tracking branch 'origin/master' into analyzer-breaking-0.27 2015-12-08 10:16:29 -08:00
Brian Wilkerson ea3ba0e31f Remove deprecated code 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1502213002 .
 2015-12-07 10:24:36 -08:00
Brian Wilkerson 1101a1e0e7 Add more (incomplete) diagnostic support to the status pages 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1503893002 .
 2015-12-07 09:50:37 -08:00