Commit Graph

196 Commits

Author SHA1 Message Date
Brian Wilkerson 0ef2f87f1c Escape file overlay text before inserting it in the diagnostics pages (issue 31906)
Change-Id: I7e0f1b6724e624ef8c91b7a526d5e52332ce0fd5
Reviewed-on: https://dart-review.googlesource.com/35811
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-01-20 19:45:36 +00:00
Brian Wilkerson 4aadf7cf47 Provide additional information about plugins (issue 31951)
Change-Id: I2ba49e12471ae8747d83da25f4bfa912badac39e
Reviewed-on: https://dart-review.googlesource.com/36120
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-01-20 19:04:28 +00:00
Jaime Wren cd878bc433 Create the new flag --use-cfe in the analyzer, analysis server and analyzer_cli and migrate the old behavior of --preview-dart-2 to --use-cfe. The --preview-dart-2 flag is now a no-op, with functionality coming soon.
See https://github.com/dart-lang/sdk/issues/31640

Change-Id: I2db2e7ef6a324cbd5d369b807e331495fed167df
Reviewed-on: https://dart-review.googlesource.com/33121
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
2018-01-08 22:37:05 +00:00
Devon Carew eb427c594a Show the --preview-dart-2 status in the diagnostics page.
Bug:
Change-Id: I04723e80c3181929c7f3da2707b560f779729a74
Reviewed-on: https://dart-review.googlesource.com/25682
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-01 21:48:45 +00:00
Brian Wilkerson c6c7580c92 Add error detection and reporting for errors related to plugins
Change-Id: If17e88b64022fe71c992c5867c80263c0e6b953b
Reviewed-on: https://dart-review.googlesource.com/18781
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2017-11-05 19:21:07 +00:00
Brian Wilkerson 454088ae28 Fix a typo in the status pages
Change-Id: I516a70537d850b94de60dcf63f832518753e5b11
Reviewed-on: https://dart-review.googlesource.com/18760
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2017-11-04 21:57:37 +00:00
Brian Wilkerson 082bbdb6a7 Remove flag and enable asserts in initializers by default
Change-Id: Ia81f5ec936981dc08ff4c740f3511c6b7c9e6eb6
Reviewed-on: https://dart-review.googlesource.com/10740
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2017-10-04 18:45:09 +00:00
Brian Wilkerson e4d44b2dcd Remove more references to the old plugin system
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3004523003 .
2017-08-23 09:25:07 -07:00
Brian Wilkerson b941f148a7 Remove uses of the old plugin model from the analysis server
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3001413002 .
2017-08-23 07:42:13 -07:00
Brian Wilkerson 4c635b7b85 Initial support for an explicit plugin list
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2988343002 .
2017-08-02 11:30:57 -07:00
Konstantin Shcheglov bdd69ccd6c Remove UriReferencedElement with its uri/uriOffset/uriEnd properties.
The 'Move File' refactoring does not work, so I comment out most
of its code.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2982993003 .
2017-07-19 09:31:03 -07:00
Devon Carew 8b7e3ef7e4 add env var info to the diagnostics page
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2981123002 .
2017-07-17 09:22:23 -07:00
Devon Carew ba625804b7 Tweaks to the profiling diagnostics page.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2966383002 .
2017-07-06 11:47:26 -07:00
Brian Wilkerson d2569cc3ee Add lint timing information to the status pages
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2970153002 .
2017-07-05 12:00:42 -07:00
Konstantin Shcheglov 077b6b687d Remove incremental: logger, validator, options.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2968473002 .
2017-06-29 11:51:12 -07:00
Brian Wilkerson e28064f405 Restore partial analysis of analysis options files
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2946313003 .
2017-06-22 08:00:50 -07:00
Brian Wilkerson e0216fef7f Remove ability to disable new analysis driver
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2937323003 .
2017-06-19 08:13:14 -07:00
Devon Carew e523061acc Minor tweaks to the diagnostics page.
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2937623005 .
2017-06-13 19:22:28 -07:00
Brian Wilkerson 62d0376231 Run the sorter to reduce code churn
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2933753002 .
2017-06-12 07:37:14 -07:00
Devon Carew 44854543ea Tweak the look of the ast and element links in the diagnostics page.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2933043003 .
2017-06-12 07:15:35 -07:00
Brian Wilkerson c0617d2015 Add access to AST ane element model data to the status pages
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2928033006 .
2017-06-11 09:44:15 -07:00
Devon Carew 79c2668d2b add memory usage to the diagnostics page
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2927783002 .
2017-06-07 11:28:34 -07:00
Devon Carew 0b79e4d20d update the analyzer and analysis server perf tags
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2917183003 .
2017-06-03 19:51:27 -07:00
Devon Carew 4f2867d86c Add clientID and clientVersion to the diagnostics page.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2925463002 .
2017-06-03 17:53:52 -07:00
Devon Carew 428c0ff59d Expose the exceptions info in the diagnostics page.
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2914383002 .
2017-06-02 09:57:09 -07:00
Devon Carew 7e32f3bd7c Remove dead code related to the diagnostics server.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2918553002 .
2017-06-01 10:31:27 -07:00
Devon Carew 02f7f5fee7 Updates to the diagnostics page.
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2918533002 .
2017-05-31 07:15:20 -07:00
Devon Carew c817241ad6 Update the analysis server diagnostic page - re-enable code completion and overlay pages,
and refactor the css and navigation.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2911313002 .
2017-05-30 18:46:33 -07:00
Devon Carew 1e7ff6bccf Add the analysis options path to the diagnostics page.
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2913493002 .
2017-05-30 13:29:25 -07:00
Devon Carew 03e0a93092 show the enableAssertInitializer setting in the diagnostics page
BUG=
R=brianwilkerson@google.com, danrubel@google.com

Review-Url: https://codereview.chromium.org/2911563002 .
2017-05-26 08:36:26 -07:00
Brian Wilkerson 1c8b59dc31 Update status pages to show package map and plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2904983003 .
2017-05-25 12:51:19 -07:00
Brian Wilkerson a6214b3129 Remove more libraries directives from server
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2894883002 .
2017-05-19 08:42:30 -07:00
Brian Wilkerson fb982f5476 Make server use the common protocol classes
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2879273002 .
2017-05-15 09:35:46 -07:00
Brian Wilkerson e55812a3f2 Unify the server and plugin versions of the generators
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2844273003 .
2017-04-28 07:46:29 -07:00
Konstantin Shcheglov d780f10d72 Remove ReferencedNames(Builder).
Nobody uses them anymore, so there is no point in computing it.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2835703002 .
2017-04-21 14:28:53 -07:00
Brian Wilkerson 9a66373ee9 Fix errors and warnings
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2760993002 .
2017-03-20 11:30:32 -07:00
Devon Carew 8f36669937 Add instrumentation data to the analysis server diagnostics page.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2717253002 .
2017-03-10 14:08:14 -08:00
Devon Carew 6d0be707d0 Some re-organization to the analysis server diagnostics pages.
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2699363002 .
2017-02-18 14:18:55 -08:00
Devon Carew 09725fc5c8 Show the platform version in the analysis server status page.
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2661043004 .
2017-01-31 18:33:40 -08:00
Konstantin Shcheglov 914a117649 Report errors like IMPORT_OF_NON_LIBRARY with the new analysis driver.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2627093010 .
2017-01-12 13:41:52 -08:00
Brian Wilkerson 22f561e914 Reapply "Add support for generic function type syntax, part 1"
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2622303006 .
2017-01-11 14:10:05 -08:00
Brian Wilkerson 85b1e7abbe Revert "Add support for generic function type syntax, part 1"
Review-Url: https://codereview.chromium.org/2624283003 .
2017-01-11 13:30:52 -08:00
Brian Wilkerson 1cd918533d Add support for generic function type syntax, part 1
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2613383003 .
2017-01-11 13:12:10 -08:00
Konstantin Shcheglov 7e15a96b1b Use AnalysisOptions.signature as a way to check compatibility.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2577943003 .
2016-12-15 13:01:06 -08:00
Konstantin Shcheglov 9a9e037e61 Show priority files on the status page.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2542673002 .
2016-11-30 09:25:31 -08:00
Konstantin Shcheglov a573765c18 Status page for the new analysis driver.
Probably more info should be added with time.
But this lets us see drivers and files.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2530273004 .
2016-11-28 09:15:31 -08:00
Brian Wilkerson e63105555b Remove uses of configuration data
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2522543007 .
2016-11-22 11:26:08 -08:00
Brian Wilkerson a3e1a0d395 Enable generic method support by default
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2488043002 .
2016-11-22 09:16:19 -08:00
Paul Berry 1dfa5685ce Update cross-context options encoding to account for patchPlatform.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2486973004 .
2016-11-09 09:12:09 -08:00
Brian Wilkerson 4942f5304a Guard against a hypothetical null pointer dereference
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2421473007 .
2016-10-14 12:31:11 -07:00