dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
73,789 Commits 2 Branches 0 Tags
bb8d145616cd8671a9c31cdfd2b03808c8efd7ce
Commit Graph

73789 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
asiva bb8d145616 Revert "[SDK] Adds an SDK hash to kernels and the VM." 
This reverts commit edde575dcd.

Reason for revert: Breaks the Dart to Flutter roll and golem

Original change's description:
> [SDK] Adds an SDK hash to kernels and the VM.
>
> Adds a new SDK hash to kernels and the VM which is optionally checked
> to verify kernels are built for the same SDK as the VM.
> This helps catch incompatibilities that are currently causing
> subtle bugs and (not so subtle) crashes.
>
> The SDK hash is encoded in kernels as a new field in components.
> The hash is derived from the 10 byte git short hash.
>
> This new check can be disabled via:
>   tools/gn.py ... --no-verify-sdk-hash
>
> This CL bumps the min. (and max.) supported kernel format version,
> making the VM backwards incompatible from this point back.
>
> Bug: https://github.com/dart-lang/sdk/issues/41802
> Change-Id: I3cbb2d481239ee64dafdaa0e4aac36c80281931b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150343
> Commit-Queue: Clement Skau <cskau@google.com>
> Reviewed-by: Jens Johansen <jensj@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=kustermann@google.com,jensj@google.com,cskau@google.com

Change-Id: I34cc7d378e2babdaaca4d932d19c19d0f35422fc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/41802
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152703
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2020-06-26 18:54:17 +00:00
Sam Rawlins a558d576b7 Use ///-style doc comments in analyzer/tool 
Bug: https://github.com/dart-lang/sdk/issues/33892
Change-Id: I67094e84af2ec54ede00b248a2e67d3cebadc576
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152702
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-06-26 18:46:25 +00:00
Sam Rawlins c68fd58513 Use ///-style doc comments in analyzer/test 
Bug: https://github.com/dart-lang/sdk/issues/33892
Change-Id: If61e07fda4d74b1e5171d22403b156855cd00596
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152701
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-06-26 18:45:05 +00:00
Robert Nystrom 48608ce9bc Migrate language_2/variance to NNBD. 
Change-Id: I8e21f82dc241a63f78fb1f6a25669b1aa633788c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152080
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-06-26 18:37:00 +00:00
Robert Nystrom d4154ac6dc Migrate language_2/unsorted to NNBD. 
Change-Id: Iad2963c7f9c184b089dc6d15aa4442f58d194bc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151983
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2020-06-26 18:34:14 +00:00
Robert Nystrom 1ab82dee7e Migrate language_2/nonfunction_type_aliases to NNBD. 
Change-Id: I2cf8ebe11b86549488fa04f18d5e92c1bf9c3a15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152585
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-06-26 18:28:55 +00:00
Sam Rawlins 648b5e9c68 Use ///-style doc comments in analyzer/lib 
Bug: https://github.com/dart-lang/sdk/issues/33892
Change-Id: I573cb81dca6462c571bd6bf7bf309a46fd628967
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152610
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-06-26 17:58:50 +00:00
Jacob MacDonald 04dd5edc6a update fixnum to nnbd version 
Bug:https://github.com/dart-lang/sdk/issues/42274
Change-Id: I18df7926fc8b767ab6ff6d3505f160147217a00f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152605
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
 2020-06-26 17:39:10 +00:00
Sam Rawlins baa5717f78 Use ///-style doc comments in analyzer/lib/src/generated 
Bug: https://github.com/dart-lang/sdk/issues/33892
Change-Id: I0cee47b71702a210c5ace9455ce9aaf914355d05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152683
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-06-26 17:31:58 +00:00
Clement Skau 411c9cc992 [Test] Skips sdk_hash_test for incompatible setups. 
Change-Id: Ib46814516085a5332538ca867caccb61313b8c1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152655
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
 2020-06-26 17:27:08 +00:00
Sam Rawlins a89b7a4ef7 Use ///-style doc comments in analyzer/lib/src/dart 
Bug: https://github.com/dart-lang/sdk/issues/33892
Change-Id: I5c4d112228ab2ee23f59743e005a5fde1ae2fff4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152681
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-06-26 16:48:18 +00:00
Joshua Litt 66c1b51c07 [dart2js] 20 dart2js tests ported to nnbd #1. 
Change-Id: I8cb1bb03655762669ac88775b5aee763e79c4b11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152594
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
 2020-06-26 15:21:42 +00:00
Joshua Litt f4b19b8c2a [dart2js] Support package json files in modular_test_suite. 
Change-Id: I6a17b9604d2a3e01d822a4872a2560f0aff0a63c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152361
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-06-26 15:08:52 +00:00
Clement Skau 1a278118dd [Test] Fixes sdk_hash_test broken by Windows line breaks. 
Change-Id: I4e87b39515e1e99197f7b03759234252b8cfa233
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152653
Auto-Submit: Clement Skau <cskau@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2020-06-26 15:00:52 +00:00
Clement Skau edde575dcd [SDK] Adds an SDK hash to kernels and the VM. 
Adds a new SDK hash to kernels and the VM which is optionally checked
to verify kernels are built for the same SDK as the VM.
This helps catch incompatibilities that are currently causing
subtle bugs and (not so subtle) crashes.

The SDK hash is encoded in kernels as a new field in components.
The hash is derived from the 10 byte git short hash.

This new check can be disabled via:
  tools/gn.py ... --no-verify-sdk-hash

This CL bumps the min. (and max.) supported kernel format version,
making the VM backwards incompatible from this point back.

Bug: https://github.com/dart-lang/sdk/issues/41802
Change-Id: I3cbb2d481239ee64dafdaa0e4aac36c80281931b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150343
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2020-06-26 13:35:42 +00:00
Johnni Winther d5120208b4 [cfe] Update CFE message to use 'null safety' instead of 'non-nullable' 
Closes #42464

Change-Id: I2865cd4ff2fac3c40d5f8b8d26d6b958919682b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152481
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-06-26 13:09:52 +00:00
Daco Harkes da39a4abff [vm/ffi] Remove try-catch from ffi trampoline if no handle scope 
https://dart-review.googlesource.com/c/sdk/+/145591 introduced a try
catch into FFI calls to call ExitHandleScope on the exception path.
However, we only need this try-catch if we actually need to exit the
handle scope on the exception path, which is not the case if we have
no handles in the signature. So this CL makes the try catch optional.

This speeds up ffi calls without handles (tested on JIT x64):
FfiCall.Uint8x01(RunTime): 206.4801280066068 us.
->
FfiCall.Uint8x01(RunTime): 203.7240782236708 us.

Also adds a test that checks that an exception can still be propagated
with Dart_PropagateError from native code when the FFI trampoline has
no try catch.

Change-Id: I9fac7078381c60fb8055b64fff29ea364fbc948f
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-msan-linux-release-x64-try,vm-kernel-precomp-msan-linux-release-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,dart-sdk-linux-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try,front-end-linux-release-x64-try,vm-kernel-precomp-win-release-x64-try,vm-kernel-mac-debug-x64-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-nnbd-linux-debug-x64-try,analyzer-nnbd-linux-release-try,front-end-nnbd-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151239
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-06-26 12:03:02 +00:00
Tess Strickland 15464a462f Add internal benchmarks to .gitignore. 
Change-Id: Ic9f698084c123fd508f279cb1b7278466b41fbc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152645
Reviewed-by: Clement Skau <cskau@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
 2020-06-26 11:57:22 +00:00
Karl Klose 99144ed84d [infra] Remove support for approvals from compare_results 
Change-Id: I41d80e8d21da0e272c0410f6f1d1e943bf4ae2d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152640
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2020-06-26 11:26:55 +00:00
William Hesse 98324c95d5 Roll benchmarks-internal to 15a6634bd60ed0b937ed5dbc874cba2da9865514 
Change-Id: Ice1ed6cd9f4038d34061e62e177adb8ce6e0c668
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152643
Reviewed-by: Karl Klose <karlklose@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2020-06-26 10:59:02 +00:00
Martin Kustermann 53807c1d79 [vm] Remove ARMv6 related code 
This also allows unaligned access, since it's mandatory for ARMv7 (we
already take advantage of it for ARMv8).

Issue https://github.com/dart-lang/sdk/issues/42069

Change-Id: I0bd61a930e61dea330ab21fd187fe64b057ca28e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152322
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2020-06-26 09:39:15 +00:00
sgrekhov 85d37c1ede [co19] Enable Language/Libraries_and_Scripts tests 
Change-Id: I9632efb404c7723258f64569fb5821b7a04941c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152326
Reviewed-by: Alexander Thomas <athom@google.com>
 2020-06-26 09:11:14 +00:00
Alexander Thomas bcd2708843 [co19] Roll co19 to e674d8ccb29250fa5d7ac886fa98c5962543fffc 
2020-06-25 sgrekhov@unipro.ru Fix test to not to fail on dart2js
2020-06-25 sgrekhov@unipro.ru Language/Libraries_and_Scripts tests fixed and issue numbers added
2020-06-25 sgrekhov@unipro.ru Fixes 767. Language\Types\Type_dynamic migrated to null safety
2020-06-25 sgrekhov@unipro.ru Fixes 766. Language\Types\Type_Void migrated to null safety
2020-06-25 sgrekhov@unipro.ru Fixes 765. Language\Types\Static_Types migrated to null safety
2020-06-25 sgrekhov@unipro.ru Fixes 764. Language\Types\Parameterized_Types migrated to null safety
2020-06-24 sgrekhov@unipro.ru Fixes 759. Language\Types\Interface_Types migrated to null safety
2020-06-24 irina.arkhipets@gmail.com Fixed issue 763: Language\Variables\Evaluation_of_Implicit_Variable_Getters tests migrated to null-safety
2020-06-24 irina.arkhipets@gmail.com Fixed issue 762: Language\Statements\Yield_and_Yield_Each\Yield_Each tests updated for nnbd
2020-06-24 irina.arkhipets@gmail.com Fixed issue 762: Language\Statements\Yield_and_Yield_Each\Yield tests adopted for nnbd
2020-06-24 irina.arkhipets@gmail.com Fixed issue 761: Language\Statements\While tests adopted for nnbd
2020-06-24 irina.arkhipets@gmail.com Fixed issue 760: Language\Statements\Try tests adopted for nnbd
2020-06-24 irina.arkhipets@gmail.com Fixed issue 758: Language\Statements\Switch tests adopted for nnbd

Change-Id: I1488f026bab1d061af5a3aa91d5aa7c4df8f0662
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152522
Reviewed-by: William Hesse <whesse@google.com>
 2020-06-26 09:09:32 +00:00
Jens Johansen b4b44d6b4b Revert "[CFE] Set correct async markers in outline phase" 
This reverts commit 2ad66bbffe.

Reason for revert: Seems to break some internal tests.

Original change's description:
> [CFE] Set correct async markers in outline phase
> 
> Change-Id: I4ac1fe1f4195dea2c20b8e55963b7e7dffc2d289
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152330
> Reviewed-by: Johnni Winther <johnniwinther@google.com>
> Commit-Queue: Jens Johansen <jensj@google.com>

TBR=jensj@google.com,johnniwinther@google.com

Change-Id: Iaa272f1bee8f99dd93e9a351a03a67f67d83e871
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152641
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-06-26 07:49:57 +00:00
Karl Klose 718df630ea [infra] Support posting results to staging in post_results_to_pubsub 
This adds the option '-s' to select posting the results to the
staging system instead of the production system.

Change-Id: I990a39c7db3d0379935b69007ebc9477da5cc051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151528
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2020-06-26 06:28:55 +00:00
Regis Crelier 63cf56d925 Roll benchmarks-internal to 02695da98bcf006b95630d3c386f4169d7ec4ecf 
Ignore invariant_booleans lint rule when analyzing benchmarks.

Change-Id: I6071d3c1407e9c67689204e4ceb50cc1c0c8e109
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152598
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2020-06-26 01:56:03 +00:00
Alexander Markov 993af42292 [vm/aot] Fix crash in AotCallSpecializer due to unreachable code 
Fixes https://github.com/dart-lang/sdk/issues/42202

Change-Id: Id7ab1ceb5c7e8400f10d883bfbc9333e9e25e6c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152620
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-06-26 01:16:13 +00:00
Konstantin Shcheglov 13a24f4de1 Issue 42474. Add LibraryElement.languageVersion 
Bug: https://github.com/dart-lang/sdk/issues/42474
Change-Id: I316f34b14f01daa517182c1cb7b7c3fb038f0be2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-25 23:54:03 +00:00
Ryan Macnak ea87c9b01a [vm] Remove the Stop stub and runtime entry. 
Assembler::Stop("message") used to pass a C string pointer to the runtime to print. This mechanism did not account for relocation needed by AppJIT and AppAOT, and now only a trap instruction is used.

Change-Id: I70f3374abb9f9e649027f7417c66d7079c56ff63
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152582
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2020-06-25 23:22:02 +00:00
Ryan Macnak 9bbadb82ed [observatory] Remove old custom element registration code. 
Change-Id: Ie6aaf7f5bdea2f6d8c9ba5b2eb9c3212be3f560e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152590
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2020-06-25 22:45:32 +00:00
Zach Anderson cbb5cee914 Widen profile sample task kind bitfield 
To match: https://github.com/dart-lang/sdk/blob/master/runtime/vm/thread.h#L247

Change-Id: If065823ff3d124ae6ad8113ccb262c4b63107265
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152587
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2020-06-25 22:21:22 +00:00
Alexander Markov 2639f146dd [gardening] Skip flaky lib_2/async/stream_state_nonzero_timer_test 
This test sporadically crashes and confuses
vm-dartkb-linux-release-x64-abi bot which compares results on different
versions of ABI.

Issue: https://github.com/dart-lang/sdk/issues/42073
Issue: https://github.com/dart-lang/sdk/issues/42331
Change-Id: Ib61ca37ed07f40384f78e19e40c51096dd68dc08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152591
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-06-25 22:13:32 +00:00
Ryan Macnak 9700d7ff63 [observatory] Include garbage and fragmentation in the heap snapshot view. 
A few people have expressed confusion about why the top-level size shown in the heap snapshot view does not correspond to the total in the allocation table view. The missing size is now shown.

Change-Id: Idc7e53cb6098263f9809d4bb7c3154a97c4ba3e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152408
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2020-06-25 21:29:12 +00:00
Robert Nystrom ffa7969bb8 Migrate lib_2/developer/timeline_recorders_test.dart to null safety. 
Looks like this was added to lib_2 after the initial migration.

Change-Id: Ic56357cd99c9b369c38628f4527cfa84f50f5f72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152600
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2020-06-25 21:21:32 +00:00
Sam Rawlins d022d4c9e1 Migrator: Fix if-null promotion with GLB 
Fixes https://github.com/dart-lang/sdk/issues/42375

EdgeBuilder wishes to do its own GLB type-joining, as does FlowAnalysis.
When FlowAnalysis pushes a promotion in ifNullExpression_rightBegin,
and then in write, and then pops those two promotions to join them in
ifNullExpression_end, EdgeBuilder is not given a chance to make its
own GLB node. Instead promotion never happens: the DecoratedType which
is the variable's type is promoted to non-nullable, for the left side.
The DecoratedType for the right side expression is not considered
non-nullable, so the FlowAnalysis.join will always fail to promote.

TypeOperations.adjustPromotedTypes solves this. It is a no-op in all
implementations except in EdgeBuilder.

Additionally FlowAnalysis.write's promotion fails for the same reason:
the only type of interest is the declared type made non-nullable, and
no matter what, the writtenType is not a subtype of this.

TypeOperations.forcePromotion solves this. It is a no-op in all
implementations except EdgeBuilder.

Change-Id: Iba6b9a69583af8fe1aa23124c7d66047acfff495
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152104
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-06-25 21:09:12 +00:00
Konstantin Shcheglov 616ed353a2 Rename / deprecate FileResolver methods. 
R=keertip@google.com

Change-Id: I684465db327f5f448a95f57a18cf65e172c09b01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152603
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-25 20:59:32 +00:00
Robert Nystrom 2034061433 Migrate language_2/vm to NNBD. 
Change-Id: I313a57ed7c7ea2ada75065f55a7367376f6bdae5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152183
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
 2020-06-25 20:39:23 +00:00
Robert Nystrom 2af6c644db Migrate language_2/superinterface_variance to NNBD. 
Change-Id: I48592c7d8a2d568dc8af14b51555bc59664ca36c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151467
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-06-25 20:21:42 +00:00
pq b42dc32514 add @doNotStore entry 
Change-Id: I025b3c71ce05383c93adad0989e57f69972d3304
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152602
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-06-25 20:12:32 +00:00
Ryan Macnak f124f0fcfc [vm, service] Add getProcessMemory, which reports a tree of major ownership of memory known to the VM. 
Removes the private extension to heap snapshots, which did not represent nesting.

Change-Id: I62e60922f094db68cf63bac037140e1a8b2b9fd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152424
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2020-06-25 19:51:12 +00:00
Robert Nystrom e49b9a141c Apply Karl's multitest changes to the migrated language tests. 
Change-Id: I6cc37cc5aa7042aacabde4814aecdfe934876d7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152583
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-06-25 19:41:22 +00:00
Robert Nystrom 28583a42b6 Mark legacy boolean tests as complete for migration. 
Change-Id: Id25f1e2bd0049ad1522bd5d2bc75101e6db00efe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152584
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
 2020-06-25 18:57:32 +00:00
Mayank Patke 3b67681bcc [dart2js] Clean up (pre-)NNBD unit test configurations. 
Change-Id: Ife85aafa90b1b0347fabb6e95f3d6c00c5307cd2
Bug: https://github.com/dart-lang/sdk/issues/42063
Fixes: https://github.com/dart-lang/sdk/issues/42063
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152440
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2020-06-25 18:44:32 +00:00
Vijay Menon a9bef090e8 Revert "[dartdevc] Clear all constant containers after a hot restart." 
This reverts commit 2e50075597.

This appears to be triggering a problem in Flutter:
https://github.com/flutter/flutter/issues/60286

Change-Id: I53bf6e7e648f2f20ae9bc38327bad3760e171ab1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152581
Reviewed-by: Jonah Williams <jonahwilliams@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2020-06-25 18:31:22 +00:00
Paul Berry 8ed0541439 Fix typo causing a test not to be run 
Change-Id: I6455621fd59603adf980dddcedb2ee4f1d455664
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152430
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-25 17:59:32 +00:00
pq 37ba50cd0c Add @doNotStore. 
See: https://github.com/dart-lang/sdk/issues/41941

As per the conversation there, I opted not to handle the formal parameter case.

(My thinking being we could add it as a refinement.)

Change-Id: Ia91c525c8ea4ce26d9debe3f52af9a3018e50d6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152540
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-25 17:27:52 +00:00
Danny Tuppeny 87d431e8de Improve flutter wrap assists when caret is at the offset of an argument list 
Bug: https://github.com/Dart-Code/Dart-Code/issues/2492
Change-Id: I296f9396b3eedcbd1a63f272ed34c65f9d95d83b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-25 17:17:12 +00:00
Brian Wilkerson 898f2cc6c7 Remove extraneous references to the virtual annotation 
Change-Id: I9361d030ffa9aabeb8c4253553c04d356fc7ff45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152580
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-25 17:04:42 +00:00
Danny Tuppeny d619edf7ae Avoid using a visitor to find the identifier of a completion target 
Change-Id: I94a3515912b373cd201a7d110382d126420bc67e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-25 17:02:02 +00:00
William Hesse 095deb888f Migrate ListCopy benchmark to null safety, clean up lints 
Change-Id: Id7b8b64727e08ad1a5ab0bec7ad692ec64fa3848
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152329
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2020-06-25 15:28:54 +00:00