Commit Graph

79322 Commits

Author SHA1 Message Date
nweiz@google.com d39197abc6 Add tests for Element#elements.
This also factors out some of the range functions in NodeList and adds them to
_Lists. _Lists was then renamed to Lists so it could be accessed from the
testing code.

This was originally submitted as r3320. That was rolled back due to errors in
the dartium bot, but the logs are unavailable and local tests seem to pass so
we're rolling forward again.

TBR

Review URL: https://chromiumcodereview.appspot.com//9178030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3374 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 22:34:16 +00:00
nweiz@google.com 14f8c8a82f CSSStyleDeclaration#cssText should take a string.
TBR

Review URL: https://chromiumcodereview.appspot.com//9243023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3369 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 21:46:56 +00:00
hausner@google.com a9f221ebc2 Improve error message for some unresolved identifiers
Review URL: https://chromiumcodereview.appspot.com//9246001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3368 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 21:16:27 +00:00
turnidge@google.com 53ba5c402e Make the "sticky error" an Error instead of a String.
I do this in preparation for using the sticky error to implement
isolate unwinding.
Review URL: https://chromiumcodereview.appspot.com//9186058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3367 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 19:54:02 +00:00
efortuna@google.com 14d6a24393 Fix test.dart to have the same behavior as test.py for --frog and --froglib.
(Fixing Issue 1046)
Review URL: https://chromiumcodereview.appspot.com//9178022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3366 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 18:37:17 +00:00
asiva@google.com 8eb4b8cdf8 - Account for the possibility of timer objects being nested.
- Time library and source loading
Review URL: https://chromiumcodereview.appspot.com//9228007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3365 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 18:29:54 +00:00
ahe@google.com 194df8319e Categorize crashes.
Review URL: https://chromiumcodereview.appspot.com//9231023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3364 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 17:12:21 +00:00
ahe@google.com 7b56550033 Generate AST nodes for field initializers.
Review URL: https://chromiumcodereview.appspot.com//9241014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3363 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 16:29:02 +00:00
sgjesse@google.com 409a5cc49a Use platform implementation of Monitor in thread pool
This removes the direct use of pthread API for the thread pool monitor now that that code is shared. It also gets the Windows implementation for free.

Next step will be to get rid of using the pthread API for handling the threads as well, but that requires additional operations on the Thread class in platform/thread.h.

R=ager@google.com

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9231020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3362 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 15:36:35 +00:00
mmendez@google.com 6dfce3cc04 Revert "Remove TypeToken as means for assigning type arguments to arrays."
This reverts commit r3356.  Apparently closure will optimize new Array(x) to Array(void 0).

Review URL: https://chromiumcodereview.appspot.com//9178020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3360 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 15:34:53 +00:00
kasperl@google.com 2b7bdf3d2e Add number checks to the numeric operations in dartc.
It makes sense to consider removing the NumberImplementation native operators -- or make them throw an error unconditionally -- because they should never be called unless the right hand side isn't a number.

R=floitsch@google.com,mmendez@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9240005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3358 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 15:09:46 +00:00
mmendez@google.com 513d5b44d5 Remove TypeToken as means for assigning type arguments to arrays.
For native, classes with a bodyless constructor, pass the constructor arguments to the native constructor in the generated factory method.  The generated factory method will handle setting the runtime type information if necessary.

Review URL: https://chromiumcodereview.appspot.com//9183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3356 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 14:55:26 +00:00
ager@google.com b01e8121b9 Tiny style and comment fixes to test_suite.dart.
R=whesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9244004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3354 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 13:09:13 +00:00
sgjesse@google.com 68d10e1568 Move Mutex and Monitor from vm/ to platform/
The tests are still in runtime/vm/thread_test.cc.

R=ager@google.com, iposva@google.com

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9196002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3349 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 10:29:24 +00:00
sgjesse@google.com fecaf3deb0 Remove dependency from platform/globals.h to platform/assert.h
R=ager@google.com

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9241008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3347 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 10:10:05 +00:00
sra@google.com ad4ca7fc52 Webkit refresh.
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9242002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3345 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-17 03:33:53 +00:00
sgjesse@google.com dde717489a Undo accidental changed in r3337
TBR=ager@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//9183004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3338 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-16 13:29:27 +00:00
sgjesse@google.com 65896148c9 Move utils.h and utils.cc from runtime/vm to runtime/platform
Moved additional parts of globals.h from vm/ to platform/ to support
types and constants used by utils.*.

R=ager@google.com, iposva@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//9209001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3337 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-16 13:23:40 +00:00
whesse@google.com c220130314 Add summary of failures to end of test.dart output.
BUG=
TEST=

Review URL: http://codereview.chromium.org//9234002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3336 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-16 12:31:50 +00:00
sgjesse@google.com bf67f24098 Move assert.h/assert.cc from runtime/vm to runtime/platform
The purpose of this change is twofold:

1. Source in the bin directory can now use the same assertions as
   source in the vm directory. The ASSERT macro used by the code
   in runtime/bin was just defined to use assert from the standard
   C library.
2. Moving other implementation parts from runtime/vm to
   runtime/platform (e.g. classes Monitor and Mutex) for sharing
   between runtime/bin and runtime/vm will be easier as these
   implementations rely on these assertion macros.

Created two gypi files for the platform directory. One for the
headers and one for the source. The source one is only included
when building the VM library and will be present in libdart.a
when the dart executable is linked.

All the code for asserts is still in the dart namespace.

Also re-arranged the order of includes to be alphabetically in
the files touched.

R=ager@google.com, iposva@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//9189003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3335 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-16 12:28:10 +00:00
jimhug@google.com 92ea87d275 cleanup resolveMember and get/set
Fixes two get/set tests as a result of cleanup and mostly addresses several other issues to be completed in a follow-up commit.  This version has been better tested and addresses perf and correctness issue in the reverted 922001.

Review URL: http://codereview.chromium.org//9222004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3328 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-15 03:08:50 +00:00
jimhug@google.com 0d1b74096d Revert "cleanup resolveMember and get/set" - undo previous commit so that more time will be available to understand buildbot failures.
Review URL: http://codereview.chromium.org//9220003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3327 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-14 20:46:07 +00:00
jimhug@google.com f87bfe780c cleanup resolveMember and get/set
Fixes two get/set tests as a result of cleanup and mostly addresses several other issues to be completed in a follow-up commit.  This is coming in a little bit early to minimize merge issues as John is making simultaneous great progress.

Review URL: http://codereview.chromium.org//9222001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3326 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-14 20:32:13 +00:00
sra@google.com 8539d4bc13 Revert "Add tests for Element#elements."
This reverts commit 19f61e67a8543fc73e8a66bf45e6f4e25e5e0655.

BUG=
TEST=

Review URL: http://codereview.chromium.org//9210006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3325 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-14 08:30:46 +00:00
jmesserly@google.com 8d77be39d7 Fix status file now that the test is fixed, and remove an assert I had in for debugging. Apparently the condition doesn't hold yet. I updated the comment.
Review URL: http://codereview.chromium.org//9207022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3323 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-14 02:41:49 +00:00
nweiz@google.com 8d027766cc Allow non-string values to be passed to setProperty and other CSS properties.
Fixed issue 825.

TBR

Review URL: http://codereview.chromium.org//9211018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3321 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-14 02:02:39 +00:00
nweiz@google.com e3171e5d18 Add tests for Element#elements.
This also factors out some of the range functions in NodeList and adds them to
_Lists. _Lists was then renamed to Lists so it could be accessed from the
testing code.

TBR

Review URL: http://codereview.chromium.org//9207020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3320 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-14 01:47:43 +00:00
hausner@google.com 6d0e70e334 More parser stuff to handle pseudo keywords as identifiers
More pathological cases.
Review URL: http://codereview.chromium.org//9212018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3318 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-14 00:44:10 +00:00
sigmund@google.com 0db85d31b1 bot: fix to get appropriate executable in windows.
Review URL: http://codereview.chromium.org//9133019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3316 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 23:26:33 +00:00
efortuna@google.com 6a518f7f37 Third time's the charm! (test.status fix)
TBR=sigmund@google.com
Review URL: http://codereview.chromium.org//9211016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3315 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 23:24:57 +00:00
efortuna@google.com 6a7c42f827 Fix isolate status file for linux tests.
TBR=sigmund
Review URL: http://codereview.chromium.org//9213014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3314 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 22:52:59 +00:00
iposva@google.com d72471512e - More cleanup after the kSAR -> kSHR rename.
Review URL: http://codereview.chromium.org//9212016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3313 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 22:46:32 +00:00
efortuna@google.com 9fa0180cc1 Get Firefox and IE working again with Object.defineProperty!
Review URL: http://codereview.chromium.org//9214005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3312 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 22:28:50 +00:00
nweiz@google.com d70df93d96 Support various range methods on NodeList.
Fix issue 1077.

Review URL: http://codereview.chromium.org//9199002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3309 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 20:53:36 +00:00
codefu@google.com 353443aa53 Issue 1171: Failing to regenerate deleted output js file.
https://code.google.com/p/dart/issues/detail?id=1171

Basically: if no files have changed, check for out of dateness on the build
file to decide on continuing or not.

R=scheglov
BUG=
TEST=

Review URL: http://codereview.chromium.org//9211014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3308 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 20:46:49 +00:00
regis@google.com 2d1f63af47 Port a couple more stubs to x64.
Fix integer implementation issues.
Enable all tests on x64.
Review URL: http://codereview.chromium.org//9114054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3307 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 20:07:54 +00:00
hausner@google.com 9e690fc833 Fix dartc build
Fails the enhanced pseudo keyword tests

TBR=mmendez
Review URL: http://codereview.chromium.org//9213007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3306 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 19:49:34 +00:00
hausner@google.com 197348daa2 Fix frog build
Doesn't handle pseudo kw right.
Review URL: http://codereview.chromium.org//9174011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3305 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 19:41:33 +00:00
vsm@google.com d7697e4281 Set htmlconverter to executable
This makes it consistent with copy_dart and other scripts.

Review URL: http://codereview.chromium.org//9211009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3304 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 19:39:04 +00:00
hausner@google.com 343dff6255 Proper handling of built-in identifiers
Allow pseudo-keywords (built-in identifiers) as regular identifiers for anything but class names, interface names, typedef names.

Still todo: Update blacklist of class/interface names, disallow pseudo-keywords as type parameter names.
Review URL: http://codereview.chromium.org//9107070

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3303 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 19:24:50 +00:00
codefu@google.com d3e882dc53 Issue 1164: Out of date system libraries + restarted compiler
http://code.google.com/p/dart/issues/detail?id=1164

When the compiler fails to complete compilation, and the system libraries are
not bundled, it will fail to recompile the missing elements.  This was only a
problem in the DartEditor and running DartC from an eclipse environment.

Please note that there still exists a condition if you are running DartC
from eclipse and have system libraries, without precompiled artifacts, in a
jar file.  I will file a separate bug for that.

R=mmendez,brianwilkerson@google.com,danrubel
BUG=
TEST=

Review URL: http://codereview.chromium.org//9212008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3301 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 18:40:09 +00:00
whesse@google.com fffd398c06 Disable test.dart on MacOS VM buildbot.
TBR=iposva@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//9212002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3299 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 16:20:13 +00:00
mmendez@google.com 51284d953e Ensure that temp files created by this test are deleted when the JVM exits.
This addresses an issue where the tmpdir on the builders fills up.

Review URL: http://codereview.chromium.org//9211001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3296 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 15:01:27 +00:00
whesse@google.com c2645c3ca6 Reenable test.dart on Windows and MacOS buildbots.
BUG=
TEST=

Review URL: http://codereview.chromium.org//9207001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3293 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 14:36:11 +00:00
whesse@google.com ffc864b671 Fix test.dart multitest generated_test directory on Windows.
Also revert debugging change r3242.

BUG=
TEST=cd runtime; ../tools/testing/bin/windows/dart.exe ../tools/test.dart -component=vm

Review URL: http://codereview.chromium.org//9162005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3292 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 14:35:41 +00:00
ager@google.com b09cb0fb16 Fix bug in VM cctest running. Recognize when the cctest binary is not there.
R=whesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//9123029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3288 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 13:34:33 +00:00
lrn@google.com f2ffb9a804 Make SourceString Iterable<int>.
Review URL: http://codereview.chromium.org//9204006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3287 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 13:24:38 +00:00
iposva@google.com 1edc2e8edb - Remove support for ">>>" operator.
Committed: https://code.google.com/p/dart/source/detail?r=3279
Review URL: http://codereview.chromium.org//9203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3280 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 09:11:05 +00:00
iposva@google.com 731616c7d3 - Remove support for ">>>" operator.
Review URL: http://codereview.chromium.org//9203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3279 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 09:10:48 +00:00
sra@google.com 140a916227 Undo manual edit to avoid shadowing warning
BUG=
TEST=

Review URL: http://codereview.chromium.org//9123026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3276 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 02:30:32 +00:00