dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

79322 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
zundel@google.com bbdbb3791e Protect vs. NPE in TypeAnalyzer.checkInitializedDeclaration() 
Stack trace came from user feedback on Dart Editor. See:
http://code.google.com/p/dart/issues/detail?id=759

I wish I could reproduce the original problem, but this guard would be sure to fix it.

Review URL: https://chromiumcodereview.appspot.com//9264022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3447 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 20:54:58 +00:00
codefu@google.com d7b7edd2e0 Issue 1177: Non-existant documentation directory throws 
https://code.google.com/p/dart/issues/detail?id=1177
-Just call mkdirs() before creating PrintStream() in DartDocumentationVisitor

R=zundel
BUG=1177
TEST=

Review URL: https://chromiumcodereview.appspot.com//9178038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3446 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 20:11:36 +00:00
rnystrom@google.com 7e2ea12a4c Add a mode to dartdoc to generate the navigation on the client. 
Right now, the generated docs are pretty huge (100MB for all of the main libs). This is mainly
because each generated HTML page includes full navigation for each type in the containing
library. For stuff like dart:html, that's tons of HTML. Even after compression, the docs are
9.2MB. Also, they take a long time to generate (30s on my laptop).

This patch adds a mode you can use called "live-nav" (and makes it the default). With that
mode, pages do not include navigation. Instead, we generate a single nav.json file with the
navigation data. Client-side Dart code does an XHR for that and then renders the navigation
on the fly.

This gets the generated docs down to 13.3MB (2MB after compression) and gets doc generation
up to 6.3s for everything.

The two downsides are:

1. There's a visible flash on page load when it renders the nav since it's asynchronous.
2. You can't browse docs locally just using file://. To be able to XHR the nav.json, you
   either need to enable file access in your browser or run a local server.

Review URL: https://chromiumcodereview.appspot.com//9256002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3445 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 20:10:51 +00:00
hausner@google.com ffa4950202 Fix compiler stats timer code 
Account for recursive start/stop of timer. This has probably been broken since the beginning, but was only caught now after Siva added an assert in timer code.
Review URL: https://chromiumcodereview.appspot.com//9150040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3443 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 18:52:08 +00:00
ager@google.com 32c84843af Fix a couple of isolate-related memory leaks that show up a lot in valgrind output. 
R=hausner@google.com,iposva@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9150031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3442 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 18:33:32 +00:00
regis@google.com 5b1da9fc27 Skip qualified identifiers that are part of ignored types. 
Review URL: https://chromiumcodereview.appspot.com//9150036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3441 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 18:31:55 +00:00
zundel@google.com 2f96a3d8b1 Remove support for >>> and >>>= operators in dartc 
http://code.google.com/p/dart/issues/detail?id=1166

Review URL: https://chromiumcodereview.appspot.com//9232041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3439 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 18:06:22 +00:00
iposva@google.com 0e36a463f6 Address comment from https://chromiumcodereview.appspot.com/9150027: 
- Add an _ between mode and arch in test configuration.
Review URL: https://chromiumcodereview.appspot.com//9150035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3438 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 17:12:31 +00:00
codefu@google.com fd3c2e8ab3 Issue 986: Static type warning when overriding static super members 
http://code.google.com/p/dart/issues/detail?id=986

Truth table:
Super    | static  | instance
Local    |         |
---------+---------+---------
static   | warning | error
instance | warning | warning

Ancillary adition: Warnings are now colored differently from errors to help
distinguish between the two.

R=zundel
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9186037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3435 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 15:38:29 +00:00
zundel@google.com 6b677ae576 Allow classes shadowed by type variables to be referenced in static context 
We still print a shadowing warning, but if there is a valid reference outside
the variable is now resolved to it.  Otherwise, we print the existing message
about not being able to reference type variables in a static context.

See bug: http://code.google.com/p/dart/issues/detail?id=643

Review URL: https://chromiumcodereview.appspot.com//9250017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3434 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 15:12:26 +00:00
sgjesse@google.com 3a02bcfc04 Add additional include guard in platform specific .h files 
R=ager@google.com

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9264006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3433 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 13:37:26 +00:00
kasperl@google.com d205c37d48 Simplify equality checks and get rid of unreachable code in number and bool. 
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9192007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3432 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 12:40:34 +00:00
whesse@google.com ca63b5de74 Add configuration information to test.dart output. 
BUG=dart:1168
TEST=

Review URL: https://chromiumcodereview.appspot.com//9150027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3431 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 12:37:41 +00:00
whesse@google.com 202d43e713 Test.dart will wait for the temporary directory to be deleted before exiting. 
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9195006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3429 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 10:21:20 +00:00
sgjesse@google.com 59bf2982c2 Make sure to use an ObjectArray when writing to a socket 
This improves performance of the native code accessing the data in the
supplied buffer when it is no already an ObjectArray.

The code is duplicated as refactoring into a separate function was not
feasible.

R=ager@google.com

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9254022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3428 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 08:49:30 +00:00
iposva@google.com 1f01a48906 - Fix the return type of File.openSync. 
- Ensure to always hand a ObjectArray to the native code.
- Start making private methods private.
Review URL: https://chromiumcodereview.appspot.com//9264001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3424 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 02:48:47 +00:00
asiva@google.com dad0f5c843 Improve compilation times for swarm application startup. 
- Avoid multiple calls to LookupFunction and LookupField once for static and once for dynamic.
Review URL: https://chromiumcodereview.appspot.com//9252033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3423 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 01:50:32 +00:00
hausner@google.com aaf01d801a Fix named parameter function calls 
Issue 1199
Review URL: https://chromiumcodereview.appspot.com//9252027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3422 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 00:51:39 +00:00
vsm@google.com dbf9aaea7f Do not set checked mode unconditionally for Dartium 
It should get picked up based on whether --checked is passed in.  This should get the bot green(er).

TBR=sigmund

Review URL: https://chromiumcodereview.appspot.com//9232033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3421 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-19 00:28:10 +00:00
hausner@google.com 3ebdf081ca Set breakpoint at url, line number 
Add debugger functionality to set breakpoint at given url and line number.
Review URL: https://chromiumcodereview.appspot.com//9240014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3420 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 23:15:56 +00:00
regis@google.com 9993072ff2 Simplify integer arithmetic code. 
Optimize Mint multiplication in 32-bit mode.
Review URL: https://chromiumcodereview.appspot.com//9112050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3417 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 22:00:40 +00:00
turnidge@google.com e62f34ce77 Give isolates names to be used during debugging. 
Implement --trace_isolates.

-------------

Sample output of --trace_isolates for the CrossIsolateMessageTest:

[+] Starting isolate:
    isolate:    CrossIsolateMessageTest.dart/main-7112
[+] Starting isolate:
    isolate:    CrossIsolateMessageTest.dart/CrossIsolate1.main-7114
[+] Starting isolate:
    isolate:    CrossIsolateMessageTest.dart/CrossIsolate2.main-7115
[>] Posting message:
    source:     CrossIsolateMessageTest.dart/main-7112
    reply_port: 7117
    dest:       CrossIsolateMessageTest.dart/CrossIsolate2.main-7115
    dest_port:  7115
[>] Posting message:
    source:     CrossIsolateMessageTest.dart/CrossIsolate2.main-7115
    reply_port: 7118
    dest:       CrossIsolateMessageTest.dart/main-7112
    dest_port:  7117
[>] Posting message:
    source:     CrossIsolateMessageTest.dart/main-7112
    reply_port: 7119
    dest:       CrossIsolateMessageTest.dart/CrossIsolate1.main-7114
    dest_port:  7114
[>] Posting message:
    source:     CrossIsolateMessageTest.dart/CrossIsolate1.main-7114
    reply_port: 7120
    dest:       CrossIsolateMessageTest.dart/main-7112
    dest_port:  7119
[>] Posting message:
    source:     CrossIsolateMessageTest.dart/main-7112
    reply_port: 0
    dest:       CrossIsolateMessageTest.dart/CrossIsolate1.main-7114
    dest_port:  7120
[>] Posting message:
    source:     CrossIsolateMessageTest.dart/CrossIsolate1.main-7114
    reply_port: 0
    dest:       CrossIsolateMessageTest.dart/CrossIsolate2.main-7115
    dest_port:  7118
[>] Posting message:
    source:     CrossIsolateMessageTest.dart/CrossIsolate2.main-7115
    reply_port: 0
    dest:       CrossIsolateMessageTest.dart/main-7112
    dest_port:  7116
[>] Posting message:
    source:     CrossIsolateMessageTest.dart/main-7112
    reply_port: 0
    dest:       CrossIsolateMessageTest.dart/main-7112
    dest_port:  7113
[-] Stopping isolate:
    isolate:    CrossIsolateMessageTest.dart/CrossIsolate2.main-7115
[-] Stopping isolate:
    isolate:    CrossIsolateMessageTest.dart/CrossIsolate1.main-7114
[-] Stopping isolate:
    isolate:    CrossIsolateMessageTest.dart/main-7112
Review URL: https://chromiumcodereview.appspot.com//9242035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3416 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 21:46:27 +00:00
scheglov@google.com 14c15293ca fix frog status 
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3414 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 20:54:33 +00:00
asiva@google.com 806f6ddc62 Improve function compilation times for swarm application startup. 
- Add a String::Equals(const String& str) method.
- Pass in isolate parameter if present for some handle creation functions.
Review URL: https://chromiumcodereview.appspot.com//9232017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3413 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 20:10:18 +00:00
mmendez@google.com 2adbd94f14 Revert the revert of http://code.google.com/p/dart/source/detail?r=3360. 
Kasper found and fixed the underlying native class code generation bug as part of http://code.google.com/p/dart/source/detail?r=3390.

TBR=kasperl,floitsch

Review URL: https://chromiumcodereview.appspot.com//9255025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3412 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 20:07:49 +00:00
scheglov@google.com 6ad2499dbd Issue 933: Fix for resolving type of Function in field. 
http://code.google.com/p/dart/issues/detail?id=933

R=zundel@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9186015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3410 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 19:35:52 +00:00
hausner@google.com c75c9944d3 Unbreak frog leg 
Review URL: https://chromiumcodereview.appspot.com//9252016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3409 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 19:35:05 +00:00
efortuna@google.com d0d58b4e89 Modify status files to account for test outcome differences between 32 bit and 
64 bit Safari.
Review URL: https://chromiumcodereview.appspot.com//9254009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3408 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 19:14:07 +00:00
hausner@google.com 43c304c00f Skip is better than Fail 
I am too stupid to understand multi-case tests. Seems the DuplicateImplementsTest needs to be tagged Skip instead of Fail
for dartc and frog.
Review URL: https://chromiumcodereview.appspot.com//9255021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3407 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 19:06:33 +00:00
hausner@google.com cb74b73a2c Fix dartc build: exclude DuplicateImplementsTest 
TBR
Review URL: https://chromiumcodereview.appspot.com//9251014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3406 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 18:22:45 +00:00
hausner@google.com a1d6281cce Fix frog build: exclude DuplicateImplementsTest 
TBR
Review URL: https://chromiumcodereview.appspot.com//9259001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3405 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 18:13:41 +00:00
regis@google.com 366695d347 Ignore parsed types of local variables in unchecked mode and replace them with 
the Dynamic type.
Review URL: https://chromiumcodereview.appspot.com//9232016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3404 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 18:08:04 +00:00
hausner@google.com 600c0e4570 Report error on duplicate supertypes 
Report error if the same type appears more than once in the implements
or extends list.
Review URL: https://chromiumcodereview.appspot.com//9252001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3403 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 17:58:05 +00:00
whesse@google.com 2367d814d1 Fix error in tests/standalone/FileTest.dart, where files were not closed. 
Review URL: https://chromiumcodereview.appspot.com//9249018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3402 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 17:35:31 +00:00
whesse@google.com d500436f9c Fix test.dart on Windows: change all backslashes to slashes eagerly. 
BUG=dart:1206
TEST=

Review URL: https://chromiumcodereview.appspot.com//9250009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3400 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 16:24:01 +00:00
whesse@google.com e543e9901e Synchronize test-runtime.dart and test-compiler.dart with changed test.dart. 
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9252009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3399 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 16:06:44 +00:00
whesse@google.com 7eb6b33a01 Add temporary directory for dartc compilation of tests. 
This subdirectory of the system temp directory is deleted after tests are run.
This CL also unifies finding of the top-level dart checkout directory.

BUG=dart:1167
TEST=tools/test.dart -cdartc,chromium

Review URL: https://chromiumcodereview.appspot.com//9240011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3397 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 15:37:44 +00:00
whesse@google.com 28429d406c Fix standalone tests that didn't delete the temporary directories they created. 
BUG=
TEST=tools/test.py standalone; ls /tmp/temp_dir*

Review URL: https://chromiumcodereview.appspot.com//9251012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3396 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 15:37:13 +00:00
floitsch@google.com 794adcc608 Support static/global field initializations. 
Works for literals (except String) and references to other fields.

Review URL: https://chromiumcodereview.appspot.com//9211005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3392 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 12:56:36 +00:00
kasperl@google.com 9df7986723 The deleted sentinel isn't of type K. 
R=floitsch@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9250006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3391 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 12:50:52 +00:00
kasperl@google.com ac0e22f2bc Fix dartc in optimized mode (broken in r3358). 
Add checks that ensure that keys used for array access are integers.

Fix bug in the optimization strategy that ended up generating the wrong
code for "native" classes.

R=floitsch@google.com,mmendez@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9250005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3390 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 12:44:47 +00:00
ahe@google.com 74e3e3d33f Fix two crashes. 
Review URL: https://chromiumcodereview.appspot.com//9241016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3388 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 09:52:06 +00:00
sgjesse@google.com 9a9db39d0e Add MutexLocker and MonitorLocker to runtime/bin 
These complements the MutexLocker and MonitorLocker in runtime/vm which have the same logic, but are also VM stack resources.

R=ager@google.com

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9255012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3387 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 09:48:30 +00:00
lrn@google.com b88c187160 Handle escapes in string literals. 
Also handles raw strings.

Review URL: https://chromiumcodereview.appspot.com//9190038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3386 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 08:59:38 +00:00
rnystrom@google.com 0201ba42f6 Fix copying dartdoc static files. 
Review URL: https://chromiumcodereview.appspot.com//9249006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3385 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 04:35:57 +00:00
asiva@google.com 7d991245cb Temporary fix to get x64 builds working again on build bot. 
TBR=regis
Review URL: https://chromiumcodereview.appspot.com//9253005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3384 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 03:05:15 +00:00
efortuna@google.com 4ecc520173 Make changes for Safari to run with webdriver on the bots. 
Review URL: https://chromiumcodereview.appspot.com//9252002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3382 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 02:22:10 +00:00
asiva@google.com f17a00e9ac Use special allocation functions for object creation while deserializing from a full snapshot in order to avoid the following: 
- unnecessary initialization of objects with null
- avoid handle creation
Review URL: https://chromiumcodereview.appspot.com//9139067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3380 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-18 00:20:17 +00:00
nweiz@google.com 0332f4b776 Register Document events on Document, not HTMLDocument. 
TBR

Review URL: https://chromiumcodereview.appspot.com//9246005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3379 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-17 23:58:27 +00:00
regis@google.com d573d5437d Enable remaining execution tests on x64. 
Review URL: https://chromiumcodereview.appspot.com//9242025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3376 260f80e4-7a28-3924-810f-c04153c831b5
 2012-01-17 22:52:54 +00:00