Commit Graph

6631 Commits

Author SHA1 Message Date
William Hesse 64c150ab1a Revert "Capture stack traces in asynchronous browser test failures."
This reverts commit ca987d5c01.
This commit was slowing down Safari by a significant factor, causing
timeouts.

Bug:
Change-Id: Iddb3bf4f86664fa823cae5b08f24b3e240b4c67d
Reviewed-on: https://dart-review.googlesource.com/15881
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-10-23 08:32:13 +00:00
Sigmund Cherem 171d7965d7 Pass through the --strong flag to the vm runtime configuration
R=rnystrom@google.com,whesse@google.com

Change-Id: I83a827b2d681152cc80e8f0d76445e38e954bfc1
Reviewed-on: https://dart-review.googlesource.com/15820
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2017-10-21 01:12:28 +00:00
P.Y. Laligand 68a4c5783d Update the location of the Flutter project.
Change-Id: I7aa9448de2e7b58a95f3e87871a11286e7b364bb
Bug:
Reviewed-on: https://dart-review.googlesource.com/15768
Reviewed-by: Zach Anderson <zra@google.com>
2017-10-20 22:57:10 +00:00
Brian Goldman 5f0b431011 Change Fuchsia root now that Dart is one level deeper in the Fuchsia tree
Change-Id: I8c5e91910fd34f52a0abb491e18301fb60f3948b
Bug:
Reviewed-on: https://dart-review.googlesource.com/15650
Reviewed-by: Zach Anderson <zra@google.com>
2017-10-20 19:28:22 +00:00
Bob Nystrom 9c0a6fd27c Add rudimentary support for dartdevk to test.dart.
It's added as a new compiler, so pass "-c dartdevk" to use it.

It doesn't support any test packages yet, so tests that, say, import
package expect won't compile. I'll work on that next, but it will
require adding some stuff to the build scripts to build .dill files for
those packages.

This does get test.dart invoking the compiler, running the resulting
test, and correctly reporting the result:

- A test that doesn't throw an exception and stays within the bounds of
  what is currently implemented in dartdevk passes.

- A test that compiles correctly but fails at runtime fails with a
  RuntimeError.

- A test that contains a compile error fails with a non-zero exit code
  and is reported as a CompileTimeError.

Change-Id: Icacbf1ff54dfe7aa4d245382d3b0aeb375cf105b
Reviewed-on: https://dart-review.googlesource.com/15420
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2017-10-20 16:00:28 +00:00
Morten Krogh-Jespersen b4e1f28e43 Add extra flags to output.
Bug:
Change-Id: I2f947b0ca91c0791fd85ea8e0e8cb8e27b2ee305
Reviewed-on: https://dart-review.googlesource.com/15520
Reviewed-by: William Hesse <whesse@google.com>
2017-10-20 13:34:01 +00:00
Morten Krogh-Jespersen b679bf0818 Tool for finding duplicate entries for tests in status files.
Bug:
Change-Id: Ia1c1110b7b5f71465763bd3042ae459008293971
Reviewed-on: https://dart-review.googlesource.com/13745
Reviewed-by: William Hesse <whesse@google.com>
2017-10-20 11:44:09 +00:00
Bob Nystrom c341575a53 Colorize section headers and slightly clean up test output.
Of course, if you're not using the color formatter, it stays uncolored.
But this gets rid of some unnecessary empty lines and section headers
that have no content.

Change-Id: I5b83345c583b79468af84f4e67a12ee757a3105f
Reviewed-on: https://dart-review.googlesource.com/14720
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2017-10-19 21:45:57 +00:00
Bob Nystrom ca987d5c01 Capture stack traces in asynchronous browser test failures.
This works for both dart2js and DDC.

Change-Id: Ic27a99c3691ee06259597b227239b974a60b2484
Reviewed-on: https://dart-review.googlesource.com/15320
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2017-10-19 21:10:57 +00:00
Alexander Aprelev b573b1bbd5 Fix location where we look for flutter relative to dart.
This is follow-up to https://github.com/flutter/engine/pull/4245.

Bug:
Change-Id: I31c16574dabb84d3f70014c11033e4045410caf1
Reviewed-on: https://dart-review.googlesource.com/15220
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2017-10-19 19:19:07 +00:00
Bob Nystrom ba2e4aff24 Some minor clean-up in test.dart.
- Fix fuzzy arrow errors.
- Default the Dart repo URI so it doesn't always need to be explicitly
  set.
- Run dartfmt on everything.
- Move some members out of the garbage bin "TestUtils" class:
  - Move the stuff around the Dart repo directory to a new Repository
    class.
  - Move absolute() into Path where it belongs.
  - Move workingDirectory in Path since it is a Path.
  - Delete the random number stuff since it was apparently unused.

Change-Id: I3dab3a4f1713b7a749e64b6776149d05a0ce1b69
Reviewed-on: https://dart-review.googlesource.com/14502
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2017-10-19 19:05:58 +00:00
Bob Nystrom 5f8f77fd03 Capture DDC JavaScript stack traces in synchronous test failures.
This still doesn't *display* then very nicely (they are buried in the
giant blob of "events" JSON in the output), but it captures them and
plumbs them out of the browser into test.dart.

Change-Id: I54ab024ed55f18af89da7742967117f0a212673d
Reviewed-on: https://dart-review.googlesource.com/15005
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2017-10-19 18:32:27 +00:00
P.Y. Laligand ce79a77331 Remove Fuchsia-specific build files.
Also fix Fuchsia tools to account for new project location (//third_party/dart).

Change-Id: If89a934729c4fa44229eaca83219dbdf8bb700a8
Bug:
Reviewed-on: https://dart-review.googlesource.com/14800
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2017-10-19 17:52:37 +00:00
Régis Crelier 0e5efbda08 Implicitly pass --reify-generic-functions option to the VM when testing Dart 2.0
Fix migrated Dart 1.0 tests for Dart 2.0
Update status files

Change-Id: I41c8a6d06008ec0213e78cdc578b24b24668d312
Reviewed-on: https://dart-review.googlesource.com/14940
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2017-10-18 22:18:46 +00:00
Morten Krogh-Jespersen f458bda37f Get builders and latest builds from CQ.
Change-Id: Ic8a53a688b82cb39061e5f6f4a1dc6beb685bc8c
Reviewed-on: https://dart-review.googlesource.com/12560
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-10-18 06:15:08 +00:00
Bob Nystrom cac79d8db9 Fix some tests to be better Dart 2.0 tests.
async_await_test was correct, but was using a misleading name. It really
cares about assertions being enabled, not "checked mode".

The setter tests originally validated the runtime type checks but were
changed to compile time checks. Used a little judicious dynamic to get
back to testing the runtime type checking.

Change-Id: I0e121bd1443376e885777d609f5d6507537c0b8c
Reviewed-on: https://dart-review.googlesource.com/14161
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
2017-10-17 23:11:25 +00:00
Peter von der Ahé bc7fc1891d Delete patched_sdk directory when rebuilding it.
Change-Id: I4713ba8aafa5f7119bbdb2b26746f2fff50042a6
Reviewed-on: https://dart-review.googlesource.com/12284
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2017-10-17 11:31:00 +00:00
Peter von der Ahé 7e40ae990b compile_platform should work when there's no checked-in dart binary.
Change-Id: Ib3338e616b05b9b1a7462c9f484402faca0fc13b
Reviewed-on: https://dart-review.googlesource.com/13983
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2017-10-17 11:29:50 +00:00
Peter von der Ahé b96ac4520a Update most clients to use computePlatformBinariesLocation.
Change-Id: I6e6960c471b2fab3f0cd8a672da05d7699217410
Reviewed-on: https://dart-review.googlesource.com/12291
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-10-17 10:48:40 +00:00
Morten Krogh-Jespersen 613393b3ff Refactoring of testpy_wrapper.
Bug:
Change-Id: I136862fe693bc3e82bc37ca1b839633f12509b9a
Reviewed-on: https://dart-review.googlesource.com/13743
Reviewed-by: William Hesse <whesse@google.com>
2017-10-16 14:22:13 +00:00
Morten Krogh-Jespersen bb0687e6f5 Add utility methods to gardening.
Bug:
Change-Id: I4b9365a34b211d2885d32a8683a3128b82832a77
Reviewed-on: https://dart-review.googlesource.com/13742
Reviewed-by: William Hesse <whesse@google.com>
2017-10-16 13:48:25 +00:00
William Hesse 1d0edd70e3 Debian package building should show all output to stdout
Bug: https://github.com/dart-lang/sdk/issues/31055
Change-Id: I464af3f09df73b19b1fc7cdfd1df133f649c7fe8
R=eernst@google.com,ahe@google.com
Reviewed-on: https://dart-review.googlesource.com/13760
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2017-10-13 14:18:33 +00:00
Morten Krogh-Jespersen 16fd76c481 Allow logging of all types of failures.
Bug:
Change-Id: I9f37f77815eda65085fa3b303d8197d480db8d66
Reviewed-on: https://dart-review.googlesource.com/13740
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-10-13 13:06:47 +00:00
P.Y. Laligand ab352af7f7 Teach the SDK patch tool to look for Flutter in a new location.
The Flutter engine will soon be mapped to //third_party/flutter in Fuchsia.

Change-Id: I280e2ffcfc3de2a5c7ffb96159d7d37341a974a3
Bug:
Reviewed-on: https://dart-review.googlesource.com/13601
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2017-10-12 22:41:05 +00:00
Morten Krogh-Jespersen a409e4ddb8 Add spec-parser to configuration for result tool.
Bug:
Change-Id: I8697fa9516bb0c43863340d4e8beb87df8b46678
Reviewed-on: https://dart-review.googlesource.com/13520
Reviewed-by: William Hesse <whesse@google.com>
2017-10-12 11:38:24 +00:00
Morten Krogh-Jespersen 4c88f9a453 Order tests by name in result failures output.
Bug:
Change-Id: Ib3f055594d396a1f0f72e5539aa63b93754b4a24
Reviewed-on: https://dart-review.googlesource.com/13461
Reviewed-by: William Hesse <whesse@google.com>
2017-10-12 11:33:46 +00:00
Erik Ernst 63de49ccde test.py will now run the spec parser.
This CL modifies tools/test.py such that it can run the spec parser
(after doing `make parser` in tools/spec_parser, and assuming that the
ANTLR 3 library is available at /usr/share/java/antlr3-runtime.jar)
with a command line like

  `tools/test.py -c spec_parser -r none language/callable_test`

It also changes status files to have a name which follows the expected
patterns (e.g., `language/language_spec_parser.status`). Finally, it
adds/changes many entries in status files, such that parsing of the
directories `language` and `language_2` run successfully.

Change-Id: I82a22e32ac4fecd23ac0d4434bcac08f75dd8ffe
Reviewed-on: https://dart-review.googlesource.com/12680
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-10-12 09:22:28 +00:00
Morten Krogh-Jespersen e1ff03c947 Updating gardening documentation with info on results tool
Bug:
Change-Id: I4cc04534c7a5658ca6fd052f4c6e45358573bdca
Reviewed-on: https://dart-review.googlesource.com/9660
Reviewed-by: William Hesse <whesse@google.com>
2017-10-11 08:15:16 +00:00
Erik Ernst b61f1047d5 Add a tools/spec_parse.py script.
This makes it possible to run the spec parser in a way which is a bit
more like the other tools that we have (e.g., tools/test.py):

  > tools/spec_parse.py tests/language/callable_test.dart

It still requires the developer to run `make parser` in
tools/spec_parser and hence does not run on a buildbot, but it's one
step forward.

Change-Id: I68ad6cea55bc02dddac21558acec33fc4bfc1981
Reviewed-on: https://dart-review.googlesource.com/9620
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2017-10-10 16:03:36 +00:00
Peter von der Ahé 90587a6837 vmservice_libraries.json is no longer generated.
Fixes #31034.

Change-Id: Ifb9ed97fe8cddb317cb63e7d66f262ef9e68ee75
Reviewed-on: https://dart-review.googlesource.com/12282
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
2017-10-09 13:37:55 +00:00
Johnni Winther 898f68334d Add ddc to buildbot_data
Change-Id: I09fe15003158fea0b0ef08794847463de192bc1a
Reviewed-on: https://dart-review.googlesource.com/11444
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-10-09 11:46:54 +00:00
Morten Krogh-Jespersen 19705f0147 Add results tool to gardening tools.
Bug:
Change-Id: I15e08fd44a56aca20cfcec92c893f94cf88d711a
Reviewed-on: https://dart-review.googlesource.com/10900
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-10-09 08:28:20 +00:00
Siva Annamalai bd2a8e1d60 Reland migrate most of the tests in standalone to be strong mode clean and move them to standalone_2 directory.
Bug:
Change-Id: I4ca50f315361422db1d4356055862463bfe1d6f3
Reviewed-on: https://dart-review.googlesource.com/12240
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2017-10-07 01:29:36 +00:00
Bob Nystrom 9a61fd572a Remove unittest checking from migration script.
It's OK for a test to keep using unittest.

Change-Id: I5789cda2baea44731e1ce01ccff04d81f42b9b0c
Reviewed-on: https://dart-review.googlesource.com/12080
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2017-10-06 21:31:43 +00:00
Zachary Anderson 86d73ad168 Add shebang to //tools/compile_platform.py
To fix Fuchsia build.

Change-Id: I8071ecd4c3029596eed7f547c813f2af9d26d137
Reviewed-on: https://dart-review.googlesource.com/12060
Reviewed-by: Zach Anderson <zra@google.com>
2017-10-06 17:39:32 +00:00
Zachary Anderson acde5b829a Mark //tools/compile_platform.py executable
Change-Id: I5b6e390a5543441ceff2b31e86dc92d957838453
Reviewed-on: https://dart-review.googlesource.com/11964
Reviewed-by: Zach Anderson <zra@google.com>
2017-10-06 17:26:01 +00:00
Siva Annamalai ff32187145 Revert "Migrate most of the tests in standalone to be strong mode clean and move"
This reverts commit c85563f582.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Migrate most of the tests in standalone to be strong mode clean and move
> them to standalone_2 directory.
> 
> Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
> Reviewed-on: https://dart-review.googlesource.com/6080
> Reviewed-by: Ben Konyi <bkonyi@google.com>

TBR=bkonyi@google.com,asiva@google.com

Change-Id: I3c7b6081f17fca45e7828603538f50d06417e2be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/12020
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2017-10-06 17:24:20 +00:00
Siva Annamalai c85563f582 Migrate most of the tests in standalone to be strong mode clean and move
them to standalone_2 directory.

Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
Reviewed-on: https://dart-review.googlesource.com/6080
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-06 17:07:34 +00:00
Peter von der Ahé 16aa720d27 Remove compiling platform.dill from patch_sdk.dart
This separates compiling platform.dill files from the patch_sdk.dart
script. The motivation for that is that I'm working on reading patch
files directly from Fasta, so we can completely remove the build step
for generating patched_sdk and dart2js_patched_sdk.

Short-term this should allow Paul to add a strong-mode version of
platform.dill without causing to many conflicts with my work on
patches.

Change-Id: I1150845b2986348d4fffe27092701d8a9b57ea54
Reviewed-on: https://dart-review.googlesource.com/11506
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-10-06 15:34:37 +00:00
Alexander Thomas 8433ba6f6a Temporarily remove SDK linux builder from CQ
TBR=whesse@google.com

Bug:
Change-Id: I58ac5b3beb19d1ff71511b223366487285215fab
Reviewed-on: https://dart-review.googlesource.com/11661
Reviewed-by: Alexander Thomas <athom@google.com>
2017-10-05 20:45:13 +00:00
Morten Krogh-Jespersen bb704408d1 Add communication with logdog to gardening tools.
Bug:
Change-Id: If99ef827f2f12758d4f0869f51fb758e3f01e7f7
Reviewed-on: https://dart-review.googlesource.com/10960
Reviewed-by: William Hesse <whesse@google.com>
2017-10-05 13:30:54 +00:00
Morten Krogh-Jespersen 46bd2e77e6 Add zip - extended printer to gardening tools.
Bug:
Change-Id: I2d403f94b6f66714b7848c91a87ef945fb4199a4
Reviewed-on: https://dart-review.googlesource.com/10920
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-10-05 12:50:14 +00:00
Morten Krogh-Jespersen 2564d99b65 New limit for truncating stdoutput from a running test.
Bug:
Change-Id: I0ad4ea30ef0ca0b9e1f15de8dd0313be27bcff12
Reviewed-on: https://dart-review.googlesource.com/11445
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2017-10-05 12:48:00 +00:00
Morten Krogh-Jespersen 03ae2965ee Add buildbucket interface to gardening tools.
Bug:
Change-Id: Ica7ca46e9dc659f325a6c7781c2f7cb5edfd8cc0
Reviewed-on: https://dart-review.googlesource.com/10941
Reviewed-by: William Hesse <whesse@google.com>
2017-10-05 12:05:58 +00:00
Morten Krogh-Jespersen 4962444511 Remove try from future.
Bug:
Change-Id: I4e003bfa1cccbb8445450d2e897037b8dd7dc941
Reviewed-on: https://dart-review.googlesource.com/10940
Reviewed-by: William Hesse <whesse@google.com>
2017-10-05 11:49:52 +00:00
Johnni Winther f9cb6c4137 Remove dart2js_with_kernel_in_ssa test option
Change-Id: I2da692a4d458acc4b36e14beb99e1fb9d2bdec70
Reviewed-on: https://dart-review.googlesource.com/10861
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-10-05 06:53:39 +00:00
Morten Krogh-Jespersen 622d6a771f Add workflow class for working with workflows in console apps.
Bug:
Change-Id: I77f7a213c995f4cb22b4fee43098839febee8f73
Reviewed-on: https://dart-review.googlesource.com/10321
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-10-05 06:43:47 +00:00
Alexander Markov 9ee73fe322 [Kernel] Remove outdated and duplicated front-end Targets
This CL replaces outdated VmTarget and FlutterTarget with VmFastaTarget
and FlutterFastaTarget. 'Fasta' suffix is droped from target names.

The new FlutterTarget extends VmTarget, so they share more code.

Change-Id: Id79956698a889c9a49b8a67914f1f96a731407ab
Reviewed-on: https://dart-review.googlesource.com/9423
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-10-04 18:02:49 +00:00
William Hesse eb71eb6032 Update checked-in SDK to version 2.0.0-dev.3.0
Bug:
Change-Id: I6f8436c88da010b14501d69fdeccb4ba034d0ddb
Reviewed-on: https://dart-review.googlesource.com/10980
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2017-10-04 12:25:32 +00:00
Morten Krogh-Jespersen 0a685691ec Updating Luci to not use try.
Bug:
Change-Id: If35ddc90e87174acb5666670697e259b72845579
Reviewed-on: https://dart-review.googlesource.com/9922
Reviewed-by: William Hesse <whesse@google.com>
2017-10-03 10:02:10 +00:00