Commit Graph

6631 Commits

Author SHA1 Message Date
Morten Krogh-Jespersen 1d1b29f469 Utility program to send arguments to try tests.
This small utility program makes it easier to invoke custom steps on try
builders.

Bug:
Change-Id: I63d3d77365f47d79f489a70fef5431a93a6663e5
Reviewed-on: https://dart-review.googlesource.com/24440
Reviewed-by: Alexander Thomas <athom@google.com>
2017-11-30 09:56:58 +00:00
Alexander Markov d282487636 Enable devirtualization optimization when testing dartkp --strong.
Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: I09a93391eaa42ff2c258b33bb229e2ca662463db
Reviewed-on: https://dart-review.googlesource.com/24562
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2017-11-29 22:56:40 +00:00
Erik Ernst d7b4d12a1e Bug fix: avoid range error
Change-Id: I4fb2f132df38516c21f76b4589aa4896d7e213bc
Reviewed-on: https://dart-review.googlesource.com/24462
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
2017-11-29 15:45:40 +00:00
Alexander Thomas 0bf5ca8e47 Fix invalid JSON in test matrix
Change-Id: Ie551fbc739922138ad026b510a9e871eb20d4af1
Reviewed-on: https://dart-review.googlesource.com/24423
Reviewed-by: Alexander Thomas <athom@google.com>
2017-11-29 12:09:25 +00:00
Karl Klose 2d48be6e62 Invoke dartdevk.dart through shell script that locates the 'dart' executable
Change-Id: Id13cc838b67785b12f95d19b480a6a830ad5c003
Reviewed-on: https://dart-review.googlesource.com/24120
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2017-11-29 11:27:50 +00:00
Alexander Thomas 4f68da06ef Add DDC kernel tests to test matrix
Change-Id: Ie04c6a0308cf19b7e051f97aafa06d81b9979d7b
Reviewed-on: https://dart-review.googlesource.com/23662
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-11-29 11:19:34 +00:00
Jens Johansen 6e9c74274c Also output --network for testing http server commandline
If for instance running ddc kernel tests via

tools/test.py -mrelease -cdartdevk language_2 -v

one is told that a http server is started with a command line that will
create a http server listening to 0.0.0.0, while generally the one
actually launched by the testing scripts only listen to 127.0.0.1.

This CL adds the extra --network output to the command line given.

Bug:
Change-Id: Ifd9278360efb0b12249fe866c49ed923f7e73b0e
Reviewed-on: https://dart-review.googlesource.com/24102
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2017-11-29 07:30:40 +00:00
Sigmund Cherem 2cf4dd41e9 Update try_benchmarks.sh to use correct platform file
Change-Id: Idf85e0a2f0ce3bafc6257ae8d5d1a8735f795835
Reviewed-on: https://dart-review.googlesource.com/23961
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2017-11-28 16:38:25 +00:00
Alexander Thomas 8588854548 Add VM debug canary builder to test matrix and commit queue
Change-Id: I7386e3e6f9f786c98a134095f1a4e772f8fa7143
Reviewed-on: https://dart-review.googlesource.com/23666
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-11-27 16:17:21 +00:00
Morten Krogh-Jespersen d7e687fecb Revert "Add triggering of dart2js bots on sdk-builders."
This reverts commit 645acdbd0e.

TBR: athom@google.com

Bug:
Change-Id: Ia47a15e000dddfe1bb040ce148ac3d9cc2ceac8f
Reviewed-on: https://dart-review.googlesource.com/23669
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-11-27 12:06:07 +00:00
Morten Krogh-Jespersen 645acdbd0e Add triggering of dart2js bots on sdk-builders.
DO NOT LAND until we have more machines.

Bug:
Change-Id: I0ad43356f3b429c807568d44a53988a30172bfe2
Reviewed-on: https://dart-review.googlesource.com/20980
Reviewed-by: Alexander Thomas <athom@google.com>
2017-11-27 11:07:28 +00:00
Alexander Thomas 9698df457c Merge SDK build steps in test matrix
Change-Id: Icc9b03e33c7375c5cc1460f1d7116efed2157d44
Reviewed-on: https://dart-review.googlesource.com/22804
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2017-11-23 09:10:16 +00:00
Ryan Macnak d366f9619a [vm] Toward deterministic builds.
- Remove random build-id.
 - Replace build time in embedded version string with commit time.
 - Remove timestamps from Observatory tarball.
 - Zero-initialize skipped bytes in snapshot streams.
 - Fix uninitialized fields in PatchClass, Script and Library.
 - Disable (under flag) random identity hashes and concurrent GC.

Bug: https://github.com/dart-lang/sdk/issues/31427
Change-Id: I3e95de679c8372841cd27ca60df78d9b00ffbfe1
Reviewed-on: https://dart-review.googlesource.com/22901
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2017-11-23 00:07:56 +00:00
Bob Nystrom 1e6e72af79 Refactor some code around TestSuite.
I was working on adding support for treating RuntimeError as Pass if
runtime == none and I noticed a lot of dead or redundant code, so
cleaned it up some.

Change-Id: I0be451a7075d99bc07d1407883861fb06d777c02
Reviewed-on: https://dart-review.googlesource.com/22800
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-11-22 16:56:17 +00:00
Zachary Anderson 761fc78aa7 [infra] Add --no-start-goma flag to build.py
For goma on builders, which start goma beforehand.

Change-Id: I68a22b842b3256c4e5aa23ec6c3817608cf035b7
Reviewed-on: https://dart-review.googlesource.com/22741
Reviewed-by: Alexander Thomas <athom@google.com>
2017-11-21 22:28:43 +00:00
Bob Nystrom 37cd5e33ce Don't spew DDC SDK build warnings when building.
Change-Id: I56b829e218a970ca8186910481422a5b9d25150c
Reviewed-on: https://dart-review.googlesource.com/22720
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2017-11-21 21:58:37 +00:00
Paul Berry 54143ef90c Add --dart2js-with-kernel configurations to run_tests.dart
Change-Id: Ie837af2934b2596a0dbe3e7f9a38d906bb6336d7
Reviewed-on: https://dart-review.googlesource.com/22341
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2017-11-21 17:01:20 +00:00
Bob Nystrom 68dc77f456 Build DDC's SDK as part of the regular build.
This involves a few main pieces:

- Add code to the GN scripts to generate DDC's patched SDK and then
  compile it to summaries and JS in the build output directory.

- Add support to the underlying DDC build scripts to support controlling
  which files are built where.

- Update test.dart to use the DDC SDK from the build directory.

- Update create_sdk to use the built SDK instead of the checked in one.

- Fix various internal DDC tools to build their own copy of the SDK
  (since they can't easily find the one in the build directory because
  it's path if config-specific) and use those.

- Delete the checked DDC SDK JS and summaries.

I think I got everything working. The built Dart SDK looks fine -- it's
identical to one built using the old build scripts.

The various tools and DDC's little test runner I *think* work, but there
may be a bug or two in there. I tried the various things I could and it
seems like they work but it's hard to tell since they may be kind of
broken right now anyway.

Bug:
Change-Id: Iea77915a5c1cc8450f60ebfbdf8c725c7ea2f32c
Reviewed-on: https://dart-review.googlesource.com/18144
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2017-11-20 23:24:07 +00:00
Harry Terkelsen f5bb30ff73 Try building "Hello World" with the v2 dart2js
Change-Id: I7ffbbd0f0dc545dac0b1e7211d9848a5757d0151
Reviewed-on: https://dart-review.googlesource.com/20910
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
2017-11-20 18:08:06 +00:00
Sigmund Cherem 3b73de2060 Rename 'driver' to 'default' in incremental_perf.dart
This just makes the name more appropriate since now that the default incremental
generator is not using kernel-driver altogether.

Change-Id: Ic7357dbb4eaad482f20249dd13ba3a49a39322d3
Reviewed-on: https://dart-review.googlesource.com/22160
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
2017-11-20 18:03:56 +00:00
Sigmund Cherem b69cc7c98b Sort expectations in test.dart --list
This makes it easier to compare the output of two different runs of test.py
--list.

Change-Id: Iabbbd4d6f60b9b7523e2773520a8b2d588c99ae3
Reviewed-on: https://dart-review.googlesource.com/21520
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2017-11-18 00:51:06 +00:00
Alexander Markov a211134136 [Tests] Update _2 tests for Dart 2.0 fixed-size integers
Also, --limit-ints-to-64-bits is enabled when running tests in _2 test
suites.

This is the re-landing of 92ebd8aefa with
fixes:

* Revert changes in pkg/dev_compiler/test/browser/language_tests.js
  and tests/language/language_dart2js.status as they describe
  'language' test suite, not 'language_2'

* Correct tests/standalone_2/io/fuzz_support.dart as file_fuzz test was
  timing out on Windows and failing on android/arm.

Closes https://github.com/dart-lang/sdk/issues/31396

Change-Id: If9ca77fca300ddc605f17a7be39d1707e9724e25
Reviewed-on: https://dart-review.googlesource.com/21700
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2017-11-17 20:28:06 +00:00
Alexander Markov 58ffdbf5fc [VM] Move kernel service to pkg/vm, populate pkg/vm with necessary files
* kernel-service.dart is moved to pkg/vm/bin and renamed to
  kernel_service.dart

* LICENSE, pubspec.yaml and analysis_options.yaml added to pkg/vm.

* Kernel isolate name is corrected to be independent of URI passed
  in --dfe VM option.

Change-Id: I5b7b860297314e240e557af80913e7ac3e6324ad
Reviewed-on: https://dart-review.googlesource.com/21260
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2017-11-17 17:45:03 +00:00
Alexander Markov 22218e9b9e Revert "[Tests] Update _2 tests for Dart 2.0 fixed-size integers"
This reverts commit 92ebd8aefa.

Reason: various failures on buildbots.
Change-Id: I03e877e240fdb010d1288baebc124a3e364d1025
Reviewed-on: https://dart-review.googlesource.com/21565
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2017-11-17 00:52:17 +00:00
Alexander Markov 92ebd8aefa [Tests] Update _2 tests for Dart 2.0 fixed-size integers
Also, --limit-ints-to-64-bits is enabled when running tests in _2 test
suites.

Change-Id: I0b75e5e6e7af78adb29401d77ff55e735781ab73
Reviewed-on: https://dart-review.googlesource.com/20960
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2017-11-16 22:40:11 +00:00
Sigmund Cherem 2a199ae689 Add flags to configure incremental_perf
This lets us benchmark separately:
- IKG implementations (the default based on kernel-driver or the minimal implementation)
- strong and non-strong mode

This also adds commands to try_benchmarks that highlight how these options will be used.

Change-Id: I5ce2c4563b7e79c33d78df7fd87be76f5d47e3f4
Reviewed-on: https://dart-review.googlesource.com/21320
Reviewed-by: Jonas Termansen <sortie@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2017-11-16 03:42:23 +00:00
Morten Krogh-Jespersen 8618c947ec Add dart2js-csp-minified to the test matrix.
Bug:
Change-Id: I877f67ea4ef9023cc1d4d767dab15c544db46b05
Reviewed-on: https://dart-review.googlesource.com/21241
Reviewed-by: Alexander Thomas <athom@google.com>
2017-11-15 22:40:12 +00:00
Morten Krogh-Jespersen 88aef0a65d Add --strong to vm-precomp builders to the test matrix.
This CL adds --strong arguments to precomp builders, based on the input in
https://dart-review.googlesource.com/c/sdk/+/20860
Bug:
Change-Id: I18f64c4a82a0cf4f5f37f19d794705b3ae69f651
Reviewed-on: https://dart-review.googlesource.com/21300
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-11-15 22:37:20 +00:00
Morten Krogh-Jespersen fe112c5357 Add jsshell to dart2js test matrix configuration.
Bug:
Change-Id: Ic488034a9f7364036690f01881bb90f43828a7a6
Reviewed-on: https://dart-review.googlesource.com/21240
Reviewed-by: Alexander Thomas <athom@google.com>
2017-11-15 22:36:50 +00:00
Morten Krogh-Jespersen 6cdd14f8da Add d8-minified to the test matrix.
Bug:
Change-Id: I2709cae4ed9eefe4297de5a60ebcc0955637e024
Reviewed-on: https://dart-review.googlesource.com/21242
Reviewed-by: Alexander Thomas <athom@google.com>
2017-11-15 22:34:06 +00:00
Sigmund Cherem 3fa203ba1f Update try_benchmarks.sh to let fasta find the VM patch files
Change-Id: I200b8fd266e866f05e4353a383f89c235c29c80a
Reviewed-on: https://dart-review.googlesource.com/21002
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2017-11-15 20:23:23 +00:00
Vyacheslav Egorov 3e59066738 [golem] Update try_benchmarks.sh for dart-v2 and dart-aot-v2
* Ensure that strong platform and outline exist.
* Ensure that pkg/vm/tool scripts work.

Bug:
Change-Id: Ief8211b85f31767341f022d1389ceb06c4f90cd9
Reviewed-on: https://dart-review.googlesource.com/20722
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
2017-11-15 07:06:51 +00:00
Alexander Thomas 1fc3092bef Put benchmark builder on commit queue in production
Change-Id: If4da0cc34501753f8e8ea29bbbe191afb111d3f9
Reviewed-on: https://dart-review.googlesource.com/21000
Reviewed-by: William Hesse <whesse@google.com>
2017-11-15 03:23:28 +00:00
Morten Krogh-Jespersen 22403530f0 Adding dart2js builders to the test matrix.
WIP

Bug:
Change-Id: I36c790884f4b31c60a7b9a5475f9c45847d9f94d
Reviewed-on: https://dart-review.googlesource.com/20840
Reviewed-by: William Hesse <whesse@google.com>
2017-11-15 02:09:16 +00:00
Morten Krogh-Jespersen 7590424b02 Enable triggering of analyzer linux builders in the test matrix.
Bug:
Change-Id: I4e50ac00d143ee16e34cf7491b7f149ad01a81e5
Reviewed-on: https://dart-review.googlesource.com/20203
Reviewed-by: William Hesse <whesse@google.com>
2017-11-15 01:49:17 +00:00
Jonas Termansen 529758bbff Fix benchmark-linux dart2js --checked test.
Change-Id: Id5e1263abdf191d8c7fb6535ffed97b7259d35d7
Reviewed-on: https://dart-review.googlesource.com/20981
Reviewed-by: Harry Terkelsen <het@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
2017-11-15 01:25:24 +00:00
Paul Berry 39fc40447e Fix subscription types in test_runner.dart.
This should fix the buildbot failure in vm-kernel-linux-release-x64-be.

Change-Id: I4078ff4eb677614684cf07dc70a50641d6926aa1
Reviewed-on: https://dart-review.googlesource.com/20905
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2017-11-15 00:51:15 +00:00
Alexander Markov 486d8e20ff [Test tool] Support test-specific environment customization
Change-Id: I129a22db37b5f1daf541dde9898b195045e4916d
Reviewed-on: https://dart-review.googlesource.com/20909
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2017-11-15 00:23:24 +00:00
Morten Krogh-Jespersen 2cab394773 Adding vm-kernel-precomp debug and release to test-matrix.
Bug:
Change-Id: Iacb4b1d9938d647ff120e983374f2aaf9935f3de
Reviewed-on: https://dart-review.googlesource.com/20860
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2017-11-14 23:19:41 +00:00
Morten Krogh-Jespersen 9d16537654 Add pkg builders to test-matrix.
The pkg builders will be triggered by the sdk builders in a later CL.

Bug:
Change-Id: I1118d8be102934bf84886b4c512129d175a982f5
Reviewed-on: https://dart-review.googlesource.com/20880
Reviewed-by: William Hesse <whesse@google.com>
2017-11-14 23:17:27 +00:00
Lasse R.H. Nielsen 0b58c4bd10 Change some constant declarations to lowerCase.
Retain the old values.

Reapply of https://dart-review.googlesource.com/c/sdk/+/20680 with fixes
for VM method fingerprints.

Change-Id: Ie14e7ccc3194d5561983348e6b6752728913ff4d
Reviewed-on: https://dart-review.googlesource.com/20664
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2017-11-14 12:59:14 +00:00
Lasse R.H. Nielsen e61fc07b58 Revert "Change some constant declarations to lowerCase."
This reverts commit c048cfb178.

Reason for revert: VM code fingerprints needs update.

Original change's description:
> Change some constant declarations to lowerCase.
> 
> Retain the old values.
> 
> Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
> Reviewed-on: https://dart-review.googlesource.com/11520
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Florian Loitsch <floitsch@google.com>

TBR=lrn@google.com,floitsch@google.com

Change-Id: I095e8198304ca4e59b39d30b0fdf0af4945e5231
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/20680
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2017-11-14 11:23:08 +00:00
Lasse R.H. Nielsen c048cfb178 Change some constant declarations to lowerCase.
Retain the old values.

Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
Reviewed-on: https://dart-review.googlesource.com/11520
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-11-14 11:13:04 +00:00
Jonas Termansen 57e05b9d0b Speed up benchmark-linux analyzer test.
This will reduce that test's runtime from 90 seconds to 3 seconds without
impacting coverage substantially.

Change-Id: I6d863d81420db6e09dc570e39623fed2d982d2be
Reviewed-on: https://dart-review.googlesource.com/20601
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
2017-11-14 01:27:41 +00:00
Alexander Thomas a201ff7e10 Require a signed CLA in commit queue
Bug: 31018
Change-Id: Iecb7905dc76a2fa6ebc13bd8310f040f95142307
Reviewed-on: https://dart-review.googlesource.com/20222
Reviewed-by: William Hesse <whesse@google.com>
2017-11-14 00:03:57 +00:00
Alexander Thomas 9dc4fd9dd3 Add experimental benchmark builder to CQ
Change-Id: I91961e6f35f48d0905d4df6e19015449f30bfab4
Reviewed-on: https://dart-review.googlesource.com/20302
Reviewed-by: Jonas Termansen <sortie@google.com>
2017-11-13 20:27:51 +00:00
Alexander Markov 0a4b151dc4 [Test tool] Pass --strong to dart_bootstrap, disable experimental opts
In '-c dartkp --strong' mode test tool should pass --strong option to
dart_bootstrap. Otherwise it uses non-strong vm_platform.dill instead
of vm_platform_strong.dill.

Also, experimental strong-mode based optimizations are disabled for now.

Closes https://github.com/dart-lang/sdk/issues/31348
Closes https://github.com/dart-lang/sdk/issues/31335

Change-Id: I2188b9165ae4daa0510e4e566393810b8165291e
Reviewed-on: https://dart-review.googlesource.com/20304
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2017-11-11 01:46:01 +00:00
Stephen Adams 7686dce346 Replace _downcast and _cast with local downcasts (dart:html)
Change-Id: I4282b20aac07da125805a2654da072742dbbdd0b
Reviewed-on: https://dart-review.googlesource.com/20300
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-11-11 00:09:38 +00:00
Jonas Termansen baa286dfcc Add benchmark-linux builder.
This bot catches whenever benchmarks would break. By putting this bot in
the commit queue, we can avoid many kinds of benchmark breakage that would
otherwise require bothersome triaging and cleaning up after the fact.

This bot has been tested and runs in 21-27 minutes.

Change-Id: I0fc08425094b32cf77d5f1a2ed840ad1bb11aedf
Reviewed-on: https://dart-review.googlesource.com/19940
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-11-10 23:09:18 +00:00
Morten Krogh-Jespersen cb499c92c3 Removed redundant comment.
Bug:
Change-Id: If2be0fcda71c9ab9741a852bb6c72862168c6637
Reviewed-on: https://dart-review.googlesource.com/20202
Reviewed-by: Alexander Thomas <athom@google.com>
2017-11-10 19:25:14 +00:00